Thanks for cancelling Jason.
The version number we're talking about is a marketing version number, it
has no technical impplications (as OSGi versioning is done on packaging
level).
The API is our most core bundle, if we increase the major version number
of the bundle, this sends out the
rombert commented on issue #7: SLING-7544 - fixing potential race between
intialization and addition…
URL:
https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/7#issuecomment-394481648
Thanks for the patch @DominikSuess . Based on our offline discussions I now
Hi Hasini,
On Tue, 2018-06-05 at 01:06 +0530, Hasini Witharana wrote:
> Hi all,
>
> I have a html login page (
> https://github.com/apache/sling-whiteboard/pull/14/files#diff-93a9b7f
> d5defb2fca21e9f8dfc553e34).
> I want to host this page in the URL "localhost:8080/auth/login".
>
> In the POM(
Hi all,
I have a html login page (
https://github.com/apache/sling-whiteboard/pull/14/files#diff-93a9b7fd5defb2fca21e9f8dfc553e34).
I want to host this page in the URL "localhost:8080/auth/login".
In the POM(
At this point I'm looking for feedback to say whether there is a consensus that
the proposed API
- stream()
- stream(Predicate)
where each one attempts to iterate through the tree is *sufficient enough for
the initial release*. I believe Stefan's concern was that he believed someone
Premature version bump has resulted in a cancellation
- Jason
On Mon, Jun 4, 2018, at 11:50 AM, Jason E Bailey wrote:
> Eh, I'm a bit confused over why a jdk requirement change is not
> considered breaking, and I don't see what the problem is with iterating
> the release rather than the
You got it. Thats's what I was attempting to describe and that's the type of
filtering we do a lot of.
- Jason
On Mon, Jun 4, 2018, at 1:58 PM, Daniel Klco wrote:
> It seems redundant, but I think they're somewhat different concepts. The
> Predicate passed into the stream method is for
It seems redundant, but I think they're somewhat different concepts. The
Predicate passed into the stream method is for evaluating the Resources
relevant for traversal, whereas (at least I'm assuming) that any subsequent
filters would filter the subsequent stream of resources. Having that sort
of
- Jason
On Mon, Jun 4, 2018, at 12:35 PM, Daniel Klco wrote:
>
> Rather than having another parameter, what about providing a
> ResourceChildrenPredicate? Based on the current API it looks like you'd
> have to provide the current resource to make this work, but it seems like
> it would be
Thanks Robert!
- Jason
On Mon, Jun 4, 2018, at 11:45 AM, Robert Munteanu wrote:
> There are two questions I want to raise:
>
> 1. API related
>
> We have two methods:
>
> - stream()
> - stream(Predicate)
>
> which traverse the whole tree.
the base stream() would traverse the whole tree,
On Mon, Jun 4, 2018 at 11:45 AM, Robert Munteanu wrote:
> Hi Jason,
>
> On Thu, 2018-05-31 at 10:39 -0400, Jason E Bailey wrote:
> > https://github.com/apache/sling-org-apache-sling-api/pull/4
> >
> > I've created a pull request to add a new class to the Sling API
> > bundle that would allow you
Nicolas Peltier created SLING-7705:
--
Summary: dryRun parameter no longer allows GET requests on pipe
modifying content
Key: SLING-7705
URL: https://issues.apache.org/jira/browse/SLING-7705
Project:
Nicolas Peltier created SLING-7704:
--
Summary: create pipe execution hooks
Key: SLING-7704
URL: https://issues.apache.org/jira/browse/SLING-7704
Project: Sling
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/SLING-7695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Munteanu resolved SLING-7695.
Resolution: Fixed
Assignee: Robert Munteanu
Fix Version/s: Dynamic Include
rombert closed pull request #4: Provide name hints for SDI configuration entries
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/4
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
rombert closed pull request #4: Provide name hints for SDI configuration entries
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/4
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of
rombert commented on issue #4: Provide name hints for SDI configuration entries
URL:
https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/4#issuecomment-394407979
Thanks @toniedzwiedz , applied!
This is an
toniedzwiedz opened a new pull request #4: Provide name hints for SDI
configuration entries
URL: https://github.com/apache/sling-org-apache-sling-dynamic-include/pull/4
Hello,
I've found that managing multiple configuration entries is a bit difficult
due to how they're presented in
Eh, I'm a bit confused over why a jdk requirement change is not considered
breaking, and I don't see what the problem is with iterating the release rather
than the version. But I'm good with changing it back.
I'll cancel this when I get the chance and reset the releases and the pom.
- Jason
Hi Jason,
On Thu, 2018-05-31 at 10:39 -0400, Jason E Bailey wrote:
> https://github.com/apache/sling-org-apache-sling-api/pull/4
>
> I've created a pull request to add a new class to the Sling API
> bundle that would allow you to create a Stream object which
> traverses a resource tree.
>
>
On Mon, 2018-06-04 at 08:48 -0400, Jason E Bailey wrote:
> The major version change is from a release perspective. The only
> change to the versioning which OSGi uses is
> org.apache.sling.api.resource which went from 2.11 to 2.12
>
> Ioan brought up the issue as part of the pull request that the
Went with adding the Stream to the Resource interface directly as a
default method. This is more intuitive and results in less code.
There has been a concern expressed about the naming methodology as to whether
Resource.stream() should by default be the children or the entire subtree.
- Jason
I explained the rationale behind the major release change in my response to
Carsten.
My apologies if you didn't think I addressed your points. Robert and Betrand
have asked that conversations like this be discussed in the Dev mailing list. I
have a [DISCUSSION] email out that was calling for
The major version change is from a release perspective. The only change to the
versioning which OSGi uses is org.apache.sling.api.resource which went from
2.11 to 2.12
Ioan brought up the issue as part of the pull request that the upgrade to jdk 8
is a significant change. If someone is
Glad to hear that. Now you can finally get to the fun stuff :-)
Robert
On Sun, 2018-06-03 at 00:55 +0530, Hasini Witharana wrote:
> Hi Robert,
>
> This helped a lot. I deployed the bundle (oauth2-oidc-sdk)
> successfully.
>
> Thank You.
>
> On Fri, Jun 1, 2018 at 2:49 AM, Robert Munteanu
>
On Fri, Jun 1, 2018 at 2:00 PM, Jason Bailey wrote:
> ...Unless things have changed with a github release, we don't have the
> permissions to add topics to Apache projects...
Yes, https://issues.apache.org/jira/browse/INFRA-16343
The alternative we've been discussing is using badges in our
Hi,
On Sat, May 26, 2018 at 12:20 PM, Ioan Eugen Stan wrote:
> ...I have created a branch to reproduce the bug [1]...
Best is to track this in jira so it doesn't fall through the cracks.
Let us know if you lack jira access rights.
-Bertrand
[
https://issues.apache.org/jira/browse/SLING-7633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1640#comment-1640
]
Julian Reschke commented on SLING-7633:
---
[~rombert] - fwiw, the config switch is present in Oak
[
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499946#comment-16499946
]
Nicolas Peltier commented on SLING-7692:
[~sseif...@pro-vision.de] done.
>
[
https://issues.apache.org/jira/browse/SLING-7510?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499929#comment-16499929
]
Ian Boston commented on SLING-7510:
---
The API was created being pragmatic rather than perfectionist.
It
[
https://issues.apache.org/jira/browse/SLING-7692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16499870#comment-16499870
]
Stefan Seifert commented on SLING-7692:
---
fine - i have only one small comment in the PR
>
stefanseifert commented on a change in pull request #1: Revert "SLING-7692
implement refresh(false)"
URL:
https://github.com/apache/sling-org-apache-sling-testing-jcr-mock/pull/1#discussion_r192657072
##
File path: src/main/java/org/apache/sling/testing/mock/jcr/MockSession.java
i think as well this is just a new feature which qualifies as a new minor
version 2.19.
that this version is java 8-only can be documented as separate ticket in the
release logs of this version.
i've also some minor open points on the naming of the new methods in
33 matches
Mail list logo
