[jira] [Commented] (SLING-8058) Make configuration of slingfeature-maven-plugin consistent

2018-11-07 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677823#comment-16677823 ] Carsten Ziegeler commented on SLING-8058: - In rev 5d06826 I've adjusted the Aggre

Re: [Feature Model] Initial API Regions implementation

2018-11-07 Thread David Bosschaert
Hi all, If nobody objects I'd like to create two new Sling Git Repositories for this: sling-org-apache-sling-feature-extension-apiregions for the extension handlers and sling-org-apache-sling-feature-apiregions for the runtime framework extension bundle. Are there any sling-specific instructions

[jira] [Comment Edited] (SLING-8058) Make configuration of slingfeature-maven-plugin consistent

2018-11-07 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16676350#comment-16676350 ] Carsten Ziegeler edited comment on SLING-8058 at 11/7/18 8:33 AM: -

[jira] [Comment Edited] (SLING-8058) Make configuration of slingfeature-maven-plugin consistent

2018-11-07 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677823#comment-16677823 ] Carsten Ziegeler edited comment on SLING-8058 at 11/7/18 8:34 AM: -

[jira] [Commented] (SLING-8058) Make configuration of slingfeature-maven-plugin consistent

2018-11-07 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677904#comment-16677904 ] Carsten Ziegeler commented on SLING-8058: - I've updated the repository mojos in r

[GitHub] trekawek opened a new pull request #6: Configurable startup timeout.

2018-11-07 Thread GitBox
trekawek opened a new pull request #6: Configurable startup timeout. URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/6 Similarly to #5, let's have a configurable startup timeout. - introduced new framework property `sling.framework.start.timeout` (in secon

[GitHub] bosschaert commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
bosschaert commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-436569075 Hi @simonetripodi thanks for this PR. For me to understa

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677941#comment-16677941 ] ASF GitHub Bot commented on SLING-8078: --- bosschaert commented on issue #7: SLING-80

Re: [Feature Model] Initial API Regions implementation

2018-11-07 Thread Radu Cotescu
Hi David, I was pointed to [0] recently, when I had to create a new repository for the HTL runtime. > On 7 Nov 2018, at 09:32, David Bosschaert wrote: > > Are there any sling-specific instructions on how to create these repos? Cheers, Radu [0] - https://cwiki.apache.org/confluence/display/SL

Re: [Feature Model] Initial API Regions implementation

2018-11-07 Thread Robert Munteanu
On Wed, 2018-11-07 at 11:04 +0100, Radu Cotescu wrote: > Hi David, > > I was pointed to [0] recently, when I had to create a new repository > for the HTL runtime. > > > On 7 Nov 2018, at 09:32, David Bosschaert < > > david.bosscha...@gmail.com> wrote: > > > > Are there any sling-specific instruc

[jira] [Commented] (SLING-8058) Make configuration of slingfeature-maven-plugin consistent

2018-11-07 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16677993#comment-16677993 ] Carsten Ziegeler commented on SLING-8058: - I've updated the analysis mojo in rev

[jira] [Assigned] (SLING-8058) Make configuration of slingfeature-maven-plugin consistent

2018-11-07 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-8058: --- Assignee: Carsten Ziegeler > Make configuration of slingfeature-maven-plugin consist

[jira] [Resolved] (SLING-8058) Make configuration of slingfeature-maven-plugin consistent

2018-11-07 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8058?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8058. - Resolution: Fixed > Make configuration of slingfeature-maven-plugin consistent >

[GitHub] karlpauls closed pull request #6: Configurable startup timeout.

2018-11-07 Thread GitBox
karlpauls closed pull request #6: Configurable startup timeout. URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/6 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] karlpauls commented on issue #6: Configurable startup timeout.

2018-11-07 Thread GitBox
karlpauls commented on issue #6: Configurable startup timeout. URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/6#issuecomment-436578644 @trekawek, makes sense - thanks a lot! This is an automated m

Re: [Feature Model] Initial API Regions implementation

2018-11-07 Thread David Bosschaert
Thanks Radu and Robert, I was looking here instead: https://sling.apache.org/project-information.html#source-repository I'll add the 'Using Git with Sling' link to that page as well. Best regards, David On Wed, 7 Nov 2018 at 10:14, Robert Munteanu wrote: > On Wed, 2018-11-07 at 11:04 +0100, R

Re: [VOTE] Release Apache Sling Engine 2.6.16

2018-11-07 Thread Karl Pauls
+1 regards, Karl On Mon, Oct 29, 2018 at 8:31 PM Daniel Klco wrote: > > +1 > > On Mon, Oct 29, 2018 at 10:47 AM Robert Munteanu wrote: > > > On Mon, 2018-10-29 at 15:29 +0100, Julian Sedding wrote: > > > Please vote to approve this release: > > > > +1 > > > > Robert > > -- Karl Pauls karlpa

Re: [Feature Model] Initial API Regions implementation

2018-11-07 Thread Carsten Ziegeler
+1 to gradudate Carsten Am 06.11.2018 um 16:50 schrieb David Bosschaert: Hi all, Over the past little while I have worked on an implementation for a runtime enforcement component for API Regions for Sling Features [1]. The implementation is based on 2 components. a. Merge/PostProcessor handl

[GitHub] cziegeler commented on issue #1: Initial attempt on providing default ServiceUserMapped and only mappi…

2018-11-07 Thread GitBox
cziegeler commented on issue #1: Initial attempt on providing default ServiceUserMapped and only mappi… URL: https://github.com/apache/sling-org-apache-sling-serviceusermapper/pull/1#issuecomment-436589108 @karlpauls The patch and described behaviour looks basically good to me, I think we

[jira] [Created] (SLING-8079) Returning false in a model PostConstruct causes an java.lang.IllegalStateException

2018-11-07 Thread JIRA
Santiago García Pimentel created SLING-8079: --- Summary: Returning false in a model PostConstruct causes an java.lang.IllegalStateException Key: SLING-8079 URL: https://issues.apache.org/jira/browse/SLING-

[jira] [Updated] (SLING-8079) Returning false in a model PostConstruct causes an java.lang.IllegalStateException

2018-11-07 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Santiago García Pimentel updated SLING-8079: Description: I was just trying the exporter framework and the feature from

[jira] [Commented] (SLING-8079) Returning false in a model PostConstruct causes an java.lang.IllegalStateException

2018-11-07 Thread JIRA
[ https://issues.apache.org/jira/browse/SLING-8079?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678060#comment-16678060 ] Santiago García Pimentel commented on SLING-8079: - One difficulty is that

[GitHub] cziegeler commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
cziegeler commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-436595682 I think the parameters should either be part of the const

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678087#comment-16678087 ] ASF GitHub Bot commented on SLING-8078: --- cziegeler commented on issue #7: SLING-807

Re: [Feature Model] Initial API Regions implementation

2018-11-07 Thread David Bosschaert
Hi all, I started migrating the code from the sling-whiteboard to individual repositories. The final step is to add the sources to the kibble demo instance http://demo.kibble.apache.org When I add https://github.com/apache/sling-org-apache-sling-feature-apiregions.git https://github.com/apache/sl

Re: [VOTE] Release Apache Sling App CMS version 0.11.0

2018-11-07 Thread Daniel Klco
+1 On Tue, Nov 6, 2018 at 6:57 PM Daniel Klco wrote: > Hi, > > We solved 24 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12344150 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2008/ > > You can use this UNIX script

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678156#comment-16678156 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi commented on issue #7: SLING

[GitHub] simonetripodi commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
simonetripodi commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-436609252 Thanks for the feedback @cziegeler , I'll modify the

Re: [Feature Model] Initial API Regions implementation

2018-11-07 Thread Robert Munteanu
Hi David, On Wed, 2018-11-07 at 12:01 +, David Bosschaert wrote: > Hi all, > > I started migrating the code from the sling-whiteboard to individual > repositories. > The final step is to add the sources to the kibble demo instance > http://demo.kibble.apache.org > > When I add > https://gith

Re: [VOTE] Release Apache Sling Engine 2.6.16

2018-11-07 Thread Carsten Ziegeler
+1 Am 07.11.2018 um 11:52 schrieb Karl Pauls: +1 regards, Karl On Mon, Oct 29, 2018 at 8:31 PM Daniel Klco wrote: +1 On Mon, Oct 29, 2018 at 10:47 AM Robert Munteanu wrote: On Mon, 2018-10-29 at 15:29 +0100, Julian Sedding wrote: Please vote to approve this release: +1 Robert

[VOTE RESULT] Release Apache Sling Engine 2.6.16

2018-11-07 Thread Carsten Ziegeler
I think we can close this vote now. The vote passes with four binding +1 votes, no other votes have been cast. Regards Carstem -- Carsten Ziegeler Adobe Research Switzerland cziege...@apache.org

Re: [VOTE] Release Apache Sling App CMS version 0.11.0

2018-11-07 Thread Robert Munteanu
On Tue, 2018-11-06 at 19:57 -0500, Daniel Klco wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10

2018-11-07 Thread Ben Fortuna (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678230#comment-16678230 ] Ben Fortuna commented on SLING-7545: [~bdelacretaz] just curious to note that the lat

Re: [VOTE] Release Apache Sling App CMS version 0.11.0

2018-11-07 Thread Jason E Bailey
+1 non-binding - Jason On Wed, Nov 7, 2018, at 8:08 AM, Robert Munteanu wrote: > On Tue, 2018-11-06 at 19:57 -0500, Daniel Klco wrote: > > Please vote to approve this release: > > +1 > > Robert > Email had 1 attachment: > + signature.asc > 1k (application/pgp-signature)

[GitHub] philipmundt opened a new pull request #5: SLING-8047 Flush response's buffer once request has been processed

2018-11-07 Thread GitBox
philipmundt opened a new pull request #5: SLING-8047 Flush response's buffer once request has been processed URL: https://github.com/apache/sling-org-apache-sling-engine/pull/5 Rendered/exported JSON requested via `SlingRequestProcessor` was previously not written to output stream. ---

[jira] [Commented] (SLING-8047) Rendered/exported JSON requested via SlingRequestProcessor is not written to output stream

2018-11-07 Thread Philip Mundt (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678258#comment-16678258 ] Philip Mundt commented on SLING-8047: - [~jsedding] thanks again for your alternative

Re: [VOTE] Release Apache Sling App CMS version 0.11.0

2018-11-07 Thread Radu Cotescu
+1 > On 7 Nov 2018, at 01:57, Daniel Klco wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours.

Re: [Feature Model] Initial API Regions implementation

2018-11-07 Thread David Bosschaert
Thanks Robert! David On Wed, 7 Nov 2018 at 12:47, Robert Munteanu wrote: > Hi David, > > On Wed, 2018-11-07 at 12:01 +, David Bosschaert wrote: > > Hi all, > > > > I started migrating the code from the sling-whiteboard to individual > > repositories. > > The final step is to add the sources

[jira] [Commented] (SLING-7545) Groovy Scripting Engine not loading in Apache Sling 10

2018-11-07 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678289#comment-16678289 ] Robert Munteanu commented on SLING-7545: [~fortuna] - Sling 11 contains the lates

Re: [VOTE] Release Apache Sling Distributed Event Admin 1.1.4

2018-11-07 Thread Robert Munteanu
Anyone else? Thanks, Robert

Re: [VOTE] Release Apache Sling Distributed Event Admin 1.1.4

2018-11-07 Thread Radu Cotescu
+1 > On 23 Oct 2018, at 17:21, Robert Munteanu wrote: > > Please vote to approve this release: > > [ ] +1 Approve the release > [ ] 0 Don't care > [ ] -1 Don't release, because ... > > This majority vote is open for at least 72 hours. > > Thanks, > > Robert

[jira] [Created] (SLING-8080) Almost all ITs fail after the Starter 11 release

2018-11-07 Thread Robert Munteanu (JIRA)
Robert Munteanu created SLING-8080: -- Summary: Almost all ITs fail after the Starter 11 release Key: SLING-8080 URL: https://issues.apache.org/jira/browse/SLING-8080 Project: Sling Issue Type

[jira] [Updated] (SLING-8080) Almost all ITs fail after the Starter 11 release

2018-11-07 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-8080: --- Priority: Critical (was: Major) > Almost all ITs fail after the Starter 11 release > ---

[jira] [Commented] (SLING-8080) Almost all ITs fail after the Starter 11 release

2018-11-07 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678366#comment-16678366 ] Robert Munteanu commented on SLING-8080: The OSGi installer status page shows we

[GitHub] karlpauls closed pull request #1: Initial attempt on providing default ServiceUserMapped and only mappi…

2018-11-07 Thread GitBox
karlpauls closed pull request #1: Initial attempt on providing default ServiceUserMapped and only mappi… URL: https://github.com/apache/sling-org-apache-sling-serviceusermapper/pull/1 This is an automated message from the Ap

[jira] [Updated] (SLING-7930) Provide default ServiceUserMapped services

2018-11-07 Thread Karl Pauls (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls updated SLING-7930: -- Fix Version/s: Service User Mapper 1.4.4 > Provide default ServiceUserMapped services > ---

[jira] [Resolved] (SLING-7930) Provide default ServiceUserMapped services

2018-11-07 Thread Karl Pauls (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Pauls resolved SLING-7930. --- Resolution: Fixed Basically, I think this issues comes down to two things namely, only provide Servi

[GitHub] simonetripodi opened a new pull request #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
simonetripodi opened a new pull request #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16 AnalyseFeaturesMojo modified in order to include the context configuration

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678389#comment-16678389 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi opened a new pull request #1

[GitHub] simonetripodi commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
simonetripodi commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-436663909 @cziegeler required modifications included in latest

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678391#comment-16678391 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi commented on issue #7: SLING

[GitHub] simonetripodi edited a comment on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
simonetripodi edited a comment on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16#issuecomment-436665191 Just to give you more background, Given a generic Fe

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678397#comment-16678397 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi edited a comment on issue #1

[GitHub] simonetripodi edited a comment on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
simonetripodi edited a comment on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16#issuecomment-436665191 Just to give you more background, Given a generic Fe

[GitHub] simonetripodi commented on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
simonetripodi commented on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16#issuecomment-436665191 Just to give you more background, Given a generic Feature F

[GitHub] simonetripodi edited a comment on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
simonetripodi edited a comment on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16#issuecomment-436665191 Just to give you more background, Given a generic Fe

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678401#comment-16678401 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi edited a comment on issue #1

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678400#comment-16678400 ] ASF GitHub Bot commented on SLING-8078: --- cziegeler commented on issue #7: SLING-807

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678399#comment-16678399 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi edited a comment on issue #1

[GitHub] cziegeler commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
cziegeler commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-436665548 The patch looks good to me, the only minor thing is that

[jira] [Commented] (SLING-8080) Almost all ITs fail after the Starter 11 release

2018-11-07 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678408#comment-16678408 ] Robert Munteanu commented on SLING-8080: The last launchpad-testing version that

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678396#comment-16678396 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi commented on issue #16: SLIN

[jira] [Commented] (SLING-8080) Almost all ITs fail after the Starter 11 release

2018-11-07 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678415#comment-16678415 ] Robert Munteanu commented on SLING-8080: Worked around the problem by not using p

[GitHub] bosschaert commented on a change in pull request #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
bosschaert commented on a change in pull request #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16#discussion_r231560554 ## File path: src/main/java/org/apac

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678421#comment-16678421 ] ASF GitHub Bot commented on SLING-8078: --- bosschaert commented on a change in pull r

[jira] [Commented] (SLING-7935) Consolidate all 'launchpad-testing' modules into a single git repository

2018-11-07 Thread Robert Munteanu (JIRA)
[ https://issues.apache.org/jira/browse/SLING-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678424#comment-16678424 ] Robert Munteanu commented on SLING-7935: [~olli] - that's something I hadn't cons

[GitHub] bosschaert commented on a change in pull request #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
bosschaert commented on a change in pull request #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16#discussion_r231562296 ## File path: src/it/analyzer-apireg

[GitHub] bosschaert commented on a change in pull request #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
bosschaert commented on a change in pull request #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16#discussion_r231562296 ## File path: src/it/analyzer-apireg

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678426#comment-16678426 ] ASF GitHub Bot commented on SLING-8078: --- bosschaert commented on a change in pull r

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678427#comment-16678427 ] ASF GitHub Bot commented on SLING-8078: --- bosschaert commented on a change in pull r

[VOTE] Release Apache Sling Service User Mapper 1.4.4

2018-11-07 Thread Karl Pauls
I would like to call a vote on the following release, Apache Sling Service User Mapper 1.4.4 We solved 1 issue in this release: https://issues.apache.org/jira/projects/SLING/versions/12344048 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2009/ You can use

[GitHub] bosschaert commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-07 Thread GitBox
bosschaert commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436676367 Hi @simonetripodi - is this PR still good to go in after the recent

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678439#comment-16678439 ] ASF GitHub Bot commented on SLING-8032: --- bosschaert commented on issue #11: SLING-8

[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-07 Thread GitBox
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436677684 Let me rebase `master` first, I need to double check! :P

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678442#comment-16678442 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi commented on issue #11: SLIN

[PROPOSAL] Moving integration tests closer to the code they test

2018-11-07 Thread Robert Munteanu
Hi, We discussed a couple of time that it would be desireable to move tests closer to the code they're testing. I wrote a proposal about how this could look like in terms of results https://cwiki.apache.org/confluence/display/SLING/Moving+integration+tests+closer+to+the+code+they+test I purpose

Re: Sling 12 themes

2018-11-07 Thread Robert Munteanu
On Tue, 2018-10-23 at 16:29 +0200, Robert Munteanu wrote: > I think it would be an interesting and worthwhile exercise to see > what > various contributors would like to see as the major themes of Sling > 12. Well, since I was the one asking :-) My areas of focus for Sling 12 would be mostly inte

[GitHub] simonetripodi commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
simonetripodi commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-436690547 Thanks @cziegeler for the feedback, very appreciated!

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678488#comment-16678488 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi commented on issue #7: SLING

Parameterizing Sling Feature model extensions

2018-11-07 Thread David Bosschaert
Hi all, I would like to be able to send some parameters to my Feature Model PostProcessHandler when its run from the slingfeature-maven-plugin. The handlers in the org.apache.sling.feature.extension.apiregions component generate files for the runtime component. I would like to be able to configu

[GitHub] simonetripodi edited a comment on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
simonetripodi edited a comment on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-436690547 Thanks @cziegeler for the feedback, very appre

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678505#comment-16678505 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi edited a comment on issue #7

[jira] [Commented] (SLING-8080) Almost all ITs fail after the Starter 11 release

2018-11-07 Thread Carsten Ziegeler (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678549#comment-16678549 ] Carsten Ziegeler commented on SLING-8080: - [~rombert] This sounds like a bug in t

[GitHub] cziegeler commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
cziegeler commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-436711291 In order to avoid that you talk to yourself :) Yes, corre

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678551#comment-16678551 ] ASF GitHub Bot commented on SLING-8078: --- cziegeler commented on issue #7: SLING-807

Re: Parameterizing Sling Feature model extensions

2018-11-07 Thread Carsten Ziegeler
Hi, we're currently discussing a similar problem for SLING-8078 with Simo. So maybe we can have a similar approach here (at least for how this is configured in the plugin configuration). I'm fine to extend the HandlerContext to provide configuration properties. I guess we should plan for cla

[GitHub] simonetripodi commented on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
simonetripodi commented on issue #16: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/16#issuecomment-436742788 thanks a lot for your feedbacks @bosschaert , I just implem

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678659#comment-16678659 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi commented on issue #16: SLIN

[GitHub] simonetripodi commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread GitBox
simonetripodi commented on issue #7: SLING-8078 - New Analyser task which is able to detect Export-Package dependencies between regions URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/7#issuecomment-436742987 Thanks @cziegeler , I just pushed another commit impl

[jira] [Commented] (SLING-8078) New Analyser task which is able to detect Export-Package dependencies between regions

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678662#comment-16678662 ] ASF GitHub Bot commented on SLING-8078: --- simonetripodi commented on issue #7: SLING

Re: [PROPOSAL] Moving integration tests closer to the code they test

2018-11-07 Thread Valentin Olteanu
On Wed, Nov 7, 2018 at 5:29 PM Robert Munteanu wrote: > Hi, > > We discussed a couple of time that it would be desireable to move tests > closer to the code they're testing. > > I wrote a proposal about how this could look like in terms of results > > > https://cwiki.apache.org/confluence/display

[GitHub] simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-07 Thread GitBox
simonetripodi commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436790341 I would consider that MOJO as a special exception for configuratio

[jira] [Commented] (SLING-8032) Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-07 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/SLING-8032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16678834#comment-16678834 ] ASF GitHub Bot commented on SLING-8032: --- simonetripodi commented on issue #11: SLIN

Re: Parameterizing Sling Feature model extensions

2018-11-07 Thread Carsten Ziegeler
Rethinking my own proposal from below, I think it's mixing the concern of how to configure it in a maven plugin with how to handle it in the respective component. So instead of doing the filtering in the component, I guess it makes more sense to let the caller do this. Or in other words instead

[GitHub] cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema

2018-11-07 Thread GitBox
cziegeler commented on issue #11: SLING-8032 - Add a MOJO which is able to validate JSON Feature file against the JSON Schema URL: https://github.com/apache/sling-slingfeature-maven-plugin/pull/11#issuecomment-436885201 While a general purpose JSON schema mojo would be nice, I see at least