[jira] [Resolved] (SLING-8839) Sensible defaults for the default set of analysers

2019-11-11 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-8839. - Resolution: Fixed I've changed the logic in rev 2974d3c to only include the checks for e

[jira] [Created] (SLING-8841) Update to Sling Bundle Parent 35

2019-11-11 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-8841: --- Summary: Update to Sling Bundle Parent 35 Key: SLING-8841 URL: https://issues.apache.org/jira/browse/SLING-8841 Project: Sling Issue Type: Task Compo

[jira] [Created] (SLING-8840) Update to Sling Bundle Parent 35

2019-11-11 Thread Oliver Lietz (Jira)
Oliver Lietz created SLING-8840: --- Summary: Update to Sling Bundle Parent 35 Key: SLING-8840 URL: https://issues.apache.org/jira/browse/SLING-8840 Project: Sling Issue Type: Task Compo

[jira] [Commented] (SLING-8706) Injections for java.util.Optional<> should be automatic optional

2019-11-11 Thread Evgeny Tugarev (Jira)
[ https://issues.apache.org/jira/browse/SLING-8706?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971748#comment-16971748 ] Evgeny Tugarev commented on SLING-8706: --- I can have a look on implementing this, ho

Re: [VOTE] Release Apache Sling Enngine version 2.6.22

2019-11-11 Thread Bertrand Delacretaz
On Tue, Nov 5, 2019 at 6:07 PM Bertrand Delacretaz wrote: > ...Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-2151 .. The vote passes with +1 from Stefan Seifert, Karl Pauls, Nicolas Peltier and Dan Klco, thank you! I'll take care of the remaining steps.

[jira] [Assigned] (SLING-8839) Sensible defaults for the default set of analysers

2019-11-11 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-8839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler reassigned SLING-8839: --- Assignee: Carsten Ziegeler > Sensible defaults for the default set of analysers > --

Re: [feature] Analyser complains that 'Bundle contains classes in the default package'

2019-11-11 Thread Robert Munteanu
On Mon, 2019-11-11 at 14:49 +0100, Carsten Ziegeler wrote: > Am 11.11.2019 um 11:51 schrieb Robert Munteanu: > > On Fri, 2019-11-08 at 14:18 +0100, Carsten Ziegeler wrote: > > > Hi > > > > > > it seems you run with all available checks. You should only run > > > api > > > region checks if you use

[jira] [Created] (SLING-8839) Sensible defaults for the default set of analysers

2019-11-11 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-8839: -- Summary: Sensible defaults for the default set of analysers Key: SLING-8839 URL: https://issues.apache.org/jira/browse/SLING-8839 Project: Sling Issue Ty

[jira] [Resolved] (SLING-8837) Add extra verbose mode to startup options

2019-11-11 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-8837. Resolution: Fixed Fixed with https://github.com/apache/sling-org-apache-sling-connection-t

Re: [feature] Analyser complains that 'Bundle contains classes in the default package'

2019-11-11 Thread Carsten Ziegeler
Am 11.11.2019 um 11:51 schrieb Robert Munteanu: On Fri, 2019-11-08 at 14:18 +0100, Carsten Ziegeler wrote: Hi it seems you run with all available checks. You should only run api region checks if you use api regions. We recently moved all analysers that use api regions to the regions extension.

[Jenkins] Sling » sling-org-apache-sling-launchpad-testing » master #391 is BROKEN

2019-11-11 Thread Apache Jenkins Server
Please see https://builds.apache.org/job/Sling/job/sling-org-apache-sling-launchpad-testing/job/master/391/ for details. No further emails will be sent until the status of the build is changed. Build log follows below: Started by timer Connecting to https://api.github.com using rombert/** (

[GitHub] [sling-org-apache-sling-feature] bosschaert merged pull request #16: Use Integer.comapreTo() for Integer comparison

2019-11-11 Thread GitBox
bosschaert merged pull request #16: Use Integer.comapreTo() for Integer comparison URL: https://github.com/apache/sling-org-apache-sling-feature/pull/16 This is an automated message from the Apache Git Service. To respond to

[GitHub] [sling-org-apache-sling-feature] bosschaert commented on issue #16: Use Integer.comapreTo() for Integer comparison

2019-11-11 Thread GitBox
bosschaert commented on issue #16: Use Integer.comapreTo() for Integer comparison URL: https://github.com/apache/sling-org-apache-sling-feature/pull/16#issuecomment-552431869 Thanks @HarisAdzemovic - merged. This is an auto

[GitHub] [sling-org-apache-sling-feature] HarisAdzemovic commented on issue #15: Strings and Boxed types should be compared using "equals()"

2019-11-11 Thread GitBox
HarisAdzemovic commented on issue #15: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-feature/pull/15#issuecomment-552427412 Thanks @rombert, I've opened a new PR making use of `compareTo`: https://github.com/apache/sling-

[jira] [Created] (SLING-8838) Add HEAD support to ContentDispositionFilter

2019-11-11 Thread Jira
Ilyas Türkben created SLING-8838: Summary: Add HEAD support to ContentDispositionFilter Key: SLING-8838 URL: https://issues.apache.org/jira/browse/SLING-8838 Project: Sling Issue Type: New Fe

[GitHub] [sling-org-apache-sling-feature] HarisAdzemovic opened a new pull request #16: Use Integer.comapreTo() for Integer comparison

2019-11-11 Thread GitBox
HarisAdzemovic opened a new pull request #16: Use Integer.comapreTo() for Integer comparison URL: https://github.com/apache/sling-org-apache-sling-feature/pull/16 See discussion in previous PR: https://github.com/apache/sling-org-apache-sling-scripting-jsp/pull/2 ---

[jira] [Created] (SLING-8837) Add extra verbose mode to startup options

2019-11-11 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-8837: -- Summary: Add extra verbose mode to startup options Key: SLING-8837 URL: https://issues.apache.org/jira/browse/SLING-8837 Project: Sling Issue Type: Impro

Re: Publishing packages on npmjs.com

2019-11-11 Thread Robert Munteanu
On Thu, 2019-10-24 at 12:04 +0200, Robert Munteanu wrote: > In https://issues.apache.org/jira/browse/SLING-8747 we are discussing > how to publish Sling packages on npmjs.com . Wrapping up - this is done and documented at https://cwiki.apache.org/confluence/display/SLING/Publishing+packages+o

[jira] [Resolved] (SLING-8747) establish @apachesling npmjs organization

2019-11-11 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-8747. Resolution: Fixed Done, see https://cwiki.apache.org/confluence/display/SLING/Publishing+p

[GitHub] [sling-org-apache-sling-commons-scheduler] rombert commented on issue #1: SLING-8764

2019-11-11 Thread GitBox
rombert commented on issue #1: SLING-8764 URL: https://github.com/apache/sling-org-apache-sling-commons-scheduler/pull/1#issuecomment-552394316 Thanks @miroslav-beranic for sending a new version of the code for review. For the future it might be simpler to force-push to the same branch - G

[GitHub] [sling-org-apache-sling-commons-scheduler] rombert commented on issue #2: SLING-8764 - A metric named commons.scheduler.oldest.running.job.millis already exists

2019-11-11 Thread GitBox
rombert commented on issue #2: SLING-8764 - A metric named commons.scheduler.oldest.running.job.millis already exists URL: https://github.com/apache/sling-org-apache-sling-commons-scheduler/pull/2#issuecomment-552394024 LGTM, thanks @miroslav-beranic . @stefan-egli - WDYT? --

Re: [feature] Analyser complains that 'Bundle contains classes in the default package'

2019-11-11 Thread Robert Munteanu
On Fri, 2019-11-08 at 14:18 +0100, Carsten Ziegeler wrote: > Hi > > it seems you run with all available checks. You should only run api > region checks if you use api regions. We recently moved all > analysers > that use api regions to the regions extension. As a bit of context, I started to in

[GitHub] [sling-org-apache-sling-scripting-esx] rombert merged pull request #1: Strings and Boxed types should be compared using "equals()"

2019-11-11 Thread GitBox
rombert merged pull request #1: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-scripting-esx/pull/1 This is an automated message from the Apache Git Service.

[GitHub] [sling-org-apache-sling-scripting-esx] rombert commented on issue #1: Strings and Boxed types should be compared using "equals()"

2019-11-11 Thread GitBox
rombert commented on issue #1: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-scripting-esx/pull/1#issuecomment-552390768 Merged, thanks for your contribution @HarisAdzemovic --

[GitHub] [sling-org-apache-sling-feature] rombert commented on issue #15: Strings and Boxed types should be compared using "equals()"

2019-11-11 Thread GitBox
rombert commented on issue #15: Strings and Boxed types should be compared using "equals()" URL: https://github.com/apache/sling-org-apache-sling-feature/pull/15#issuecomment-552389808 My reading of the code is that it's not null-safe anyway. It will fail at `o1 == 0` and `o2 == 0`. Incid

Re: Sling FM Starter Module

2019-11-11 Thread Robert Munteanu
Hi Andreas, On Fri, 2019-11-08 at 09:51 -0800, Andreas Schaefer wrote: > Hi > > I am wondering how a Sling FM Starter Module would look like and how > it is used by clients like Peregrine. > > It is my assumption that any FM slingosgifeature project will install > that file on release on a publi

Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.0.4

2019-11-11 Thread Karl Pauls
+1 regards, Karl On Mon, Nov 11, 2019 at 11:02 AM Carsten Ziegeler wrote: > > +1 > > Carsten > > Am 11.11.2019 um 10:42 schrieb Simone Tripodi: > > Hi, > > > > We solved 1 issue > > > > https://issues.apache.org/jira/browse/SLING-8815?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Feat

Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.0.4

2019-11-11 Thread Carsten Ziegeler
+1 Carsten Am 11.11.2019 um 10:42 schrieb Simone Tripodi: Hi, We solved 1 issue https://issues.apache.org/jira/browse/SLING-8815?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Feature%20Model%20API%20Regions%20Runtime%20Fragment%201.0.4%22 Staging repository: https://repository.apac

Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.0.4

2019-11-11 Thread David Bosschaert
+1 David On Mon, 11 Nov 2019 at 09:43, Simone Tripodi wrote: > Hi, > > We solved 1 issue > > > https://issues.apache.org/jira/browse/SLING-8815?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Feature%20Model%20API%20Regions%20Runtime%20Fragment%201.0.4%22 > > Staging repository: > https

Re: [VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.0.4

2019-11-11 Thread Simone Tripodi
My own non-binding +1 ~Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Mon, Nov 11, 2019 at 10:42 AM Simone Tripodi wrote: > > Hi, > > We solved 1 issue > > https://issues.apache.org/jira/browse/SLING-8815?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22

[VOTE] Release Apache Sling Feature Model API Regions Runtime Fragment 1.0.4

2019-11-11 Thread Simone Tripodi
Hi, We solved 1 issue https://issues.apache.org/jira/browse/SLING-8815?jql=project%20%3D%20SLING%20AND%20fixVersion%20%3D%20%22Feature%20Model%20API%20Regions%20Runtime%20Fragment%201.0.4%22 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-2153 You can use t

[jira] [Commented] (SLING-8743) Move DistributionQueueBuilderFactory class from impl to api surface

2019-11-11 Thread Ashish Chopra (Jira)
[ https://issues.apache.org/jira/browse/SLING-8743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971403#comment-16971403 ] Ashish Chopra commented on SLING-8743: -- (responding on behalf of [~mohiaror] who's c