On Sun, 2021-04-18 at 16:56 +0200, Carsten Ziegeler wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
[
https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324805#comment-17324805
]
Konrad Windszus commented on SLING-8243:
[~jebailey] Ping again.
Also it is not
[
https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324805#comment-17324805
]
Konrad Windszus edited comment on SLING-8243 at 4/19/21, 7:59 AM:
-
[
https://issues.apache.org/jira/browse/SLING-10316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-10316.
--
Resolution: Fixed
Added two new options:
- useApiDependenciesForJavadoc : if enabled,
bdelacretaz commented on pull request #26:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26#issuecomment-82229
> ...Sling starter uses openjdk:8-jre-alpine and that is an jre not an jdk...
Correct, sorry about the noise and +1 for this change then!
Konrad Windszus created SLING-10318:
---
Summary: Content Loader - Fix merge and overwrite options
Key: SLING-10318
URL: https://issues.apache.org/jira/browse/SLING-10318
Project: Sling
Issue
[
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324836#comment-17324836
]
Konrad Windszus commented on SLING-10318:
-
[~sseifert] [~jeb] I would appreciate
[
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10318:
Description:
There are 4 boolean flags which influence the import behaviour:
1. overwrite
[
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10318:
Description:
There are 4 boolean flags which influence the import behaviour:
1. overwrite
stbischof commented on pull request #26:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/26#issuecomment-822312127
I am happy to get the fast review/response!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log o
[
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10318:
Description:
There are 4 boolean flags which influence the import behaviour:
# overwrite
[
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-10318:
Description:
There are 4 boolean flags which influence the import behaviour:
# overwrite
karlpauls commented on a change in pull request #74:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r615699403
##
File path:
src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java
kwin commented on pull request #74:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#issuecomment-822331297
> do we need another cli switch for this?
Currently `Sling-Initial-Content` does not require the prefixes to be
defined. As long as they exis
kwin commented on a change in pull request #74:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r615700227
##
File path:
src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java
##
@@
kwin commented on a change in pull request #6:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/6#discussion_r615703327
##
File path: src/main/java/org/apache/sling/jcr/contentloader/package-info.java
##
@@ -17,6 +17,6 @@
* under the License.
*/
kwin merged pull request #6:
URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries ab
[
https://issues.apache.org/jira/browse/SLING-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved SLING-10297.
-
Resolution: Fixed
Fixed in
https://github.com/apache/sling-org-apache-sling-jcr-content
[
https://issues.apache.org/jira/browse/SLING-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-7926:
---
Summary: JSON Content Parser should support FileVault filename escaping
(was: JSON Content P
[
https://issues.apache.org/jira/browse/SLING-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated SLING-7926:
---
Description:
Currently it's possible to define a json file with a name that matches a
mangle
karlpauls commented on a change in pull request #74:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r615709459
##
File path:
src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java
[
https://issues.apache.org/jira/browse/SLING-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324926#comment-17324926
]
Konrad Windszus commented on SLING-7926:
As mentioned by [~sseifert] I don't see
[
https://issues.apache.org/jira/browse/SLING-7926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324926#comment-17324926
]
Konrad Windszus edited comment on SLING-7926 at 4/19/21, 10:16 AM:
kwin commented on a change in pull request #74:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r615766440
##
File path:
src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java
##
@@
kwin commented on a change in pull request #74:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#discussion_r615767600
##
File path:
src/main/java/org/apache/sling/feature/cpconverter/handlers/BundleEntryHandler.java
##
@@ -108,111 +144,302 @@
sonarcloud[bot] commented on pull request #74:
URL:
https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/74#issuecomment-822396941
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-cpconverter&pullReq
[
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324982#comment-17324982
]
Jason Bailey commented on SLING-10318:
--
The idea here is that there was a need to h
[
https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324997#comment-17324997
]
Jason Bailey commented on SLING-8243:
-
It's been 2 1/2 years since I touched this cod
[
https://issues.apache.org/jira/browse/SLING-8243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17324997#comment-17324997
]
Jason Bailey edited comment on SLING-8243 at 4/19/21, 12:36 PM:
---
[
https://issues.apache.org/jira/browse/SLING-10318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325001#comment-17325001
]
Konrad Windszus commented on SLING-10318:
-
The first goal is to identify the des
abhishekgarg18 closed pull request #8:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
Hi,
The vote has passed with the following result :
+1 (binding): Stefan Seifert, Carsten Ziegeler, Eric Norman, Daniel Klco
+1 (non binding): Jörg Hoh
I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.
Cheers,
Stefan
On 13.04.21 15
Hi,
-1 (non-binding) for now
All the work happened directly on the master branch. Why not have a PR so
others can review the changes in their totality?
PR's make it easier to review, because you get a clear picture of the overall
changes and test coverage[0].
Issue 8825 is not included in this
[
https://issues.apache.org/jira/browse/SLING-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli closed SLING-7756.
--
> Improve logging for Job retries
> ---
>
> Key: SLING-7756
>
[
https://issues.apache.org/jira/browse/SLING-9906?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli closed SLING-9906.
--
> Avoid retrying to load jobs if classes are missing
> --
>
[
https://issues.apache.org/jira/browse/SLING-10300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli closed SLING-10300.
---
> fix maven dependencies in sling.event
> -
>
> Key:
[
https://issues.apache.org/jira/browse/SLING-10120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Egli closed SLING-10120.
---
> Upgrade event to parent 41 [was: Upgrade event to parent 40]
> ---
fpackages/java/oraclejdk-1.8.0-281/jre
Default locale: en_US, platform encoding: ISO-8859-1
OS name: "linux", version: "4.15.0-122-generic", arch: "amd64", family: "unix"
[INFO] [jenkins-event-spy] Generate
/home/jenkins/jenkins-agent/workspace/_org
Thanks Cris,
while you bring up valid concerns, this release is not "worse" than the
previous one. I've increased the overall code coverage - still not
optimal. Especially the new code is covered. And in fact it's fixing a
bug introduced in 1.5.0.
Based on that I don't see a technical reason
stbischof opened a new pull request #27:
URL: https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27
uses the DockerHub CI and hooks to build and tag and push the docker images.
tags: latest, project-version, commit-sha1
--
This is an automated message from the
[
https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325059#comment-17325059
]
Stefan Bischof edited comment on SLING-10229 at 4/19/21, 2:06 PM:
[
https://issues.apache.org/jira/browse/SLING-10229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325059#comment-17325059
]
Stefan Bischof commented on SLING-10229:
here is a pr that usex the dockerhub ho
cziegeler closed pull request #1:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about
cziegeler commented on pull request #1:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/1#issuecomment-822501382
Closing in favour of https://issues.apache.org/jira/browse/SLING-10319
--
This is an automated message from the Apache Git Service.
To respond to the mess
Carsten Ziegeler created SLING-10319:
Summary: Use the "equals" method if value comparison was intended
Key: SLING-10319
URL: https://issues.apache.org/jira/browse/SLING-10319
Project: Sling
sonarcloud[bot] commented on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822508035
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe
+1
On Sun, Apr 18, 2021 at 10:57 AM Carsten Ziegeler
wrote:
> Hi,
>
> We solved 10 issues in this release:
> https://issues.apache.org/jira/projects/SLING/versions/12348715
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2431/
>
> You can use this UNIX
[
https://issues.apache.org/jira/browse/SLING-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-10319.
--
Assignee: Carsten Ziegeler
Resolution: Fixed
Replaced the if block with a much s
cziegeler commented on pull request #9:
URL:
https://github.com/apache/sling-org-apache-sling-auth-core/pull/9#issuecomment-822528731
I guess we can close this PR as the problem was elsewhere?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/SLING-10319?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325103#comment-17325103
]
Carsten Ziegeler commented on SLING-10319:
--
Forgot to push one test:
https://gi
abhishekgarg18 closed pull request #9:
URL: https://github.com/apache/sling-org-apache-sling-auth-core/pull/9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
On Thursday, 15 April 2021 14:24:19 CEST Radu Cotescu wrote:
> Hi,
>
> > On 14 Apr 2021, at 13:47, Oliver Lietz wrote:
> >
> > Sounds good! Do we agree on dedicated package
> > org.apache.sling.api.resource.type?
>
> This has now been addressed -
> https://github.com/apache/sling-org-apache-sli
I discussed the Version class with Radu briefly offline, looking for an
alternative - but we coulnd't come up with any good alternative. So I
think its ok for this use case to have it there.
Regards
Carsten
Am 19.04.2021 um 17:13 schrieb Oliver Lietz:
On Thursday, 15 April 2021 14:24:19 CEST
[
https://issues.apache.org/jira/browse/SLING-10317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Carsten Ziegeler resolved SLING-10317.
--
Resolution: Fixed
Added a report about the sources for each artifact and a report for
Hi Cris,
On Mon, 2021-04-19 at 09:23 -0400, Cris Rockwell wrote:
> All the work happened directly on the master branch. Why not have a
> PR
> so others can review the changes in their totality?
comm...@sling.apache.org records all the commits that are pushed to
Sling repositories, so there is alw
+1 Conditionally on there being some documentation somewhere that states
that this version is not quite a drop in replacement for the previous
release. The o.a.s.auth.core bundle now requires the [1] and [2] bundles
and those bundles should have a start level that is even or below the
o.a.s.auth.c
Hi,
The vote has passed with the following result :
+1 (binding): Eric Norman, Daniel Klco, Stefan Seifert
I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.
stefan-egli opened a new pull request #2:
URL: https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/2
When resourceResolverFactory is deactivated we have seen some noisy log
messages, including lengthy stack traces. While what these logs report is
legitimate, we should log l
[
https://issues.apache.org/jira/browse/SLING-10204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17325195#comment-17325195
]
Stefan Egli commented on SLING-10204:
-
* [PR|https://github.com/apache/sling-org-apa
sonarcloud[bot] commented on pull request #2:
URL:
https://github.com/apache/sling-org-apache-sling-discovery-oak/pull/2#issuecomment-822642542
SonarCloud Quality Gate failed.
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-discovery-oak&pullRequest=2&resolve
dear sling community
Andreas has been working to create a way to dynamically create component
proxies in Sling based on a configuration. In peregrine-cms we are
planning to use this approach when a new tenant (a new website) is
created by a user. It allows us to proxy the base components into
[
https://issues.apache.org/jira/browse/SLING-10263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman closed SLING-10263.
---
Closing with the JCR Maintenance 1.0.2 release
> create the sling-versionmgr system user with path syst
[
https://issues.apache.org/jira/browse/SLING-10310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Eric Norman closed SLING-10310.
---
Closing with the JCR Maintenance 1.0.2 release
> Update to Sling Bundle Parent 41
> ---
sonarcloud[bot] removed a comment on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822508035
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launche
sonarcloud[bot] commented on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822657421
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe
sonarcloud[bot] commented on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822669156
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe
sonarcloud[bot] removed a comment on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822657421
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launche
sonarcloud[bot] removed a comment on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822669156
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launche
sonarcloud[bot] commented on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822690285
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe
sonarcloud[bot] commented on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822706448
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe
sonarcloud[bot] removed a comment on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822690285
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launche
sonarcloud[bot] commented on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822736080
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe
sonarcloud[bot] removed a comment on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822706448
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launche
sonarcloud[bot] commented on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822738997
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe
sonarcloud[bot] removed a comment on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822736080
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launche
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/93/
for details.
No further emails will be sent until the status of the build is changed.
e it does not
exist.
[INFO] [jenkins-event-spy] Generated
/home/jenkins/jenkins-agent/workspace/e-sling-launchpad-testing_master@tmp/withMaven8da05807/maven-spy-20210419-195959-5581655062780740309154.log
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-failsafe-plugin:2.21.0:verify
sonarcloud[bot] commented on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822763929
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launcher&pullRe
sonarcloud[bot] removed a comment on pull request #27:
URL:
https://github.com/apache/sling-org-apache-sling-feature-launcher/pull/27#issuecomment-822738997
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_sling-org-apache-sling-feature-launche
Please see
https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-launchpad-testing/job/master/433/
for details.
No further emails will be sent until the status of the build is changed.
[
https://issues.apache.org/jira/browse/SLING-10320?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joerg Hoh updated SLING-10320:
--
Description:
Currently the Distribution events are sent and processed synchronously by using
{{eventA
Joerg Hoh created SLING-10320:
-
Summary: Sling Distribution Events should be sent async
Key: SLING-10320
URL: https://issues.apache.org/jira/browse/SLING-10320
Project: Sling
Issue Type: Improvem
82 matches
Mail list logo
