Re: [PR] SLING-11114 update SLING API to 2.21.0 [sling-org-apache-sling-caconfig-integration-tests]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-caconfig-integration-tests/pull/1#issuecomment-1762420906 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[jira] [Resolved] (SLING-12097) Installer Core build fails with Java 17

2023-10-13 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12097?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-12097. - Resolution: Fixed > Installer Core build fails with Java 17 >

Re: [PR] SLING-12097 - Installer Core build fails with Java 17 [sling-org-apache-sling-installer-core]

2023-10-13 Thread via GitHub
rombert merged PR #10: URL: https://github.com/apache/sling-org-apache-sling-installer-core/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SLING-12097 - Installer Core build fails with Java 17 [sling-org-apache-sling-installer-core]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-installer-core/pull/10#issuecomment-1762304534 Please retry analysis of this Pull-Request directly on

Re: [PR] SLING-12097 - Installer Core build fails with Java 17 [sling-org-apache-sling-installer-core]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #10: URL: https://github.com/apache/sling-org-apache-sling-installer-core/pull/10#issuecomment-1762304314 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[PR] SLING-12097 - Installer Core build fails with Java 17 [sling-org-apache-sling-installer-core]

2023-10-13 Thread via GitHub
rombert opened a new pull request, #10: URL: https://github.com/apache/sling-org-apache-sling-installer-core/pull/10 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Created] (SLING-12097) Installer Core build fails with Java 17

2023-10-13 Thread Robert Munteanu (Jira)
Robert Munteanu created SLING-12097: --- Summary: Installer Core build fails with Java 17 Key: SLING-12097 URL: https://issues.apache.org/jira/browse/SLING-12097 Project: Sling Issue Type:

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1762271679 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1762258563 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] chore(renovate): switch to built-in maven property versions regex manager [sling-org-apache-sling-starter]

2023-10-13 Thread via GitHub
rombert merged PR #254: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/254 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] chore(renovate): switch to built-in maven property versions regex manager [sling-org-apache-sling-starter]

2023-10-13 Thread via GitHub
rombert opened a new pull request, #254: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/254 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
adamcin commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1762169343 > this is taking good shape, thanks for all the work you put into this. is anything functional missing from your side? it would be good to update the

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1762141102 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1762131325 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1762055560 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1762042557 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.commons.mime to v2.2.4 [sling-site]

2023-10-13 Thread via GitHub
renovate-bot opened a new pull request, #138: URL: https://github.com/apache/sling-site/pull/138 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

Re: svn commit: r64512 - in /release/sling: ./ checkout/ checkout/.git/ checkout/.git/hooks/ checkout/.git/info/ checkout/.git/logs/ checkout/.git/objects/ checkout/.git/objects/35/ checkout/.git/obje

2023-10-13 Thread Eric Norman
Hi Andrei, I think you are going to want to rollback this revision from svn and try again. Revision 64512 appears to contain some (but not all) of the org.apache.sling.testing.clients-3.0.20 release binaries but also includes a bunch of other stuff that doesn't belong there. Regards, Eric On

Re: [PR] Bump commons-io from 2.5 to 2.7 [sling-org-apache-sling-clam]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-clam/pull/1#issuecomment-1761838820 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] Bump org.apache.sling.engine from 2.2.0 to 2.14.0 [sling-org-apache-sling-junit-scriptable]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-junit-scriptable/pull/1#issuecomment-1761839007 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] Bump org.apache.sling.jcr.base from 3.0.6 to 3.1.12 [sling-org-apache-sling-jcr-contentloader]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #20: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/20#issuecomment-1761835689 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-11891 SlingPostServlet: Support importing binary data from json [sling-org-apache-sling-jcr-contentloader]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #22: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/22#issuecomment-1761834389 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] JsonReader to recognize UTC dates [sling-org-apache-sling-jcr-contentloader]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #24: URL: https://github.com/apache/sling-org-apache-sling-jcr-contentloader/pull/24#issuecomment-1761832357 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [VOTE] Release Apache Sling Commons MIME version 2.2.4

2023-10-13 Thread Daniel Klco
+1 On Fri, Oct 6, 2023 at 5:06 AM Jörg Hoh wrote: > > +1 > > Am Fr., 6. Okt. 2023 um 06:52 Uhr schrieb Carsten Ziegeler < > cziege...@apache.org>: > > > +1 > > > > Carsten > > > > On 05.10.2023 20:28, Daniel Klco wrote: > > > Hi, > > > > > > We solved 2 issues in this release: > > > > >

[RESULT] [VOTE] Release Apache Sling Commons MIME version 2.2.4

2023-10-13 Thread Daniel Klco
Hi, The vote has passed with the following result : +1 (binding): Carsten Ziegeler, Jörg Hoh, Dan Klco +1 (non binding): N/A I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository.

Re: [PR] SLING-12091 Use constructor injection to ensure bundleContext is set [sling-org-apache-sling-resourcemerger]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #12: URL: https://github.com/apache/sling-org-apache-sling-resourcemerger/pull/12#issuecomment-1761820052 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] Strings and Boxed types should be compared using "equals()" [sling-org-apache-sling-launchpad-base]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #6: URL: https://github.com/apache/sling-org-apache-sling-launchpad-base/pull/6#issuecomment-1761792264 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] Bump org.apache.sling.api from 2.1.0 to 2.25.4 [sling-org-apache-sling-reqanalyzer]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-reqanalyzer/pull/3#issuecomment-1761777082 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] Bump org.apache.sling.engine from 2.2.0 to 2.14.0 [sling-org-apache-sling-reqanalyzer]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #4: URL: https://github.com/apache/sling-org-apache-sling-reqanalyzer/pull/4#issuecomment-1761776232 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] no-jira / no-merge : only to trigger tests [sling-org-apache-sling-event]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #33: URL: https://github.com/apache/sling-org-apache-sling-event/pull/33#issuecomment-1761775467 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] Bump jsoup from 1.14.3 to 1.15.3 [sling-org-apache-sling-commons-crypto]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-commons-crypto/pull/2#issuecomment-1761773077 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-11067 extend URIProvider by method returning Optional [sling-org-apache-sling-api]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #40: URL: https://github.com/apache/sling-org-apache-sling-api/pull/40#issuecomment-1761767732 SonarCloud Quality Gate failed. [![Quality Gate

Re: [PR] Upgrade to sling 48 [sling-org-apache-sling-auth-xing-api]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-auth-xing-api/pull/2#issuecomment-1761749936 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-11114 Use a LazySupplier for the caconfig binding [sling-org-apache-sling-caconfig-impl]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #5: URL: https://github.com/apache/sling-org-apache-sling-caconfig-impl/pull/5#issuecomment-1761748248 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12067: migrate to jackrabbit 2.20.2 (due to java.security.acl.Group issue) [sling-org-apache-sling-commons-testing]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #3: URL: https://github.com/apache/sling-org-apache-sling-commons-testing/pull/3#issuecomment-1761749989 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12064: migrate to jakarta.json [sling-org-apache-sling-caconfig-impl]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #7: URL: https://github.com/apache/sling-org-apache-sling-caconfig-impl/pull/7#issuecomment-1761747287 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-11352 - Fix parsing of path-only mappings [sling-org-apache-sling-resourceresolver]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #84: URL: https://github.com/apache/sling-org-apache-sling-resourceresolver/pull/84#issuecomment-1761731212 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-5884 : deprecate job queries, introduce query-free JobManager2,… [sling-org-apache-sling-event-api]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #1: URL: https://github.com/apache/sling-org-apache-sling-event-api/pull/1#issuecomment-1761717045 SonarCloud Quality Gate failed. [![Quality Gate

Re: [PR] [SECURITY] Fix Temporary File Information Disclosure Vulnerability [sling-org-apache-sling-feature-analyser]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #41: URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/41#issuecomment-1761713799 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12071: upgrade to sling parent 49 [sling-org-apache-sling-fsresource]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #2: URL: https://github.com/apache/sling-org-apache-sling-fsresource/pull/2#issuecomment-1761674044 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1761654081 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1761633529 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1761601260 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1761573164 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] SLING-12080 Update to Bnd 7.0.0 [sling-parent]

2023-10-13 Thread via GitHub
rombert commented on PR #37: URL: https://github.com/apache/sling-parent/pull/37#issuecomment-1761542047 That would work for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] SLING-12080 Update to Bnd 7.0.0 [sling-parent]

2023-10-13 Thread via GitHub
kwin commented on PR #37: URL: https://github.com/apache/sling-parent/pull/37#issuecomment-1761467602 For me the best option is release as 60 with bnd 7 (requiring Java 17) and once there is a need for a Java 8 compatible bugfix release of parent, create a maintenance branch and release as

Re: [PR] SLING-12080 Update to Bnd 7.0.0 [sling-parent]

2023-10-13 Thread via GitHub
rombert commented on PR #37: URL: https://github.com/apache/sling-parent/pull/37#issuecomment-1761462042 We have several options, and neither are IMO perfect: - postpone adopting bnd 7 until we really need it (but it may be painful to do it in a rushed way) - include in the next

[jira] [Commented] (SLING-12080) Update to Bnd 7.0 and require at least Java 17 for build

2023-10-13 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/SLING-12080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774889#comment-17774889 ] Konrad Windszus commented on SLING-12080: - [~rombert] I guess you are referring to

[jira] [Commented] (SLING-12080) Update to Bnd 7.0 and require at least Java 17 for build

2023-10-13 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-12080?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17774888#comment-17774888 ] Robert Munteanu commented on SLING-12080: - Judging from

Re: [PR] chore(deps): update dependency org.apache.sling:org.apache.sling.testing.clients to v3.0.20 [sling-site]

2023-10-13 Thread via GitHub
rombert merged PR #137: URL: https://github.com/apache/sling-site/pull/137 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] chore(deps): update dependency org.apache.sling:org.apache.sling.testing.clients to v3.0.20 [sling-site]

2023-10-13 Thread via GitHub
renovate-bot opened a new pull request, #137: URL: https://github.com/apache/sling-site/pull/137 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing |

Re: [PR] SLING-12089 Jenkins: Generate javadocs to spot illegal javadoc markup in sources [sling-tooling-jenkins]

2023-10-13 Thread via GitHub
kwin commented on code in PR #19: URL: https://github.com/apache/sling-tooling-jenkins/pull/19#discussion_r1358126094 ## vars/slingOsgiBundleBuild.groovy: ## @@ -189,6 +189,8 @@ def defineStage(def globalConfig, def jobConfig, def jdkVersion, def operatingSy }

Re: [PR] chore(deps): update dependency com.fasterxml.jackson.core:jackson-core to v2.15.3 [sling-org-apache-sling-starter]

2023-10-13 Thread via GitHub
rombert merged PR #253: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [PR] SLING-12089 Jenkins: Generate javadocs to spot illegal javadoc markup in sources [sling-tooling-jenkins]

2023-10-13 Thread via GitHub
stefanseifert commented on code in PR #19: URL: https://github.com/apache/sling-tooling-jenkins/pull/19#discussion_r1358063124 ## vars/slingOsgiBundleBuild.groovy: ## @@ -189,6 +189,8 @@ def defineStage(def globalConfig, def jobConfig, def jdkVersion, def operatingSy

[RESULT] [VOTE] Release Apache Sling Testing Clients version 3.0.20

2023-10-13 Thread Andrei Dulvac
Hi, The vote has passed with the following result : +1 (binding): Robert, Daniel, Stefan, Andrei +1 (non binding): none I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. Cheers, - Andrei On Fri, Oct 13, 2023 at 11:40 AM Andrei

[jira] [Updated] (SLING-12096) Testing clients - don't log request headers

2023-10-13 Thread Andrei Dulvac (Jira)
[ https://issues.apache.org/jira/browse/SLING-12096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-12096: -- Fix Version/s: (was: Apache Sling Testing Clients 3.0.20) > Testing clients - don't log

[jira] [Updated] (SLING-12096) Testing clients - don't log request headers

2023-10-13 Thread Andrei Dulvac (Jira)
[ https://issues.apache.org/jira/browse/SLING-12096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-12096: -- Affects Version/s: Apache Sling Testing Clients 3.0.16 (was: Apache

Re: [PR] SLING-11748 - Improve logging output of HTTP retries in testing clients [sling-org-apache-sling-testing-clients]

2023-10-13 Thread via GitHub
dulvac commented on PR #43: URL: https://github.com/apache/sling-org-apache-sling-testing-clients/pull/43#issuecomment-1761226271 Created [SLING-12096](https://issues.apache.org/jira/browse/SLING-12096) for this obe -- This is an automated message from the Apache Git Service. To respond

[jira] [Updated] (SLING-12096) Testing clients - don't log request headers

2023-10-13 Thread Andrei Dulvac (Jira)
[ https://issues.apache.org/jira/browse/SLING-12096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac updated SLING-12096: -- Affects Version/s: Apache Sling Testing Clients 3.0.20 (was: Apache

[jira] [Created] (SLING-12096) Testing clients - don't log request headers

2023-10-13 Thread Andrei Dulvac (Jira)
Andrei Dulvac created SLING-12096: - Summary: Testing clients - don't log request headers Key: SLING-12096 URL: https://issues.apache.org/jira/browse/SLING-12096 Project: Sling Issue Type:

Re: [VOTE] Release Apache Sling Testing Clients version 3.0.20

2023-10-13 Thread Andrei Dulvac
Hi Stefan. Thanks for pointing it out. I resolved SLING-11748 and should now be in the list. I probably should've cleaned up that ticket and dealt with the other PR before cutting this release. But we can do it with the next one. With that being said, here's my +1 for this release. - Andrei On

[jira] [Resolved] (SLING-11748) Improve logging output of HTTP retries in testing clients

2023-10-13 Thread Andrei Dulvac (Jira)
[ https://issues.apache.org/jira/browse/SLING-11748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andrei Dulvac resolved SLING-11748. --- Fix Version/s: Apache Sling Testing Clients 3.0.20 Assignee: Andrei Dulvac

Re: [PR] SLING-12089 Jenkins: Generate javadocs to spot illegal javadoc markup in sources [sling-tooling-jenkins]

2023-10-13 Thread via GitHub
kwin commented on code in PR #19: URL: https://github.com/apache/sling-tooling-jenkins/pull/19#discussion_r1358030566 ## vars/slingOsgiBundleBuild.groovy: ## @@ -189,6 +189,8 @@ def defineStage(def globalConfig, def jobConfig, def jdkVersion, def operatingSy }

[PR] chore(deps): update dependency com.fasterxml.jackson.core:jackson-core to v2.15.3 [sling-org-apache-sling-starter]

2023-10-13 Thread via GitHub
renovate-bot opened a new pull request, #253: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/253 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age |

Re: [PR] SLING-12070: migrate to jakarta.json [sling-org-apache-sling-xss]

2023-10-13 Thread via GitHub
rombert commented on PR #35: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/35#issuecomment-1761169980 > > Are there technical blockers to keeping Java 8 compatibility? > > @rombert Yes, we do. This is due to the latest version of the maven-compiler-plugin, which

Re: [PR] Test feature/SLING-12089-javadocs build branch [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
stefanseifert closed pull request #32: Test feature/SLING-12089-javadocs build branch URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] SLING-12089 Jenkins: Generate javadocs to spot illegal javadoc markup in sources [sling-tooling-jenkins]

2023-10-13 Thread via GitHub
stefanseifert commented on PR #19: URL: https://github.com/apache/sling-tooling-jenkins/pull/19#issuecomment-1761135700 i've testes this with an experimental PR and it seems to work fine: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/32/commits -- This is an

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1761124869 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

Re: [PR] Test feature/SLING-12089-javadocs build branch [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
sonarcloud[bot] commented on PR #32: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/32#issuecomment-1761124161 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[PR] Test feature/SLING-12089-javadocs build branch [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
stefanseifert opened a new pull request, #32: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/32 do not merge, experimental branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
stefanseifert commented on PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#issuecomment-1761093876 this is taking good shape, thanks for all the work you put into this. is anything functional missing from your side? it would be good to update the

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
stefanseifert commented on code in PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#discussion_r1357913099 ## core/src/main/java/org/apache/sling/testing/mock/osgi/config/annotations/ConfigType.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
stefanseifert commented on code in PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#discussion_r1357912860 ## core/src/main/java/org/apache/sling/testing/mock/osgi/config/annotations/UpdateConfig.java: ## @@ -0,0 +1,61 @@ +/* + * Licensed

Re: [PR] SLING-12038 add support for reified OSGi config annotations as test parameters [sling-org-apache-sling-testing-osgi-mock]

2023-10-13 Thread via GitHub
stefanseifert commented on code in PR #31: URL: https://github.com/apache/sling-org-apache-sling-testing-osgi-mock/pull/31#discussion_r1357894613 ## core/src/main/java/org/apache/sling/testing/mock/osgi/config/annotations/ConfigType.java: ## @@ -0,0 +1,79 @@ +/* + * Licensed

Re: [PR] SLING-12070: migrate to jakarta.json [sling-org-apache-sling-xss]

2023-10-13 Thread via GitHub
apelluru commented on PR #35: URL: https://github.com/apache/sling-org-apache-sling-xss/pull/35#issuecomment-1761041515 > Are there technical blockers to keeping Java 8 compatibility? @rombert Yes, we do. This is due to the latest version of the maven-compiler-plugin, which mandates

[jira] [Updated] (SLING-12063) Migrate sling.bundleresource.impl to jakarta.json

2023-10-13 Thread Ashok Pelluru (Jira)
[ https://issues.apache.org/jira/browse/SLING-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Pelluru updated SLING-12063: -- Fix Version/s: Bundle Resource 2.3.6 > Migrate sling.bundleresource.impl to jakarta.json >

[jira] [Resolved] (SLING-12063) Migrate sling.bundleresource.impl to jakarta.json

2023-10-13 Thread Ashok Pelluru (Jira)
[ https://issues.apache.org/jira/browse/SLING-12063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashok Pelluru resolved SLING-12063. --- Resolution: Fixed > Migrate sling.bundleresource.impl to jakarta.json >

Re: [PR] SLING-12063: migrate to jakarta.json [sling-org-apache-sling-bundleresource-impl]

2023-10-13 Thread via GitHub
apelluru merged PR #3: URL: https://github.com/apache/sling-org-apache-sling-bundleresource-impl/pull/3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: