[RESULT] [VOTE] Release Apache Sling File Optimization version 0.9.2 - Round 2

Hi, The vote has passed with the following result: +1 (binding): Dan Klco, Robert Munteanu, Stefan Seifert +1 (non binding): Jason Bailey I will copy this release to the Sling dist directory and promote the artifacts to the central Maven repository. On Wed, Sep 12, 2018 at 3:15 AM Robert

Re: [VOTE] Release Apache Sling File Optimization version 0.9.2 - Round 2

On Fri, 2018-09-07 at 13:15 -0400, Daniel Klco wrote: > Please vote to approve this release: +1 Robert signature.asc Description: This is a digitally signed message part

Re: [VOTE] Release Apache Sling File Optimization version 0.9.2 - Round 2

orgapachesling-1962 >> >> and >> sh check_staged_release.sh 1962 /tmp/sling-staging >> >> stefan >> >> >-----Original Message- >> >From: Daniel Klco >> >Sent: Friday, September 7, 2018 7:16 PM >> >To: dev@sling.apache.org &g

Re: [VOTE] Release Apache Sling File Optimization version 0.9.2 - Round 2

repositories/orgapachesling-1962 > > and > sh check_staged_release.sh 1962 /tmp/sling-staging > > stefan > > >-Original Message- > >From: Daniel Klco > >Sent: Friday, September 7, 2018 7:16 PM > >To: dev@sling.apache.org > >Subject: [VOTE] Release

RE: [VOTE] Release Apache Sling File Optimization version 0.9.2 - Round 2

;Subject: [VOTE] Release Apache Sling File Optimization version 0.9.2 - Round >2 > >Hi, > >We solved 1 issues in this release: >https://issues.apache.org/jira/projects/SLING/versions/12343855 > >Staging repository: >https://repository.apache.org/content/repositories/orgapaches

Re: [VOTE] Release Apache Sling File Optimization version 0.9.2 - Round 2

+1 non-binding - Jason On Fri, Sep 7, 2018, at 1:15 PM, Daniel Klco wrote: > Hi, > > We solved 1 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12343855 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1957/ > > You

[VOTE] Release Apache Sling File Optimization version 0.9.2 - Round 2

Hi, We solved 1 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12343855 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1957/ You can use this UNIX script to download the release and verify the signatures:

Re: [VOTE] Release Apache Sling File Optimization version 0.9.2

Hi Dan, Using the annotations depends on what you intend to do with the bundle and what you expect consumers of the bundle to do. In the commit I see that only FileOptimizer is marked as a @ConsumerType, which means that you expect consumers to typically implement this interface, but not others

Re: [VOTE] Release Apache Sling File Optimization version 0.9.2

Would someone mind taking a look at the last commit and ensure I'm using the Provider / Consumer Type annotations correctly? https://github.com/apache/sling-org-apache-sling-file-optimization/commit/b8abe02a3e4290743cb89a5f8a4a077ec884be69 Thanks! On Thu, Sep 6, 2018 at 11:59 AM Daniel Klco

Re: [VOTE] Release Apache Sling File Optimization version 0.9.2

Thanks for spotting this Jason. I'm going to cancel this release and resolve the issues. Regards, Dan On Thu, Sep 6, 2018 at 11:17 AM Jason E Bailey wrote: > Hey Dan, > > Since the interfaces that are made available are meant to be provided by > the bundle they should be annotated with the

Re: [VOTE] Release Apache Sling File Optimization version 0.9.2

Hey Dan, Since the interfaces that are made available are meant to be provided by the bundle they should be annotated with the @ProviderType annotation. Additionally, the default style for Sling is that spaces are used for indentations rather than tabs. Just an FYI. - Jason On Thu, Sep 6,

Re: [VOTE] Release Apache Sling File Optimization version 0.9.2

+1 On Thu, Sep 6, 2018 at 11:01 AM Daniel Klco wrote: > Hi, > > We solved 1 issues in this release: > https://issues.apache.org/jira/projects/SLING/versions/12343855 > > Staging repository: > https://repository.apache.org/content/repositories/orgapachesling-1957/ > > You can use this UNIX

[VOTE] Release Apache Sling File Optimization version 0.9.2

Hi, We solved 1 issues in this release: https://issues.apache.org/jira/projects/SLING/versions/12343855 Staging repository: https://repository.apache.org/content/repositories/orgapachesling-1957/ You can use this UNIX script to download the release and verify the signatures: