Re: Release of Servlets Resolver and Scripting bundles

2021-04-19 Thread Carsten Ziegeler
I discussed the Version class with Radu briefly offline, looking for an alternative - but we coulnd't come up with any good alternative. So I think its ok for this use case to have it there. Regards Carsten Am 19.04.2021 um 17:13 schrieb Oliver Lietz: On Thursday, 15 April 2021 14:24:19 CEST

Re: Release of Servlets Resolver and Scripting bundles

2021-04-19 Thread Oliver Lietz
On Thursday, 15 April 2021 14:24:19 CEST Radu Cotescu wrote: > Hi, > > > On 14 Apr 2021, at 13:47, Oliver Lietz wrote: > > > > Sounds good! Do we agree on dedicated package > > org.apache.sling.api.resource.type? > > This has now been addressed - >

Re: Release of Servlets Resolver and Scripting bundles

2021-04-15 Thread Radu Cotescu
Hi, > On 14 Apr 2021, at 13:47, Oliver Lietz wrote: > > Sounds good! Do we agree on dedicated package > org.apache.sling.api.resource.type? This has now been addressed -

Re: Release of Servlets Resolver and Scripting bundles

2021-04-14 Thread Oliver Lietz
On Wednesday, 14 April 2021 07:21:06 CEST Carsten Ziegeler wrote: > Am 14.04.2021 um 00:09 schrieb Oliver Lietz: > > I don't get the eventing example. Resources are a substantial part of > > Sling > > and defined in Sling API. Sling API bundle already contains several utils > > around Resource

Re: Release of Servlets Resolver and Scripting bundles

2021-04-13 Thread Carsten Ziegeler
Am 14.04.2021 um 00:09 schrieb Oliver Lietz: I don't get the eventing example. Resources are a substantial part of Sling and defined in Sling API. Sling API bundle already contains several utils around Resource (and HTTP Request/Response and Scripting). Resource and Resource Type are very

Re: Release of Servlets Resolver and Scripting bundles

2021-04-13 Thread Oliver Lietz
On Tuesday, 13 April 2021 15:08:25 CEST Carsten Ziegeler wrote: > Am 13.04.2021 um 14:35 schrieb Oliver Lietz: > > On Tuesday, 13 April 2021 08:03:02 CEST Carsten Ziegeler wrote: > > > > IMHO Resource versioning is now a common practice is Sling/AEM projects. > > I strongly suggest keeping API

Re: Release of Servlets Resolver and Scripting bundles

2021-04-13 Thread Carsten Ziegeler
Am 13.04.2021 um 14:35 schrieb Oliver Lietz: On Tuesday, 13 April 2021 08:03:02 CEST Carsten Ziegeler wrote: IMHO Resource versioning is now a common practice is Sling/AEM projects. I strongly suggest keeping API and helpers/utils in a single place (as we have done it so far) instead of

Re: Release of Servlets Resolver and Scripting bundles

2021-04-13 Thread Oliver Lietz
On Tuesday, 13 April 2021 08:03:02 CEST Carsten Ziegeler wrote: > I tend to agree that there is not that much value in moving this to the > api. I don't see any use cases for users of Sling's resource api to also > use this class. > > Apart from the reasons mentioned, ResourceType talks about

Re: Release of Servlets Resolver and Scripting bundles

2021-04-13 Thread Carsten Ziegeler
I tend to agree that there is not that much value in moving this to the api. I don't see any use cases for users of Sling's resource api to also use this class. Apart from the reasons mentioned, ResourceType talks about versioning - a concept we currently don't have in the api. In addition

Re: Release of Servlets Resolver and Scripting bundles

2021-04-12 Thread Radu Cotescu
Hi Julian, The reason for pushing back on this is that ResourceType [1] is more of a utility class, rather than an API one. It’s a final class, used to: Generate require and provide capabilities with the help of the scriptingbundle-maven-plugin Set up the servlets for each provided capability

Re: Release of Servlets Resolver and Scripting bundles

2021-04-12 Thread Julian Sedding
Hi * I agree with Olli that moving ResourceType later will not happen, because it causes too much disruption. I also agree that it is generally useful and not inherently linked to scripting. Why can't we just move it now, before we make our lives harder? If o.a.s.scripting.spi should not depend

Re: Release of Servlets Resolver and Scripting bundles

2021-04-08 Thread Oliver Lietz
On Thursday, 8 April 2021 15:48:27 CEST Radu Cotescu wrote: > Hi Olli, Hi Radu, > > On 1 Apr 2021, at 21:26, Oliver Lietz wrote: > > > > I have a use case for ResourceType not related to Scripting and would like > > to see it in Sling API (see SLING- for reasons) where it fits well. > > >

Re: Release of Servlets Resolver and Scripting bundles

2021-04-08 Thread Radu Cotescu
Hi Olli, > On 1 Apr 2021, at 21:26, Oliver Lietz wrote: > > I have a use case for ResourceType not related to Scripting and would like to > see it in Sling API (see SLING- for reasons) where it fits well. > > https://github.com/apache/sling-org-apache-sling-scripting-spi/blob/master/ >

Re: Release of Servlets Resolver and Scripting bundles

2021-04-08 Thread Radu Cotescu
Hi Konrad, > On 30 Mar 2021, at 09:12, Konrad Windszus > wrote: > > Hi, > It seems that the big changes for > https://issues.apache.org/jira/browse/SLING- > are done now. > > Also currently no issues are open for >

Re: Release of Servlets Resolver and Scripting bundles

2021-04-01 Thread Oliver Lietz
On Tuesday, 30 March 2021 09:12:43 CEST Konrad Windszus wrote: > Hi, Hi Konrad, > It seems that the big changes for > https://issues.apache.org/jira/browse/SLING- > are done now. > > Also currently no issues are open for >

Release of Servlets Resolver and Scripting bundles

2021-03-30 Thread Konrad Windszus
Hi, It seems that the big changes for https://issues.apache.org/jira/browse/SLING- are done now. Also currently no issues are open for