Re: Remove Session Pooling

2010-01-11 Thread Ian Boston
On 11 Jan 2010, at 07:52, Felix Meschberger wrote: Hi, On 09.01.2010 11:48, Ian Boston wrote: Ok, so I was slow on the uptake, as usual, I now see the problems and I agree, the pooling should be removed. Ok, shall I move on then ? Or should I wait for the full consequences with

Re: Remove Session Pooling

2010-01-11 Thread Felix Meschberger
Hi, On 11.01.2010 09:38, Ian Boston wrote: On 11 Jan 2010, at 07:52, Felix Meschberger wrote: Hi, On 09.01.2010 11:48, Ian Boston wrote: Ok, so I was slow on the uptake, as usual, I now see the problems and I agree, the pooling should be removed. Ok, shall I move on then ? Or should

Re: Remove Session Pooling

2010-01-11 Thread Felix Meschberger
I have created SLING-1283 to track this removal. Regards Felix [1] https://issues.apache.org/jira/browse/SLING-1283 On 06.01.2010 23:11, Felix Meschberger wrote: Hi all, Today I stumbled upon a potential problem with the JCR Session Pooling we have in the JCR Base bundle. Some time ago,

Re: Remove Session Pooling

2010-01-10 Thread Felix Meschberger
Hi, On 09.01.2010 11:48, Ian Boston wrote: Ok, so I was slow on the uptake, as usual, I now see the problems and I agree, the pooling should be removed. Ok, shall I move on then ? Or should I wait for the full consequences with respect to ACL caching (see below) are known ? Just for the

Re: Remove Session Pooling

2010-01-07 Thread Carsten Ziegeler
+1 for removal Carsten -- Carsten Ziegeler cziege...@apache.org

Re: Remove Session Pooling

2010-01-07 Thread Felix Meschberger
Hi, You are correctly noting these potential issues. But for a long time now, Jackrabbit has dramatically grown in this area: * The compiled ACLs are not cached within the session but in an ACL cache (where they IMHO belong) * Session setup once was a very heavy-weight operation (due to

Re: Remove Session Pooling

2010-01-07 Thread Ian Boston
On 7 Jan 2010, at 09:22, Felix Meschberger wrote: Hi, You are correctly noting these potential issues. But for a long time now, Jackrabbit has dramatically grown in this area: * The compiled ACLs are not cached within the session but in an ACL cache (where they IMHO belong)

Remove Session Pooling

2010-01-06 Thread Felix Meschberger
Hi all, Today I stumbled upon a potential problem with the JCR Session Pooling we have in the JCR Base bundle. Some time ago, we disabled session pooling by default. Only today I actually set this default for the Embedded Jackrabbit bundle (see SLING-1272). The problems with session pooling are

Re: Remove Session Pooling

2010-01-06 Thread Justin Edelson
+1 Session pooling is part of Jackrabbit 2 (which is where it belongs) anyway. IIRC, you removed it in your JR 2 branch. On Jan 6, 2010, at 5:11 PM, Felix Meschberger fmesc...@gmail.com wrote: Hi all, Today I stumbled upon a potential problem with the JCR Session Pooling we have in the

Re: Remove Session Pooling

2010-01-06 Thread Felix Meschberger
Hi, On 06.01.2010 23:20, Justin Edelson wrote: +1 Session pooling is part of Jackrabbit 2 (which is where it belongs) anyway. IIRC, you removed it in your JR 2 branch. I actually removed it in that branch exactly for the reasons outlined below ;-) Regards Felix On Jan 6, 2010, at 5:11

Re: Remove Session Pooling

2010-01-06 Thread Justin Edelson
On Jan 6, 2010, at 5:26 PM, Felix Meschberger fmesc...@gmail.com wrote: Hi, On 06.01.2010 23:20, Justin Edelson wrote: +1 Session pooling is part of Jackrabbit 2 (which is where it belongs) anyway. IIRC, you removed it in your JR 2 branch. I actually removed it in that branch exactly