reschke commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2112861725
FTR:
1. Yes, we want to completely remove even the shaded Guava variant, but
it'll take time.
2. *Major* version updates of Guava happened ~ once
rombert commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2112842362
Echoing a direct conversation I had with @reschke - it's hard for me to
formulate an ask to the Oak project since we can pull in a lot of components
(from oak
reschke commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2112496633
It's not clear to me yet what makes those Oak objects special. Or are they
really special? At the end of the day, each repostiory instance will end up
reschke commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2109422262
@rombert - is there something we can do systematically in Oak (other than
removing Guava completely) at this point? Also, can you file tickets for the
classes
reschke commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2107970625
Yes, indeed.
So it seems we we missed the case implementation objects leak the
dependency. For now we should open tickets for each that we encounter, we
rombert commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2107641629
> Yes, that's why we have removed Oak from the public Oak API.
I think you meant 'removed Guava', right? At any rate, for closely
integrated bundles l
reschke commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2107614606
Yes, that's why we have removed Oak from the public Oak API.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
rombert commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2107549956
> Oak's shaded Guava lib should be treated just as any other Oak component,
such as [oak-core](https://issues.apache.org/jira/browse/OAK-core). I'm not
s
reschke commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2107533908
Oak's shaded Guava lib should be treated just as any other Oak component,
such as oak-core. I'm not sure what's different?
--
This is an automated message
rombert commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2107526113
@reschke - the problem is that there seems to be no way to have a
SlingRepository implementation without pulling in Guava transitively. If you do
see a way
reschke commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2107521572
And no, by all means do not inline internal Oak classes!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
reschke commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2107516285
The goal definitively way for Oak not to leak any Guava-ish stuff in the
public APIs. AFAICT, this has been the case for approximately one year now
rombert commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2107499868
@enapps-enorman - good catch with the `AuthInfoImpl`. I hand-rolled a
different implementation (which does not seem to work, not sure why). But we
still have
enapps-enorman commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2099118388
> Thanks for looking into this. I wonder though whether it makes more sense
to extend the version range that we acc
sonarcloud[bot] commented on PR #10:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/10#issuecomment-2094365049
## [ which results in a failure to resolve
sonarcloud[bot] commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/7#issuecomment-2089214317
## [: Stefan Seifert, Jörg Hoh, Radu Cotescu, Robert Munteanu
I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.
stefan
Hi,
The vote has passed with the following result :
+1 (binding): Stefan Seifert, Jörg Hoh, Radu Cotescu, Robert Munteanu
I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.
stefan
On Wed, 2024-04-17 at 18:32 +, Stefan Seifert wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
On Wed, 2024-04-17 at 18:32 +, Stefan Seifert wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
+1
On Wed, 17 Apr 2024 at 20:32, Stefan Seifert
wrote:
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
+1
On Wed, 17 Apr 2024 at 20:32, Stefan Seifert
wrote:
>
> Please vote to approve this release:
>
> [ ] +1 Approve the release
> [ ] 0 Don't care
> [ ] -1 Don't release, because ...
>
+1
Am Mi., 17. Apr. 2024 um 20:32 Uhr schrieb Stefan Seifert
:
> Hi,
>
> We solved 6 issues in this release:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353253=Text=12310710
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2849/
+1
Am Mi., 17. Apr. 2024 um 20:32 Uhr schrieb Stefan Seifert
:
> Hi,
>
> Testing Sling Mock 3.5.0 (3 issues)
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12354169=Text=12310710
>
> Testing Sling Mock Oak 4.0.0-1.62.0 (7 issues)
>
> https://is
+1
stefan
+1
stefan
Hi,
Testing Sling Mock 3.5.0 (3 issues)
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12354169=Text=12310710
Testing Sling Mock Oak 4.0.0-1.62.0 (7 issues)
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12354581=Text=12310710
Staging repository:
https
Hi,
We solved 6 issues in this release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12353253=Text=12310710
Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2849/
You can use this UNIX script to download the release and verify the
[
https://issues.apache.org/jira/browse/SLING-12296?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved SLING-12296.
Resolution: Fixed
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak
stefanseifert merged PR #15:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
sonarcloud[bot] commented on PR #15:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/15#issuecomment-2061927885
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
stefanseifert opened a new pull request, #15:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/15
https://issues.apache.org/jira/browse/SLING-12296
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
Stefan Seifert created SLING-12296:
--
Summary: sling-mock-oak: Update to Oak 1.62.0
Key: SLING-12296
URL: https://issues.apache.org/jira/browse/SLING-12296
Project: Sling
Issue Type
-testing-sling-mock-oak/commit/d4f0388ac9cf592a218230ee01cf14a6c3a93463]
* 3.2.x:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/commit/edf70e21c3e06b9e4960d99332669050727c7251
> sling-mock-oak: Update to Oak 1.60 and provide separate 1.22 rele
stefanseifert merged PR #14:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/14
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
:
-
looking deeper into this, i think it's not easy possible to have a single
JAR/POM supporting both oak 1.22 and latest oak version at the same time. there
is too much change between them, regarding supported jdks and the change guava
is embedded.
i currently plan to do a branching of sling-mock-oak
stefanseifert merged PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/13
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
[
https://issues.apache.org/jira/browse/SLING-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-12287:
---
Fix Version/s: Testing Sling Mock Oak 4.0.0-1.60.0
> sling-mock-oak: Update to Oak 1
[
https://issues.apache.org/jira/browse/SLING-12287?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert updated SLING-12287:
---
Summary: sling-mock-oak: Update to Oak 1.60 and provide separate 1.22
release (was: sling
possible to have a single
JAR/POM supporting both oak 1.22 and latest oak version at the same time. there
is too much change between them, regarding supported jdks and the change guava
is embedded.
i currently plan to do a branching of sling-mock-oak - one maintenance branch
for 1.22.x and one
sonarcloud[bot] commented on PR #14:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/14#issuecomment-2051164075
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
sonarcloud[bot] commented on PR #13:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/13#issuecomment-2051120443
## [![Quality Gate
Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png
stefanseifert opened a new pull request, #13:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/13
switch back to Oak 1.22, which is the officially support "legacy" version of
oak.
switch back to parent 52 and limit build to java 11, as build wi
stefanseifert merged PR #12:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
sonarcloud[bot] commented on PR #12:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/12#issuecomment-2049560447
## [
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stefanseifert merged PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/11
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
sonarcloud[bot] commented on PR #11:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/11#issuecomment-2045754797
## [: Robert Munteanu, Stefan Seifert, Daniel Klco, Jörg Hoh, Eric
Norman
+1 (non binding): None
I will copy this release to the Sling dist directory and promote the
artifacts to the central Maven repository.
+1
On Mon, Oct 9, 2023 at 4:14 PM Eric Norman wrote:
> Hi,
>
> These releases are needed to be compatible with the latest production
> version of oak (1.56.0 or later).
>
> We solved 2 issues in the JCR Maintenance release:
>
>
+1
Am Di., 10. Okt. 2023 um 01:15 Uhr schrieb Eric Norman :
> Hi,
>
> These releases are needed to be compatible with the latest production
> version of oak (1.56.0 or later).
>
> We solved 2 issues in the JCR Maintenance release:
>
>
+1
On Wed, Oct 11, 2023 at 6:56 AM Stefan Seifert
wrote:
>
> +1
>
> stefan
+1
stefan
sonarcloud[bot] commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/7#issuecomment-1755973019
Kudos, SonarCloud Quality Gate passed! [.
We solved 2 issues in the JCR Maintenance release:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310710=12350102=Text
We solved 5 issues in the JCR Oak Server
sonarcloud[bot] commented on PR #7:
URL:
https://github.com/apache/sling-org-apache-sling-jcr-oak-server/pull/7#issuecomment-1737474342
Kudos, SonarCloud Quality Gate passed! [: Stefan Seifert, Robert Munteanu, Eric Norman, Daniel Klco
I will copy this release to the Sling dist directory and
promote the artifacts to the central Maven repository.
stefan
ling Mock 3.4.10 (2 issues)
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12353212
> >
> > Testing Sling Mock Oak 3.1.10-1.44.0 (2 issues)
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12352741
> >
> > Context-Aware Configuration
/12353031
>
> Testing ResourceResolver Mock 1.4.2 (1 issue)
> https://issues.apache.org/jira/browse/SLING/fixforversion/12352243
>
> Testing Sling Mock 3.4.10 (2 issues)
> https://issues.apache.org/jira/browse/SLING/fixforversion/12353212
>
> Testing Sling Mock Oak 3.1.10-1
On Tue, 2023-05-16 at 08:57 +, Stefan Seifert wrote:
> Please vote to approve this release:
+1
Robert
signature.asc
Description: This is a digitally signed message part
+1
stefan
/SLING/fixforversion/12352243
Testing Sling Mock 3.4.10 (2 issues)
https://issues.apache.org/jira/browse/SLING/fixforversion/12353212
Testing Sling Mock Oak 3.1.10-1.44.0 (2 issues)
https://issues.apache.org/jira/browse/SLING/fixforversion/12352741
Context-Aware Configuration Mock Plugin 1.5.0
[
https://issues.apache.org/jira/browse/SLING-11873?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Seifert resolved SLING-11873.
Resolution: Fixed
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak
stefanseifert merged PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe
sonarcloud[bot] commented on PR #8:
URL:
https://github.com/apache/sling-org-apache-sling-testing-sling-mock-oak/pull/8#issuecomment-1545531669
Kudos, SonarCloud Quality Gate passed! [