Re: [VOTE] Release Apache Sling Rewriter version 1.3.6

2023-04-25 Thread Daniel Klco
My +1 On Tue, Apr 25, 2023 at 12:30 AM Stefan Seifert wrote: > +1 > > stefan >

[GitHub] [sling-org-apache-sling-starter] enapps-enorman commented on pull request #155: SLING-11836 - Add Jakarta JSON support to the Sling Starter

2023-04-25 Thread via GitHub
enapps-enorman commented on PR #155: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/155#issuecomment-1522290454 Perhaps they would accept a patch that uses the osgi service loader mediator instead of that glasssfish workaround? We already have the

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#issuecomment-1522062801 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] rombert commented on pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
rombert commented on PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#issuecomment-1522053521 @DominikSuess - I've pushed

[jira] [Assigned] (SLING-11838) Unexpected runmode inheritance behavior

2023-04-25 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reassigned SLING-11838: --- Assignee: Dominik Süß > Unexpected runmode inheritance behavior >

[jira] [Updated] (SLING-11838) Unexpected runmode inheritance behavior

2023-04-25 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu updated SLING-11838: Fix Version/s: Content-Package to Feature Model Converter 1.3.2 > Unexpected runmode

[GitHub] [sling-org-apache-sling-starter] rombert opened a new pull request, #155: SLING-11836 - Add Jakarta JSON support to the Sling Starter

2023-04-25 Thread via GitHub
rombert opened a new pull request, #155: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/155 Add the glassfish osgi resource locator to the boot feature. This shim is explicitly invoked by the JsonProvider to properly function in OSGi environments [1]. [1]:

[jira] [Resolved] (SLING-11851) Prevent recursive invocations of error handler

2023-04-25 Thread Carsten Ziegeler (Jira)
[ https://issues.apache.org/jira/browse/SLING-11851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Carsten Ziegeler resolved SLING-11851. -- Resolution: Fixed

[jira] [Created] (SLING-11851) Prevent recursive invocations of error handler

2023-04-25 Thread Carsten Ziegeler (Jira)
Carsten Ziegeler created SLING-11851: Summary: Prevent recursive invocations of error handler Key: SLING-11851 URL: https://issues.apache.org/jira/browse/SLING-11851 Project: Sling Issue

[jira] [Created] (SLING-11850) HTL: Add support for suffix manipulation in ResourceRuntimeExtension

2023-04-25 Thread Robin Brouns (Jira)
Robin Brouns created SLING-11850: Summary: HTL: Add support for suffix manipulation in ResourceRuntimeExtension Key: SLING-11850 URL: https://issues.apache.org/jira/browse/SLING-11850 Project: Sling

RE: [RESULT] [VOTE] Release Apache Sling GraphQL Core 0.0.20

2023-04-25 Thread Stefan Seifert
> Can a PMC push the release to > https://dist.apache.org/repos/dist/release/sling/ for me? Completed: At revision: 61471 stefan

[RESULT] [VOTE] Release Apache Sling GraphQL Core 0.0.20

2023-04-25 Thread Andreas Schaefer
Hi The vote passed with the following result: +1 (binding): Radu Cotescu, Robert Munteanu, Stefan Seifert Can a PMC push the release to https://dist.apache.org/repos/dist/release/sling/ for me? Cheers - Andy Schaefer

[jira] [Commented] (SLING-11836) Add Jakarta JSON support to the Sling Starter

2023-04-25 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716288#comment-17716288 ] Robert Munteanu commented on SLING-11836: - Seems the solution that we implemented does not work

[jira] [Reopened] (SLING-11836) Add Jakarta JSON support to the Sling Starter

2023-04-25 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu reopened SLING-11836: - > Add Jakarta JSON support to the Sling Starter >

[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #105: chore(deps): update dependency org.apache.sling:org.apache.sling.jcr.contentloader to v2.6.0

2023-04-25 Thread via GitHub
rombert commented on PR #105: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/105#issuecomment-1521818502 ```25.04.2023 15:43:30.706 *ERROR* [Apache Sling Repository Startup Thread #1] org.apache.sling.jcr.contentloader.internal.BundleContentLoader Cannot load initial

[GitHub] [sling-org-apache-sling-starter] rombert commented on pull request #105: chore(deps): update dependency org.apache.sling:org.apache.sling.jcr.contentloader to v2.6.0

2023-04-25 Thread via GitHub
rombert commented on PR #105: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/105#issuecomment-1521812476 Seems like the Jakarta JSON changes done in #153 were not enough (or incorrect). -- This is an automated message from the Apache Git Service. To respond to the

[jira] [Comment Edited] (SLING-11849) Create osgiContext#unregisterService() for easy unregistering of services

2023-04-25 Thread Henry Kuijpers (Jira)
[ https://issues.apache.org/jira/browse/SLING-11849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716267#comment-17716267 ] Henry Kuijpers edited comment on SLING-11849 at 4/25/23 1:40 PM: - Hm, it

[jira] [Comment Edited] (SLING-11849) Create osgiContext#unregisterService() for easy unregistering of services

2023-04-25 Thread Henry Kuijpers (Jira)
[ https://issues.apache.org/jira/browse/SLING-11849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716267#comment-17716267 ] Henry Kuijpers edited comment on SLING-11849 at 4/25/23 1:40 PM: - Hm, it

[jira] [Commented] (SLING-11849) Create osgiContext#unregisterService() for easy unregistering of services

2023-04-25 Thread Henry Kuijpers (Jira)
[ https://issues.apache.org/jira/browse/SLING-11849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17716267#comment-17716267 ] Henry Kuijpers commented on SLING-11849: Hm, it seems to be not so easy though: To obtain the

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#issuecomment-1521805495 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#issuecomment-1521805247 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#issuecomment-1521804936 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #789 is FIXED

2023-04-25 Thread Apache Jenkins Server
Please see https://ci-builds.apache.org/job/Sling/job/modules/job/sling-org-apache-sling-starter/job/master/789/ for details. No further emails will be sent until the status of the build is changed.

[GitHub] [sling-org-apache-sling-feature-cpconverter] DominikSuess commented on a diff in pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
DominikSuess commented on code in PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#discussion_r1176465618 ## src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java: ## @@ -145,6 +146,9

[Jenkins] Sling » Modules » sling-org-apache-sling-starter » master #788 is BROKEN

2023-04-25 Thread Apache Jenkins Server
/_org-apache-sling-starter_master/jdk_11_latest@tmp/withMaven0dd51d7f/maven-spy-20230425-122833-322182606475620378760.log [Pipeline] } [withMaven] artifactsPublisher - Archive artifact pom.xml under org/apache/sling/org.apache.sling.starter/13-SNAPSHOT/org.apache.sling.starter-13-SNAPSHOT.pom

[jira] [Resolved] (SLING-11836) Add Jakarta JSON support to the Sling Starter

2023-04-25 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11836. - Resolution: Fixed > Add Jakarta JSON support to the Sling Starter >

[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #154: chore(deps): update dependency org.apache.jackrabbit:oak-api to v1.50.0

2023-04-25 Thread via GitHub
rombert merged PR #154: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #153: SLING-11718 - Add Jakarta JSON support to the Sling Starter

2023-04-25 Thread via GitHub
rombert merged PR #153: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [sling-org-apache-sling-starter] renovate-bot opened a new pull request, #154: chore(deps): update dependency org.apache.jackrabbit:oak-api to v1.50.0

2023-04-25 Thread via GitHub
renovate-bot opened a new pull request, #154: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/154 [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age |

[jira] [Created] (SLING-11849) Create osgiContext#unregisterService() for easy unregistering of services

2023-04-25 Thread Henry Kuijpers (Jira)
Henry Kuijpers created SLING-11849: -- Summary: Create osgiContext#unregisterService() for easy unregistering of services Key: SLING-11849 URL: https://issues.apache.org/jira/browse/SLING-11849

[GitHub] [sling-org-apache-sling-starter] kwin commented on a diff in pull request #153: SLING-11718 - Add Jakarta JSON support to the Sling Starter

2023-04-25 Thread via GitHub
kwin commented on code in PR #153: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/153#discussion_r1176327384 ## src/main/features/boot.json: ## @@ -84,6 +84,14 @@ "id":"org.apache.felix:org.apache.felix.log:1.2.6",

[GitHub] [sling-org-apache-sling-starter] kwin commented on a diff in pull request #153: SLING-11718 - Add Jakarta JSON support to the Sling Starter

2023-04-25 Thread via GitHub
kwin commented on code in PR #153: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/153#discussion_r1176322605 ## src/main/features/boot.json: ## @@ -84,6 +84,14 @@ "id":"org.apache.felix:org.apache.felix.log:1.2.6",

[GitHub] [sling-org-apache-sling-starter] kwin commented on a diff in pull request #153: SLING-11718 - Add Jakarta JSON support to the Sling Starter

2023-04-25 Thread via GitHub
kwin commented on code in PR #153: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/153#discussion_r1176320949 ## src/main/features/boot.json: ## @@ -84,6 +84,14 @@ "id":"org.apache.felix:org.apache.felix.log:1.2.6",

[GitHub] [sling-org-apache-sling-starter] kwin commented on a diff in pull request #153: SLING-11718 - Add Jakarta JSON support to the Sling Starter

2023-04-25 Thread via GitHub
kwin commented on code in PR #153: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/153#discussion_r1176319050 ## src/main/features/boot.json: ## @@ -84,6 +84,14 @@ "id":"org.apache.felix:org.apache.felix.log:1.2.6",

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
kwin commented on code in PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#discussion_r1176314895 ## src/main/java/org/apache/sling/feature/cpconverter/ContentPackage2FeatureModelConverter.java: ## @@ -242,7 +260,16 @@ public boolean

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a diff in pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
kwin commented on code in PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#discussion_r1176313939 ## src/main/java/org/apache/sling/feature/cpconverter/cli/ContentPackage2FeatureModelConverterLauncher.java: ## @@ -145,6 +146,9 @@

[GitHub] [sling-org-apache-sling-starter] rombert opened a new pull request, #153: SLING-11718 - Add Jakarta JSON support to the Sling Starter

2023-04-25 Thread via GitHub
rombert opened a new pull request, #153: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/153 Add Eclipse Parsson. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Resolved] (SLING-11840) Drop Java 8 support for the Sling Starter

2023-04-25 Thread Robert Munteanu (Jira)
[ https://issues.apache.org/jira/browse/SLING-11840?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Munteanu resolved SLING-11840. - Resolution: Fixed > Drop Java 8 support for the Sling Starter >

[GitHub] [sling-org-apache-sling-starter] rombert merged pull request #152: SLING-11840 - Drop Java 8 support for the Sling Starter

2023-04-25 Thread via GitHub
rombert merged PR #152: URL: https://github.com/apache/sling-org-apache-sling-starter/pull/152 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: Sling GrsphQL CORE 0.0.20 Release ?

2023-04-25 Thread Robert Munteanu
Hi Andy, On Mon, 2023-04-24 at 16:39 -0700, Andreas Schaefer wrote: (snip) > Unfortunately I only got 2 Up Votes. So what shall I do next? Cancel > the vote? Cancel the Vote and try again? There is no reason to cancel the vote, since there were no -1 votes, and from your email I understand

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#issuecomment-1521356717 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] sonarcloud[bot] commented on pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
sonarcloud[bot] commented on PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#issuecomment-1521348271 Kudos, SonarCloud Quality Gate passed! [![Quality Gate

[GitHub] [sling-org-apache-sling-feature-cpconverter] DominikSuess commented on a diff in pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
DominikSuess commented on code in PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#discussion_r1176152073 ## src/main/java/org/apache/sling/feature/cpconverter/ContentPackage2FeatureModelConverter.java: ## @@ -117,6 +117,19 @@ public

[GitHub] [sling-org-apache-sling-feature-cpconverter] DominikSuess commented on a diff in pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
DominikSuess commented on code in PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#discussion_r1176147776 ## src/main/java/org/apache/sling/feature/cpconverter/handlers/AbstractConfigurationEntryHandler.java: ## @@ -45,11 +44,13 @@

[GitHub] [sling-org-apache-sling-feature-cpconverter] DominikSuess commented on a diff in pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
DominikSuess commented on code in PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#discussion_r1176147445 ## src/main/java/org/apache/sling/feature/cpconverter/handlers/AbstractRegexEntryHandler.java: ## @@ -45,4 +54,39 @@ public

RE: [VOTE] Release Apache Sling Rewriter version 1.3.6

2023-04-25 Thread Stefan Seifert
+1 stefan

RE: [VOTE] Release Apache Sling GraphQL Core 0.0.20

2023-04-25 Thread Stefan Seifert
+1 stefan

[GitHub] [sling-org-apache-sling-feature-cpconverter] DominikSuess commented on a diff in pull request #165: SLING-11838 - adding support for runMode policies & runmode inheritance

2023-04-25 Thread via GitHub
DominikSuess commented on code in PR #165: URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/165#discussion_r1176084733 ## src/main/java/org/apache/sling/feature/cpconverter/handlers/AbstractRegexEntryHandler.java: ## @@ -45,4 +54,39 @@ public