Re: Simpler Feature flags for sling

2023-09-21 Thread Robert Munteanu
On Thu, 2023-09-21 at 11:06 +0200, Robert Munteanu wrote: > On Thu, 2023-09-21 at 09:07 +0200, Christian Schneider wrote: > > He proposed a nice alternative to simply use "toggle.FT-SLING-1234" > > scheme > > for the Condition ids. > > I think I am still missing context, sorry for being dense :-)

Re: Simpler Feature flags for sling

2023-09-21 Thread Robert Munteanu
On Thu, 2023-09-21 at 09:07 +0200, Christian Schneider wrote: > He proposed a nice alternative to simply use "toggle.FT-SLING-1234" > scheme > for the Condition ids. I think I am still missing context, sorry for being dense :-) What does using the toggle mean for a Sling module? I am not sure if

Re: Simpler Feature flags for sling

2023-09-21 Thread Christian Schneider
I spoke to Carsten about how to have feature flags for closed as well as open source OSGi projects. He proposed a nice alternative to simply use "toggle.FT-SLING-1234" scheme for the Condition ids. This would work universally if all our OSGi projects (Oak, Sling, Felix) can agree on it. What do

Re: Simpler Feature flags for sling

2023-09-19 Thread Robert Munteanu
Hi Christian, On Mon, 2023-09-18 at 16:57 +0200, Christian Schneider wrote: > I propose that we expose feature toggles using a prefix + the toggle > name. > So for example it could be "org.apache.sling.toggle.FT-SLING-1234". > > I have already experimented with this and it seems feasible. This

Simpler Feature flags for sling

2023-09-18 Thread Christian Schneider
Hi all, I need to introduce a feature flag to sling code. I have seen https://sling.apache.org/documentation/the-sling-engine/featureflags.html but I think we can do this simpler. In OSGi R8 there is https://docs.osgi.org/specification/osgi.core/8.0.0/service.condition.html . This is ideal for