Re: Call for Vote on 3.4.0-rc1

2013-06-18 Thread Axb
KEvin, Please allow +- 7 days to test latest Bayes/Redis changes before cutting the RC1. Otherwise +1 On 06/18/2013 05:26 AM, Kevin A. McGrail wrote: Please vote to release 3.4.0-rc1. Files at http://people.apache.org/~kmcgrail/devel/ Proposed Announcement follows. Regards, KAM To:

[Bug 6942] Redis bayes storage module fixes and updates

2013-06-18 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6942 --- Comment #40 from AXB axb.li...@gmail.com --- (In reply to Mark Martinec from comment #39) Created attachment 5151 [details] the BayesStore/Redis.pm implementing the new data repr. using Lua (updated) New attachment: just fixed

Re: Call for Vote on 3.4.0-rc1

2013-06-18 Thread Kevin A. McGrail
On 6/18/2013 9:17 AM, Axb wrote: On 06/18/2013 03:07 PM, Kevin A. McGrail wrote: On 6/18/2013 2:03 AM, Axb wrote: KEvin, Please allow +- 7 days to test latest Bayes/Redis changes before cutting the RC1. Otherwise +1 I'll wait on your vote until the 25th. Thanks Kevin Mark is polishing

Re: Call for Vote on 3.4.0-rc1

2013-06-18 Thread Axb
On 06/18/2013 03:30 PM, Kevin A. McGrail wrote: On 6/18/2013 9:17 AM, Axb wrote: On 06/18/2013 03:07 PM, Kevin A. McGrail wrote: On 6/18/2013 2:03 AM, Axb wrote: KEvin, Please allow +- 7 days to test latest Bayes/Redis changes before cutting the RC1. Otherwise +1 I'll wait on your vote

Re: Call for Vote on 3.4.0-rc1

2013-06-18 Thread Kevin A. McGrail
On 6/18/2013 9:34 AM, Axb wrote: To be clear, if the polish involves changing the code, then you are asking for an rc2. The changes should be reflected in RC1 to avoid ppl having to trash their Bayes data due to a data format change. This would not be very kind and could scsare potential

[Bug 6942] Redis bayes storage module fixes and updates

2013-06-18 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6942 --- Comment #41 from Mark Martinec mark.marti...@ijs.si --- redis-cli info redis_version:2.6.13 used_memory_lua:31744 CPAN Redis.pm is 1.961 Perfect. Investigated which is the minimal version of Redis.pm module to support what we

[Bug 6942] Redis bayes storage module fixes and updates

2013-06-18 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6942 Mark Martinec mark.marti...@ijs.si changed: What|Removed |Added Attachment #5145|0 |1

Re: Call for Vote on 3.4.0-rc1

2013-06-18 Thread Axb
On 06/18/2013 03:58 PM, Kevin A. McGrail wrote: On 6/18/2013 9:34 AM, Axb wrote: To be clear, if the polish involves changing the code, then you are asking for an rc2. The changes should be reflected in RC1 to avoid ppl having to trash their Bayes data due to a data format change. This would

[Bug 6942] Redis bayes storage module fixes and updates

2013-06-18 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6942 Mark Martinec mark.marti...@ijs.si changed: What|Removed |Added Attachment #5152|0 |1

[Bug 6942] Redis bayes storage module fixes and updates

2013-06-18 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6942 --- Comment #44 from Mark Martinec mark.marti...@ijs.si --- Oh well, Bug 6942 - Redis bayes storage module - fix database restore/init Sending lib/Mail/SpamAssassin/BayesStore/Redis.pm Committed revision 1494159. -- You are

Re: Call for Vote on 3.4.0-rc1

2013-06-18 Thread Mark Martinec
To be clear, if the polish involves changing the code, then you are asking for an rc2. The changes should be reflected in RC1 to avoid ppl having to trash their Bayes data due to a data format change. This would not be very kind and could scsare potential early adopters away and give

Re: Call for Vote on 3.4.0-rc1

2013-06-18 Thread Axb
On 06/18/2013 05:11 PM, Mark Martinec wrote: To be clear, if the polish involves changing the code, then you are asking for an rc2. The changes should be reflected in RC1 to avoid ppl having to trash their Bayes data due to a data format change. This would not be very kind and could scsare

Re: Call for Vote on 3.4.0-rc1

2013-06-18 Thread Kevin A. McGrail
On 6/18/2013 11:11 AM, Mark Martinec wrote: To be clear, if the polish involves changing the code, then you are asking for an rc2. The changes should be reflected in RC1 to avoid ppl having to trash their Bayes data due to a data format change. This would not be very kind and could scsare

Re: Call for Vote on 3.4.0-rc1

2013-06-18 Thread Mark Martinec
I'm sorry the work on Lua happened to coincide with Kevin's work on RC1. No worries! I've been documenting much more of the process which is the real time drain. I can cut a new rc in a hour or sooner now I believe other than waiting for a make disttest to complete. Should I wait 1 week

Re: Call for Vote on 3.4.0-rc1

2013-06-18 Thread Kevin A. McGrail
On 6/18/2013 12:19 PM, Mark Martinec wrote: Don't think a week is needed, perhaps a day would be in order to let AXB roll this version into his setup and let it run for a little while. OK, I'll check the vote tomorrow night (which already has negatives) and make it official to get started on

Re: Call for Vote on 3.4.0-rc1

2013-06-18 Thread John Hardin
On Tue, 18 Jun 2013, Kevin A. McGrail wrote: On 6/18/2013 12:19 PM, Mark Martinec wrote: Don't think a week is needed, perhaps a day would be in order to let AXB roll this version into his setup and let it run for a little while. OK, I'll check the vote tomorrow night (which already has

[Bug 6942] Redis bayes storage module fixes and updates

2013-06-18 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6942 --- Comment #45 from AXB axb.li...@gmail.com --- (In reply to Mark Martinec from comment #44) Oh well, Bug 6942 - Redis bayes storage module - fix database restore/init Sending lib/Mail/SpamAssassin/BayesStore/Redis.pm Committed

[Bug 6942] Redis bayes storage module fixes and updates

2013-06-18 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6942 --- Comment #46 from Mark Martinec mark.marti...@ijs.si --- After replacing Redis.pm, flushing the DB, restzart redis server I'm getting only autolearn=unavailable Jun 18 21:02:03.566 [39947] warn: bayes: bayes old token format 0 not

[Bug 6942] Redis bayes storage module fixes and updates

2013-06-18 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6942 --- Comment #47 from AXB axb.li...@gmail.com --- (In reply to Mark Martinec from comment #46) After replacing Redis.pm, flushing the DB, restzart redis server I'm getting only autolearn=unavailable Jun 18 21:02:03.566 [39947]

[Bug 6942] Redis bayes storage module fixes and updates

2013-06-18 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6942 --- Comment #48 from Mark Martinec mark.marti...@ijs.si --- So ... either ditch the existing database and restart redis server (so that SA will initialize it to v:TOKEN_FORMAT = 2), or hack it: $ redis-cli set v:TOKEN_FORMAT 2

[Bug 6942] Redis bayes storage module fixes and updates

2013-06-18 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6942 --- Comment #49 from Mark Martinec mark.marti...@ijs.si --- My guess is that the redis server wasn't fully stopped while deleting its redis/dump.rdb file. ... or perhaps one of running SpamAssassin processes was still at an old

Re: Call for Vote on 3.4.0-rc1

2013-06-18 Thread Michael Parker
On Jun 18, 2013, at 11:39 AM, Kevin A. McGrail kmcgr...@pccc.com wrote: On 6/18/2013 12:19 PM, Mark Martinec wrote: Don't think a week is needed, perhaps a day would be in order to let AXB roll this version into his setup and let it run for a little while. OK, I'll check the vote tomorrow

Re: Call for Vote on 3.4.0-rc1

2013-06-18 Thread Kevin A. McGrail
On 6/18/2013 8:36 PM, Michael Parker wrote: On Jun 18, 2013, at 11:39 AM, Kevin A. McGrail kmcgr...@pccc.com wrote: On 6/18/2013 12:19 PM, Mark Martinec wrote: Don't think a week is needed, perhaps a day would be in order to let AXB roll this version into his setup and let it run for a

[Bug 6942] Redis bayes storage module fixes and updates

2013-06-18 Thread bugzilla-daemon
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6942 --- Comment #50 from AXB axb.li...@gmail.com --- (In reply to Mark Martinec from comment #49) My guess is that the redis server wasn't fully stopped while deleting its redis/dump.rdb file. ... or perhaps one of running