On 1/15/2015 11:09 AM, Mark Martinec wrote:
:-) Well I don't want to change the vetting process for a release and
xt/60_perlcritic.t has been used for years on the code base.
Suggestions what we can do to resolve the issue that also passes that
test so we don't have to go down that rabbithole?
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7119
Bug ID: 7119
Summary: Perl::Critic:
ControlStructures::ProhibitMutatingListFunctions
Product: Spamassassin
Version: SVN Trunk (Latest Devel Version)
Hardware: All
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7119
--- Comment #1 from Mark Martinec mark.marti...@ijs.si ---
Created attachment 5264
-- https://issues.apache.org/SpamAssassin/attachment.cgi?id=5264action=edit
log
Full output from '$ prove xt/60_perlcritic.t'
--
You are receiving
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7120
Bug ID: 7120
Summary: return statement with explicit undef -
Perl::Critic :
Subroutines::ProhibitExplicitReturnUndef
Product: Spamassassin
Version: SVN
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7119
Mark Martinec mark.marti...@ijs.si changed:
What|Removed |Added
Target Milestone|Undefined |3.4.1
---
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=7119
--- Comment #2 from Mark Martinec mark.marti...@ijs.si ---
Created attachment 5265
-- https://issues.apache.org/SpamAssassin/attachment.cgi?id=5265action=edit
proposed fix
--
You are receiving this mail because:
You are the assignee
:-) Well I don't want to change the vetting process for a release and
xt/60_perlcritic.t has been used for years on the code base.
Suggestions what we can do to resolve the issue that also passes that
test so we don't have to go down that rabbithole?
There are some other perlcritic warnings
There are some other perlcritic warnings about modifying $_ in list
functions
(in sa-update, spamassassin, spamd). Opening a PR would be warranted.
What is a PR? A bugzilla ticket?
Yes, a problem report. Sorry for using terminology from another
context.
If there are other perl critic
--On Thursday, January 15, 2015 11:48 AM -0500 Kevin A. McGrail
kmcgr...@pccc.com wrote:
(in sa-update, spamassassin, spamd). Opening a PR would be warranted.
What is a PR? A bugzilla ticket?
PR is generally short for problem report. So yes, I'd guess a bugzilla
ticket.
--Quanah
