Re: How to run tests properly?

2014-10-30 Thread Niklas Wilcke
Can you please briefly explain why packaging is necessary. I thought packaging would only build the jar and place it in the target folder. How does that affect the tests? If tests depend on the assembly a mvn install would be more sensible to me. Probably I misunderstand the maven build

Re: How to run tests properly?

2014-10-30 Thread Sean Owen
You are right that this is a bit weird compared to the Maven lifecycle semantics. Maven wants assembly to come after tests but here tests want to launch the final assembly as part of some tests. Yes you would not normally have to do this in 2 stages. On Oct 30, 2014 12:28 PM, Niklas Wilcke

Re: How to run tests properly?

2014-10-30 Thread Patrick Wendell
Some of our tests actually require spinning up a small multi-process spark cluster. These use the normal deployment codepath for Spark which is that we rely on the spark assembly jar to be present. That jar is generated when you run mvn package via a special sub project called assembly in our

Re: How to run tests properly?

2014-10-29 Thread Niklas Wilcke
Hi Sean, thanks for your reply. The tests still don't work. I focused on the mllib and core tests and made some observations. The core tests seems to fail because of my german locale. Some tests are locale dependend like the UtilsSuite.scala - string formatting of time durations - checks for

Re: How to run tests properly?

2014-10-29 Thread Patrick Wendell
One thing is you need to do a maven package before you run tests. The local-cluster tests depend on Spark already being packaged. - Patrick On Wed, Oct 29, 2014 at 10:02 AM, Niklas Wilcke 1wil...@informatik.uni-hamburg.de wrote: Hi Sean, thanks for your reply. The tests still don't work. I

Re: How to run tests properly?

2014-10-29 Thread Sean Owen
On Wed, Oct 29, 2014 at 6:02 PM, Niklas Wilcke 1wil...@informatik.uni-hamburg.de wrote: The core tests seems to fail because of my german locale. Some tests are locale dependend like the UtilsSuite.scala - string formatting of time durations - checks for locale dependend seperators like .

How to run tests properly?

2014-10-28 Thread Niklas Wilcke
Hi, I want to contribute to the MLlib library but I can't get the tests up working. I've found three ways of running the tests on the commandline. I just want to execute the MLlib tests. 1. via dev/run-tests script This script executes all tests and take several hours to finish. Some tests

Re: How to run tests properly?

2014-10-28 Thread Sean Owen
On Tue, Oct 28, 2014 at 6:18 PM, Niklas Wilcke 1wil...@informatik.uni-hamburg.de wrote: 1. via dev/run-tests script This script executes all tests and take several hours to finish. Some tests failed but I can't say which of them. Should this really take that long? Can I specify to run only