[GitHub] incubator-spark pull request: SPARK-1072 Use binary search when ne...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/571#issuecomment-34607363 One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12659/

[GitHub] incubator-spark pull request: SPARK-1072 Use binary search when ne...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/571#issuecomment-34607362 Merged build finished.

[GitHub] incubator-spark pull request: SPARK-1072 Use binary search when ne...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/571#issuecomment-34607324 Merged build triggered.

[GitHub] incubator-spark pull request: SPARK-1072 Use binary search when ne...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/571#issuecomment-34607326 Merged build started.

Github merge script

2014-02-09 Thread Andrew Ash
The current script for merging a GitHub PR squashes the commits and sticks a "Merge pull request #123 from abc/def" at the top of the commit message. However this obscures the original commit message when doing a short gitlog (first line only) so the recent history is much less meaningful than bef

[GitHub] incubator-spark pull request: SPARK-1072 Use binary search when ne...

2014-02-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/571#issuecomment-34607216 Jenkins, add to whitelist. Jenkins, test this please.

[GitHub] incubator-spark pull request: Default log4j initialization causes ...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/573#issuecomment-34607127 Merged build triggered.

[GitHub] incubator-spark pull request: Default log4j initialization causes ...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/573#issuecomment-34607128 Merged build started.

[GitHub] incubator-spark pull request: Default log4j initialization causes ...

2014-02-09 Thread pwendell
GitHub user pwendell opened a pull request: https://github.com/apache/incubator-spark/pull/573 Default log4j initialization causes errors for those not using log4j This is a re-do of #560 which got merged too soon. There are some maven build issues we need to fix before merging this

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/570#issuecomment-34606938 @prb - understood that this maintains the status quo otherwise, I hadn't looked closely at it.

[GitHub] incubator-spark pull request: MLI-2: Add k-fold cross validation t...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-34606890 Merged build triggered.

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/570#issuecomment-34606918 FYI #560 had a build issue so I had to revert it. But we'll fix that up and get it merged soon into 0.9 as a fix.

[GitHub] incubator-spark pull request: MLI-2: Add k-fold cross validation t...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-34606891 Merged build started.

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-09 Thread prb
Github user prb commented on the pull request: https://github.com/apache/incubator-spark/pull/570#issuecomment-34606733 @pwendell I think @srowen's changes are actually cleaning up some different loose ends around jcl versus log4j, and what he's talking about being incumbent on the in

Re: 0.9.0 forces log4j usage

2014-02-09 Thread Patrick Wendell
Thanks Paul - it isn't mean to be a "full solution" but just a fix for the 0.9 branch - for the full solution there is another PR by Sean Owen. On Sun, Feb 9, 2014 at 11:35 PM, Paul Brown wrote: > Hi, Patrick -- > > I gave that a go locally, and it works as desired. > > Best. > -- Paul > > -- > p

[GitHub] incubator-spark pull request: MLI-2: Add k-fold cross validation t...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-34606646 Can one of the admins verify this patch?

[GitHub] incubator-spark pull request: MLI-2: Add k-fold cross validation t...

2014-02-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/incubator-spark/pull/572#issuecomment-34606676 Jenkins, add to whitelist.

[GitHub] incubator-spark pull request: MLI-2: Add k-fold cross validation t...

2014-02-09 Thread holdenk
GitHub user holdenk opened a pull request: https://github.com/apache/incubator-spark/pull/572 MLI-2: Add k-fold cross validation to MLLib You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-spark addkfoldcrossvalidat

[GitHub] incubator-spark pull request: [WIP] SPARK-1067: Default log4j init...

2014-02-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/560#issuecomment-34606359 FYI I reverted in both branches this because it caused a maven build error. Also it was a WIP and @rxin merged it by accident.

Re: 0.9.0 forces log4j usage

2014-02-09 Thread Paul Brown
Hi, Patrick -- I gave that a go locally, and it works as desired. Best. -- Paul — p...@mult.ifario.us | Multifarious, Inc. | http://mult.ifario.us/ On Fri, Feb 7, 2014 at 6:10 PM, Patrick Wendell wrote: > Ah okay sounds good. This is what I meant earlier by "You have > some other application

[GitHub] incubator-spark pull request: SPARK-1072 Use binary search when ne...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/571#issuecomment-34606224 Can one of the admins verify this patch?

[GitHub] incubator-spark pull request: SPARK-1072 Use binary search when ne...

2014-02-09 Thread holdenk
GitHub user holdenk opened a pull request: https://github.com/apache/incubator-spark/pull/571 SPARK-1072 Use binary search when needed in RangePartioner You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/incubator-spark switc

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/570#issuecomment-34605097 @prb the changes you are referring to are ripping out direct use of log4j there... right?

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34604097 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12656/

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34604095 Merged build finished.

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread ScrapCodes
Github user ScrapCodes closed the pull request at: https://github.com/apache/incubator-spark/pull/567

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34603635 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12655/

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34603633 Merged build finished.

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34603519 Thanks! I'm merging this now.

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34603285 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12654/

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34603284 Merged build finished.

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34603041 Merged build started.

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34603040 Merged build triggered.

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34603004 Jenkins, retest this please.

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34602966 This patch LGTM then. We should get it in soon (once @rxin is happy) to avoid merge conflicts.

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread ScrapCodes
Github user ScrapCodes commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34602737 Hey thanks @aarondav, they should have been fixed by now :)

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34602711 Merged build started.

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34602710 Merged build triggered.

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread aarondav
Github user aarondav commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34602635 Added a couple comments on top of @rxin's. Thanks so much for doing this @ScrapCodes!

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34602377 Merged build started.

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34602376 Merged build triggered.

[GitHub] incubator-spark pull request: [SPARK-1039] Set the upper bound for...

2014-02-09 Thread CodingCat
Github user CodingCat commented on the pull request: https://github.com/apache/incubator-spark/pull/472#issuecomment-34601727 added some test cases for the feature, waiting for more feedbacks from the users..

[GitHub] incubator-spark pull request: Support negative implicit input in A...

2014-02-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/incubator-spark/pull/500#issuecomment-34601206 Thanks, @mengxr and @MLnick for reviewing this. @srowen this is no longer mergeable due to the style update pr. Do you mind updating the PR so it can be mer

[GitHub] incubator-spark pull request: Improved NetworkReceiver in Spark St...

2014-02-09 Thread hsaputra
Github user hsaputra commented on the pull request: https://github.com/apache/incubator-spark/pull/559#issuecomment-34599448 @tdas, per discussion we have in the dev list, could you file JIRA ticket for this PR? Thanks

Re: How to write test cases for the functionalities which involves actor communication

2014-02-09 Thread Nan Zhu
Good, thank you very much Patrick Best, -- Nan Zhu On Sunday, February 9, 2014 at 1:23 PM, Patrick Wendell wrote: > It's possible to mock out actors... we have a few examples in the code > base. One his here: > > https://github.com/apache/incubator-spark/blob/master/core/src/test/scala/or

[GitHub] incubator-spark pull request: [SPARK-1022] Add real unit test for ...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/510#issuecomment-34596636 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12653/

[GitHub] incubator-spark pull request: [SPARK-1022] Add real unit test for ...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/510#issuecomment-34596635 Merged build finished.

[GitHub] incubator-spark pull request: [SPARK-1022] Add real unit test for ...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/510#issuecomment-34595768 Merged build triggered.

[GitHub] incubator-spark pull request: [SPARK-1022] Add real unit test for ...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/510#issuecomment-34595769 Merged build started.

Re: proposal: replace lift-json with spray-json

2014-02-09 Thread Will Benton
Matei, sorry if I was unclear: I'm referring to downstream operating system distributions (like Fedora or Debian) that have policies requiring that all packages are built from source (using only tools already packaged in the distribution). So end-users (and distributions with different polici

[GitHub] incubator-spark pull request: new MLlib documentation for optimiza...

2014-02-09 Thread martinjaggi
Github user martinjaggi closed the pull request at: https://github.com/apache/incubator-spark/pull/566

Re: proposal: replace lift-json with spray-json

2014-02-09 Thread Mark Hamstra
The JSON handling in the Rapture I/O library is also pretty interesting, but I have no idea what its performance now is or is likely to be, and code maturity is an issue with this project. On Sun, Feb 9, 2014 at 3:06 PM, Pascal Voitot Dev < pascal.voitot@gmail.

[GitHub] incubator-spark pull request: new MLlib documentation for optimiza...

2014-02-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/incubator-spark/pull/566#issuecomment-34591185 Thanks. I've merged this.

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/570#issuecomment-34591106 Merged build finished.

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/570#issuecomment-34591107 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12652/

[GitHub] incubator-spark pull request: Support negative implicit input in A...

2014-02-09 Thread mengxr
Github user mengxr commented on the pull request: https://github.com/apache/incubator-spark/pull/500#issuecomment-34591039 LGTM and thanks for fixing some existing errors!

[GitHub] incubator-spark pull request: new MLlib documentation for optimiza...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/566#issuecomment-34590974 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12651/

[GitHub] incubator-spark pull request: new MLlib documentation for optimiza...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/566#issuecomment-34590973 Merged build finished.

Re: proposal: replace lift-json with spray-json

2014-02-09 Thread Pascal Voitot Dev
Hey andy ;) pickling would be cool for raw serialization/deserialization (not custom validations naturally). Anyway, as said in a previous mail on this mailing list, pickling can't be integrated now until we modify serializers to carry more type information so that pickling macros can be compiled.

Re: proposal: replace lift-json with spray-json

2014-02-09 Thread Pascal Voitot Dev
Hi, I'm one of the play-json developer and I'm advocating for making it an completely independent library outside of Play (it's already independent of Play but it's still delivered as a module of Play) and integrating useful tooling I've been developing last year (JsZipper + Json interpolators). W

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/570#issuecomment-34590322 Merged build triggered.

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/570#issuecomment-34590323 Merged build started.

[GitHub] incubator-spark pull request: new MLlib documentation for optimiza...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/566#issuecomment-34590263 Merged build finished.

[GitHub] incubator-spark pull request: new MLlib documentation for optimiza...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/566#issuecomment-34590264 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12650/

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-09 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/incubator-spark/pull/570 SPARK-1071: Tidy logging strategy and use of log4j Prompted by a recent thread on the mailing list, I tried and failed to see if Spark can be made independent of log4j. There are a few cases

[GitHub] incubator-spark pull request: new MLlib documentation for optimiza...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/566#issuecomment-34590189 Merged build started.

[GitHub] incubator-spark pull request: new MLlib documentation for optimiza...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/566#issuecomment-34590188 Merged build triggered.

[GitHub] incubator-spark pull request: spark on yarn - yarn-client mode doe...

2014-02-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/526#issuecomment-34590172 @tgravescs mind closing this

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34589963 Thanks, @ScrapCodes, for doing this! I just went through all your changes. I made some comments to improve the readability of some line wraps. Often you want to tak

[GitHub] incubator-spark pull request: new MLlib documentation for optimiza...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/566#issuecomment-34589394 Merged build triggered.

[GitHub] incubator-spark pull request: Fixes bug where merges won't close a...

2014-02-09 Thread pwendell
Github user pwendell closed the pull request at: https://github.com/apache/incubator-spark/pull/569

[GitHub] incubator-spark pull request: new MLlib documentation for optimiza...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/566#issuecomment-34589395 Merged build started.

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-09 Thread qqsun8819
Github user qqsun8819 closed the pull request at: https://github.com/apache/incubator-spark/pull/551

[GitHub] incubator-spark pull request: new MLlib documentation for optimiza...

2014-02-09 Thread martinjaggi
Github user martinjaggi commented on the pull request: https://github.com/apache/incubator-spark/pull/566#issuecomment-34589384 yes, that conflict came from the style change. i have rebased the patch again now

Re: proposal: replace lift-json with spray-json

2014-02-09 Thread Matei Zaharia
Will, why are you saying that downstream distributes need to build all of Lift to package lift-json? Spark just downloads it from Maven Central, where it’s a JAR with no external dependencies. We don’t have any dependency on the rest of lift. Matei On Feb 9, 2014, at 11:28 AM, Will Benton wro

[GitHub] incubator-spark pull request: new MLlib documentation for optimiza...

2014-02-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/incubator-spark/pull/566#issuecomment-34588467 Thanks for rebasing this. There's a couple small conflicts, likely from the style cleanup pull request. Do you mind updating this so it can be merged cleanly?

[GitHub] incubator-spark pull request: [SPARK-1038] Add more fields in Json...

2014-02-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/incubator-spark/pull/551#issuecomment-34588354 LGTM. Merging this now. Thanks!

[GitHub] incubator-spark pull request: Fixes bug where merges won't close a...

2014-02-09 Thread rxin
Github user rxin commented on the pull request: https://github.com/apache/incubator-spark/pull/569#issuecomment-34588246 Ok I merged this PR using the script in this PR. Let's see ...

[GitHub] incubator-spark pull request: Fixes bug where merges won't close a...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/569#issuecomment-34587274 Merged build finished.

[GitHub] incubator-spark pull request: Fixes bug where merges won't close a...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/569#issuecomment-34587275 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12649/

[GitHub] incubator-spark pull request: Fixes bug where merges won't close a...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/569#issuecomment-34586304 Merged build started.

[GitHub] incubator-spark pull request: Fixes bug where merges won't close a...

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/569#issuecomment-34586303 Merged build triggered.

[GitHub] incubator-spark pull request: Fixes bug where merges won't close a...

2014-02-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/569#issuecomment-34586150 /cc @rxin

[GitHub] incubator-spark pull request: Fixes bug where merges won't close a...

2014-02-09 Thread pwendell
GitHub user pwendell opened a pull request: https://github.com/apache/incubator-spark/pull/569 Fixes bug where merges won't close associated pull request. Previously we added "Closes #XX" in the title. Github will sometimes linbreak the title in a way that causes this to not work

Re: proposal: replace lift-json with spray-json

2014-02-09 Thread Luis Ángel Vicente Sánchez
I could take a look on how lift-json is used in spark and compare it to argonaut.io. That would be a nice exercise as I still haven't played with json in spark. On 9 Feb 2014 20:12, "Will Benton" wrote: > - Original Message - > > > spray-json only relies on parboiled, a library mantained

[GitHub] incubator-spark pull request: spark on yarn - yarn-client mode doe...

2014-02-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/526#issuecomment-34585080 @rxin - ya I just checked. Kay's pull request had the same issue. I'll change the script around to fix this.

[GitHub] incubator-spark pull request: Principal Component Analysis

2014-02-09 Thread rezazadeh
Github user rezazadeh commented on the pull request: https://github.com/apache/incubator-spark/pull/564#issuecomment-34585044 Yes I agree, densifying the matrix for sake of centering is a problem for sparse matrices. I can solve it, but with appropriate sparse vector support. Once we

[GitHub] incubator-spark pull request: spark on yarn - yarn-client mode doe...

2014-02-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/526#issuecomment-34585015 @rxin Hm seems like this didn't link up correctly either, wonder if this is because the "Closes XX" gets broken in the way that github renders the pull request

Re: proposal: replace lift-json with spray-json

2014-02-09 Thread Will Benton
Thanks; I'll take a look! - Original Message - > From: "andy petrella" > To: dev@spark.incubator.apache.org > Sent: Sunday, February 9, 2014 2:09:05 PM > Subject: Re: proposal: replace lift-json with spray-json > > Pickling ? > At least, Heather did some benchmarks as well and the compu

Re: proposal: replace lift-json with spray-json

2014-02-09 Thread Will Benton
- Original Message - > spray-json only relies on parboiled, a library mantained by the spray-team > itself. Right now it's performance is much worse than lift-json ( > http://engineering.ooyala.com/blog/comparing-scala-json-libraries) but that > would change when they finished parboiled2.

Re: proposal: replace lift-json with spray-json

2014-02-09 Thread andy petrella
Pickling ? At least, Heather did some benchmarks as well and the computability plus its automation thanks to macro are two encouraging features. Also, it is low level enough to allow some de/serialisation optimization. The ooyala blog doesn't include it already, but I know his author knows about P

Re: proposal: replace lift-json with spray-json

2014-02-09 Thread Luis Ángel Vicente Sánchez
spray-json future is not clear as spray is going to become akka-http and the spray team is still deciding the future of spray-json... it may stay or it may be combined with play-json to create a better library. spray-json only relies on parboiled, a library mantained by the spray-team itself. Righ

[GitHub] incubator-spark pull request: Principal Component Analysis

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/564#issuecomment-34583713 All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/12648/

[GitHub] incubator-spark pull request: Principal Component Analysis

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/564#issuecomment-34583712 Build finished.

proposal: replace lift-json with spray-json

2014-02-09 Thread Will Benton
lift-json is a nice library, but Lift is a pretty heavyweight dependency to track just for its JSON support. (lift-json is relatively self-contained as a dependency from an end-user's perspective, but downstream distributors need to build all of Lift in order to package the JSON support.) I un

[GitHub] incubator-spark pull request: Principal Component Analysis

2014-02-09 Thread sscdotopen
Github user sscdotopen commented on the pull request: https://github.com/apache/incubator-spark/pull/564#issuecomment-34583075 Centering a sparse matrix like it is done in textbook PCA is a serious scalability bottleneck as it densifies the input matrix, not sure if you can apply the

[GitHub] incubator-spark pull request: Principal Component Analysis

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/564#issuecomment-34582981 Build triggered.

[GitHub] incubator-spark pull request: Principal Component Analysis

2014-02-09 Thread AmplabJenkins
Github user AmplabJenkins commented on the pull request: https://github.com/apache/incubator-spark/pull/564#issuecomment-34582982 Build started.

[GitHub] incubator-spark pull request: Principal Component Analysis

2014-02-09 Thread rezazadeh
Github user rezazadeh commented on the pull request: https://github.com/apache/incubator-spark/pull/564#issuecomment-34582915 Good catch, added handling of the zeros. Once we have unified sparse data support I will revisit this, tracked by: https://spark-project.atlassian.net/browse/M

[GitHub] incubator-spark pull request: SPARK-1058, Fix Style Errors and Add...

2014-02-09 Thread pwendell
Github user pwendell commented on the pull request: https://github.com/apache/incubator-spark/pull/567#issuecomment-34582688 @ScrapCodes Looks good to me! If you can re-base this on your existing patch I will merge it. Also can you add an Apache header to the xml file?

  1   2   >