[GitHub] incubator-spark pull request: SPARK-1125: When using a http proxy,...

2014-02-24 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/639#issuecomment-35888184 Did you mean to reopen this? it seems entirely specific to your network and proxy requirements. --- If your project is set up for it, you can reply to this

[GitHub] incubator-spark pull request: SPARK-1125: Fix building with maven ...

2014-02-24 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/639#issuecomment-35872621 Hmm! is there a proxy between you and the outside world? anything that would break the SSL connection? I think it's environment-specific in any event. Great

[GitHub] incubator-spark pull request: SPARK-1125: Fix building with maven ...

2014-02-24 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/639#issuecomment-35871340 Why would you exclude the dependency? It is necessary to work, as you show. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] incubator-spark pull request: SPARK-1125: Fix building with maven ...

2014-02-24 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/639#issuecomment-35870621 Still works fine for me even with clearing the local artifact and cleaning. I have the exact same Maven from brew. ``` rm -fr ~/.m2/repository/org

[GitHub] incubator-spark pull request: SPARK-1125: Fix building with maven ...

2014-02-24 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/639#issuecomment-35866347 I am not seeing this problem with the build, and I am using OS X. (It would not be OS X-specific anyway.) Try running with "mvn -U ..." -- this is kin

[GitHub] incubator-spark pull request: SPARK-1084 (part 1). Fix most build ...

2014-02-23 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/incubator-spark/pull/637 SPARK-1084 (part 1). Fix most build warnings. This is a redo of https://github.com/apache/incubator-spark/pull/586 This contains all the same changes, minus dependency changes. It

[GitHub] incubator-spark pull request: SPARK-1084. Fix most build warnings

2014-02-23 Thread srowen
Github user srowen closed the pull request at: https://github.com/apache/incubator-spark/pull/586 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-post your response. If your project does not have this

[GitHub] incubator-spark pull request: SPARK-1084. Fix most build warnings

2014-02-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/586#issuecomment-35843240 OK I'm going to come back with two PRs. One will have the squashed final output of this PR, and the other will have the parts related to dependencies (whic

[GitHub] incubator-spark pull request: [Proposal] Adding sparse data suppor...

2014-02-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/575#issuecomment-35842122 @fommil ASF is silent on the MPL: http://www.apache.org/legal/resolved.html#category-a But Mozilla says it's compatible with AL2: http://www.mozilla.or

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/570#issuecomment-35837259 @pwendell I addressed the last point about pulling up slf4j-over-log4j12 into core (non-test), and the indentation issue. Tests look good. --- If your project

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/incubator-spark/pull/570#discussion_r9976665 --- Diff: project/SparkBuild.scala --- @@ -236,13 +236,15 @@ object SparkBuild extends Build { publishLocalBoth <<= Seq(publishLo

[GitHub] incubator-spark pull request: SPARK-1084. Fix most build warnings

2014-02-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/incubator-spark/pull/586#discussion_r9975107 --- Diff: project/SparkBuild.scala --- @@ -340,7 +336,8 @@ object SparkBuild extends Build { def streamingSettings = sharedSettings ++ Seq

[GitHub] incubator-spark pull request: SPARK-1084. Fix most build warnings

2014-02-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/incubator-spark/pull/586#discussion_r9975099 --- Diff: project/SparkBuild.scala --- @@ -340,7 +336,8 @@ object SparkBuild extends Build { def streamingSettings = sharedSettings ++ Seq

[GitHub] incubator-spark pull request: SPARK-1084. Fix most build warnings

2014-02-23 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/586#issuecomment-35827729 @aarondav Sure, it's already split into commits, and one of them has the dependency changes: https://github.com/srowen/incubator-spark/c

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/incubator-spark/pull/570#discussion_r9975070 --- Diff: project/SparkBuild.scala --- @@ -236,13 +236,15 @@ object SparkBuild extends Build { publishLocalBoth <<= Seq(publishLo

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/incubator-spark/pull/570#discussion_r9975071 --- Diff: project/SparkBuild.scala --- @@ -268,9 +272,9 @@ object SparkBuild extends Build { "it.unimi.dsi" %

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-23 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/incubator-spark/pull/570#discussion_r9975073 --- Diff: bagel/pom.xml --- @@ -51,6 +51,11 @@ scalacheck_${scala.binary.version} test + + org.slf4j

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-22 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/570#issuecomment-35801874 @pwendell I rebased this PR to handle one tiny conflict. Following the conversation yesterday -- yeah the Spark build has core depending on both log4j and slf4j

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-21 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/570#issuecomment-35784348 @pwendell For jcl, yeah have a look at places where this PR excludes commons-logging, like for netty and jets3t. jul is used by, well, Java's own librar

[GitHub] incubator-spark pull request: MLLIB-25: Implicit ALS runs out of m...

2014-02-21 Thread srowen
Github user srowen commented on a diff in the pull request: https://github.com/apache/incubator-spark/pull/629#discussion_r9957753 --- Diff: mllib/src/main/scala/org/apache/spark/mllib/recommendation/ALS.scala --- @@ -212,7 +212,7 @@ class ALS private (var numBlocks: Int, var rank

[GitHub] incubator-spark pull request: MLLIB-25: Implicit ALS runs out of m...

2014-02-21 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/incubator-spark/pull/629 MLLIB-25: Implicit ALS runs out of memory for moderately large numbers of features There's a step in implicit ALS where the matrix `Yt * Y` is computed. It's computed as

[GitHub] incubator-spark pull request: SPARK-1084. Fix most build warnings

2014-02-20 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/586#issuecomment-35619835 Hello all - I think all outstanding questions and comments had been addressed in the last round of comments last week. Before it goes too stale, thought I'd

[GitHub] incubator-spark pull request: Default log4j initialization causes ...

2014-02-20 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/573#issuecomment-35619639 @aarondav They are actually separate issues, although concerning the same specific aspect of the code. @pwendell has a good handle on this particular problem I

[GitHub] incubator-spark pull request: [Proposal] Adding sparse data suppor...

2014-02-18 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/575#issuecomment-35447529 For what it's worth, I like the idea of using breeze, even though I know little about it. Mostly, I like the idea of using something consistent most of all

[GitHub] incubator-spark pull request: [Proposal] Adding sparse data suppor...

2014-02-12 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/575#issuecomment-34954740 My $0.02 to the discussion: 1. Within whatever operations mllib provides, serialization can be considered an implementation detail. But external

[GitHub] incubator-spark pull request: SPARK-1084. Fix most build warnings

2014-02-12 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/586#issuecomment-34940308 Done, I believe. Have another glance at it.

[GitHub] incubator-spark pull request: SPARK-1084. Fix most build warnings

2014-02-12 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/586#issuecomment-34935722 I have a new commit ready to go that addresses the comments, but before I pull the trigger, see replies inline with some questions about how you'd li

[GitHub] incubator-spark pull request: SPARK-1084. Fix most build warnings

2014-02-12 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/incubator-spark/pull/586 SPARK-1084. Fix most build warnings https://spark-project.atlassian.net/browse/SPARK-1084 I hope another boring tidy-up JIRA might be welcome. I'd like to fix most of the war

[GitHub] incubator-spark pull request: [Proposal] Adding sparse data suppor...

2014-02-10 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/575#issuecomment-34715135 Wow nice writeup. (Is Breeze benchmarked too somewhere? don't see it there). Totally agree. That's why I would use JBlas at least for the complex

[GitHub] incubator-spark pull request: [Proposal] Adding sparse data suppor...

2014-02-10 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/575#issuecomment-34711528 I see the other discussion -- https://github.com/mesos/spark/pull/736 ? I didn't see the benchmark but maybe missed it. I think there was an impre

[GitHub] incubator-spark pull request: Default log4j initialization causes ...

2014-02-10 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/573#issuecomment-34701207 I think I misunderstood the nature of the infinite loop and thought it had to do with querying for the appenders. If not, yeah, removing the guard does not

[GitHub] incubator-spark pull request: [Proposal] Adding sparse data suppor...

2014-02-10 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/575#issuecomment-34692729 The mahout-math implementation of vectors is encumbered with a few bad design choices, Hadoop stuff that's not needed here, dependence on that old fork of

[GitHub] incubator-spark pull request: Default log4j initialization causes ...

2014-02-10 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/573#issuecomment-34666426 Sorry, my meaning was: how about solving this by removing the guard? The guard is the problem. It's there to prevent executing the log4j config when log4j i

[GitHub] incubator-spark pull request: MLLIB-22. Support negative implicit ...

2014-02-10 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/500#issuecomment-34627005 @rxin Done, and I opened a JIRA for this too, retroactively, given that's the current practice.

[GitHub] incubator-spark pull request: Default log4j initialization causes ...

2014-02-10 Thread srowen
Github user srowen commented on the pull request: https://github.com/apache/incubator-spark/pull/573#issuecomment-34623406 A few thoughts on this issue -- I don't know if these lead to a solution -- Is it necessary to guard this block of code with a check to see if log

[GitHub] incubator-spark pull request: SPARK-1071: Tidy logging strategy an...

2014-02-09 Thread srowen
GitHub user srowen opened a pull request: https://github.com/apache/incubator-spark/pull/570 SPARK-1071: Tidy logging strategy and use of log4j Prompted by a recent thread on the mailing list, I tried and failed to see if Spark can be made independent of log4j. There are a few