Re: Review Request 38836: SQOOP-2549

2015-09-28 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38836/#review100918 --- Thank you for the patch Abe! common/src/main/java/org/apache/sqoo

[jira] [Commented] (SQOOP-2549) Sqoop2: Allow connector developers to mask certain keys in Maps when sending them back to clients

2015-09-28 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934533#comment-14934533 ] Sqoop QA bot commented on SQOOP-2549: - Testing file [SQOOP-2549.patch|https://issues.

[jira] [Commented] (SQOOP-2586) Sqoop2: Oracle DATE type error

2015-09-28 Thread lvchuanwen (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934511#comment-14934511 ] lvchuanwen commented on SQOOP-2586: --- thanks > Sqoop2: Oracle DATE type error >

[jira] [Commented] (SQOOP-2549) Sqoop2: Allow connector developers to mask certain keys in Maps when sending them back to clients

2015-09-28 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934478#comment-14934478 ] Jarek Jarcec Cecho commented on SQOOP-2549: --- Not sure whether the integration te

[jira] [Commented] (SQOOP-2549) Sqoop2: Allow connector developers to mask certain keys in Maps when sending them back to clients

2015-09-28 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934473#comment-14934473 ] Sqoop QA bot commented on SQOOP-2549: - Testing file [SQOOP-2549.patch|https://issues.

[jira] [Updated] (SQOOP-2549) Sqoop2: Allow connector developers to mask certain keys in Maps when sending them back to clients

2015-09-28 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated SQOOP-2549: Attachment: SQOOP-2549.patch > Sqoop2: Allow connector developers to mask certain keys in Maps when

[jira] [Updated] (SQOOP-2549) Sqoop2: Allow connector developers to mask certain keys in Maps when sending them back to clients

2015-09-28 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated SQOOP-2549: Attachment: (was: SQOOP-2549.patch) > Sqoop2: Allow connector developers to mask certain keys in

Review Request 38836: SQOOP-2549

2015-09-28 Thread Abraham Fine
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38836/ --- Review request for Sqoop. Bugs: SQOOP-2549 https://issues.apache.org/jira/b

[jira] [Updated] (SQOOP-2549) Sqoop2: Allow connector developers to mask certain keys in Maps when sending them back to clients

2015-09-28 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated SQOOP-2549: Attachment: SQOOP-2549.patch > Sqoop2: Allow connector developers to mask certain keys in Maps when

[jira] [Commented] (SQOOP-2579) Sqoop2: Refactore RepositoryManager to not load structure from repository when loading jobs and links

2015-09-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934369#comment-14934369 ] Hudson commented on SQOOP-2579: --- SUCCESS: Integrated in Sqoop2 #909 (See [https://builds.ap

[jira] [Updated] (SQOOP-2579) Sqoop2: Refactore RepositoryManager to not load structure from repository when loading jobs and links

2015-09-28 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-2579: -- Fix Version/s: 1.99.7 > Sqoop2: Refactore RepositoryManager to not load structure from r

[jira] [Commented] (SQOOP-2579) Sqoop2: Refactore RepositoryManager to not load structure from repository when loading jobs and links

2015-09-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934335#comment-14934335 ] ASF subversion and git services commented on SQOOP-2579: Commit be

Re: Review Request 38689: SQOOP-2579

2015-09-28 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38689/#review100894 --- Ship it! Ship It! - Jarek Cecho On Sept. 28, 2015, 10:26 p.m.,

Re: Review Request 38689: SQOOP-2579

2015-09-28 Thread Jarek Cecho
> On Sept. 28, 2015, 10:21 p.m., Jarek Cecho wrote: > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java, > > lines 2103-2106 > > > > > > Considering how di

Re: Review Request 38689: SQOOP-2579

2015-09-28 Thread Abraham Fine
> On Sept. 28, 2015, 10:21 p.m., Jarek Cecho wrote: > > repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java, > > lines 2103-2106 > > > > > > Considering how di

[jira] [Commented] (SQOOP-2577) Sqoop2: Support loading classes using custom classloader in ClassUtils

2015-09-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934283#comment-14934283 ] Hudson commented on SQOOP-2577: --- SUCCESS: Integrated in Sqoop2 #908 (See [https://builds.ap

[jira] [Commented] (SQOOP-2579) Sqoop2: Refactore RepositoryManager to not load structure from repository when loading jobs and links

2015-09-28 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934229#comment-14934229 ] Sqoop QA bot commented on SQOOP-2579: - Testing file [SQOOP-2579.patch|https://issues.

Re: Review Request 38689: SQOOP-2579

2015-09-28 Thread Abraham Fine
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38689/ --- (Updated Sept. 28, 2015, 10:26 p.m.) Review request for Sqoop and Jarek Cecho.

[jira] [Commented] (SQOOP-2577) Sqoop2: Support loading classes using custom classloader in ClassUtils

2015-09-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934165#comment-14934165 ] ASF subversion and git services commented on SQOOP-2577: Commit 7c

[jira] [Updated] (SQOOP-2579) Sqoop2: Refactore RepositoryManager to not load structure from repository when loading jobs and links

2015-09-28 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated SQOOP-2579: Attachment: SQOOP-2579.patch > Sqoop2: Refactore RepositoryManager to not load structure from reposi

[jira] [Updated] (SQOOP-2579) Sqoop2: Refactore RepositoryManager to not load structure from repository when loading jobs and links

2015-09-28 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated SQOOP-2579: Attachment: (was: SQOOP-2579.patch) > Sqoop2: Refactore RepositoryManager to not load structure

[jira] [Updated] (SQOOP-2579) Sqoop2: Refactore RepositoryManager to not load structure from repository when loading jobs and links

2015-09-28 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated SQOOP-2579: Attachment: SQOOP-2579.patch > Sqoop2: Refactore RepositoryManager to not load structure from reposi

[jira] [Updated] (SQOOP-2579) Sqoop2: Refactore RepositoryManager to not load structure from repository when loading jobs and links

2015-09-28 Thread Abraham Fine (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Abraham Fine updated SQOOP-2579: Attachment: (was: SQOOP-2579.patch) > Sqoop2: Refactore RepositoryManager to not load structure

[jira] [Commented] (SQOOP-2577) Sqoop2: Support loading classes using custom classloader in ClassUtils

2015-09-28 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933832#comment-14933832 ] Sqoop QA bot commented on SQOOP-2577: - Testing file [SQOOP-2577.3.patch|https://issue

[jira] [Commented] (SQOOP-2586) Sqoop2: Oracle DATE type error

2015-09-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933824#comment-14933824 ] Hudson commented on SQOOP-2586: --- SUCCESS: Integrated in Sqoop2 #907 (See [https://builds.ap

[jira] [Commented] (SQOOP-2387) Sqoop should support importing from table with column names containing some special character

2015-09-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933801#comment-14933801 ] Hudson commented on SQOOP-2387: --- FAILURE: Integrated in Sqoop-hadoop23 #1220 (See [https://

[jira] [Commented] (SQOOP-2387) Sqoop should support importing from table with column names containing some special character

2015-09-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933780#comment-14933780 ] Hudson commented on SQOOP-2387: --- FAILURE: Integrated in Sqoop-hadoop100 #984 (See [https://

[jira] [Commented] (SQOOP-2387) Sqoop should support importing from table with column names containing some special character

2015-09-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933759#comment-14933759 ] Hudson commented on SQOOP-2387: --- FAILURE: Integrated in Sqoop-hadoop200 #1024 (See [https:/

Re: Review Request 38554: SQOOP-817 Avro import is not supporting CLOB data type

2015-09-28 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38554/#review100840 --- The patch looks good to me, my only comment is that we should docum

[jira] [Commented] (SQOOP-2387) Sqoop should support importing from table with column names containing some special character

2015-09-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933738#comment-14933738 ] Hudson commented on SQOOP-2387: --- FAILURE: Integrated in Sqoop-hadoop20 #1017 (See [https://

Re: Review Request 37353: Support snappy compression in Sqoop Import with HCatalog.The Jira is SQOOP-2331

2015-09-28 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37353/#review100838 --- Thanks for taking a look Shashank and my apologies for late review

[jira] [Commented] (SQOOP-2577) Sqoop2: Support loading classes using custom classloader in ClassUtils

2015-09-28 Thread Sqoop QA bot (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933711#comment-14933711 ] Sqoop QA bot commented on SQOOP-2577: - Testing file [SQOOP-2577.3.patch|https://issue

Re: Review Request 38670: Sqoop2: Support loading classes using custom classloader in ClassUtils

2015-09-28 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38670/#review100836 --- Ship it! +1 as long as precommit hook passes - Jarek Cecho On S

[jira] [Commented] (SQOOP-2577) Sqoop2: Support loading classes using custom classloader in ClassUtils

2015-09-28 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933708#comment-14933708 ] Jarek Jarcec Cecho commented on SQOOP-2577: --- I'm not sure why the precommit hook

Re: Review Request 38670: Sqoop2: Support loading classes using custom classloader in ClassUtils

2015-09-28 Thread Jarek Cecho
> On Sept. 24, 2015, 8:50 p.m., Jarek Cecho wrote: > > Overall the code looks good to me, but I have few questions: > > > > 1) Since this is significant change, we should provide some tests for it. > > I'm not immediately sure how to test those though. Any thoughts Dian? > > > > 2) I was wonde

[jira] [Commented] (SQOOP-2586) Sqoop2: Oracle DATE type error

2015-09-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933668#comment-14933668 ] ASF subversion and git services commented on SQOOP-2586: Commit 2e

[jira] [Updated] (SQOOP-2586) Sqoop2: Oracle DATE type error

2015-09-28 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho updated SQOOP-2586: -- Summary: Sqoop2: Oracle DATE type error (was: oracle DATE type error) > Sqoop2: Oracle

[jira] [Commented] (SQOOP-2586) oracle DATE type error

2015-09-28 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933666#comment-14933666 ] Jarek Jarcec Cecho commented on SQOOP-2586: --- I see your reasoning [~lvchuanwen],

[jira] [Assigned] (SQOOP-2586) oracle DATE type error

2015-09-28 Thread Jarek Jarcec Cecho (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jarek Jarcec Cecho reassigned SQOOP-2586: - Assignee: lvchuanwen Added you to contributors list so that you can assign JIRAs

[jira] [Commented] (SQOOP-2387) Sqoop should support importing from table with column names containing some special character

2015-09-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933643#comment-14933643 ] ASF subversion and git services commented on SQOOP-2387: Commit 69

Re: Review Request 37249: SQOOP-2387: Sqoop should support importing from table with column names containing some special character

2015-09-28 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37249/#review100825 --- Ship it! Ship It! - Jarek Cecho On Sept. 16, 2015, 11:42 p.m.,

[jira] [Commented] (SQOOP-2578) Sqoop2: Port the ApplicationClassLoader in Hadoop into Sqoop

2015-09-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933570#comment-14933570 ] Hudson commented on SQOOP-2578: --- SUCCESS: Integrated in Sqoop2 #906 (See [https://builds.ap

[jira] [Commented] (SQOOP-2578) Sqoop2: Port the ApplicationClassLoader in Hadoop into Sqoop

2015-09-28 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/SQOOP-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933551#comment-14933551 ] ASF subversion and git services commented on SQOOP-2578: Commit 52

Re: Review Request 38458: Sqoop2: Port the ApplicationClassLoader in Hadoop into Sqoop

2015-09-28 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38458/#review100818 --- Ship it! Ship It! - Jarek Cecho On Sept. 25, 2015, 1:36 a.m., D

Re: Review Request 38589: SQOOP-2563: Sqoop2: Jetty: Update script for Jetty server

2015-09-28 Thread Jarek Cecho
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38589/#review100815 --- My last round of testing on real cluster: dist/src/main/bin/sqoop