[GitHub] sqoop pull request #38: Metastore

2017-08-02 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130811043 --- Diff: src/java/org/apache/sqoop/metastore/GenericJobStorage.java --- @@ -675,6 +736,14 @@ private void initV0Schema() throws SQLException { }

[GitHub] sqoop pull request #38: Metastore

2017-08-02 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130806000 --- Diff: src/docs/user/metastore-purpose.txt --- @@ -22,6 +22,7 @@ Multiple users and/or remote users can define and execute saved jobs (created with +sq

[GitHub] sqoop pull request #38: Metastore

2017-08-02 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130812016 --- Diff: src/java/org/apache/sqoop/tool/JobTool.java --- @@ -369,6 +366,61 @@ public void applyOptions(CommandLine in, SqoopOptions out) } }

[GitHub] sqoop pull request #38: Metastore

2017-08-02 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130810721 --- Diff: src/java/org/apache/sqoop/metastore/GenericJobStorage.java --- @@ -666,6 +722,11 @@ private void createJobTable() throws SQLException { */

[GitHub] sqoop pull request #38: Metastore

2017-08-02 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130807571 --- Diff: src/java/org/apache/sqoop/manager/CubridManager.java --- @@ -44,7 +44,7 @@ // driver class to ensure is loaded when making db connection.

Re: [GitHub] sqoop pull request #38: Metastore

2017-08-01 Thread Szabolcs Vasas
Hi Priyanshi, I am happy that you would like to contribute! There is a wiki page ( https://cwiki.apache.org/confluence/display/SQOOP/How+to+Contribute) about how you can start working on Sqoop I think reading it is a good first step. If you have any further questions you can always contact the dev

Re: [GitHub] sqoop pull request #38: Metastore

2017-07-31 Thread Priyanshi Sharma
Hey everyone, I'm Priyanshi Sharma. 3rd year B.tech student studying Computer Science. I'd like to contribute. Can someone please help me get started? On Fri, Jul 28, 2017 at 7:41 PM, szvasas wrote: > Github user szvasas commented on a diff in the pull request: > > https://github.com/apache

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130098767 --- Diff: src/test/com/cloudera/sqoop/JobToolTest.java --- @@ -0,0 +1,258 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130098876 --- Diff: src/test/com/cloudera/sqoop/JobToolTest.java --- @@ -0,0 +1,258 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + *

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130062627 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130062575 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130057397 --- Diff: src/docs/Makefile --- @@ -24,8 +24,7 @@ VERSION=Unknown # Building documentation under CentOS causes xmlto to have issues # with valid

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130082318 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130062375 --- Diff: src/java/org/apache/sqoop/tool/JobTool.java --- @@ -346,8 +361,21 @@ public void applyOptions(CommandLine in, SqoopOptions out) this.storage

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130084482 --- Diff: src/java/org/apache/sqoop/metastore/GenericJobStorage.java --- @@ -666,6 +681,14 @@ private void createJobTable() throws SQLException { */

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130062813 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130059198 --- Diff: src/java/org/apache/sqoop/metastore/GenericJobStorage.java --- @@ -113,11 +121,14 @@ private static final String SQOOP_TOOL_KEY = "sqoop.tool";

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130062567 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130082337 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130057718 --- Diff: src/docs/user/metastore-purpose.txt --- @@ -22,6 +22,8 @@ Multiple users and/or remote users can define and execute saved jobs (created with +sq

[GitHub] sqoop pull request #38: Metastore

2017-07-28 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r130063002 --- Diff: src/test/com/cloudera/sqoop/metastore/SavedJobsTest.java --- @@ -0,0 +1,379 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] sqoop pull request #38: Metastore

2017-07-26 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r129515098 --- Diff: src/docs/user/metastore-purpose.txt --- @@ -22,6 +22,8 @@ Multiple users and/or remote users can define and execute saved jobs (created with +sq

[GitHub] sqoop pull request #38: Metastore

2017-07-26 Thread szvasas
Github user szvasas commented on a diff in the pull request: https://github.com/apache/sqoop/pull/38#discussion_r129511691 --- Diff: src/java/com/cloudera/sqoop/metastore/GeneralJobStorage.java --- @@ -15,22 +15,22 @@ * See the License for the specific language governing permi

[GitHub] sqoop pull request #38: Metastore

2017-07-24 Thread zachb1217
GitHub user zachb1217 opened a pull request: https://github.com/apache/sqoop/pull/38 Metastore You can merge this pull request into a Git repository by running: $ git pull https://github.com/zachb1217/sqoop metastore Alternatively you can review and apply these changes as the