Re: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-24 Thread Martin Sebor
Travis Vitek wrote: Martin Sebor wrote: Okay, so are we all comfortable with this? Or does anyone want to argue to have this change reverted from 4.2.1? Yes, it seems fine. If there are no objections I will go ahead and create a release candidate tarball and get the vote rolling sometime

RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-24 Thread Travis Vitek
Martin Sebor wrote: > >Okay, so are we all comfortable with this? Or does anyone >want to argue to have this change reverted from 4.2.1? > Yes, it seems fine. > >If there are no objections I will go ahead and create >a release candidate tarball and get the vote rolling >sometime later today.

Re: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-24 Thread Martin Sebor
- From: Martin Sebor [mailto:[EMAIL PROTECTED] Sent: Thursday, April 24, 2008 6:02 PM To: dev@stdcxx.apache.org Subject: Re: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp So let me try to summarize the new behavior: Solaris Windows Other floatX

RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-24 Thread Farid Zaripov
> -Original Message- > From: Martin Sebor [mailto:[EMAIL PROTECTED] > Sent: Thursday, April 24, 2008 6:02 PM > To: dev@stdcxx.apache.org > Subject: Re: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp > > So let me try to summarize the new behavior: > &g

Re: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-24 Thread Martin Sebor
Farid Zaripov wrote: -Original Message- From: Martin Sebor [mailto:[EMAIL PROTECTED] On Behalf Of Martin Sebor Sent: Thursday, April 24, 2008 8:53 AM To: dev@stdcxx.apache.org Subject: Re: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp I guess I don't understand why the

RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-24 Thread Farid Zaripov
> -Original Message- > From: Martin Sebor [mailto:[EMAIL PROTECTED] On Behalf Of Martin Sebor > Sent: Thursday, April 24, 2008 8:53 AM > To: dev@stdcxx.apache.org > Subject: Re: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp > > I guess I don't understand w

Re: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Martin Sebor
Farid Zaripov wrote: From: Travis Vitek [mailto:[EMAIL PROTECTED] To: dev@stdcxx.apache.org Suject: RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp With just a quick review, this change looks a bit suspicious. The respective overloads for type double are all defined within

Re: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Martin Sebor
Travis Vitek wrote: Thanks for the careful review! Eric Lemings wrote: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Author: faridz Date: Wed Apr 23 08:20:07 2008 New Revision: 650902 URL: http://svn.apache.org/viewvc?rev=650902&view=rev Log: 2008-04-2

Re: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Farid Zaripov
> From: Travis Vitek [mailto:[EMAIL PROTECTED] > To: dev@stdcxx.apache.org > Suject: RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp >>With just a quick review, this change looks a bit suspicious. The >>respective overloads for type double are all defined within

RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Travis Vitek
>Travis Vitek wrote: > >The overloads on double are in platform specific #ifdef blocks because >they have platform specific code in them (_finite, finite, >isfinite). At >least that is the only reason I see for it. So I don't really see the >overloads on float and double outside of platform spe

RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Travis Vitek
> Eric Lemings wrote: > > >> -Original Message- >> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] >> >> Author: faridz >> Date: Wed Apr 23 08:20:07 2008 >> New Revision: 650902 >> >> URL: http://svn.apache.org/viewvc?rev=650902&view=rev >> Log: >> 2008-04-23 Farid Zaripov <[EMAIL

RE: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp

2008-04-23 Thread Eric Lemings
> -Original Message- > From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] > Sent: Wednesday, April 23, 2008 9:21 AM > To: [EMAIL PROTECTED] > Subject: svn commit: r650902 - /stdcxx/trunk/src/num_put.cpp > > Author: faridz > Date: Wed Apr 23 08:20:07 2008 > Ne