Github user itaifrenkel commented on the pull request:
https://github.com/apache/storm/pull/685#issuecomment-131539757
@HeartSaVioR I also recommend this fix
https://github.com/forter/storm/commit/70f5689b15ab5c6092ed2310fdde4820a4f7bc0d
Otherwise the bolt can fail when preparing
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/665#discussion_r37147769
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/schema/builder/RestJsonSchemaBuilder.java
---
@@ -0,0 +1,53 @@
+package org.apache.stor
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/665#issuecomment-131583675
I volunteer to be sponsor for this connector
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
[
https://issues.apache.org/jira/browse/STORM-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698761#comment-14698761
]
ASF GitHub Bot commented on STORM-851:
--
Github user harshach commented on the pull req
[
https://issues.apache.org/jira/browse/STORM-851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698759#comment-14698759
]
ASF GitHub Bot commented on STORM-851:
--
Github user harshach commented on a diff in th
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/673#issuecomment-131586602
@arunmahadevan is there any option for the user to set that they want to %
of flowing tuples in a topology?
Overall this looks good to me but we need a doc on how thi
[
https://issues.apache.org/jira/browse/STORM-954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698774#comment-14698774
]
ASF GitHub Bot commented on STORM-954:
--
Github user harshach commented on the pull req
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/669#discussion_r37148051
--- Diff: external/storm-kafka/src/jvm/storm/kafka/PartitionManager.java ---
@@ -137,8 +137,14 @@ public EmitState next(SpoutOutputCollector collector) {
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/669#discussion_r37148057
--- Diff: external/storm-kafka/src/jvm/storm/kafka/SpoutConfig.java ---
@@ -27,6 +27,9 @@
public String zkRoot = null;
public String id = nul
[
https://issues.apache.org/jira/browse/STORM-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698775#comment-14698775
]
ASF GitHub Bot commented on STORM-854:
--
Github user harshach commented on a diff in th
[
https://issues.apache.org/jira/browse/STORM-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698776#comment-14698776
]
ASF GitHub Bot commented on STORM-854:
--
Github user harshach commented on a diff in th
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/664#issuecomment-131588005
@arunmahadevan since you've made changes to HdfsBolt as part of STORM-837
can you take look at this PR check if its already handled by your changes.
---
If your project
[
https://issues.apache.org/jira/browse/STORM-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698782#comment-14698782
]
ASF GitHub Bot commented on STORM-969:
--
Github user harshach commented on the pull req
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/649#issuecomment-131588513
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
[
https://issues.apache.org/jira/browse/STORM-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698785#comment-14698785
]
ASF GitHub Bot commented on STORM-958:
--
Github user harshach commented on the pull req
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/651#issuecomment-13151
@tandrup can you please open a JIRA here
https://issues.apache.org/jira/browse/STORM/ and also update the PR with JIRA
number in the title.
---
If your project is set
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/686
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabl
[
https://issues.apache.org/jira/browse/STORM-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698800#comment-14698800
]
ASF GitHub Bot commented on STORM-965:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/STORM-965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698801#comment-14698801
]
Sriharsha Chintalapani commented on STORM-965:
--
Thanks [~pshah] merged into ma
Github user itaifrenkel commented on the pull request:
https://github.com/apache/storm/pull/497#issuecomment-131598963
@HeartSaVioR I also recommend this fix forter@70f5689
Otherwise the bolt can fail when preparing in a busy build server (race
condition between reader and heartbea
[
https://issues.apache.org/jira/browse/STORM-742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698809#comment-14698809
]
ASF GitHub Bot commented on STORM-742:
--
Github user itaifrenkel commented on the pull
Github user arunmahadevan commented on the pull request:
https://github.com/apache/storm/pull/664#issuecomment-131602837
@harshach the changes I made were in the trident implementation (HDFSState)
which is independent of this. Anyways I reviewed the changes.
Overall it appears
[
https://issues.apache.org/jira/browse/STORM-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698819#comment-14698819
]
ASF GitHub Bot commented on STORM-969:
--
Github user arunmahadevan commented on the pul
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/354#issuecomment-131620644
I am +1 on merging into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
[
https://issues.apache.org/jira/browse/STORM-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698911#comment-14698911
]
ASF GitHub Bot commented on STORM-969:
--
Github user dossett commented on the pull requ
Github user dossett commented on the pull request:
https://github.com/apache/storm/pull/664#issuecomment-131648086
@arunmahadevan Thank you for the feedback! I have added a tick tuple
feature to address your first point (I am already using this locally, I forgot
to include it in this
Github user vesense commented on the pull request:
https://github.com/apache/storm/pull/649#issuecomment-131648237
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
[
https://issues.apache.org/jira/browse/STORM-958?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698912#comment-14698912
]
ASF GitHub Bot commented on STORM-958:
--
Github user vesense commented on the pull requ
Github user sweetest commented on a diff in the pull request:
https://github.com/apache/storm/pull/679#discussion_r37155605
--- Diff: external/storm-elasticsearch/README.md ---
@@ -6,37 +6,75 @@
## EsIndexBolt (org.apache.storm.elasticsearch.bolt.EsIndexBolt)
EsIndex
[
https://issues.apache.org/jira/browse/STORM-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698946#comment-14698946
]
ASF GitHub Bot commented on STORM-974:
--
Github user sweetest commented on a diff in th
Github user sweetest commented on a diff in the pull request:
https://github.com/apache/storm/pull/679#discussion_r37155617
--- Diff:
external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/common/EsTestUtil.java
---
@@ -46,6 +47,30 @@ public Fields getComponentO
[
https://issues.apache.org/jira/browse/STORM-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698947#comment-14698947
]
ASF GitHub Bot commented on STORM-974:
--
Github user sweetest commented on a diff in th
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/679#discussion_r37156295
--- Diff:
external/storm-elasticsearch/src/test/java/org/apache/storm/elasticsearch/common/EsTestUtil.java
---
@@ -46,6 +47,30 @@ public Fields getCompone
[
https://issues.apache.org/jira/browse/STORM-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698957#comment-14698957
]
ASF GitHub Bot commented on STORM-974:
--
Github user HeartSaVioR commented on a diff in
Github user HeartSaVioR commented on the pull request:
https://github.com/apache/storm/pull/679#issuecomment-131676338
@sweetest Addressed your comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
[
https://issues.apache.org/jira/browse/STORM-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699008#comment-14699008
]
ASF GitHub Bot commented on STORM-974:
--
Github user HeartSaVioR commented on the pull
Github user sweetest commented on the pull request:
https://github.com/apache/storm/pull/679#issuecomment-131676548
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled a
[
https://issues.apache.org/jira/browse/STORM-974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699010#comment-14699010
]
ASF GitHub Bot commented on STORM-974:
--
Github user sweetest commented on the pull req
Github user rohanag12 commented on a diff in the pull request:
https://github.com/apache/storm/pull/669#discussion_r37159376
--- Diff: external/storm-kafka/src/jvm/storm/kafka/PartitionManager.java ---
@@ -137,8 +137,14 @@ public EmitState next(SpoutOutputCollector collector) {
[
https://issues.apache.org/jira/browse/STORM-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699031#comment-14699031
]
ASF GitHub Bot commented on STORM-854:
--
Github user rohanag12 commented on a diff in t
[
https://issues.apache.org/jira/browse/STORM-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699033#comment-14699033
]
ASF GitHub Bot commented on STORM-854:
--
Github user rohanag12 commented on a diff in t
Github user rohanag12 commented on a diff in the pull request:
https://github.com/apache/storm/pull/669#discussion_r37159512
--- Diff: external/storm-kafka/src/jvm/storm/kafka/SpoutConfig.java ---
@@ -27,6 +27,9 @@
public String zkRoot = null;
public String id = nu
Github user rohanag12 commented on a diff in the pull request:
https://github.com/apache/storm/pull/669#discussion_r37159560
--- Diff: external/storm-kafka/src/jvm/storm/kafka/PartitionManager.java ---
@@ -137,8 +137,14 @@ public EmitState next(SpoutOutputCollector collector) {
[
https://issues.apache.org/jira/browse/STORM-854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699035#comment-14699035
]
ASF GitHub Bot commented on STORM-854:
--
Github user rohanag12 commented on a diff in t
[
https://issues.apache.org/jira/browse/STORM-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699054#comment-14699054
]
ASF GitHub Bot commented on STORM-969:
--
Github user arunmahadevan commented on a diff
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/664#discussion_r37160568
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/HdfsBolt.java ---
@@ -80,6 +86,11 @@ public HdfsBolt addRotationAction(RotationAct
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/664#discussion_r37160668
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/HdfsBolt.java ---
@@ -88,35 +99,94 @@ public void doPrepare(Map conf, TopologyCont
[
https://issues.apache.org/jira/browse/STORM-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699056#comment-14699056
]
ASF GitHub Bot commented on STORM-969:
--
Github user arunmahadevan commented on a diff
Github user arunmahadevan commented on a diff in the pull request:
https://github.com/apache/storm/pull/664#discussion_r37161325
--- Diff:
external/storm-hdfs/src/main/java/org/apache/storm/hdfs/bolt/HdfsBolt.java ---
@@ -88,35 +99,94 @@ public void doPrepare(Map conf, TopologyCont
[
https://issues.apache.org/jira/browse/STORM-969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14699071#comment-14699071
]
ASF GitHub Bot commented on STORM-969:
--
Github user arunmahadevan commented on a diff
50 matches
Mail list logo
