[jira] [Commented] (STORM-1152) Change map keySet iteration to entrySet iteration for efficiency

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983648#comment-14983648 ] ASF GitHub Bot commented on STORM-1152: --- Github user hmcl commented on the pull requ

[GitHub] storm pull request: STORM-1152 Change map keySet iteration to entr...

2015-10-30 Thread hmcl
Github user hmcl commented on the pull request: https://github.com/apache/storm/pull/836#issuecomment-152676783 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[jira] [Commented] (STORM-1152) Change map keySet iteration to entrySet iteration for efficiency

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983632#comment-14983632 ] ASF GitHub Bot commented on STORM-1152: --- Github user harshach commented on the pull

[GitHub] storm pull request: STORM-1152 Change map keySet iteration to entr...

2015-10-30 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/836#issuecomment-152675912 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-1147) Storm JDBCBolt should add validation to ensure either insertQuery or table name is specified and not both.

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983545#comment-14983545 ] ASF GitHub Bot commented on STORM-1147: --- Github user asfgit closed the pull request

[GitHub] storm pull request: STORM-1147: Added validation checks and tests.

2015-10-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/831 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-855) Add tuple batching

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983537#comment-14983537 ] ASF GitHub Bot commented on STORM-855: -- Github user knusbaum commented on a diff in th

[jira] [Commented] (STORM-855) Add tuple batching

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983535#comment-14983535 ] ASF GitHub Bot commented on STORM-855: -- Github user knusbaum commented on a diff in th

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559947 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -375,7 +394,7 @@ private void waitForPendingMessagesToBeSent() { lo

[jira] [Commented] (STORM-855) Add tuple batching

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983533#comment-14983533 ] ASF GitHub Bot commented on STORM-855: -- Github user knusbaum commented on a diff in th

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559957 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -386,11 +405,10 @@ private void waitForPendingMessagesToBeSent() {

[jira] [Commented] (STORM-855) Add tuple batching

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983527#comment-14983527 ] ASF GitHub Bot commented on STORM-855: -- Github user knusbaum commented on a diff in th

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559976 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -510,8 +546,7 @@ public void operationComplete(ChannelFuture future) throws Exc

[jira] [Commented] (STORM-855) Add tuple batching

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983529#comment-14983529 ] ASF GitHub Bot commented on STORM-855: -- Github user knusbaum commented on a diff in th

[jira] [Commented] (STORM-855) Add tuple batching

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983532#comment-14983532 ] ASF GitHub Bot commented on STORM-855: -- Github user knusbaum commented on a diff in th

[jira] [Commented] (STORM-855) Add tuple batching

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983530#comment-14983530 ] ASF GitHub Bot commented on STORM-855: -- Github user knusbaum commented on a diff in th

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559942 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -335,7 +354,7 @@ public void operationComplete(ChannelFuture future) throws Exc

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559969 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -495,7 +531,7 @@ public void operationComplete(ChannelFuture future) throws Exc

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559934 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -292,7 +311,7 @@ private void dropMessages(Iterator msgs) { // We c

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559884 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -202,7 +217,7 @@ public Status status() { @Override public Ite

[jira] [Commented] (STORM-855) Add tuple batching

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983524#comment-14983524 ] ASF GitHub Bot commented on STORM-855: -- Github user knusbaum commented on a diff in th

[jira] [Commented] (STORM-855) Add tuple batching

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983526#comment-14983526 ] ASF GitHub Bot commented on STORM-855: -- Github user knusbaum commented on a diff in th

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559892 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -266,7 +281,7 @@ public void send(Iterator msgs) { // We can re

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r43559925 --- Diff: storm-core/src/jvm/backtype/storm/messaging/netty/Client.java --- @@ -281,6 +296,10 @@ private Channel getConnectedChannel() { }

[GitHub] storm pull request: [STORM-855] Heartbeat Server (Pacemaker)

2015-10-30 Thread knusbaum
GitHub user knusbaum opened a pull request: https://github.com/apache/storm/pull/838 [STORM-855] Heartbeat Server (Pacemaker) This pull request redirects worker heartbeats away from Zookeeper and into a new server, 'Pacemaker'. The redirection is accomplished by making `Clu

[jira] [Commented] (STORM-855) Add tuple batching

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983491#comment-14983491 ] ASF GitHub Bot commented on STORM-855: -- GitHub user knusbaum opened a pull request:

[jira] [Commented] (STORM-1152) Change map keySet iteration to entrySet iteration for efficiency

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983351#comment-14983351 ] ASF GitHub Bot commented on STORM-1152: --- Github user sureshms commented on a diff in

[GitHub] storm pull request: STORM-1152 Change map keySet iteration to entr...

2015-10-30 Thread sureshms
Github user sureshms commented on a diff in the pull request: https://github.com/apache/storm/pull/836#discussion_r43554133 --- Diff: storm-core/src/jvm/backtype/storm/utils/TransferDrainer.java --- @@ -30,18 +31,20 @@ private HashMap>> bundles = new HashMap();

[jira] [Commented] (STORM-1152) Change map keySet iteration to entrySet iteration for efficiency

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983346#comment-14983346 ] ASF GitHub Bot commented on STORM-1152: --- Github user sureshms commented on a diff in

[GitHub] storm pull request: STORM-1152 Change map keySet iteration to entr...

2015-10-30 Thread sureshms
Github user sureshms commented on a diff in the pull request: https://github.com/apache/storm/pull/836#discussion_r43553925 --- Diff: storm-core/src/jvm/backtype/storm/serialization/SerializationFactory.java --- @@ -81,8 +81,9 @@ public static Kryo getKryo(Map conf) {

[jira] [Commented] (STORM-1144) Display requested and assigned cpu/mem resources for schedulers in UI

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983332#comment-14983332 ] ASF GitHub Bot commented on STORM-1144: --- Github user asfgit closed the pull request

[jira] [Resolved] (STORM-1144) Display requested and assigned cpu/mem resources for schedulers in UI

2015-10-30 Thread Derek Dagit (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Derek Dagit resolved STORM-1144. Resolution: Fixed Fix Version/s: 0.11.0 Thanks, [~zhuoliu], I merged this to master. > Displ

[GitHub] storm pull request: [STORM-1144] Provide resource (mem/cpu) assign...

2015-10-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/829 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[jira] [Commented] (STORM-1144) Display requested and assigned cpu/mem resources for schedulers in UI

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983318#comment-14983318 ] ASF GitHub Bot commented on STORM-1144: --- Github user d2r commented on the pull reque

[GitHub] storm pull request: [STORM-1144] Provide resource (mem/cpu) assign...

2015-10-30 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/829#issuecomment-152650906 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wish

[jira] [Commented] (STORM-1144) Display requested and assigned cpu/mem resources for schedulers in UI

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983314#comment-14983314 ] ASF GitHub Bot commented on STORM-1144: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1144] Provide resource (mem/cpu) assign...

2015-10-30 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/829#discussion_r43552033 --- Diff: storm-core/src/jvm/backtype/storm/scheduler/resource/ResourceAwareScheduler.java --- @@ -76,20 +84,30 @@ public void schedule(Topologies topologies, Clu

[jira] [Commented] (STORM-1144) Display requested and assigned cpu/mem resources for schedulers in UI

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983310#comment-14983310 ] ASF GitHub Bot commented on STORM-1144: --- Github user zhuoliu commented on a diff in

[GitHub] storm pull request: [STORM-1144] Provide resource (mem/cpu) assign...

2015-10-30 Thread zhuoliu
Github user zhuoliu commented on a diff in the pull request: https://github.com/apache/storm/pull/829#discussion_r43551741 --- Diff: storm-core/src/storm.thrift --- @@ -146,6 +146,12 @@ struct TopologySummary { 513: optional string sched_status; 514: optional string owner;

[GitHub] storm pull request: [STORM-1144] Provide resource (mem/cpu) assign...

2015-10-30 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/829#discussion_r43551272 --- Diff: storm-core/src/storm.thrift --- @@ -146,6 +146,12 @@ struct TopologySummary { 513: optional string sched_status; 514: optional string owner;

[jira] [Commented] (STORM-1144) Display requested and assigned cpu/mem resources for schedulers in UI

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983298#comment-14983298 ] ASF GitHub Bot commented on STORM-1144: --- Github user d2r commented on a diff in the

[jira] [Commented] (STORM-1144) Display requested and assigned cpu/mem resources for schedulers in UI

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983295#comment-14983295 ] ASF GitHub Bot commented on STORM-1144: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1144] Provide resource (mem/cpu) assign...

2015-10-30 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/829#discussion_r43551008 --- Diff: storm-core/src/jvm/backtype/storm/generated/DebugOptions.java --- @@ -51,7 +51,7 @@ import org.slf4j.LoggerFactory; @SuppressWarnings({"ca

[jira] [Commented] (STORM-1144) Display requested and assigned cpu/mem resources for schedulers in UI

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983291#comment-14983291 ] ASF GitHub Bot commented on STORM-1144: --- Github user d2r commented on a diff in the

[GitHub] storm pull request: [STORM-1144] Provide resource (mem/cpu) assign...

2015-10-30 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/829#discussion_r43550745 --- Diff: STORM-UI-REST-API.md --- @@ -204,6 +213,14 @@ Sample response: "workersTotal": 3, "executorsTotal": 28,

[jira] [Commented] (STORM-1152) Change map keySet iteration to entrySet iteration for efficiency

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983268#comment-14983268 ] ASF GitHub Bot commented on STORM-1152: --- Github user hmcl commented on the pull requ

[jira] [Commented] (STORM-1153) Use static final instead of just static for class members

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983270#comment-14983270 ] ASF GitHub Bot commented on STORM-1153: --- GitHub user sureshms opened a pull request:

[GitHub] storm pull request: STORM-1153 Use static final instead of just st...

2015-10-30 Thread sureshms
GitHub user sureshms opened a pull request: https://github.com/apache/storm/pull/837 STORM-1153 Use static final instead of just static for class members Along with making static variables, I have also cleaned up the code in those files. Especially around reducing code verbosity by

[GitHub] storm pull request: STORM-1152 Change map keySet iteration to entr...

2015-10-30 Thread hmcl
Github user hmcl commented on the pull request: https://github.com/apache/storm/pull/836#issuecomment-152646032 +1 LGTM. A few pinpoints only related with readability of the code that are left to the discretion of the implementer. --- If your project is set up for it, you can reply t

[jira] [Commented] (STORM-1152) Change map keySet iteration to entrySet iteration for efficiency

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983265#comment-14983265 ] ASF GitHub Bot commented on STORM-1152: --- Github user hmcl commented on a diff in the

[GitHub] storm pull request: STORM-1152 Change map keySet iteration to entr...

2015-10-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/836#discussion_r43549539 --- Diff: storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java --- @@ -248,8 +250,9 @@ public StormTopology buildTopology() { }

[jira] [Commented] (STORM-1152) Change map keySet iteration to entrySet iteration for efficiency

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983262#comment-14983262 ] ASF GitHub Bot commented on STORM-1152: --- Github user hmcl commented on a diff in the

[GitHub] storm pull request: STORM-1152 Change map keySet iteration to entr...

2015-10-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/836#discussion_r43549404 --- Diff: storm-core/src/jvm/storm/trident/topology/TridentTopologyBuilder.java --- @@ -233,8 +234,9 @@ public StormTopology buildTopology() { }

[jira] [Commented] (STORM-1152) Change map keySet iteration to entrySet iteration for efficiency

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983260#comment-14983260 ] ASF GitHub Bot commented on STORM-1152: --- Github user hmcl commented on a diff in the

[GitHub] storm pull request: STORM-1152 Change map keySet iteration to entr...

2015-10-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/836#discussion_r43549300 --- Diff: storm-core/src/jvm/storm/trident/spout/OpaquePartitionedTridentSpoutExecutor.java --- @@ -162,9 +162,9 @@ public void commit(TransactionAttempt attempt

[jira] [Created] (STORM-1153) Use static final instead of just static for class members

2015-10-30 Thread Suresh Srinivas (JIRA)
Suresh Srinivas created STORM-1153: -- Summary: Use static final instead of just static for class members Key: STORM-1153 URL: https://issues.apache.org/jira/browse/STORM-1153 Project: Apache Storm

[jira] [Commented] (STORM-1152) Change map keySet iteration to entrySet iteration for efficiency

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983247#comment-14983247 ] ASF GitHub Bot commented on STORM-1152: --- Github user hmcl commented on a diff in the

[GitHub] storm pull request: STORM-1152 Change map keySet iteration to entr...

2015-10-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/836#discussion_r43548584 --- Diff: storm-core/src/jvm/backtype/storm/utils/TransferDrainer.java --- @@ -30,18 +31,20 @@ private HashMap>> bundles = new HashMap(); pu

[jira] [Commented] (STORM-1152) Change map keySet iteration to entrySet iteration for efficiency

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983243#comment-14983243 ] ASF GitHub Bot commented on STORM-1152: --- Github user hmcl commented on a diff in the

[GitHub] storm pull request: STORM-1152 Change map keySet iteration to entr...

2015-10-30 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/836#discussion_r43548241 --- Diff: storm-core/src/jvm/backtype/storm/serialization/SerializationFactory.java --- @@ -81,8 +81,9 @@ public static Kryo getKryo(Map conf) { kryo

[jira] [Commented] (STORM-1144) Display requested and assigned cpu/mem resources for schedulers in UI

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983240#comment-14983240 ] ASF GitHub Bot commented on STORM-1144: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1144] Provide resource (mem/cpu) assign...

2015-10-30 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/829#issuecomment-152642779 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-1144) Display requested and assigned cpu/mem resources for schedulers in UI

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983214#comment-14983214 ] ASF GitHub Bot commented on STORM-1144: --- Github user zhuoliu commented on the pull r

[GitHub] storm pull request: [STORM-1144] Provide resource (mem/cpu) assign...

2015-10-30 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/829#issuecomment-152639230 Sure, @revans2 . The REST API doc for topology summary has been updated. Thanks. --- If your project is set up for it, you can reply to this email and have your reply a

[jira] [Commented] (STORM-1144) Display requested and assigned cpu/mem resources for schedulers in UI

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983132#comment-14983132 ] ASF GitHub Bot commented on STORM-1144: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1144] Provide resource (mem/cpu) assign...

2015-10-30 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/829#issuecomment-152625417 The code and the UI look good. +1 But please either file a follow on JIRA or add in documentation about the REST API changes --- If your project is set up for it, you c

[jira] [Resolved] (STORM-1151) Add batching to disruptor

2015-10-30 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1151. Resolution: Fixed Fix Version/s: 0.11.0 > Add batching to disruptor > ---

[GitHub] storm pull request: Fixed incubator URLs

2015-10-30 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/828#issuecomment-152624019 @jnioche Thanks. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[jira] [Commented] (STORM-1151) Add batching to disruptor

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983123#comment-14983123 ] ASF GitHub Bot commented on STORM-1151: --- Github user asfgit closed the pull request

[GitHub] storm pull request: STORM-1151: Batching in DisruptorQueue

2015-10-30 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] storm pull request: STORM-1152 Change map keySet iteration to entr...

2015-10-30 Thread sureshms
GitHub user sureshms opened a pull request: https://github.com/apache/storm/pull/836 STORM-1152 Change map keySet iteration to entrySet iteration for effi… keySet to entrySet iteration changes along with other minor comments and code cleanup. You can merge this pull request into

[jira] [Commented] (STORM-1152) Change map keySet iteration to entrySet iteration for efficiency

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983061#comment-14983061 ] ASF GitHub Bot commented on STORM-1152: --- GitHub user sureshms opened a pull request:

[GitHub] storm pull request: Fixed incubator URLs

2015-10-30 Thread jerrypeng
Github user jerrypeng commented on the pull request: https://github.com/apache/storm/pull/828#issuecomment-152610714 LGTM +1 but probably should update this doc with more current information in the near future --- If your project is set up for it, you can reply to this email and have

[RESULT] [VOTE] Accept Alibaba JStorm Code Donation

2015-10-30 Thread P. Taylor Goetz
This vote is now closed with 9 binding +1 votes, 5 non-binding +1 votes, and no +0 or -1 votes. Vote tally (* indicates a binding vote): +1: Bobby Evans* Derek Dagit* Parth Brahmbhatt* P. Taylor Goetz* Priyank Shah Sriharsha Chintalapani* Jungtaek Lim* Nathan Marz* Andy Feng* 刘键(夏蒅) Wuchong wc 方

[jira] [Created] (STORM-1152) Change map keySet iteration to entrySet iteration for efficiency

2015-10-30 Thread Suresh Srinivas (JIRA)
Suresh Srinivas created STORM-1152: -- Summary: Change map keySet iteration to entrySet iteration for efficiency Key: STORM-1152 URL: https://issues.apache.org/jira/browse/STORM-1152 Project: Apache St

[RESULT] [VOTE] Release Apache Storm 0.10.0 (rc1)

2015-10-30 Thread P. Taylor Goetz
This vote is now closed and passes with 7 binding +1 votes, 1 non-binding +1 vote and no +0 or -1 votes. Vote tally (* indicates a binding vote): +1: Juntaek Lim* Bobby Evans* Sriharsha Chintalapani* Derek Dagit* Kishorkumar Patil* 方孝健(玄弟) P. Taylor Goetz* Parth Brahmbhatt* +0: -1: (Note that

Re: [VOTE] Release Apache Storm 0.10.0 (rc1)

2015-10-30 Thread Parth Brahmbhatt
+1 Tested locally. On 10/29/15, 12:46 PM, "P. Taylor Goetz" wrote: >+1 (binding) > >Ran a suite of fault tolerance tests. > >-Taylor > >> On Oct 23, 2015, at 4:26 PM, P. Taylor Goetz wrote: >> >> This is a call to vote on releasing Apache Storm 0.10.0 (rc1) >> >> Full list of changes in this

[jira] [Created] (STORM-1151) Add batching to disruptor

2015-10-30 Thread Robert Joseph Evans (JIRA)
Robert Joseph Evans created STORM-1151: -- Summary: Add batching to disruptor Key: STORM-1151 URL: https://issues.apache.org/jira/browse/STORM-1151 Project: Apache Storm Issue Type: Improv

[jira] [Commented] (STORM-40) Turn worker GC logging and heapdump on by default

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982961#comment-14982961 ] ASF GitHub Bot commented on STORM-40: - Github user revans2 commented on the pull request

[GitHub] storm pull request: [STORM-40] Turn worker garbage collection and ...

2015-10-30 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/835#issuecomment-152599615 @harshach the reason we have the gc logs on by default is because we have lots of users who ask why was my worker shot? Most of the time it is due to heavy GC and we wan

[jira] [Commented] (STORM-40) Turn worker GC logging and heapdump on by default

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982822#comment-14982822 ] ASF GitHub Bot commented on STORM-40: - Github user zhuoliu commented on the pull request

[GitHub] storm pull request: [STORM-40] Turn worker garbage collection and ...

2015-10-30 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/835#issuecomment-152579483 Thanks @harshach . This configuration is similar to what we have in Yahoo cluster. Different types of workers may diff, mostly generating less than 100B per second.

[jira] [Assigned] (STORM-902) Simple Log Search

2015-10-30 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu reassigned STORM-902: -- Assignee: Zhuo Liu (was: Derek Dagit) > Simple Log Search > - > > Key:

Re: 答复: [VOTE] Accept Alibaba JStorm Code Donation

2015-10-30 Thread Supun Kamburugamuve
+1, we are doing some improvements to Jstorm. Would like to contribute back in the future with the approval of the community. Thanks, Supun.. On Fri, Oct 30, 2015 at 1:14 AM, Sean Zhong wrote: > +1 > > On Fri, Oct 30, 2015 at 9:23 AM, Cody Innowhere > wrote: > > > +1 > > (sorry for previous mi

[GitHub] storm pull request: [STORM-40] Turn worker garbage collection and ...

2015-10-30 Thread harshach
Github user harshach commented on the pull request: https://github.com/apache/storm/pull/835#issuecomment-152553592 @zhuoliu heapdump will be helpful but I am not sure about the gc.log as it can produce lot of logging. --- If your project is set up for it, you can reply to this email

[jira] [Commented] (STORM-40) Turn worker GC logging and heapdump on by default

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982686#comment-14982686 ] ASF GitHub Bot commented on STORM-40: - Github user harshach commented on the pull reques

[GitHub] storm pull request: [STORM-40] Turn worker garbage collection and ...

2015-10-30 Thread zhuoliu
GitHub user zhuoliu opened a pull request: https://github.com/apache/storm/pull/835 [STORM-40] Turn worker garbage collection and heapdump on by default Since STORM-901 worker artifacts directory just gets merged in, it provides a private place for us to turn on the garbage collecti

[jira] [Commented] (STORM-40) Turn worker GC logging and heapdump on by default

2015-10-30 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-40?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982680#comment-14982680 ] ASF GitHub Bot commented on STORM-40: - GitHub user zhuoliu opened a pull request: h

[jira] [Updated] (STORM-40) Turn worker GC logging and heapdump on by default

2015-10-30 Thread Zhuo Liu (JIRA)
[ https://issues.apache.org/jira/browse/STORM-40?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zhuo Liu updated STORM-40: -- Summary: Turn worker GC logging and heapdump on by default (was: Turn worker GC logging on by default) > Turn wo

Re: Kafka exception on Toplogy start

2015-10-30 Thread 임정택
Hi Abe, Having a look into stack trace and trace some source codes, I feel that Message itself could be broken. (Or maybe offset is not valid. I'm just using Kafka so I couldn't know the details.) Message class is from Kafka, and storm-kafka just seems to fetch them from Kafka, and doesn't modify

Kafka exception on Toplogy start

2015-10-30 Thread abe oppenheim
I realize this is a little vague, but any advice as to how I can troubleshoot this would be very helpful. My Topology uses a KafkaSpout. When I start the Topology I see the below exception and all my Executors die. Then the Worker tries to start again, the exception occurs, and the Executors die.

[jira] [Created] (STORM-1150) The authorization mode of Logviewer is not working well when I add other groups for log

2015-10-30 Thread rujia (JIRA)
rujia created STORM-1150: Summary: The authorization mode of Logviewer is not working well when I add other groups for log Key: STORM-1150 URL: https://issues.apache.org/jira/browse/STORM-1150 Project: Apach