[GitHub] storm pull request: [STORM-756] ShellBolt can delay sending tuples...

2015-11-16 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/532#issuecomment-157076377 @HeartSaVioR I would like to see ABP work correctly be default on the Shell bolt, and have it work correctly when TOPOLOGY_SHELLBOLT_MAX_PENDING is off, but I don't

[jira] [Commented] (STORM-1016) Generate trident bolt ids with sorted group names

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006717#comment-15006717 ] ASF GitHub Bot commented on STORM-1016: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: STORM-1016: Generate trident bolt ids with sor...

2015-11-16 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/706#issuecomment-157046815 The build is complaining that storm-core/test/jvm/storm/trident/TestTridentTopology.java does not have an apache license header. --- If your project is set up for it,

Re: Question about acker & timeout behavior

2015-11-16 Thread Bobby Evans
Glad to help the code can be a bit confusing at times.  - Bobby On Monday, November 16, 2015 8:29 AM, Stephen Powis wrote: Ah Thanks Bobby!  That was the piece I was missing then. On Mon, Nov 16, 2015 at 10:24 PM, Bobby Evans

[jira] [Commented] (STORM-885) Heartbeat Server (Pacemaker)

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006742#comment-15006742 ] ASF GitHub Bot commented on STORM-885: -- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-1204) Logviewer should graceful report page-not-found instead of 500 for bad topo-id etc

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006778#comment-15006778 ] ASF GitHub Bot commented on STORM-1204: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-1204] Fixing attempt to access to direc...

2015-11-16 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/879#issuecomment-157066468 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] storm pull request: [STORM-1204] Fixing attempt to access to direc...

2015-11-16 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/879#issuecomment-157097910 @redsanket We are doing this only are couple of places.. no making it a utility may not be much useful. --- If your project is set up for it, you can reply to this

[jira] [Commented] (STORM-1204) Logviewer should graceful report page-not-found instead of 500 for bad topo-id etc

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006925#comment-15006925 ] ASF GitHub Bot commented on STORM-1204: --- Github user kishorvpatil commented on the pull request:

[GitHub] storm pull request: STORM-1009:Link on http://storm.apache.org/doc...

2015-11-16 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/880#issuecomment-157077703 @jayapriya90 sadly the documentation was moved to the asf-site branch, but the old docs were not removed from the master branch. Could you update your pull request to

[jira] [Commented] (STORM-756) [multilang] Introduce overflow control mechanism

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006818#comment-15006818 ] ASF GitHub Bot commented on STORM-756: -- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-1009) link on http://storm.apache.org/documentation/Kestrel-and-Storm.html is wrong

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006825#comment-15006825 ] ASF GitHub Bot commented on STORM-1009: --- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-885] Heartbeat Server (Pacemaker)

2015-11-16 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/838#issuecomment-157057138 @bastiliu There is a possibility of that. If you have a congested network or if there are other issues around the pacemaker node that it could become a bottleneck. We

[jira] [Commented] (STORM-1016) Generate trident bolt ids with sorted group names

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006719#comment-15006719 ] ASF GitHub Bot commented on STORM-1016: --- Github user revans2 commented on the pull request:

[jira] [Commented] (STORM-1016) Generate trident bolt ids with sorted group names

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006718#comment-15006718 ] ASF GitHub Bot commented on STORM-1016: --- Github user revans2 commented on a diff in the pull

[GitHub] storm pull request: STORM-1016: Generate trident bolt ids with sor...

2015-11-16 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/706#issuecomment-157047192 Two very minor things, and I am +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] storm pull request: STORM-1016: Generate trident bolt ids with sor...

2015-11-16 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/706#discussion_r44928324 --- Diff: storm-core/src/jvm/storm/trident/graph/GraphGrouper.java --- @@ -34,8 +31,8 @@ public GraphGrouper(DirectedGraph

[jira] [Commented] (STORM-1204) Logviewer should graceful report page-not-found instead of 500 for bad topo-id etc

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006755#comment-15006755 ] ASF GitHub Bot commented on STORM-1204: --- Github user redsanket commented on the pull request:

Question about acker & timeout behavior

2015-11-16 Thread Stephen Powis
I'm trying to better understand the acker behavior and how it deals with tuple time outs. I've read the documentation on the storm website, but from my rudimentary knowledge of clojure, it seems like the docs and the code don't completely align (or I'm completely missing something) The short of

Re: 答复: load configurations to topology

2015-11-16 Thread Bobby Evans
first of all the code looks like it was copied and pasted oddly https://github.com/apache/storm/blob/master/storm-core/src/jvm/backtype/storm/StormSubmitter.java#L188-L199 ``` public static void submitTopologyAs(String name, Map stormConf, StormTopology topology, SubmitOptions opts,

[GitHub] storm pull request: [STORM-885] Heartbeat Server (Pacemaker)

2015-11-16 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/838#issuecomment-157059718 The code looks good to me and I am +1. As part of full disclosure I didn't write any of this code, but I did talk with @knusbaum a few times about the design of it and

[jira] [Commented] (STORM-1204) Logviewer should graceful report page-not-found instead of 500 for bad topo-id etc

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006752#comment-15006752 ] ASF GitHub Bot commented on STORM-1204: --- Github user redsanket commented on a diff in the pull

Re: Question about acker & timeout behavior

2015-11-16 Thread Bobby Evans
You are correct about the put restarting the clock for removing the tuple tree from the acker map, but the timeout code in the acker does not trigger a timeout of a tuple, it just purges the tuple from the ackers memory.  The timeout code for a tuple is actually in the spout.  It has a

[jira] [Commented] (STORM-885) Heartbeat Server (Pacemaker)

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15006746#comment-15006746 ] ASF GitHub Bot commented on STORM-885: -- Github user revans2 commented on the pull request:

[GitHub] storm pull request: [STORM-1204] Fixing attempt to access to direc...

2015-11-16 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/879#issuecomment-157061483 minor suggestion, +1 NB --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request: [STORM-885] Heartbeat Server (Pacemaker)

2015-11-16 Thread zhuoliu
Github user zhuoliu commented on a diff in the pull request: https://github.com/apache/storm/pull/838#discussion_r44965169 --- Diff: storm-core/src/clj/org/apache/storm/pacemaker/pacemaker.clj --- @@ -0,0 +1,239 @@ +;; Licensed to the Apache Software Foundation (ASF) under one

[jira] [Commented] (STORM-885) Heartbeat Server (Pacemaker)

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007116#comment-15007116 ] ASF GitHub Bot commented on STORM-885: -- Github user zhuoliu commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-1208] Guard against NPE, and avoid usin...

2015-11-16 Thread d2r
GitHub user d2r opened a pull request: https://github.com/apache/storm/pull/881 [STORM-1208] Guard against NPE, and avoid using NaN values * Removes malformed preconditions that don't do anything, and if they did work would throw Errors that would crash nimbus. * When reading

[jira] [Commented] (STORM-1204) Logviewer should graceful report page-not-found instead of 500 for bad topo-id etc

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1204?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007365#comment-15007365 ] ASF GitHub Bot commented on STORM-1204: --- Github user zhuoliu commented on the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/845#issuecomment-157180717 struct AccessControl { 1: required AccessControlType type; 2: optional string name; //Name of user or group in ACL 3: required i32 access; //bitmasks

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007394#comment-15007394 ] ASF GitHub Bot commented on STORM-876: -- Github user redsanket commented on the pull request:

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007494#comment-15007494 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44994348 --- Diff: storm-core/src/jvm/backtype/storm/blobstore/KeyVersion.java --- @@ -0,0 +1,125 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007519#comment-15007519 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44995641 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -326,16 +331,29 @@ (log-error t "Error

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007551#comment-15007551 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44996912 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -454,10 +456,78 @@ (shutdown-worker supervisor id)) ))

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44996811 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -454,10 +456,78 @@ (shutdown-worker supervisor id)) ))

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44997265 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -671,6 +787,11 @@ 0 (conf

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44985482 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -390,53 +444,99 @@ [(.getNodeId slot) (.getPort slot)] )))

[jira] [Commented] (STORM-1208) UI: NPE seen when aggregating bolt streams stats

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007370#comment-15007370 ] ASF GitHub Bot commented on STORM-1208: --- Github user zhuoliu commented on the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44987127 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -1047,25 +1162,34 @@ (ls-topo-hist! topo-history-state new-history

[GitHub] storm pull request: [STORM-1208] Guard against NPE, and avoid usin...

2015-11-16 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/881#issuecomment-157178283 Nice fix. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007400#comment-15007400 ] ASF GitHub Bot commented on STORM-876: -- Github user redsanket closed the pull request at:

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007401#comment-15007401 ] ASF GitHub Bot commented on STORM-876: -- GitHub user redsanket reopened a pull request:

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007399#comment-15007399 ] ASF GitHub Bot commented on STORM-876: -- Github user redsanket commented on the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44989185 --- Diff: external/storm-hdfs/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStore.java --- @@ -0,0 +1,381 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44989413 --- Diff: external/storm-hdfs/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStore.java --- @@ -0,0 +1,381 @@ +/** + * Licensed to the Apache

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007523#comment-15007523 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44996296 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -454,10 +456,78 @@ (shutdown-worker supervisor id)) ))

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007547#comment-15007547 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44996771 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -454,10 +456,78 @@ (shutdown-worker supervisor id)) ))

[GitHub] storm pull request: [STORM-1208] Guard against NPE, and avoid usin...

2015-11-16 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/881#issuecomment-157175212 +1 NB --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1208) UI: NPE seen when aggregating bolt streams stats

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007351#comment-15007351 ] ASF GitHub Bot commented on STORM-1208: --- Github user redsanket commented on the pull request:

[GitHub] storm pull request: [STORM-1204] Fixing attempt to access to direc...

2015-11-16 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/879#issuecomment-157177411 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007371#comment-15007371 ] ASF GitHub Bot commented on STORM-876: -- Github user d2r commented on a diff in the pull request:

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007368#comment-15007368 ] ASF GitHub Bot commented on STORM-876: -- Github user d2r commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread redsanket
GitHub user redsanket reopened a pull request: https://github.com/apache/storm/pull/845 [STORM-876] Blobstore API Please take a look at the blobstore API. The design docs have been uploaded earlier under the same JIRA. Currently, the blobstore API also works with Nimbus-HA. Apart

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread redsanket
Github user redsanket commented on the pull request: https://github.com/apache/storm/pull/845#issuecomment-157180992 //BLOB APIs // These blob APIs guarantee very little. // Writes and reads can fail at any point in time and should be retried. // deletes are a

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread redsanket
Github user redsanket closed the pull request at: https://github.com/apache/storm/pull/845 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007408#comment-15007408 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44989679 --- Diff: external/storm-hdfs/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStoreFile.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007415#comment-15007415 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44989851 --- Diff: external/storm-hdfs/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStore.java --- @@ -0,0 +1,381 @@ +/** + * Licensed to the Apache

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007418#comment-15007418 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007471#comment-15007471 ] ASF GitHub Bot commented on STORM-876: -- Github user redsanket commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44995171 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -326,16 +331,29 @@ (log-error t "Error

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007510#comment-15007510 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007557#comment-15007557 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44997133 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -526,6 +605,41 @@ {Config/SUPERVISOR_MEMORY_CAPACITY_MB (double (conf

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007559#comment-15007559 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44986991 --- Diff: storm-core/src/clj/backtype/storm/daemon/nimbus.clj --- @@ -984,25 +1108,30 @@ (defn cleanup-corrupt-topologies! [nimbus]

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44992600 --- Diff: external/storm-hdfs/src/main/java/org/apache/storm/hdfs/blobstore/HdfsBlobStoreFile.java --- @@ -0,0 +1,196 @@ +/** + * Licensed to the

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44995542 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -326,16 +331,29 @@ (log-error t "Error

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007537#comment-15007537 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44996393 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -454,10 +456,78 @@ (shutdown-worker supervisor id)) ))

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007540#comment-15007540 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007548#comment-15007548 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44997103 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -526,6 +605,41 @@ {Config/SUPERVISOR_MEMORY_CAPACITY_MB (double (conf

[jira] [Closed] (STORM-1173) Support string operations in StormSQL

2015-11-16 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1173?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai closed STORM-1173. - Resolution: Fixed Thanks [~sriharsha] for the reviews and commit. > Support string operations in

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44997502 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -732,25 +863,89 @@ (if (conf SUPERVISOR-RUN-WORKER-AS-USER)

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44997547 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -732,25 +863,89 @@ (if (conf SUPERVISOR-RUN-WORKER-AS-USER)

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007577#comment-15007577 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-1208] Guard against NPE, and avoid usin...

2015-11-16 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/881#issuecomment-157164426 LGTM. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[jira] [Commented] (STORM-1009) link on http://storm.apache.org/documentation/Kestrel-and-Storm.html is wrong

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007286#comment-15007286 ] ASF GitHub Bot commented on STORM-1009: --- GitHub user jayapriya90 opened a pull request:

[GitHub] storm pull request: STORM-1009: link on http://storm.apache.org/do...

2015-11-16 Thread jayapriya90
GitHub user jayapriya90 opened a pull request: https://github.com/apache/storm/pull/882 STORM-1009: link on http://storm.apache.org/documentation/Kestrel-and… …-Storm.html is wrong You can merge this pull request into a Git repository by running: $ git pull

[GitHub] storm pull request: [STORM-1198] Web UI to show resource usages an...

2015-11-16 Thread zhuoliu
Github user zhuoliu commented on the pull request: https://github.com/apache/storm/pull/875#issuecomment-157165262 Upmerged. For RAS schedulers, assigned/requested mem/cpu will be shown for each supervisor; for non-RAS schedulers, the assigned memory will be calculated for each

[jira] [Commented] (STORM-1198) Web UI to show resource usages and Total Resources on all supervisors

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007293#comment-15007293 ] ASF GitHub Bot commented on STORM-1198: --- Github user zhuoliu commented on the pull request:

[jira] [Commented] (STORM-1009) link on http://storm.apache.org/documentation/Kestrel-and-Storm.html is wrong

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1009?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007309#comment-15007309 ] ASF GitHub Bot commented on STORM-1009: --- Github user jayapriya90 commented on the pull request:

[jira] [Created] (STORM-1208) UI: NPE seen when aggregating bolt streams stats

2015-11-16 Thread Derek Dagit (JIRA)
Derek Dagit created STORM-1208: -- Summary: UI: NPE seen when aggregating bolt streams stats Key: STORM-1208 URL: https://issues.apache.org/jira/browse/STORM-1208 Project: Apache Storm Issue

[jira] [Commented] (STORM-1208) UI: NPE seen when aggregating bolt streams stats

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007288#comment-15007288 ] ASF GitHub Bot commented on STORM-1208: --- Github user kishorvpatil commented on the pull request:

[GitHub] storm pull request: STORM-1009:Link on http://storm.apache.org/doc...

2015-11-16 Thread jayapriya90
Github user jayapriya90 commented on the pull request: https://github.com/apache/storm/pull/880#issuecomment-157168951 @hustfxj and @revans2 Thanks for the review and update. I created new pull request #882 for asf-site branch. I've also noticed in asf-site branch that

[jira] [Commented] (STORM-1208) UI: NPE seen when aggregating bolt streams stats

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007246#comment-15007246 ] ASF GitHub Bot commented on STORM-1208: --- GitHub user d2r opened a pull request:

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007572#comment-15007572 ] ASF GitHub Bot commented on STORM-876: -- Github user knusbaum commented on a diff in the pull request:

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007590#comment-15007590 ] ASF GitHub Bot commented on STORM-876: -- Github user redsanket commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44997972 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -927,31 +1133,32 @@ first )) (defmethod download-storm-code

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r44997943 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -927,31 +1133,32 @@ first )) (defmethod download-storm-code

[jira] [Assigned] (STORM-1201) Support distributed deployment in StormSQL

2015-11-16 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1201?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Haohui Mai reassigned STORM-1201: - Assignee: Haohui Mai > Support distributed deployment in StormSQL >

[jira] [Commented] (STORM-876) Dist Cache: Basic Functionality

2015-11-16 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15007614#comment-15007614 ] ASF GitHub Bot commented on STORM-876: -- Github user redsanket commented on a diff in the pull request:

[GitHub] storm pull request: [STORM-876] Blobstore API

2015-11-16 Thread redsanket
Github user redsanket commented on a diff in the pull request: https://github.com/apache/storm/pull/845#discussion_r45000490 --- Diff: storm-core/src/clj/backtype/storm/daemon/supervisor.clj --- @@ -927,31 +1133,32 @@ first )) (defmethod download-storm-code

  1   2   >