[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177289#comment-15177289 ] ASF GitHub Bot commented on STORM-1469: --- Github user kishorvpatil commented on the p

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/1173#issuecomment-191596685 Created two pull requests as follow-up #1178 Remove SimpleTransportPlugin and configuration and #1179 Decommissioning SimpleTransportPlugin and configu

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177288#comment-15177288 ] ASF GitHub Bot commented on STORM-1469: --- GitHub user kishorvpatil opened a pull requ

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177287#comment-15177287 ] ASF GitHub Bot commented on STORM-1469: --- GitHub user kishorvpatil opened a pull requ

[GitHub] storm pull request: [STORM-1469] Decommissioning SimpleTransportPl...

2016-03-02 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/1179 [STORM-1469] Decommissioning SimpleTransportPlugin and configuration This pull request awaits merging in #1173 merged into 1.x-branch as well. You can merge this pull request into a Git reposit

[GitHub] storm pull request: [STORM-1469] Remove SimpleTransportPlugin and ...

2016-03-02 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/1178 [STORM-1469] Remove SimpleTransportPlugin and configuration This pull request awaits merging in #1173 You can merge this pull request into a Git repository by running: $ git pull https://

[GitHub] storm pull request: [Storm-1585] Add DDL support for UDFs in storm...

2016-03-02 Thread arunmahadevan
Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/1169#discussion_r54837625 --- Diff: external/sql/storm-sql-core/src/codegen/includes/parserImpls.ftl --- @@ -83,4 +83,23 @@ SqlNode SqlCreateTable() : input_format_c

[GitHub] storm pull request: [Storm-1585] Add DDL support for UDFs in storm...

2016-03-02 Thread satishd
Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/1169#discussion_r54837137 --- Diff: external/sql/storm-sql-core/src/codegen/includes/parserImpls.ftl --- @@ -83,4 +83,23 @@ SqlNode SqlCreateTable() : input_format_class_n

[jira] [Created] (STORM-1598) Replace metric separator colon (:) with dot (.)

2016-03-02 Thread Abhishek Agarwal (JIRA)
Abhishek Agarwal created STORM-1598: --- Summary: Replace metric separator colon (:) with dot (.) Key: STORM-1598 URL: https://issues.apache.org/jira/browse/STORM-1598 Project: Apache Storm Is

[jira] [Commented] (STORM-1595) 'Fail' messages get stuck somewhere

2016-03-02 Thread Abhishek Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177174#comment-15177174 ] Abhishek Agarwal commented on STORM-1595: - can you tell us the following configura

[jira] [Created] (STORM-1597) Provide a separate metric for timed out tuples in the spout

2016-03-02 Thread Abhishek Agarwal (JIRA)
Abhishek Agarwal created STORM-1597: --- Summary: Provide a separate metric for timed out tuples in the spout Key: STORM-1597 URL: https://issues.apache.org/jira/browse/STORM-1597 Project: Apache Storm

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176946#comment-15176946 ] ASF GitHub Bot commented on STORM-822: -- Github user hmcl commented on a diff in the pu

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-02 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r54825460 --- Diff: external/storm-kafka-new-consumer-api/pom.xml --- @@ -0,0 +1,91 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/20

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176890#comment-15176890 ] ASF GitHub Bot commented on STORM-822: -- Github user hmcl commented on a diff in the pu

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-02 Thread hmcl
Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r54822068 --- Diff: pom.xml --- @@ -836,14 +839,39 @@ test - org.apache.calcite -

[jira] [Commented] (STORM-1596) Multiple Subject sharing Kerberos TGT - causes services to fail

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176817#comment-15176817 ] ASF GitHub Bot commented on STORM-1596: --- Github user kishorvpatil commented on the p

[GitHub] storm pull request: [STORM-1596] Do not single Kerberos TGT instan...

2016-03-02 Thread kishorvpatil
Github user kishorvpatil commented on the pull request: https://github.com/apache/storm/pull/1177#issuecomment-191508435 The Travis CI test failure seems unrelated to this issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[jira] [Commented] (STORM-1596) Multiple Subject sharing Kerberos TGT - causes services to fail

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176769#comment-15176769 ] ASF GitHub Bot commented on STORM-1596: --- GitHub user kishorvpatil opened a pull requ

[GitHub] storm pull request: [STORM-1596] Do not single Kerberos TGT instan...

2016-03-02 Thread kishorvpatil
GitHub user kishorvpatil opened a pull request: https://github.com/apache/storm/pull/1177 [STORM-1596] Do not single Kerberos TGT instance between multiple threads. This needs to be ported to 1.x-branch as well. You can merge this pull request into a Git repository by running:

[jira] [Created] (STORM-1596) Multiple Subject sharing Kerberos TGT - causes services to fail

2016-03-02 Thread Kishor Patil (JIRA)
Kishor Patil created STORM-1596: --- Summary: Multiple Subject sharing Kerberos TGT - causes services to fail Key: STORM-1596 URL: https://issues.apache.org/jira/browse/STORM-1596 Project: Apache Storm

[jira] [Updated] (STORM-1595) 'Fail' messages get stuck somewhere

2016-03-02 Thread Kyle Nusbaum (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyle Nusbaum updated STORM-1595: Attachment: (was: Screen Shot 2016-03-02 at 3.14.25 PM.png) > 'Fail' messages get stuck somewher

[jira] [Updated] (STORM-1595) 'Fail' messages get stuck somewhere

2016-03-02 Thread Kyle Nusbaum (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyle Nusbaum updated STORM-1595: Attachment: screenshot-1.png > 'Fail' messages get stuck somewhere > --

[jira] [Updated] (STORM-1595) 'Fail' messages get stuck somewhere

2016-03-02 Thread Kyle Nusbaum (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kyle Nusbaum updated STORM-1595: Attachment: Screen Shot 2016-03-02 at 3.14.25 PM.png > 'Fail' messages get stuck somewhere > --

[jira] [Created] (STORM-1595) 'Fail' messages get stuck somewhere

2016-03-02 Thread Kyle Nusbaum (JIRA)
Kyle Nusbaum created STORM-1595: --- Summary: 'Fail' messages get stuck somewhere Key: STORM-1595 URL: https://issues.apache.org/jira/browse/STORM-1595 Project: Apache Storm Issue Type: Bug A

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176441#comment-15176441 ] ASF GitHub Bot commented on STORM-1469: --- Github user d2r commented on the pull reque

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread d2r
Github user d2r commented on the pull request: https://github.com/apache/storm/pull/1173#issuecomment-191419837 Seems good to me. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1173#issuecomment-191407577 Looks good to me. The test failures look unrelated to this. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176386#comment-15176386 ] ASF GitHub Bot commented on STORM-1469: --- Github user revans2 commented on the pull r

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176356#comment-15176356 ] ASF GitHub Bot commented on STORM-822: -- Github user revans2 commented on the pull requ

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1131#issuecomment-191399473 @hmcl I went through the code again. It looks good. There are a few issues with activate and deactivate and The APIs for KafkaSpoutStream(s) does not seem as clean as

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176334#comment-15176334 ] ASF GitHub Bot commented on STORM-822: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r54779292 --- Diff: external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpoutStream.java --- @@ -0,0 +1,60 @@ +/* + * License

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176281#comment-15176281 ] ASF GitHub Bot commented on STORM-822: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r54774473 --- Diff: external/storm-kafka-new-consumer-api/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java --- @@ -0,0 +1,454 @@ +/* + * Licensed to

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r54773759 --- Diff: external/storm-kafka-new-consumer-api/pom.xml --- @@ -0,0 +1,91 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176272#comment-15176272 ] ASF GitHub Bot commented on STORM-822: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/1173#discussion_r54772909 --- Diff: storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainClientCallbackHandler.java --- @@ -0,0 +1,31 @@ +/** + * Licensed to the

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176265#comment-15176265 ] ASF GitHub Bot commented on STORM-1469: --- Github user kishorvpatil commented on a dif

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176255#comment-15176255 ] ASF GitHub Bot commented on STORM-822: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r54771740 --- Diff: pom.xml --- @@ -836,14 +839,39 @@ test - org.apache.calcite -

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176238#comment-15176238 ] ASF GitHub Bot commented on STORM-822: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r54770496 --- Diff: external/storm-kafka-new-consumer-api/pom.xml --- @@ -0,0 +1,91 @@ + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org

[jira] [Commented] (STORM-1565) Multi-Lang Performance Improvements

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176230#comment-15176230 ] ASF GitHub Bot commented on STORM-1565: --- Github user dan-blanchard commented on a di

[GitHub] storm pull request: [STORM-1565] Multi-Lang Performance Improvemen...

2016-03-02 Thread dan-blanchard
Github user dan-blanchard commented on a diff in the pull request: https://github.com/apache/storm/pull/1136#discussion_r54769764 --- Diff: conf/defaults.yaml --- @@ -226,7 +226,7 @@ topology.eventlogger.executors: null topology.tasks: null # maximum amount of time a messa

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176219#comment-15176219 ] ASF GitHub Bot commented on STORM-1469: --- Github user kishorvpatil commented on a dif

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/1173#discussion_r54769352 --- Diff: storm-core/src/jvm/org/apache/storm/security/auth/AbstractSaslServerCallbackHandler.java --- @@ -0,0 +1,77 @@ +package org.apache.storm.se

[jira] [Commented] (STORM-1592) clojure code calling into Utils.exitProcess throws ClassCastException

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176188#comment-15176188 ] ASF GitHub Bot commented on STORM-1592: --- Github user asfgit closed the pull request

[jira] [Commented] (STORM-1565) Multi-Lang Performance Improvements

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176215#comment-15176215 ] ASF GitHub Bot commented on STORM-1565: --- Github user dan-blanchard commented on the

[jira] [Commented] (STORM-822) As a storm developer I’d like to use the new kafka consumer API (0.8.3) to reduce dependencies and use long term supported kafka apis

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176211#comment-15176211 ] ASF GitHub Bot commented on STORM-822: -- Github user revans2 commented on a diff in the

[GitHub] storm pull request: [STORM-1565] Multi-Lang Performance Improvemen...

2016-03-02 Thread dan-blanchard
Github user dan-blanchard commented on the pull request: https://github.com/apache/storm/pull/1136#issuecomment-191365530 Also, this would be amazing, as I was trying to convince the Pyleus folks to contribute their serializer to Storm anyway in Yelp/pyleus#159. --- If your project i

[jira] [Commented] (STORM-1565) Multi-Lang Performance Improvements

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176207#comment-15176207 ] ASF GitHub Bot commented on STORM-1565: --- Github user dan-blanchard commented on the

[GitHub] storm pull request: STORM-822: Kafka Spout New Consumer API

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1131#discussion_r54768912 --- Diff: pom.xml --- @@ -836,14 +839,39 @@ test - org.apache.calcite -

[GitHub] storm pull request: [STORM-1565] Multi-Lang Performance Improvemen...

2016-03-02 Thread dan-blanchard
Github user dan-blanchard commented on the pull request: https://github.com/apache/storm/pull/1136#issuecomment-191364958 You may want to look at the [Pyleus project's `MessagePackSerializer`](https://github.com/Yelp/pyleus/blob/64036a8d8ccaa656ddebb3dbd1a7dfb40e15a14a/topology_builder

[jira] [Resolved] (STORM-1592) clojure code calling into Utils.exitProcess throws ClassCastException

2016-03-02 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1592. Resolution: Fixed Fix Version/s: 2.0.0 I merged this into master > clojure c

[GitHub] storm pull request: STORM-1592: clojure code calling into Utils.ex...

2016-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1172 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (STORM-1552) Fix topology event sampling log directory

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176034#comment-15176034 ] ASF GitHub Bot commented on STORM-1552: --- Github user asfgit closed the pull request

[jira] [Resolved] (STORM-1579) Got NoSuchFileException when running tests in storm-core

2016-03-02 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Joseph Evans resolved STORM-1579. Resolution: Fixed Thanks [~Cody], I merged this into master. > Got NoSuchFileExcep

[GitHub] storm pull request: [Storm-1579] Fix NoSuchFileException when runn...

2016-03-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/1161 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm pull request: STORM-1592: clojure code calling into Utils.ex...

2016-03-02 Thread knusbaum
Github user knusbaum commented on the pull request: https://github.com/apache/storm/pull/1172#issuecomment-191337207 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[jira] [Commented] (STORM-1592) clojure code calling into Utils.exitProcess throws ClassCastException

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15176029#comment-15176029 ] ASF GitHub Bot commented on STORM-1592: --- Github user knusbaum commented on the pull

[GitHub] storm pull request: [Storm-1579] Fix NoSuchFileException when runn...

2016-03-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1161#issuecomment-191330287 One minor comment, but it is important that we get this and #1172 in, so I am fine with making the change myself as a part of the merge. +1 --- If your project is set

[GitHub] storm pull request: [Storm-1579] Fix NoSuchFileException when runn...

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1161#discussion_r54755980 --- Diff: pom.xml --- @@ -914,6 +916,26 @@ org.apache.maven.plugins +

[jira] [Commented] (STORM-1549) Add support for extending tuple tree timeout

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175986#comment-15175986 ] ASF GitHub Bot commented on STORM-1549: --- Github user srdo commented on the pull requ

[GitHub] storm pull request: STORM-1549: [master] Add support for resetting...

2016-03-02 Thread srdo
Github user srdo commented on the pull request: https://github.com/apache/storm/pull/1174#issuecomment-191326068 The NPE should be fixed, I've added the missing space to the if, and added a comment to the javadoc about reset timeout being an expensive operation. The comment has also b

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/1173#discussion_r54749129 --- Diff: conf/defaults.yaml --- @@ -39,7 +39,7 @@ storm.exhibitor.port: 8080 storm.exhibitor.poll.uripath: "/exhibitor/v1/cluster/list" storm.c

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175885#comment-15175885 ] ASF GitHub Bot commented on STORM-1469: --- Github user kishorvpatil commented on a dif

[jira] [Commented] (STORM-1590) port defmeters/defgauge/defhistogram... to java for all of our code to use

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175835#comment-15175835 ] ASF GitHub Bot commented on STORM-1590: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1590] port defmeters/defgauge/defhistog...

2016-03-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1171#issuecomment-191301019 @abhishekagarwal87 I would be fine with a change like that. Please file a JIRA for it and we can make the change everywhere. --- If your project is set up for it, you

[jira] [Commented] (STORM-1593) Nimbus indicator for when a Topology finished processing all tuples

2016-03-02 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175821#comment-15175821 ] Robert Joseph Evans commented on STORM-1593: Just so you know there was an old

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175813#comment-15175813 ] ASF GitHub Bot commented on STORM-1469: --- Github user kishorvpatil commented on a dif

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread kishorvpatil
Github user kishorvpatil commented on a diff in the pull request: https://github.com/apache/storm/pull/1173#discussion_r54740640 --- Diff: storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainSaslTransportPlugin.java --- @@ -0,0 +1,69 @@ +/** + * Licensed to the Ap

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175768#comment-15175768 ] ASF GitHub Bot commented on STORM-1469: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1173#discussion_r54736725 --- Diff: storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainClientCallbackHandler.java --- @@ -0,0 +1,31 @@ +/** + * Licensed to the Apach

[jira] [Commented] (STORM-1593) Nimbus indicator for when a Topology finished processing all tuples

2016-03-02 Thread Michael Schonfeld (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175753#comment-15175753 ] Michael Schonfeld commented on STORM-1593: -- That's super helpful! Thanks, [~revan

[jira] [Commented] (STORM-1593) Nimbus indicator for when a Topology finished processing all tuples

2016-03-02 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175744#comment-15175744 ] Robert Joseph Evans commented on STORM-1593: Watching the queue population wou

[jira] [Commented] (STORM-1549) Add support for extending tuple tree timeout

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175699#comment-15175699 ] ASF GitHub Bot commented on STORM-1549: --- Github user revans2 commented on a diff in

[jira] [Commented] (STORM-1549) Add support for extending tuple tree timeout

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175694#comment-15175694 ] ASF GitHub Bot commented on STORM-1549: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: STORM-1549: [master] Add support for resetting...

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1174#discussion_r54731300 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/Acker.java --- @@ -100,6 +101,8 @@ public void execute(Tuple input) { }

[GitHub] storm pull request: STORM-1549: [master] Add support for resetting...

2016-03-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1174#issuecomment-191264712 Overall things look good. Just a few minor nits about javadocs and what @abhishekagarwal87 pointed out. --- If your project is set up for it, you can reply to this ema

[jira] [Commented] (STORM-1549) Add support for extending tuple tree timeout

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175686#comment-15175686 ] ASF GitHub Bot commented on STORM-1549: --- Github user revans2 commented on a diff in

[jira] [Commented] (STORM-1549) Add support for extending tuple tree timeout

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175682#comment-15175682 ] ASF GitHub Bot commented on STORM-1549: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: STORM-1549: [master] Add support for resetting...

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1174#discussion_r54730716 --- Diff: storm-core/src/jvm/org/apache/storm/topology/BasicOutputCollector.java --- @@ -52,6 +52,10 @@ public void emitDirect(int taskId, List tuple) {

[GitHub] storm pull request: STORM-1549: [master] Add support for resetting...

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1174#discussion_r54730661 --- Diff: storm-core/src/jvm/org/apache/storm/task/OutputCollector.java --- @@ -218,6 +218,16 @@ public void fail(Tuple input) { _delegate.fail(in

[jira] [Commented] (STORM-1593) Nimbus indicator for when a Topology finished processing all tuples

2016-03-02 Thread Michael Schonfeld (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175675#comment-15175675 ] Michael Schonfeld commented on STORM-1593: -- That's fair. A hard number is def a m

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175671#comment-15175671 ] ASF GitHub Bot commented on STORM-1469: --- Github user revans2 commented on a diff in

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175670#comment-15175670 ] ASF GitHub Bot commented on STORM-1469: --- Github user revans2 commented on the pull r

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread revans2
Github user revans2 commented on the pull request: https://github.com/apache/storm/pull/1173#issuecomment-191261944 Overall it looks fairly good, but you have a problem with RAT somewhere. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1173#discussion_r54730042 --- Diff: storm-core/src/jvm/org/apache/storm/security/auth/AbstractSaslServerCallbackHandler.java --- @@ -0,0 +1,77 @@ +package org.apache.storm.securit

[jira] [Commented] (STORM-1593) Nimbus indicator for when a Topology finished processing all tuples

2016-03-02 Thread Robert Joseph Evans (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175667#comment-15175667 ] Robert Joseph Evans commented on STORM-1593: That sounds not too difficult to

[jira] [Commented] (STORM-1593) Nimbus indicator for when a Topology finished processing all tuples

2016-03-02 Thread Michael Schonfeld (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175647#comment-15175647 ] Michael Schonfeld commented on STORM-1593: -- Yeah, that's exactly right. I want to

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175656#comment-15175656 ] ASF GitHub Bot commented on STORM-1469: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1173#discussion_r54728926 --- Diff: storm-core/src/jvm/org/apache/storm/security/auth/plain/SaslPlainServer.java --- @@ -0,0 +1,154 @@ +/** + * Licensed to the Apache Software

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175660#comment-15175660 ] ASF GitHub Bot commented on STORM-1469: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1173#discussion_r54727990 --- Diff: storm-core/src/jvm/org/apache/storm/security/auth/AbstractSaslClientCallbackHandler.java --- @@ -0,0 +1,76 @@ +/** + * Licensed to the Apac

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175659#comment-15175659 ] ASF GitHub Bot commented on STORM-1469: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1173#discussion_r54728782 --- Diff: storm-core/src/jvm/org/apache/storm/security/auth/plain/PlainSaslTransportPlugin.java --- @@ -0,0 +1,69 @@ +/** + * Licensed to the Apache

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175655#comment-15175655 ] ASF GitHub Bot commented on STORM-1469: --- Github user revans2 commented on a diff in

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1173#discussion_r54728326 --- Diff: storm-core/src/jvm/org/apache/storm/security/auth/AbstractSaslServerCallbackHandler.java --- @@ -0,0 +1,77 @@ +package org.apache.storm.securit

[GitHub] storm pull request: [STORM-1469] Adding Plain Sasl Transport Plugi...

2016-03-02 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1173#discussion_r54728287 --- Diff: storm-core/src/jvm/org/apache/storm/security/auth/AbstractSaslServerCallbackHandler.java --- @@ -0,0 +1,77 @@ +package org.apache.storm.securit

[jira] [Commented] (STORM-1469) Unable to deploy large topologies on apache storm

2016-03-02 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STORM-1469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15175651#comment-15175651 ] ASF GitHub Bot commented on STORM-1469: --- Github user revans2 commented on a diff in

  1   2   >