[GitHub] storm pull request #2091: fix typo in storm-client pom file: kyro -> kryo

GitHub user erikdw opened a pull request: https://github.com/apache/storm/pull/2091 fix typo in storm-client pom file: kyro -> kryo @revans2 : typo I found while poking around and trying to understand the shaded kryo jar, as per [our discussion in STORM-2191](https://issues.apache.

[GitHub] storm pull request #2090: STORM-2489: Overlap and data loss on WindowedBolt ...

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2090#discussion_r113369572 --- Diff: storm-client/src/jvm/org/apache/storm/windowing/TimeTriggerPolicy.java --- @@ -109,13 +112,22 @@ private Runnable newTriggerTask() { r

[GitHub] storm pull request #2090: STORM-2489: Overlap and data loss on WindowedBolt ...

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2090#discussion_r113369191 --- Diff: storm-client/src/jvm/org/apache/storm/windowing/TimeTriggerPolicy.java --- @@ -62,7 +63,9 @@ public void reset() { @Override

[GitHub] storm pull request #2090: STORM-2489: Overlap and data loss on WindowedBolt ...

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2090#discussion_r113368411 --- Diff: storm-client/src/jvm/org/apache/storm/windowing/TimeTriggerPolicy.java --- @@ -62,7 +63,9 @@ public void reset() { @Override

[GitHub] storm pull request #2090: STORM-2489: Overlap and data loss on WindowedBolt ...

Github user arunmahadevan commented on a diff in the pull request: https://github.com/apache/storm/pull/2090#discussion_r113368417 --- Diff: storm-client/src/jvm/org/apache/storm/windowing/TimeTriggerPolicy.java --- @@ -109,13 +112,22 @@ private Runnable newTriggerTask() {

[GitHub] storm issue #2089: STORM-2490: Lambda support

Github user vesense commented on the issue: https://github.com/apache/storm/pull/2089 @srdo Addressed your comments. Please take a look again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm pull request #2090: STORM-2489: Overlap and data loss on WindowedBolt ...

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2090#discussion_r113366037 --- Diff: storm-client/src/jvm/org/apache/storm/windowing/TimeTriggerPolicy.java --- @@ -109,13 +112,22 @@ private Runnable newTriggerTask() { r

[GitHub] storm pull request #2090: STORM-2489: Overlap and data loss on WindowedBolt ...

Github user satishd commented on a diff in the pull request: https://github.com/apache/storm/pull/2090#discussion_r113363343 --- Diff: storm-client/src/jvm/org/apache/storm/windowing/TimeTriggerPolicy.java --- @@ -62,7 +63,9 @@ public void reset() { @Override

[GitHub] storm pull request #2089: STORM-2490: Lambda support

Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/2089#discussion_r113364466 --- Diff: storm-client/src/jvm/org/apache/storm/lambda/LambdaBiConsumerBolt.java --- @@ -0,0 +1,36 @@ +/** + * Licensed to the Apache Software Founda

[GitHub] storm pull request #2089: STORM-2490: Lambda support

Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/2089#discussion_r113364472 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/LambdaTopology.java --- @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Software F

[GitHub] storm pull request #2089: STORM-2490: Lambda support

Github user vesense commented on a diff in the pull request: https://github.com/apache/storm/pull/2089#discussion_r113364469 --- Diff: storm-client/src/jvm/org/apache/storm/topology/TopologyBuilder.java --- @@ -316,6 +322,68 @@ public BoltDeclarer setBolt(String id, IWindowedBolt

[GitHub] storm issue #2083: STORM-2421: support lists of childopts in DaemonConfig.

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2083 +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] storm issue #2082: expose Tuple for node.js

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2082 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm pull request #2084: STORM-2488: The UI user Must be HTTP

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2084 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] storm issue #2086: STORM-2491: Adding extra Cassandra configuration paramete...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2086 overall LGTM. +1 . @tandrup would like to see these configs documented here https://github.com/apache/storm/blob/master/external/storm-cassandra/README.md --- If your project is set up for i

[GitHub] storm issue #2086: STORM-2491: Adding extra Cassandra configuration paramete...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2086 @tandrup for small docs changes etc. we don't file JIRAs but this one had quite few changes good to have that in JIRA and subsequently in CHANGELOG. --- If your project is set up for it, you can r

[GitHub] storm issue #2089: STORM-2490: Lambda support

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2089 @vesense this looks good. +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] storm issue #2066: [STORM-2472] kafkaspout should work normally in kerberos ...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2066 @liu-zhaokun following upon my previous comment , do not use stom-kafka-client from 1.0.x-branch as there are lot of bug-fixes went into storm-kafka-client in Storm 1.1 release --- If your project

[GitHub] storm issue #2066: [STORM-2472] kafkaspout should work normally in kerberos ...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2066 @liu-zhaokun I am still not sure why are we adding this code. One shouldn't be using 0.9 kafka clients and this storm-kafka-client will not work with 0.9 as the interface changed in 0.10 and we made

[GitHub] storm issue #2058: [STORM-2466] The example of jaas.conf in jaas_kerberos.co...

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2058 @vesense Hi, I am sorry to bother you,could you help me to review it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] storm issue #2066: [STORM-2472] kafkaspout should work normally in kerberos ...

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2066 @vesense Hello,could you help me to review this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

Re: [DISCUSS] Code Style

Code convention discussions can get pretty heated/religious in nature, which we should seek to avoid. I'm largely in alignment with Hugo on this: Start with a good base like the Google or Sun/Oracle style guides, and establish consensus on where we feel a desire to differ. Rather than haggle ov

Re: [DISCUSS] Code Style

Hi, We should just follow the Google Java Style Guide. There are many opinions on this subject, but I conjecture that this guide, which is very similar to the original Sun Java Code Conventions

Re: [DISCUSS] Code Style

- Personally not a big fan of _ for members either from the readability standpoint. Also much of the existing code doesn’t follow this. - Personally I find it is easier to write/read one-liner if/else without the curlys. Always wondered about the rationale behind that. Would suggest any such a

Re: [DISCUSS] Code Style

I would like to review the style guide of other projects, like HBase, and so. Btw, IMHO, I don't like using underscore as prefix for fields. We're using Java and the expression "class member variable" is from C++, and also underscore style came from C++. We need to avoid mixing other languages' st

[DISCUSS] Code Style

Now that most of our code is in Java, I think it might be time to revisit the issue of having some official and enforced code style. I don't have very strong feelings about most of it, but here is what I was thinking as a start, since I've seen this style quite a bit, and I've found it makes cod

[GitHub] storm issue #2088: [STORM-2486] Prevent cd from printing target directory to...

Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2088 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #2088: [STORM-2486] Prevent cd from printing target directory to...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2088 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] storm pull request #2089: STORM-2490: Lambda support

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2089#discussion_r113218838 --- Diff: storm-client/src/jvm/org/apache/storm/lambda/LambdaBiConsumerBolt.java --- @@ -0,0 +1,36 @@ +/** + * Licensed to the Apache Software Foundatio

[GitHub] storm pull request #2089: STORM-2490: Lambda support

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2089#discussion_r113237257 --- Diff: examples/storm-starter/src/jvm/org/apache/storm/starter/LambdaTopology.java --- @@ -0,0 +1,52 @@ +/** + * Licensed to the Apache Software Foun

[GitHub] storm pull request #2089: STORM-2490: Lambda support

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2089#discussion_r113220738 --- Diff: storm-client/src/jvm/org/apache/storm/topology/TopologyBuilder.java --- @@ -316,6 +322,68 @@ public BoltDeclarer setBolt(String id, IWindowedBolt bol

[GitHub] storm issue #2074: Storm 1290:port backtype.storm.local-state-test to java

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2074 +1. once the commits gets squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] storm issue #2074: Storm 1290:port backtype.storm.local-state-test to java

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2074 @kamleshbhatt can you please squash commits into single commit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] storm issue #2088: [STORM-2486] Prevent cd from printing target directory to...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2088 +1. Thanks @erikdw --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] storm issue #2090: STORM-2489: Overlap and data loss on WindowedBolt based o...

Github user harshach commented on the issue: https://github.com/apache/storm/pull/2090 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #2085: STORM-2492: Adding Cassandra Object Mapper statement buil...

Github user tandrup commented on the issue: https://github.com/apache/storm/pull/2085 Thanks for the tip @vesense --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wis

[GitHub] storm pull request #2090: STORM-2489: Overlap and data loss on WindowedBolt ...

GitHub user arunmahadevan opened a pull request: https://github.com/apache/storm/pull/2090 STORM-2489: Overlap and data loss on WindowedBolt based on Duration - Fixed time eviction to not evict events beyond current timestamp. - Modified time trigger to compute the reference tim