[GitHub] storm pull request #:

2017-05-10 Thread hmcc
Github user hmcc commented on the pull request: https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22098567 In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java: In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTe

[GitHub] storm pull request #:

2017-05-10 Thread vinodkc
Github user vinodkc commented on the pull request: https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22098195 In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java: In storm-client/test/jvm/org/apache/storm/utils/ConfigUtil

[GitHub] storm issue #1950: STORM-2369 [storm-redis] Use binary type for State manage...

2017-05-10 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/1950 @arunmahadevan Sorry got really late for addressing review comments. Addressed comments, and created migration tool `Base64ToBinaryStateMigrationUtil`. (Succeed to read State wi

[GitHub] storm pull request #:

2017-05-10 Thread erikdw
Github user erikdw commented on the pull request: https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22096706 In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java: In storm-client/test/jvm/org/apache/storm/utils/ConfigUtils

[GitHub] storm pull request #:

2017-05-10 Thread erikdw
Github user erikdw commented on the pull request: https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22096665 In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java: In storm-client/test/jvm/org/apache/storm/utils/ConfigUtils

[GitHub] storm issue #1044: STORM-1464: Support multiple file outputs

2017-05-10 Thread dossett
Github user dossett commented on the issue: https://github.com/apache/storm/pull/1044 @ryanpersaud Your basic approach looks right to me, thanks for taking the lead on this. Regarding rotation actions, my concern is that there's no absolute guarantee they will get executed. I

[GitHub] storm pull request #:

2017-05-10 Thread erikdw
Github user erikdw commented on the pull request: https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22096565 In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java: In storm-client/test/jvm/org/apache/storm/utils/ConfigUtils

[GitHub] storm pull request #:

2017-05-10 Thread vinodc
Github user vinodc commented on the pull request: https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22096432 In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java: In storm-client/test/jvm/org/apache/storm/utils/ConfigUtils

[GitHub] storm pull request #:

2017-05-10 Thread erikdw
Github user erikdw commented on the pull request: https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22096048 In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java: In storm-client/test/jvm/org/apache/storm/utils/ConfigUtils

[GitHub] storm pull request #:

2017-05-10 Thread erikdw
Github user erikdw commented on the pull request: https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22096038 In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java: In storm-client/test/jvm/org/apache/storm/utils/ConfigUtils

[GitHub] storm pull request #2108: STORM-2508:storm-solr enhancement: update solrj to...

2017-05-10 Thread AleiHanami
GitHub user AleiHanami opened a pull request: https://github.com/apache/storm/pull/2108 STORM-2508:storm-solr enhancement: update solrj to 5.5, support custom SolrClientFactory and commit operation I have a case that the SolrCloud in my organization is protected by SSL + Basic Auth

[GitHub] storm issue #2106: [STORM-2507] Temp Fix-Master branch build failure due to ...

2017-05-10 Thread erikdw
Github user erikdw commented on the issue: https://github.com/apache/storm/pull/2106 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur