Github user erikdw commented on the pull request:
https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22096048
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java:
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java on
line 66:
Per my comments in the email and [other PR related to fixing
these](https://github.com/apache/storm/pull/2105), changing everything from 4
space indent to 2 space indent is going to be obscuring authorship for little
value, and aesthetically I personally prefer 4 space indents with java code.
If I figure out how to make checkstyle be ok with 4 space indents can we do
that instead of having to adapt all of the code? (I haven't done any analysis
to see how the code is indented in general, so I might be making a bad
assumption that it's generally already 4 space indented.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
