Github user vinodkc commented on the pull request:
https://github.com/apache/storm/commit/63567ae4e9fe573467db41e13696cbc50176b27a#commitcomment-22098195
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java:
In storm-client/test/jvm/org/apache/storm/utils/ConfigUtilsTest.java on
line 66:
@erikdw Predefined rulesets available in maven checkstyle plugin itself
e.g.: sun_checks.xml and google_checks.xml, these files are already embedded
in the maven plugin and hence we can not rename it to google_checkstyle.xml
If required, we can customize ruleset by specifying it in the plugin
configuration
Refer parent pom.xml
<plugin>
<!--To support checkstyle goals. For example: "mvn checkstyle:checkstyle"-->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>2.17</version>
<executions>
<execution>
<id>validate</id>
<phase>validate</phase>
<configuration>
<configLocation>google_checks.xml</configLocation>
<encoding>UTF-8</encoding>
<failOnViolation></failOnViolation>
<logViolationsToConsole>false</logViolationsToConsole>
<outputFile></outputFile>
<violationSeverity>warning</violationSeverity>
</configuration>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
