[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-07-11 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2203 @ptgoetz Suppose we deprecate the built-in metrics, are they deprecated for public API or also Storm codebase? If we would want latter, we should have alternative way to collect metrics (maybe in

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-07-11 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2203 @HeartSaVioR > Do we plan to close all of sub-issues after merging this patch? No. I'm proposing a alternative. The RocksDb license issue is a blocker, so I'm proposing we move forw

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-07-11 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2203 @ptgoetz OK. Thanks for clarification. Makes sense. Btw, I still wish that we address issues on built-in metrics and integrate newer thing to the UI, like what @abellina proposed in

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-07-11 Thread ptgoetz
Github user ptgoetz commented on the issue: https://github.com/apache/storm/pull/2203 @erikdw Of course! This needs to be documented, and if accepted (or likely to be), I will do so. But if there's community consensus around NOT accepting this patch, I'd rather not waste the effort.

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-07-11 Thread HeartSaVioR
Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2203 I second @erikdw . It would be better which part(s) this patch covers in STORM-2153. I can see various and numerous discussions from STORM-2153, and also various sub-issues. At a glance,

[GitHub] storm issue #2203: STORM-2153: New Metrics Reporting API

2017-07-11 Thread erikdw
Github user erikdw commented on the issue: https://github.com/apache/storm/pull/2203 @ptgoetz: thanks for your work on this. But I may please request that you add some description about what you've actually done? There is a lot of discussion in STORM-2153, and a ton of different top

Re: Few observations related to KafkaSpout implementation (1.1.0)

2017-07-11 Thread Roshan Naik
There is a set of simple topologies in storm-perf for such benchmarking… we have one there that measures perf of the old KafkaSpout : https://github.com/apache/storm/blob/1.x-branch/examples/storm-perf/src/main/java/org/apache/storm/perf/KafkaSpoutNullBoltTopo.java We don’t have one yet for the n

[GitHub] storm pull request #2203: STORM-2153: New Metrics Reporting API

2017-07-11 Thread ptgoetz
GitHub user ptgoetz opened a pull request: https://github.com/apache/storm/pull/2203 STORM-2153: New Metrics Reporting API See JIRA for more information: https://issues.apache.org/jira/browse/STORM-2153 You can merge this pull request into a Git repository by running: