[GitHub] storm pull request #2199: [STORM-2201] Add dynamic scheduler configuration l...

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2199#discussion_r135337335 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/utils/IConfigLoader.java --- @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2199: [STORM-2201] Add dynamic scheduler configuration l...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2199#discussion_r135334556 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/utils/IConfigLoader.java --- @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2199: [STORM-2201] Add dynamic scheduler configuration l...

Github user Ethanlm commented on a diff in the pull request: https://github.com/apache/storm/pull/2199#discussion_r135331427 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/utils/IConfigLoader.java --- @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2289: STORM-2702: storm-loadgen

Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/2289#discussion_r135317773 --- Diff: examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/InputStream.java --- @@ -0,0 +1,263 @@ +/** + * Licensed to the Apache

[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2249 Still +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2289 @knusbaum I think I have addressed all of your review comments so far. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] storm pull request #2289: STORM-2702: storm-loadgen

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2289#discussion_r135307748 --- Diff: examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/InputStream.java --- @@ -0,0 +1,263 @@ +/** + * Licensed to the Apache

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

Github user knusbaum commented on the issue: https://github.com/apache/storm/pull/2289 Partial review done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] storm pull request #2289: STORM-2702: storm-loadgen

Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/2289#discussion_r135084038 --- Diff: examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/CaptureLoad.java --- @@ -0,0 +1,468 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2289: STORM-2702: storm-loadgen

Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/2289#discussion_r135073224 --- Diff: examples/storm-loadgen/README.md --- @@ -0,0 +1,195 @@ +# Storm Load Generation Tools + +A set of tools to place an artificial load on

[GitHub] storm pull request #2289: STORM-2702: storm-loadgen

Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/2289#discussion_r135074782 --- Diff: examples/storm-loadgen/README.md --- @@ -0,0 +1,195 @@ +# Storm Load Generation Tools + +A set of tools to place an artificial load on

[GitHub] storm pull request #2289: STORM-2702: storm-loadgen

Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/2289#discussion_r135078488 --- Diff: examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/CaptureLoad.java --- @@ -0,0 +1,468 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2289: STORM-2702: storm-loadgen

Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/2289#discussion_r135074180 --- Diff: examples/storm-loadgen/README.md --- @@ -0,0 +1,195 @@ +# Storm Load Generation Tools + +A set of tools to place an artificial load on

[GitHub] storm pull request #2289: STORM-2702: storm-loadgen

Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/2289#discussion_r135085622 --- Diff: examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/EstimateThroughput.java --- @@ -0,0 +1,108 @@ +/** + * Licensed to the

[GitHub] storm pull request #2289: STORM-2702: storm-loadgen

Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/2289#discussion_r135086409 --- Diff: examples/storm-loadgen/src/main/java/org/apache/storm/loadgen/InputStream.java --- @@ -0,0 +1,263 @@ +/** + * Licensed to the Apache

[GitHub] storm pull request #2199: [STORM-2201] Add dynamic scheduler configuration l...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2199#discussion_r135291998 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/utils/ArtifactoryHttpConfigLoader.java --- @@ -0,0 +1,375 @@ +/** + * Licensed to

[GitHub] storm pull request #2199: [STORM-2201] Add dynamic scheduler configuration l...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2199#discussion_r135292464 --- Diff: storm-server/src/main/java/org/apache/storm/scheduler/utils/IConfigLoader.java --- @@ -0,0 +1,138 @@ +/** + * Licensed to the Apache

[GitHub] storm issue #2233: Storm 2258: Streams api - support CoGroupByKey

Github user kamleshbhatt commented on the issue: https://github.com/apache/storm/pull/2233 Thanks for all your help and guidance. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm pull request #2233: Storm 2258: Streams api - support CoGroupByKey

Github user kamleshbhatt closed the pull request at: https://github.com/apache/storm/pull/2233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] storm issue #2199: [STORM-2201] Add dynamic scheduler configuration loading

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2199 @revans2 Do you have any suggestions? Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] storm issue #2199: [STORM-2201] Add dynamic scheduler configuration loading

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2199 @Ethanlm Thanks for the information. Looks like we can't expect users to use artifactory. If possible we'd be better to have HttpConfigLoader implementation, but may be not easy to implement

Some old pull requests worth to revisit

Hi devs, I have been revisiting the PR pages and found some pull requests which are really old, but looks like worth to revisit it. I already handled some of them, and it would be great if someone could help reviewing. * STORM-2083: Blacklist Scheduler PR:

[GitHub] storm issue #2249: STORM-2648/STORM-2357: Add storm-kafka-client support for...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2249 @hmcl Are you reviewing this, or are you satisfied with it? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] storm issue #2199: [STORM-2201] Add dynamic scheduler configuration loading

Github user Ethanlm commented on the issue: https://github.com/apache/storm/pull/2199 @HeartSaVioR You may want to check with this [website](https://www.jfrog.com/artifactory/). My understanding is that we can get most recent file from artifactory server. It's not the same with

[GitHub] storm issue #2289: STORM-2702: storm-loadgen

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2289 I think I am done with new features unless someone else comes up with something else that I missed out on. I really would appreciate some reviews. @knusbaum if you have the time I know you expressed

Re: [DISCUSS] Release Storm 1.0.5 / 1.1.2

Hello, Would you please include https://issues.apache.org/jira/browse/STORM-2648 in upcoming Storm 1.1.2 release : we need to have latency etc stats when using Storm Kafka Client spout in autocommit mode, not having this feature is blocking us from moving from old Storm-Kafka lib (limited to

Re: Still getting "Internal error processing getClusterInfo" with Storm 1.1.0, isn't STORM-1977 supposed to be closed?

I'm not sure. Topology code can't be restored, so my best bet would be detecting it (periodically, or react in failure) and give up leadership. If my memory is right, leader Nimbus doesn't pull blobs from followers, so if it doesn't have any blobs and need to sync, it just needs to become follower

[DISCUSS] Release Storm 1.0.5 / 1.1.2

Hi devs, We received a bug report (STORM-2682 ) on Storm 1.0.4 and 1.1.1 which prevents Storm cluster from update. Personally it looks like pretty critical, and hopefully it is fixed now. So maybe we would like to have another bug fix releases

[GitHub] storm pull request #2291: [STORM-2704] Check blob permission before submitti...

Github user asfgit closed the pull request at: https://github.com/apache/storm/pull/2291 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is