Re: The #storm-user IRC channel

I think removing IRC channel got enough votes which we could treat it as having consensus. For reaching out a person 1 by 1 anything they prefer would be OK, but if my understanding is right, if there're some decisions derived from there, decisions and summary of context should be shared to the

Re: The #storm-user IRC channel

Hi, I believe that we never reached a consensus on this thread. Can we make a decision on this ? I have changed my position to NOT support a channel at all. The reason is because all the user/dev discussion should go through the email list, and it is very easy to reach out to a particular

[GitHub] storm issue #2368: STORM-2771: By default don't run any tests as integration...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2368 Thanks for trying it out. I think we can get the same effect as the annotation by setting `no.tests` in the default properties. It's similar to how integration-tests-only disables the unit tests.

[GitHub] storm issue #2368: STORM-2771: By default don't run any tests as integration...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2368 Maven does not support conditional properties. I would have to do some ugly things with a profile that is activated when a property is set, and I am not sure that even then I could make it work.

[GitHub] storm issue #2368: STORM-2771: By default don't run any tests as integration...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2368 @srdo I did some tests and it works. The only problem with it is that if I do something odd like `mvn clean install -Pall-tests -DskipTests` it ends up running all of the java integration tests.

[GitHub] storm issue #2368: STORM-2771: By default don't run any tests as integration...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2368 @srdo I'm not sure I can try it out and see. ---

[GitHub] storm issue #2367: STORM-2607: Storm-kafka-client never commits the last mes...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2367 @hmcl Just signed in on Gitter, feel free to message me. ---

[GitHub] storm issue #2367: STORM-2607: Storm-kafka-client never commits the last mes...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2367 @srdo are you on Gitter or some sort of chat room where I could ask you a few questions? Thanks. ---

Re: [Discuss] - Output format of CLI command 'storm list'

Hi everyone, No one replied to this thread. If no one opposes I am going to submit a patch with these changes. Thanks, Hugo > On Aug 13, 2017, at 5:39 PM, Hugo Da Cruz Louro > wrote: > > Currently the CLI command 'storm list’ presents the output as follows: > >

[GitHub] storm issue #2368: STORM-2771: By default don't run any tests as integration...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2368 Can we avoid using the dummy annotation by setting http://maven.apache.org/surefire/maven-failsafe-plugin/integration-test-mojo.html#skipTests to true for the default plugin configuration, and setting

[GitHub] storm pull request #2367: STORM-2607: Storm-kafka-client never commits the l...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2367#discussion_r144083046 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java --- @@ -53,8 +54,8 @@ public

[GitHub] storm pull request #2367: STORM-2607: Storm-kafka-client never commits the l...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2367#discussion_r144080187 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java --- @@ -163,8 +167,9 @@ public long

[GitHub] storm pull request #2369: STORM-2607 1.x

GitHub user srdo opened a pull request: https://github.com/apache/storm/pull/2369 STORM-2607 1.x 1.x version of https://github.com/apache/storm/pull/2367. The changes are in the last commit, will squash once review is done. You can merge this pull request into a Git repository by

[GitHub] storm pull request #2367: STORM-2607: Storm-kafka-client never commits the l...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2367#discussion_r144079454 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java --- @@ -163,8 +167,9 @@ public long

[GitHub] storm pull request #2367: STORM-2607: Storm-kafka-client never commits the l...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2367#discussion_r144078200 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java --- @@ -53,8 +54,8 @@ public

[GitHub] storm issue #2367: STORM-2607: Storm-kafka-client never commits the last mes...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2367 @hmcl It's not that I feel strongly about keeping the contributions separate, but I think it's a rule for Apache projects that it must be possible to tell who contributed what, even historically. I

[GitHub] storm issue #2367: STORM-2607: Storm-kafka-client never commits the last mes...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2367 @srdo in my opinion the most important thing is to keep the project, and in particular the git log clean. I often have to cherry-pick changes from Apache branch into my own branch, and multiple commits

[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2181 @tiodollar Happy to hear it :) ---

[GitHub] storm issue #2367: STORM-2607: Storm-kafka-client never commits the last mes...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2367 @hmcl I agree that this many commits is not ideal. The issue is with being able to track who contributed what code. If I squash we can't tell which parts of this PR was contributed by me, and which

[GitHub] storm pull request #2367: STORM-2607: Storm-kafka-client never commits the l...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2367#discussion_r144069466 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java --- @@ -53,8 +54,8 @@ public

[GitHub] storm issue #2367: STORM-2607: Storm-kafka-client never commits the last mes...

Github user hmcl commented on the issue: https://github.com/apache/storm/pull/2367 @srdo I understand that you want to keep the commit history for @tiodollar but I don't think we should have 4 commits for such a simple change. This patch should be one commit only, either yours or

[GitHub] storm pull request #2367: STORM-2607: Storm-kafka-client never commits the l...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2367#discussion_r144066568 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java --- @@ -53,8 +54,8 @@ public

[GitHub] storm issue #2367: STORM-2607: Storm-kafka-client never commits the last mes...

Github user srdo commented on the issue: https://github.com/apache/storm/pull/2367 @HeartSaVioR No, it doesn't look like it. I'll put up a 1.x and 1.1.x version. ---

[GitHub] storm pull request #2367: STORM-2607: Storm-kafka-client never commits the l...

Github user srdo commented on a diff in the pull request: https://github.com/apache/storm/pull/2367#discussion_r144062571 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java --- @@ -53,8 +54,8 @@ public

Say Hi and need some suggestions to become a contributor

Hi, My Name is Shawn XIAO, and I'm new to the Storm project. I'm very interested in Real Time Data processing and computation and want to become a contributor of Storm project. I have read Apache Mentoring Programme and I want to know is it

[GitHub] storm pull request #2367: STORM-2607: Storm-kafka-client never commits the l...

Github user hmcl commented on a diff in the pull request: https://github.com/apache/storm/pull/2367#discussion_r144044782 --- Diff: external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/internal/OffsetManager.java --- @@ -53,8 +54,8 @@ public

[GitHub] storm issue #2363: STORM-2759: Let users indicate if a blob should restart a...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2363 @kishorvpatil I addressed your review comments. ---

[GitHub] storm pull request #2363: STORM-2759: Let users indicate if a blob should re...

Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/2363#discussion_r144041524 --- Diff: storm-server/src/test/java/org/apache/storm/localizer/AsyncLocalizerTest.java --- @@ -286,29 +297,80 @@ public void

[GitHub] storm issue #2365: [STORM-2773]If a drpcserver node in cluster is down,drpc ...

Github user revans2 commented on the issue: https://github.com/apache/storm/pull/2365 Actually I have dug deeper, and I think we want to do this differently, although it will be just as simple of a change. Currently a ConnectException is thrown deep down that end up being

[GitHub] storm issue #2181: [STORM-2607] Offset consumer + 1

Github user tiodollar commented on the issue: https://github.com/apache/storm/pull/2181 @srdo tks for this! I'm very busy, and is better that! For me it's ok! ---

[GitHub] storm issue #2367: STORM-2607: Storm-kafka-client never commits the last mes...

Github user HeartSaVioR commented on the issue: https://github.com/apache/storm/pull/2367 +1 Would this be a clean merge to 1.x version lines? ---

[GitHub] storm issue #2365: [STORM-2773]If a drpcserver node in cluster is down,drpc ...

Github user liu-zhaokun commented on the issue: https://github.com/apache/storm/pull/2365 @revans2 I have fix the checkstyle errors and log the exception.Could you help me review this PR again? ---