Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2490
---
Github user OuYangLiang commented on the issue:
https://github.com/apache/storm/pull/2494
@HeartSaVioR thanks, you can't see previous patch because I've squashed to
one commit.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2498
Maybe we could file a blocker issue for Storm 2.0.0 and allow this patch.
Filed https://issues.apache.org/jira/browse/STORM-2882 for that.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2491
---
Github user govind-menon closed the pull request at:
https://github.com/apache/storm/pull/2312
---
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2500
STORM-2876: Work around memory leak, and try to speed up tests
The actual fix is just the changes in storm-hdfs/pom.xml But this added 1
min to the build time on a decently powerful box. So to com
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2498
It doesn't represent we decided to not relocate. We just didn't decide it,
and it should be done within releasing 2.0.0.
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2498
https://mail-archives.apache.org/mod_mbox/incubator-storm-dev/201703.mbox/%3ccaf5108gjjqzsyywcp99bgpgec7tufe-tbt9fi0m78ah8rkm...@mail.gmail.com%3E
You can follow up the discussion to see
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2498
@HeartSaVioR , any reason why we dont relocate in 2.0.0 vs 1.x ? If not
users would hit issues with conflicting versions (like curator).
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2498
In master branch we don't relocate any dependencies so it will make
conflict anyway. Looks like this case represents that we should have a solution
for 2.0.0 sooner.
---
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2499
STORM-2881: Explicitly specify the curator dependencies in storm-druid pom
https://github.com/apache/storm/pull/2498 applied to 1.x branch.
You can merge this pull request into a Git repositor
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2499
ping @omkreddy , @HeartSaVioR
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2498
ping @omkreddy , @HeartSaVioR
---
GitHub user arunmahadevan opened a pull request:
https://github.com/apache/storm/pull/2498
STORM-2881: Explicitly specify the curator dependencies in storm-druid pom
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunmahadevan/s
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r159519245
--- Diff: storm-core/src/jvm/org/apache/storm/utils/DisruptorQueue.java ---
@@ -65,7 +66,7 @@
private static final Object INTERRUPT = new Object();
Github user ptgoetz commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r159515622
--- Diff: storm-core/src/jvm/org/apache/storm/utils/DisruptorQueue.java ---
@@ -65,7 +66,7 @@
private static final Object INTERRUPT = new Object();
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2203#discussion_r159514108
--- Diff: storm-core/src/jvm/org/apache/storm/utils/DisruptorQueue.java ---
@@ -65,7 +66,7 @@
private static final Object INTERRUPT = new Object();
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2480
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2495
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2495
I believe we don't need to wait 24 hours since this is just port work. Will
merge shortly.
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2480
+1
---
Github user arunmahadevan commented on the issue:
https://github.com/apache/storm/pull/2495
@omkreddy , thanks for the patch. +1
---
Github user omkreddy commented on the issue:
https://github.com/apache/storm/pull/2467
PR for master: https://github.com/apache/storm/pull/2497
---
GitHub user omkreddy opened a pull request:
https://github.com/apache/storm/pull/2497
STORM-2860: Add Kerberos support to Solr bolt
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omkreddy/storm kerberos-solr-bolt-master1
Altern
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2496
STORM-2858 1.x
1.x version of https://github.com/apache/storm/pull/2462
I didn't think we needed this initially since asprintf isn't used in 1.x,
but it looks like the build is failing on 1.x
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2489
---
Github user OuYangLiang commented on the issue:
https://github.com/apache/storm/pull/2494
@srdo I still think it makes senses, and made a few changes, please review
it again, thanks.
---
Github user omkreddy commented on the issue:
https://github.com/apache/storm/pull/2495
@srdo squashed the commits.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2495
Thanks, this looks good.
+1, if you squash to one commit we should be able to merge soon. Please
also squash the 1.x version.
---
Github user omkreddy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159413588
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -144,10 +147,37 @@ public void open(Map conf, Topol
Github user omkreddy commented on the issue:
https://github.com/apache/storm/pull/2495
@srdo Thanks for the review. Fixed the checkstyle issues.
---
Github user omkreddy commented on the issue:
https://github.com/apache/storm/pull/2467
Updated the PR for 1.x. Will raise PR for master
---
Github user omkreddy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159409982
--- Diff:
external/storm-solr/src/main/java/org/apache/storm/solr/schema/builder/RestJsonSchemaBuilderV2.java
---
@@ -0,0 +1,127 @@
+/**
+ * Licens
Github user omkreddy commented on a diff in the pull request:
https://github.com/apache/storm/pull/2467#discussion_r159409508
--- Diff: external/storm-solr/README.md ---
@@ -171,7 +194,7 @@ Querying Solr for these patterns, you will see the
values that have been indexe
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2494
Bikeshedding incoming:
I'm not sure this is better. The two methods in ProcessingGuarantee are
just named variants of equals. I think we might as well just replace the checks
in KafkaSpout with
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2495
There are checkstyle violations, you can find the list in
storm-kafka-client/target/checkstyle-violations.xml. Other than that this looks
good.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2480#discussion_r159407800
--- Diff:
external/storm-kafka-client/src/main/java/org/apache/storm/kafka/spout/KafkaSpout.java
---
@@ -144,10 +147,37 @@ public void open(Map conf, TopologyC
Github user omkreddy commented on the issue:
https://github.com/apache/storm/pull/2480
@srdo Raised PR for master : https://github.com/apache/storm/pull/2495
---
GitHub user omkreddy opened a pull request:
https://github.com/apache/storm/pull/2495
STORM-2867: Add consumer lag metrics to KafkaSpout
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omkreddy/storm kafka-metrics-apache-master
GitHub user OuYangLiang opened a pull request:
https://github.com/apache/storm/pull/2494
STORM-2880 Minor optimisation about kafka spout.
Based on the **single responsibility principle**, method
`isAtLeastOnceProcessing()` should reside in `KafkaSpoutConfig` rather than
`KafkaSpout
40 matches
Mail list logo
