--
Regards,
Ahamed Minhaj.A
Github user srishtyagrawal commented on the issue:
https://github.com/apache/storm/pull/2505
@revans2 if I understand correctly your concern is that every time a table
is paginated for a given page, there will be a call to get the cluster
configuration. I verified that for multiple pa
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r160011014
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/Task.java ---
@@ -177,6 +195,35 @@ public BuiltinMetrics getBuiltInMetrics() {
return b
Github user roshannaik commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r160010894
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/spout/SpoutOutputCollectorImpl.java
---
@@ -105,19 +134,16 @@ public void reportError(Throwable
Github user danny0405 closed the pull request at:
https://github.com/apache/storm/pull/2503
---
GitHub user danny0405 opened a pull request:
https://github.com/apache/storm/pull/2506
[STORM-2879] Supervisor collapse continuously when there is a expired
assignment for overdue storm [fix for 1.x-branch]
Supervisor collapse continuously when there is a expired assignment for
ove
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159973491
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159973149
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -246,59 +259,133 @@ public boolean
couldHoldIgnori
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159972982
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -184,30 +191,25 @@ public void remove(NormalizedRes
Github user hmcc commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159972449
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2505
@srishtyagrawal I am fine with the change in principal, but I am not happy
with an implementation that adds many new called to get the cluster
configuration. One for each table on the page.
---
Best,
Bo
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159969475
--- Diff: storm-client/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -328,20 +328,22 @@ public static boolean isSystemId(String id) {
* @return t
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159962361
--- Diff:
storm-client/src/jvm/org/apache/storm/executor/ExecutorTransfer.java ---
@@ -17,72 +17,124 @@
*/
package org.apache.storm.executor;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159969170
--- Diff: storm-client/src/jvm/org/apache/storm/utils/JCQueue.java ---
@@ -0,0 +1,458 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) unde
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159956952
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/worker/BackPressureTracker.java ---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software F
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159968476
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ObjectReader.java ---
@@ -76,6 +76,32 @@ public static Integer getInt(Object o, Integer
defaultValue) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159969789
--- Diff: storm-server/src/main/java/org/apache/storm/Testing.java ---
@@ -712,6 +712,6 @@ public static Tuple testTuple(List values,
MkTupleParam param) {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159969910
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -79,6 +79,7 @@
protected final long lowMemoryThr
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159954450
--- Diff: storm-client/src/jvm/org/apache/storm/cluster/ClusterUtils.java
---
@@ -47,7 +47,6 @@
public static final String STORMS_ROOT = "storms";
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159967636
--- Diff: storm-client/src/jvm/org/apache/storm/tuple/TupleImpl.java ---
@@ -24,50 +24,46 @@
import org.apache.storm.task.GeneralTopologyContext;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159954152
--- Diff: storm-client/src/jvm/org/apache/storm/StormTimer.java ---
@@ -193,6 +210,24 @@ public void run() {
});
}
+/**
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159957697
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -155,134 +150,159 @@ public void start() throws Exception {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159949952
--- Diff: docs/Performance.md ---
@@ -0,0 +1,132 @@
+---
--- End diff --
Great Documentation, but can we have some of the other docs link to
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159955584
--- Diff:
storm-client/src/jvm/org/apache/storm/daemon/metrics/SpoutThrottlingMetrics.java
---
@@ -22,24 +22,25 @@
public class SpoutThrottlingMe
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159960326
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -225,51 +228,62 @@ private static String
getExecutorType(WorkerTopologyContext
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159958378
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -155,134 +150,159 @@ public void start() throws Exception {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159963018
--- Diff: storm-client/src/jvm/org/apache/storm/executor/TupleInfo.java ---
@@ -23,7 +23,7 @@
import java.io.Serializable;
import java.util.List;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159960500
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -225,51 +228,62 @@ private static String
getExecutorType(WorkerTopologyContext
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159966670
--- Diff:
storm-client/src/jvm/org/apache/storm/serialization/SerializationFactory.java
---
@@ -20,6 +20,7 @@
import org.apache.storm.Config;
impo
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159959648
--- Diff: storm-client/src/jvm/org/apache/storm/executor/Executor.java ---
@@ -196,19 +197,21 @@ public static Executor mkExecutor(WorkerState
workerState, L
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2502#discussion_r159968772
--- Diff: storm-client/src/jvm/org/apache/storm/utils/RunningAvg.java ---
@@ -0,0 +1,88 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) un
Github user srishtyagrawal commented on the issue:
https://github.com/apache/storm/pull/2505
@revans2
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159957760
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -246,59 +259,133 @@ public boolean
couldHoldIgnoringS
GitHub user srishtyagrawal opened a pull request:
https://github.com/apache/storm/pull/2505
STORM-2877: Add an option to configure pagination in Storm UI
The current pagination default value for Storm UI is hard-coded to be 20.
Pagination has been introduced in Storm 1.x. Having 20
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159957666
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -246,59 +259,133 @@ public boolean
couldHoldIgnoringS
GitHub user agresch opened a pull request:
https://github.com/apache/storm/pull/2504
STORM-2156: store metrics into RocksDB
This PR adds a RocksDB key/value database to Nimbus for storing metrics
from the Supervisors. The implementation is replaceable by implementing the
Metr
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2485#discussion_r159952878
--- Diff:
storm-server/src/main/java/org/apache/storm/scheduler/resource/NormalizedResources.java
---
@@ -184,30 +191,25 @@ public void remove(NormalizedResour
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2501
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2501
Thanks @dvehar I merged this into master
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2502
I am still seeing test failures when running `mvn clean install -Pall-tests
-fn | tee log.txt`
`integration.org.apache.storm.integration-test` Looks like an NPE at
ExecutorTransfer.java:114
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2502
Yes I checked it out wrong... My bad.
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2500
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2500
@HeartSaVioR thanks...
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2502
@roshannaik I may have checked it out wrong, I will try again...
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2500
@revans2 Sure. I guess small change while porting back has been always
acceptable.
---
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2500
@HeartSaVioR I have not seen the issue on 1.x, but it is also an issue
there. It is a problem with using the mini-dfs cluster, and we use it for
tests in 1.x too. The patch applies mostly cleanly t
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159895567
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159863976
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundat
Github user hmcc commented on a diff in the pull request:
https://github.com/apache/storm/pull/2475#discussion_r159850662
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ShellLogHandler.java
---
@@ -0,0 +1,113 @@
+/**
+ * Licensed to the Apache Software Foundation (AS
GitHub user danny0405 opened a pull request:
https://github.com/apache/storm/pull/2503
[STORM-2879] Supervisor collapse continuously when there is a expired
assignment for overdue storm [fix for 1.x-branch]
2.0 patch [#2439](https://github.com/apache/storm/pull/2493)
This i
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2203
@revans2 Friendly reminder. I think your confirmation is required to merge
this in, because I guess STORM-2156 is coupled with this patch (and maybe vice
versa).
---
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2500
@revans2 Is this an issue only for 2.0.0? If not could you please also
provide a patch for 1.x branch? Thanks in advance!
---
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2499
---
54 matches
Mail list logo
