Github user krichter722 commented on the issue:
https://github.com/apache/storm/pull/2596
> Thanks for the fixes. I'll review this as soon as I can. In the meantime,
could you raise issues on https://issues.apache.org/jira to track your changes?
Nice. Done.
---
Github user SreeramGarlapati commented on the issue:
https://github.com/apache/storm/pull/2588
@srdo - when I try to merge my changes with `master` - I ended up with a
merge conflicts due to `line endings` change. is there any simple tip - which I
can use to ease through this? like
Github user hummelm commented on the issue:
https://github.com/apache/storm/pull/2591
After some digging I finally found a workaround.
Using a simple trick in the start method of the worker-hook (rewind of
the byteBuffer to allow the deserialization on stop)it can work as
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2596
@krichter722 Thanks for the fixes. I'll review this as soon as I can. In
the meantime, could you raise issues on https://issues.apache.org/jira to track
your changes? It makes it easier for us to track
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2595
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2595
@krichter722 Thanks, merged to master. I think we don't need to track this
in a jira issue since it's not a code change.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2595
@krichter722 Great, thanks for looking into it. This looks good, +1
---
Github user d2r commented on the issue:
https://github.com/apache/storm/pull/2603
The CI test error was in the nimbus test,
`test-check-authorization-getSupervisorPageInfo`, and seems unrelated.
@kishorvpatil does it look that way to you?
---
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2603#discussion_r176771823
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1196,6 +1198,12 @@ private IStormClusterState getStormClusterState() {
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2603#discussion_r176777374
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1944,6 +1957,7 @@ private void mkAssignments(String scratchTopoId)
Github user d2r commented on a diff in the pull request:
https://github.com/apache/storm/pull/2603#discussion_r176786400
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1754,7 +1762,7 @@ private TopologyResources
11 matches
Mail list logo
