Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2148#discussion_r120129559
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -246,7 +248,19 @@ public void start() throws Exception
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2148#discussion_r120129659
--- Diff: storm-client/src/jvm/org/apache/storm/daemon/worker/Worker.java
---
@@ -299,6 +313,33 @@ public void doExecutorHeartbeats
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2149#discussion_r120122106
--- Diff:
storm-core/test/jvm/org/apache/storm/scheduler/resource/strategies/scheduling/TestDefaultResourceAwareStrategy.java
---
@@ -111,55 +112,23
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2113
@kishorvpatil Could you look again. I had to rebase becase of a minor
conflict in the DefaultResourceAwareStrategy. It ended up resulting in only
some comment changes to this code, but I wanted
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2142#discussion_r119911355
--- Diff:
storm-core/src/clj/org/apache/storm/pacemaker/pacemaker_state_factory.clj ---
@@ -106,16 +106,15 @@
(defn get-pacemaker-write-client [conf
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2143
@jerrypeng Like I said in the previous pull request. The unit test that
failed was not cause by this change. It was cause by an actual fix to the
comparison logic for `sortComponents`. In my
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2100
@jerrypeng The reason that particular piece of code was flagged was because
the logic and the return values were not consistent with each other.
returning -1 means less than (but the code
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2127
Well no one else has looked at it, and it does cut 30 mins off of a build,
so I am going to check it in, and if we run into issues in the future we can
fix them then.
---
If your project is set up
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2136
It is looking good. A few notes.
Ackers (__acker) are not spouts. They are bolts (but it might be nice to
distinguish between system bolts and other bolts)
Ackers are not showing
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2135
+1
Although I think this is already happening. As a part of
https://github.com/apache/storm/pull/2113 I added in an xslt script to make
reading the XML format better (like plain
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2052
But I am happy to only add this into our own release of storm if you don't
think this is something you want to try and support.
---
If your project is set up for it, you can reply to this email
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2052
@HeartSaVioR We do have a large number on 0.10 and we are hoping that this
will be a good way to transition them off to 2.x when we are ready to go to
that version. The plan is not to have 0.10 run
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2129#discussion_r117826289
--- Diff: storm-core/src/ui/public/js/visualization.js ---
@@ -16,434 +16,330 @@
* limitations under the License.
*/
-// Inspired
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2129#discussion_r117822198
--- Diff: storm-core/src/ui/public/js/vis.min.js ---
@@ -0,0 +1,45 @@
+/**
+ * vis.js
+ * https://github.com/almende/vis
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2129
@Crim Don't feel bad. When I was playing around with this I found
(https://issues.apache.org/jira/browse/STORM-2526) which was my own face palm
moment.
---
If your project is set up for it, you
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2125
Thanks @lijiansong I merged this in keep up the good work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2126
Also please upmerge there is a merge conflict.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2126#discussion_r117774461
--- Diff: external/storm-kafka/pom.xml ---
@@ -57,7 +57,7 @@
maven-checkstyle-plugin
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2129
My biggest concern right now it that it looks like you missed checking in a
few files.
I see `vis.min.js`, `vis.min.css`, `streams.png`, and `bolt_info.png` all
getting a 404 when I try
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2130
STORM-2526: Revert changes mistakenly made to generated files
I regenerated all of the generated thrift files to be sure I hadn't
mistakenly changed anything else. Then I updated the one call
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2083
@hmcc looks like there is a merge conflict now. If you could resolve it I
would be happy to check this in.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2072
@HeartSaVioR Thanks I'll make the change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2072#discussion_r117247959
--- Diff: .travis.yml ---
@@ -27,6 +27,7 @@ before_install:
- rvm use 2.1.5 --install
- nvm install 0.12.2
- nvm use 0.12.2
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2072#discussion_r117247297
--- Diff: .travis.yml ---
@@ -27,6 +27,7 @@ before_install:
- rvm use 2.1.5 --install
- nvm install 0.12.2
- nvm use 0.12.2
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2083#discussion_r117245034
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -313,6 +317,33 @@ public static File getWorkerDirFromRoot(String
logRoot
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2109
@erikdw and @srishtyagrawal I know that we are still working through issues
with checkstyle being new, but I get a little nervous with making too many
changes to the "standard".
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2100
I am +1 on the change, but because my fix for the test is a part of this
please consider my +1 non-binding.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2049
@kishorvpatil @knusbaum Could you two take a look at this and also the
patches for 1.x etc.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2072
@ptgoetz @HeartSaVioR if either of you could take a look at this I would
appreciate it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2074#discussion_r116600864
--- Diff: storm-server/src/test/java/org/apache/storm/LocalStateTest.java
---
@@ -0,0 +1,61 @@
+package org.apache.storm;
+
+import
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2074#discussion_r116601117
--- Diff: storm-server/src/test/java/org/apache/storm/LocalStateTest.java
---
@@ -0,0 +1,61 @@
+package org.apache.storm;
+
+import
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2100
@adityasharad I put up https://github.com/adityasharad/storm/pull/1 to your
repo that should fix the failing test.
---
If your project is set up for it, you can reply to this email and have your
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2100
@adityasharad so the test itself was testing for the wrong behavior, and
when you fixed it the test stated to fail. I will try to make a pull request
to your repo with a fix for the test
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2100
@adityasharad Some of the tests are failing now specifically
TestDefaultResourceAwareStrategy.
I'll try and spend some time looking into it to see if I can see why it is
failing, because
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2111
Thanks, @arunmahadevan I merged this in
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2113
STORM-2497: Let Supervisor enforce memory and add in support for shared
memory regions
This is based off of #2112 so that the formatting is simpler.
You can merge this pull request into a Git
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2112
Oops we need a license in `storm-buildtools/storm_checkstyle.xml` or we
need to white list it for rat.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2112
Like I said before I am fine with whatever convention we have, so long as
we have one.
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2093
Still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2083#discussion_r114172094
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -313,6 +315,34 @@ public static File getWorkerDirFromRoot(String
logRoot
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2093
@vinodkc Looks good we are likely going to need to modify the total number
of violations when this is ready to be merged in.
I would love to see something that can find the checkstyle
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2076
@govind-menon Actually I think it is SASL not SSL that you want.
if you just set
```
storm.messaging.netty.authentication=true
```
Either as the default for your cluster
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2093
@vinodkc We cannot increase the size of the log without paying money to
travisci, or switching the build to the internal Jenkins servers at apache.
The later has been proposed but is not likely
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2094#discussion_r113919131
--- Diff: docs/Setting-up-a-Storm-cluster.md ---
@@ -102,9 +102,9 @@ The time to allow any given healthcheck script to run
before it is marked failed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2083#discussion_r113841362
--- Diff: storm-client/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -313,6 +315,34 @@ public static File getWorkerDirFromRoot(String
logRoot
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2049
@ptgoetz @HeartSaVioR ping again. This should give us the ability to do a
rolling upgrade from 1.x to 2.x
---
If your project is set up for it, you can reply to this email and have your
reply
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2060
@HeartSaVioR @ptgoetz If you have time to take a look I would appreciate
it. It looks like @knusbaum might be a bit too busy to take a look in a timely
manor.
---
If your project is set up
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2076#discussion_r111955758
--- Diff:
storm-core/src/jvm/org/apache/storm/serialization/KryoTupleDeserializer.java ---
@@ -50,7 +54,8 @@ public Tuple deserialize(byte[] ser
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2072
@srdo please continue to nit pick. I like good clean code and I am happy
to see people call me out on things that should be fixed. I find that people
who read the code closely and nit pick find
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2072
@srdo done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2072
@srdo can do. Wow you really don't like ugly code :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2076#discussion_r111740922
--- Diff:
storm-core/src/jvm/org/apache/storm/serialization/KryoTupleDeserializer.java ---
@@ -50,7 +54,8 @@ public Tuple deserialize(byte[] ser
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2072
@srdo I addressed your review comments about empty map.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2072#discussion_r111739215
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/AbstractHBaseBolt.java
---
@@ -51,11 +51,11 @@ public AbstractHBaseBolt(String
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2072
STORM-2477: Add generics to Config types
Because this touches so much of the code to avoid having to constantly
upmerge I have a script that will transform most of the code automatically
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2069
STORM-2475: Fix parsing of host:port to deal with IPv6 addresses
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2063
@jacobtolar please remove the line from the changelog. It is too hard to
keep it in sync while the code is reviewed. We will add it back in when we
merge it in.
---
If your project is set up
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2064
@ptgoetz and yes lets please do port this back
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2065
STORM-832: Allow config validation to be used by plugins/etc.
I did this because hard coding the usage of DaemonConf.java into a few
places just didn't look right, and I thought it would be better
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2063
+1 looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2054
I have been thinking about this, and I am not sure if a REGEX is really
what we want. Hadoop does this in a semi-standard way using auth_to_local
rules like PAM does.
It might be worth
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2054#discussion_r91074
--- Diff:
storm-client/src/jvm/org/apache/storm/security/auth/RegexKerberosPrincipalToLocal.java
---
@@ -0,0 +1,56 @@
+/**
+ * Licensed
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2060
@knusbaum please take a look at this.
There were a number of changes here. Some to replace functionality being
used from clojure runtime with java code. Some of it was moving/deduplicating
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2060
Now that STORM-2447 is in I have rebased this on master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2059
OK Still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2049
@ptgoetz @HeartSaVioR I would appreciate a review of this. I would like to
know what people think about it. If it is good I am happy to add in more
documentation and to rip out the rename hack
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2028
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2060
Only the last commit is the one to look at.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2060
STORM-2468: Remove clojure from storm-client
This is based off STORM-2447
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2032
@ppoulosk Sadly with the latest refactoring of the code
`SupervisorUtils.processLauncherAndWait` is not on the classpath for storm-core
any more. It is a part of storm-server. You may need to do
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2032
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2054#discussion_r110968429
--- Diff:
storm-client/src/jvm/org/apache/storm/security/auth/RegexKerberosPrincipalToLocal.java
---
@@ -0,0 +1,56 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2054#discussion_r110968735
--- Diff:
storm-client/src/jvm/org/apache/storm/security/auth/RegexKerberosPrincipalToLocal.java
---
@@ -0,0 +1,56 @@
+/**
+ * Licensed
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2054#discussion_r110967560
--- Diff:
storm-client/src/jvm/org/apache/storm/security/auth/RegexKerberosPrincipalToLocal.java
---
@@ -0,0 +1,56 @@
+/**
+ * Licensed
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2047
@HeartSaVioR could you please take a look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2052
STORM-2448: Report storm and jdk versions to nimbus on topology submission
0.10.x support for #2049
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2051
STORM-2448: Add in Storm and JDK versions when submitting a topology
1.0.x support for #2049
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2050
STORM-2448: Add in Storm and JDK versions when submitting a topology
1.x support for #2049
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2049
STORM-2448: Add in Storm and JDK versions when submitting a topology
This is based off of the local mode patch #2047 once it goes in I'll rebase
it again, so it is simpler to see the changes. All
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2047
STORM-2447: add in storm local to avoid having server on worker classpath
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2042
Still +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2042
Oops I missed that the build failed because of
```
[WARNING] Files with unapproved licenses:
flux/flux-wrappers/src/main/resources/resources/__init__.py
```
We
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2038
@HeartSaVioR it actually took me way too long beating my head against it
thinking I broke the thing as part of trying to make local mode transparent.
---
If your project is set up for it, you can
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
@HeartSaVioR Yes I gave these changes a +1 because they were as good as I
could expect without having storm server removed completely from the storm jar
classpath. To make that happen we really had
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
Just to let you know that I have been working on making local mode
transparent. I have it working, but I have a lot of work to do on the examples
and docs left.
https://github.com
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2038
STORM-2450: Write resources into correct local directory
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2450
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
+1 it looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
I filed STORM-2447 and STORM-2448 to allow for us to separate out the
classpath and make the change transparent for end users.
---
If your project is set up for it, you can reply to this email
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2034
I am +1 for the general concept. I need to finish going through the code,
but I am probably going to do it outside of github because the patch is so
huge.
As a side note git used to use
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2019
+1 for the concept, would like to understand the test failures though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2016
@arunmahadevan yes this is showing up in a real topology (part of
monitoring and alerting at Yahoo). And yes some of these topologies are really
large. They are machine generated from a number
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2016
STORM-2422: Reduce the size of a serialized trident topology
For now I only plan to do this for master. If someone else runs into this
issue I am happy to backport it to other versions of storm
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2014
@HeartSaVioR could you also take a look at #2015 it is almost identical,
except some white space changes in nimbus.clj made it so the cherry-pick was
not 100% clean.
---
If your project is set up
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1974
@ptgoetz yes #1972 was a clean cherry pick so I pulled it into 1.x and
1.0.x. This is not so I have #2014 and #2015.
The only real changes for them is that I had to translate the code
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2014
STORM-2038: Disable symlinks with a config option (1.x)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm
STORM-2038-sym
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2015
STORM-2038: Disable symlinks with a config option (1.0.x)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm
STORM-2038
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/2013
I manually ran the tests and they passed, so I am not going to wait for
travis to finish.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2013
STORM-2420: fix build
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2420
Alternatively you can review
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1974
@HeartSaVioR I have rebased the changes to remove the conflict (it was just
in the documentation). I'll start working on backporting it.
---
If your project is set up for it, you can reply
1001 - 1100 of 3470 matches
Mail list logo
