Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1677#discussion_r77868697
--- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java ---
@@ -0,0 +1,114 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1677#discussion_r77868535
--- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java ---
@@ -0,0 +1,114 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1677#discussion_r77867791
--- Diff: storm-core/src/jvm/org/apache/storm/command/AdminCommands.java ---
@@ -0,0 +1,114 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1677
For reference the original code that this is replacing was
```
(defn cleanup-corrupt-topologies! [nimbus]
(let [storm-cluster-state (:storm-cluster-state nimbus)
blob-store
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
@knusbaum @srdo @harshach @HeartSaVioR @abellina I really would appreciate
it if you could take another look at this patch. I think everything is ready
to go except a final squash before merging
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77738006
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java ---
@@ -17,135 +17,231 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77726704
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java ---
@@ -17,135 +17,231 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77725278
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java ---
@@ -17,135 +17,231 @@
*/
package
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1674
For me either the supervisor works or it does not. If it doesn't work
don't use it. If it is slightly better then another supervisor does not tell
me much. If too many don't work let someone know
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1673
@HeartSaVioR thanks, I should have looked more closely at the conflict.
+1 post-merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1674
Overall I like the concept here, and if a supervisor is
appearing/disappearing a lot we probably do want to blacklist that supervisor.
That said I have a few system concerns.
1) I would
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
Not sure what has been happening with travis not being able to get to the
apache maven repo all the time, but my build in travis passed
https://travis-ci.org/revans2/incubator-storm/builds/157725399
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
I could not reproduce the one failure and the rat failure is fixed by
STORM-2054 https://github.com/apache/storm/pull/1648
---
If your project is set up for it, you can reply to this email
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1648
+1 fixes the rat issues on storm-submit-tools.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
Looks like there were two failures in travis. One is a rat issue with
storm-submit-tools the other is an integration test that timed out. I'll try
to reproduce the issues and see if I can fix them
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
I recovered it and fixed some issues with integration tests/rat. I think
it should be good to go.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
@srdo Ya that is what I did. Thanks for the advice. Not sure what
happened somehow when I upmerged all but 2 of my commits disappeared.
---
If your project is set up for it, you can reply
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
Sorry, git just ate all of my more recent changes, and I have no idea what
happened. I'll try to see if I can recover them, but I might have to start
over...
---
If your project is set up
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
I just pushed in a much of new fixes and addressed all of the outstanding
review comments. I think it is good to go. Please take another look/test it
and let me know.
I have run tests
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77527879
--- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java
---
@@ -0,0 +1,420 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77527810
--- Diff: storm-core/src/jvm/org/apache/storm/localizer/AsyncLocalizer.java
---
@@ -0,0 +1,420 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77526779
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,766 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77526151
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
@HeartSaVioR I figured out what happened to make the supervisor crash. In
the transition from RUNNING to KILL to speed things up slot starts localizing
resources for the new assignment
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
@HeartSaVioR Yes it looks like I need to think through recovery and any
races with the AsyncLocalizer a bit more. I'll try to reproduce your error.
---
If your project is set up for it, you can
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77417627
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/RunAsUserContainerLauncher.java
---
@@ -0,0 +1,71 @@
+/**
+ * Licensed to the Apache
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77417198
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77416935
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77416395
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77416200
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77415816
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77415710
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ReadClusterState.java ---
@@ -0,0 +1,318 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77415373
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,484 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77415016
--- Diff: storm-core/src/jvm/org/apache/storm/utils/Utils.java ---
@@ -1990,31 +1995,26 @@ protected void forceDeleteImpl(String path) throws
IOException
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77414257
--- Diff:
storm-core/test/jvm/org/apache/storm/daemon/supervisor/BasicContainerTest.java
---
@@ -0,0 +1,459 @@
+package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77411245
--- Diff: storm-core/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -353,25 +350,21 @@ public LocalState nimbusTopoHistoryStateImpl(Map
conf) throws
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77407551
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,493 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
I think I have addressed most of the issues so far. I have been running
some manual tests and have run a cluster with run as user and cgroup
enforcement enabled. I plan on doing some more tests
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77260851
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,644 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77253867
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,629 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r77245653
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java ---
@@ -0,0 +1,314 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1669
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1661
I would be happy to pull that fix back into a separate patch. @ppoulosk
this patch looks fine to me, my only concern would be documenting it a little
more explaining that the state change might
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
@HeartSaVioR take your time. I want to be sure that I have plenty of
eyeballs looking at this. We are doing this mostly because we started to run
into a lot of race conditions in the supervisor
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76997296
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java ---
@@ -0,0 +1,319 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1660
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76875777
--- Diff:
storm-core/src/jvm/org/apache/storm/localizer/LocalDownloadedResource.java ---
@@ -0,0 +1,107 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76875102
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,769 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76874493
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,769 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76873417
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,493 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76873268
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,629 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76873184
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,629 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76684178
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ContainerLauncher.java ---
@@ -0,0 +1,99 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
@d2r @abellina @harshach @knusbaum
I believe that I am done and that the code is ready to merge. I have
addressed all of the review comments to date. I have finished with updating
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76611455
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,437 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76610605
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,429 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76609083
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java ---
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76609228
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,569 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76608228
--- Diff:
storm-core/src/jvm/org/apache/storm/container/ResourceIsolationInterface.java
---
@@ -56,4 +64,13 @@
*/
List
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76334398
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java ---
@@ -0,0 +1,202 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76334407
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java ---
@@ -0,0 +1,202 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
@harshach @knusbaum I think I addressed all of your review comments along
with upmerging to the latest master. I still have a bit more to do, mostly
with writing a replacement
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76309477
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java ---
@@ -17,135 +17,541 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76309388
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,749 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76308994
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,749 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76308561
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,494 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76308272
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,494 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76303019
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,494 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/838
@knusbaum please file a JIRA and make sure that we do that soon. Did you
do that work or was it @redsanket ?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76245840
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java ---
@@ -17,135 +17,541 @@
*/
package
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76245649
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,417 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/838
@knusbaum can you please take a look at what we have internally and be sure
that the fail over/load balancing features all got merged in to open source?
If it is all in then we probably need some
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1628
@HeartSaVioR Technically I don't think the bylaws cover changing minimum
requirements beyond a code change. If you want to modify the bylaws in that
way I would be happy to support you
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1630
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1606
@HeartSaVioR thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1608
Conceptually I like the idea, and overall the code looks good. My biggest
concern is around cleanup of the bobs after the topology finishes. I don't see
anywhere in the code that it is doing
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r7369
--- Diff: bin/storm.py ---
@@ -154,6 +157,39 @@ def confvalue(name, extrapaths, daemon=True):
return " ".join(tokens[1:])
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1606
This time the failures really are unrelated :).
```
[WARNING] Could not transfer metadata
org.apache.storm:multilang-python:2.0.0-SNAPSHOT/maven-metadata.xml from/to
apache-snapshots
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1522
@HeartSaVioR looks like one of the test failures was related.
https://issues.apache.org/jira/browse/STORM-2022
---
If your project is set up for it, you can reply to this email and have
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1586
@harshach actually some of the build errors are related see
https://issues.apache.org/jira/browse/STORM-2021
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1606
STORM-2020: Stop using sun internal classes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2020
Alternatively
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1574
@HeartSaVioR the local file system blobstore behaves exactly the same as
the nimbus HA before it. It tries to replicate all of the blobs to all of the
nimbus nodes as quickly as possible
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/414
@danny0405 That is very similar to what we want to move towards in our
rolling upgrades. We have done a very good job of maintaining compatibility of
LS and ZK once we moved to thrift for all
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1572
@harshach I don't think that would fix the issue, although it is an
improvement. If I think about it more I think what happened was that they were
not running with HA/expecting HA to work, but ran
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1574
@HeartSaVioR
I am OK with this change, like I am OK with the change for STORM-1976. I
just don't think that this is the final solution for the local
blobstore+nimbus, nor do I think
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1572
+1, but I would like to see a tool that can kill a corrupted topology
without nimbus being involved, or instructions somewhere on how to do it by
logging directly into ZooKeeper.
---
If your
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1574
The code to do the leader election based off of the IDs was removed because
architecturally the blobstore should be in charge of maintaining high
availability. Exposing what is stored on the local
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/414
@danny0405 like @HeartSaVioR said it depends on the versions you are
upgrading between. Most of the time we have maintained wire and binary
compatibility so you can do the upgrade piecemeal
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1552
I thought we already did a lot of this for the search side of things.
https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java#L243-L245
How
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1553
STORM-1962: support python 3 and 2 in multilang
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-1962
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1551
Travis passed this is just a comment/documentation change, not a code
change so I will push this in without waiting 24 hours.
---
If your project is set up for it, you can reply to this email
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1551
+1 pending travis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1526
The file without a license is
external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaPartitionOffsetLag.java
I'll file a separate JIRA for that.
---
If your project
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1526
+1 but all 4 CI jobs failed. They look unrelated to this, as some of them
are failing because of a RAT problem. Lets fix the build ASAP before we merge
in much more.
---
If your project is set
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1526
one minor nit, but overall I am +1 with or without the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1515#discussion_r68280266
--- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java
---
@@ -339,8 +353,13 @@ public SpoutDeclarer setSpout(String id, IRichSpout
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1515#discussion_r68280207
--- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java
---
@@ -179,8 +188,13 @@ public BoltDeclarer setBolt(String id, IRichBolt bolt
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1515#discussion_r68279943
--- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java
---
@@ -113,6 +113,15 @@ public StormTopology createTopology() {
Map
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1448#issuecomment-222158287
+1 the travis failures look unrelated (but we should pull this change into
master before 1.x.
---
If your project is set up for it, you can reply to this email
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1441#discussion_r64638916
--- Diff: bin/storm.py ---
@@ -241,7 +240,6 @@ def jar(jarfile, klass, *args):
extrajars=[tmpjar, USER_CONF_DIR, STORM_BIN_DIR
1501 - 1600 of 3470 matches
Mail list logo
