[GitHub] [storm] rzo1 commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-08-01 Thread via GitHub
rzo1 commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1661608128 Guess we can include this after 2.5.0 vote is over. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [storm] rzo1 commented on pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions

2023-08-01 Thread via GitHub
rzo1 commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1661607392 @6harat triggered the workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [storm] bipinprasad commented on pull request #3556: Missing dependency prevents Storm from being built, fixes #3940

2023-08-01 Thread via GitHub
bipinprasad commented on PR #3556: URL: https://github.com/apache/storm/pull/3556#issuecomment-1660768551 storm builds on all pull requests under github actions currently. However, I think it is better to consistent in excluding this dependency. -- This is an automated message from the Ap

[GitHub] [storm] rzo1 commented on pull request #3556: Missing dependency prevents Storm from being built, fixes #3940

2023-08-01 Thread via GitHub
rzo1 commented on PR #3556: URL: https://github.com/apache/storm/pull/3556#issuecomment-1660648311 > This artifact is available on maven central. Is there a need to exclude it? https://mvnrepository.com/artifact/org.pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde I think, that the

[GitHub] [storm] bipinprasad commented on pull request #3556: Missing dependency prevents Storm from being built, fixes #3940

2023-08-01 Thread via GitHub
bipinprasad commented on PR #3556: URL: https://github.com/apache/storm/pull/3556#issuecomment-1660419649 This artifact is available on maven central. Is there a need to exclude it? https://mvnrepository.com/artifact/org.pentaho/pentaho-aggdesigner-algorithm/5.1.5-jhyde -- This is an auto

[GitHub] [storm] jnioche opened a new pull request, #3556: Missing dependency prevents Storm from being built, fixes #3940

2023-08-01 Thread via GitHub
jnioche opened a new pull request, #3556: URL: https://github.com/apache/storm/pull/3556 ## What is the purpose of the change Storm can't be built because the dependency pentaho-aggdesigner-algorithm is not available.  This dependency is excluded in some places of the poms but

[GitHub] [storm] bipinprasad merged pull request #3555: [STORM-3895] Add JDK-17 build

2023-07-31 Thread via GitHub
bipinprasad merged PR #3555: URL: https://github.com/apache/storm/pull/3555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] bipinprasad commented on pull request #3555: [STORM-3895] Add JDK-17 build

2023-07-27 Thread via GitHub
bipinprasad commented on PR #3555: URL: https://github.com/apache/storm/pull/3555#issuecomment-1654447554 For some reason, under openjdk-17, the license file is much smaller (and different) from that generated under jdk8 and jdk11. Wondering is this is related to strict isolation of package

[GitHub] [storm] agresch commented on a diff in pull request #3555: [STORM-3895] Add JDK-17 build

2023-07-27 Thread via GitHub
agresch commented on code in PR #3555: URL: https://github.com/apache/storm/pull/3555#discussion_r1276602250 ## storm-server/pom.xml: ## @@ -169,6 +169,8 @@ maven-surefire-plugin 1 + Review Comment:

[GitHub] [storm] avermeer commented on pull request #3555: [STORM-3895] Add JDK-17 build

2023-07-26 Thread via GitHub
avermeer commented on PR #3555: URL: https://github.com/apache/storm/pull/3555#issuecomment-1653001618 Very good initiative, thanks ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [storm] bipinprasad opened a new pull request, #3555: [STORM-3895] Add JDK-17 build

2023-07-26 Thread via GitHub
bipinprasad opened a new pull request, #3555: URL: https://github.com/apache/storm/pull/3555 ## What is the purpose of the change *Add JDK-17 Build* ## How was the change tested *Let the github actions run* -- This is an automated message from the Apache Git Service. T

[GitHub] [storm] 6harat commented on pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions

2023-07-23 Thread via GitHub
6harat commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1647188305 @bipinprasad just pushed a README update commit, the prev workflow was already successful, so triggering it again might not be reqd. Please let me know if anything else is required from my s

[GitHub] [storm] 6harat commented on a diff in pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions

2023-07-23 Thread via GitHub
6harat commented on code in PR #3546: URL: https://github.com/apache/storm/pull/3546#discussion_r1271728650 ## docs/flux.md: ## @@ -765,6 +770,16 @@ The `override` property controls how includes affect the values defined in the c **N.B.:** Includes are not yet recursive. Inc

[GitHub] [storm] 6harat commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-07-23 Thread via GitHub
6harat commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1647184755 @bipinprasad please let me know if anything else is required for going ahead with merge -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [storm] LoggingResearch opened a new pull request, #3554: [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(…

2023-07-22 Thread via GitHub
LoggingResearch opened a new pull request, #3554: URL: https://github.com/apache/storm/pull/3554 ## What is the purpose of the change This PR addresses the handling of InterruptedException in the close() method of the Supervisor class. The changes include: Adding a separate cat

[GitHub] [storm] LoggingResearch closed pull request #3553: Handle InterruptedException in Supervisor close() method.

2023-07-22 Thread via GitHub
LoggingResearch closed pull request #3553: Handle InterruptedException in Supervisor close() method. URL: https://github.com/apache/storm/pull/3553 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [storm] LoggingResearch opened a new pull request, #3553: Handle InterruptedException in Supervisor close() method.

2023-07-17 Thread via GitHub
LoggingResearch opened a new pull request, #3553: URL: https://github.com/apache/storm/pull/3553 ## What is the purpose of the change This PR addresses the handling of InterruptedException in the close() method of the Supervisor class. The changes include: 1. Adding a separate catc

[GitHub] [storm] bipinprasad merged pull request #3552: [STORM-3930] Change the source code control URI

2023-07-06 Thread via GitHub
bipinprasad merged PR #3552: URL: https://github.com/apache/storm/pull/3552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] bipinprasad opened a new pull request, #3552: [STORM-3930] Change the source code control URI

2023-07-06 Thread via GitHub
bipinprasad opened a new pull request, #3552: URL: https://github.com/apache/storm/pull/3552 …d update the uri from gitbox to github ## What is the purpose of the change *While doing "mvm perform", the checkout times out at the end when using the https connection. Also the url

[GitHub] [storm] bipinprasad merged pull request #3549: [STORM-3927] Change python to python3 in examples

2023-07-01 Thread via GitHub
bipinprasad merged PR #3549: URL: https://github.com/apache/storm/pull/3549 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] bipinprasad commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-06-30 Thread via GitHub
bipinprasad commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1614815685 Triggered workflow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [storm] bipinprasad merged pull request #3550: [STORM-3928] Use python3 in flux test, examples and wrappers

2023-06-30 Thread via GitHub
bipinprasad merged PR #3550: URL: https://github.com/apache/storm/pull/3550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] bipinprasad merged pull request #3551: [STORM-3929] Update documentation to refer to python3

2023-06-30 Thread via GitHub
bipinprasad merged PR #3551: URL: https://github.com/apache/storm/pull/3551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] bipinprasad merged pull request #3548: [STORM-3926] Require python3 for bin/storm

2023-06-30 Thread via GitHub
bipinprasad merged PR #3548: URL: https://github.com/apache/storm/pull/3548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] bipinprasad opened a new pull request, #3551: [STORM-3929] Update documentation to refer to python3

2023-06-29 Thread via GitHub
bipinprasad opened a new pull request, #3551: URL: https://github.com/apache/storm/pull/3551 ## What is the purpose of the change *Python2 has been deprecated and removed Storm 2.5.0. Update documentation to reflect this change.* ## How was the change tested *Render ".md

[GitHub] [storm] bipinprasad opened a new pull request, #3550: [STORM-3928] Use python3 in flux test, examples and wrappers

2023-06-29 Thread via GitHub
bipinprasad opened a new pull request, #3550: URL: https://github.com/apache/storm/pull/3550 ## What is the purpose of the change *Python2 has been deprecated. However many systems still activate python2 when only using python. Change it to python3 to ensure Python version 3 is used.

[GitHub] [storm] bipinprasad opened a new pull request, #3549: [STORM-3927] Change python to python3 in examples

2023-06-29 Thread via GitHub
bipinprasad opened a new pull request, #3549: URL: https://github.com/apache/storm/pull/3549 ## What is the purpose of the change *Python2 has been deprecated. However many systems still activate python2 when only using python. Change it to python3 to ensure Python version 3 is used.

[GitHub] [storm] rzo1 commented on a diff in pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions

2023-06-29 Thread via GitHub
rzo1 commented on code in PR #3546: URL: https://github.com/apache/storm/pull/3546#discussion_r1246591112 ## docs/flux.md: ## @@ -765,6 +770,16 @@ The `override` property controls how includes affect the values defined in the c **N.B.:** Includes are not yet recursive. Inclu

[GitHub] [storm] rzo1 commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-06-25 Thread via GitHub
rzo1 commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1605965102 @6harat i am no committer on Storm, so nö karma to do so ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [storm] 6harat commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-06-25 Thread via GitHub
6harat commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1605948131 @bipinprasad @rzo1 could you please help trigger the workflow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [storm] 6harat commented on pull request #3546: [STORM-3924] Support for declaring WorkerHook in Flux topology definitions

2023-06-25 Thread via GitHub
6harat commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1605932509 > I was going through other parts of the code and found this TODO. Seems like it was intended to be connected to WorkerHooks when those were first introduced. > > ``` > private

[GitHub] [storm] bipinprasad merged pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-20 Thread via GitHub
bipinprasad merged PR #3540: URL: https://github.com/apache/storm/pull/3540 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] 6harat commented on pull request #3547: [STORM-3925] Allow user resources (in WorkerTopologyContext) to be set by Worker Hooks

2023-06-20 Thread via GitHub
6harat commented on PR #3547: URL: https://github.com/apache/storm/pull/3547#issuecomment-1599002790 Pending tasks: 1. Add feature tests 2. Update documentation / comments -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [storm] bipinprasad commented on pull request #3546: [STORM-XXXX] Support for declaring WorkerHook in Flux topology definitions

2023-06-19 Thread via GitHub
bipinprasad commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1597358946 Activated the checks. There may be some PMD exceptions - that can be checked locally as "mvn pmd:check" -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [storm] bipinprasad merged pull request #3545: [STORM-3923] Increase MAVEN_OPTS max memory setting to 2gb

2023-06-19 Thread via GitHub
bipinprasad merged PR #3545: URL: https://github.com/apache/storm/pull/3545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] 6harat commented on pull request #3546: [STORM-XXXX] Support for declaring WorkerHook in Flux topology definitions

2023-06-18 Thread via GitHub
6harat commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1596224842 I was going through other parts of the code and found this TODO. Seems like it was intended to be connected to WorkerHooks when those were first introduced. ``` private Map make

[GitHub] [storm] 6harat commented on pull request #3546: [STORM-XXXX] Support for declaring WorkerHook in Flux topology definitions

2023-06-17 Thread via GitHub
6harat commented on PR #3546: URL: https://github.com/apache/storm/pull/3546#issuecomment-1595677853 Please note the following observations / callouts: 1. have not added workerHoosk to executioncontext. AFAIS constructed spouts and bolts are being stored here so as to allow creation o

[GitHub] [storm] 6harat opened a new pull request, #3546: [STORM-XXXX] Support for declaring WorkerHook in Flux topology definitions

2023-06-17 Thread via GitHub
6harat opened a new pull request, #3546: URL: https://github.com/apache/storm/pull/3546 ## What is the purpose of the change A while back the support for declaring WorkerHook in TopologyBuilder was added. Related JIRA: https://issues.apache.org/jira/browse/STORM-126. This change adds

[GitHub] [storm] bipinprasad opened a new pull request, #3545: [STORM-3923] Increase MAVEN_OPTS max memory setting to 2gb

2023-06-16 Thread via GitHub
bipinprasad opened a new pull request, #3545: URL: https://github.com/apache/storm/pull/3545 ## What is the purpose of the change *Storm Cassandra (external/storm-cassandra) test fail because OOM* ## How was the code tested *Git Actions build and test run as part of this

[GitHub] [storm] bipinprasad merged pull request #3544: [STORM-3922] Acker scheduling changes.

2023-06-13 Thread via GitHub
bipinprasad merged PR #3544: URL: https://github.com/apache/storm/pull/3544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] bipinprasad opened a new pull request, #3544: [STORM-3922] Acker scheduling changes.

2023-06-12 Thread via GitHub
bipinprasad opened a new pull request, #3544: URL: https://github.com/apache/storm/pull/3544 ## What is the purpose of the change *Acker executors are sorted in a specific order that backtracking needs to account for.* ## How was the change tested *This code has been run

[GitHub] [storm] agresch commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-07 Thread via GitHub
agresch commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1221809229 ## storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java: ## @@ -527,13 +538,13 @@ protected SchedulingResul

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1220355853 ## storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java: ## @@ -527,13 +538,13 @@ protected SchedulingR

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1220322597 ## storm-client/src/jvm/org/apache/storm/Config.java: ## @@ -859,9 +859,11 @@ public class Config extends HashMap { @IsString public static final String STO

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1220291317 ## storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java: ## @@ -164,6 +168,7 @@ public SchedulingResult

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1220277226 ## storm-server/src/main/java/org/apache/storm/scheduler/resource/strategies/scheduling/BaseResourceAwareStrategy.java: ## @@ -123,6 +123,10 @@ public BaseResourceAwa

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1219931053 ## storm-client/src/jvm/org/apache/storm/Config.java: ## @@ -859,9 +859,11 @@ public class Config extends HashMap { @IsString public static final String STO

[GitHub] [storm] bipinprasad commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-06 Thread via GitHub
bipinprasad commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1219927539 ## storm-client/src/jvm/org/apache/storm/Config.java: ## @@ -859,9 +859,11 @@ public class Config extends HashMap { @IsString public static final String STO

[GitHub] [storm] agresch commented on a diff in pull request #3540: [STORM-3916] Add Round Robin Scheduling strategy with optional node limit

2023-06-05 Thread via GitHub
agresch commented on code in PR #3540: URL: https://github.com/apache/storm/pull/3540#discussion_r1218307249 ## storm-client/src/jvm/org/apache/storm/Config.java: ## @@ -859,9 +859,11 @@ public class Config extends HashMap { @IsString public static final String STORM_D

[GitHub] [storm] bipinprasad merged pull request #3538: [STORM-3921] Bump spring-core from 5.3.26 to 5.3.27 in /examples/storm-jms-examples

2023-06-02 Thread via GitHub
bipinprasad merged PR #3538: URL: https://github.com/apache/storm/pull/3538 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] bipinprasad commented on a diff in pull request #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced

2023-06-01 Thread via GitHub
bipinprasad commented on code in PR #3536: URL: https://github.com/apache/storm/pull/3536#discussion_r1213687480 ## storm-core/pom.xml: ## @@ -137,6 +137,7 @@ org.mockito mockito-core +${mockito.version} Review Comment: removed

[GitHub] [storm] agresch commented on a diff in pull request #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced

2023-06-01 Thread via GitHub
agresch commented on code in PR #3536: URL: https://github.com/apache/storm/pull/3536#discussion_r1213655650 ## storm-core/pom.xml: ## @@ -137,6 +137,7 @@ org.mockito mockito-core +${mockito.version} Review Comment: why was thi

[GitHub] [storm] bipinprasad merged pull request #3535: [STORM-3910] Enhanced logging for rocksdb metrics store.

2023-06-01 Thread via GitHub
bipinprasad merged PR #3535: URL: https://github.com/apache/storm/pull/3535 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm-site] ScottBrenner commented on pull request #35: Update meetups.yml

2023-05-26 Thread via GitHub
ScottBrenner commented on PR #35: URL: https://github.com/apache/storm-site/pull/35#issuecomment-1565183279 @bipinprasad please review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [storm] vesense commented on pull request #3543: STORM-3920 Update security document

2023-05-22 Thread via GitHub
vesense commented on PR #3543: URL: https://github.com/apache/storm/pull/3543#issuecomment-1557058816 Thanks @snikhil5 Merged into master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [storm] vesense merged pull request #3543: STORM-3920 Update security document

2023-05-22 Thread via GitHub
vesense merged PR #3543: URL: https://github.com/apache/storm/pull/3543 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

[GitHub] [storm] snikhil5 opened a new pull request, #3543: STORM-3920 Update security document

2023-05-18 Thread via GitHub
snikhil5 opened a new pull request, #3543: URL: https://github.com/apache/storm/pull/3543 ## What is the purpose of the change Update the document for setting up secure cluster ## How was the change tested Tested on a secure cluster -- This is an automated message from the

[GitHub] [storm] vesense commented on pull request #3542: [STORM-3917] Remove explicit worker heap size in ThroughputVsLatency

2023-05-12 Thread via GitHub
vesense commented on PR #3542: URL: https://github.com/apache/storm/pull/3542#issuecomment-1545705349 Thanks @jmartell7 Merged into master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [storm] vesense merged pull request #3542: [STORM-3917] Remove explicit worker heap size in ThroughputVsLatency

2023-05-12 Thread via GitHub
vesense merged PR #3542: URL: https://github.com/apache/storm/pull/3542 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

[GitHub] [storm] jmartell7 opened a new pull request, #3542: Remove explicit worker heap size in ThroughputVsLatency

2023-05-08 Thread via GitHub
jmartell7 opened a new pull request, #3542: URL: https://github.com/apache/storm/pull/3542 Allow users to change worker heap size in ThroughputVsLatency example topo. ## What is the purpose of the change ThroughputVsLatency adds an explicit 2GB worker heapsize overriding the RAS

[GitHub] [storm] agresch merged pull request #3541: Fix infinite loop when no files are left to remove

2023-05-04 Thread via GitHub
agresch merged PR #3541: URL: https://github.com/apache/storm/pull/3541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

[GitHub] [storm] jmartell7 opened a new pull request, #3541: Fix infinite loop when no files are left to remove

2023-05-03 Thread via GitHub
jmartell7 opened a new pull request, #3541: URL: https://github.com/apache/storm/pull/3541 ## What is the purpose of the change An infinite loop can occur when the worker directory takes too much space, but no files are found to remove. ## How was the change tested I have not in

[GitHub] [storm] bipinprasad opened a new pull request, #3540: [STORM-3916] Add Round Robin Scheduling stretgy with optional node li…

2023-05-03 Thread via GitHub
bipinprasad opened a new pull request, #3540: URL: https://github.com/apache/storm/pull/3540 …mit. ## What is the purpose of the change *Round Robin strategy will distribute components evenly across nodes. Default behavior will be to spread across all nodes. But can be limited

[GitHub] [storm] bipinprasad merged pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-05-01 Thread via GitHub
bipinprasad merged PR #3539: URL: https://github.com/apache/storm/pull/3539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] bipinprasad commented on pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-05-01 Thread via GitHub
bipinprasad commented on PR #3539: URL: https://github.com/apache/storm/pull/3539#issuecomment-1529862186 storm-cassandra test failure will be fixed in a separate Jira https://issues.apache.org/jira/browse/STORM-3915 -- This is an automated message from the Apache Git Service. To respond

[GitHub] [storm] bipinprasad commented on a diff in pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-04-28 Thread via GitHub
bipinprasad commented on code in PR #3539: URL: https://github.com/apache/storm/pull/3539#discussion_r1180617441 ## storm-server/pom.xml: ## @@ -60,6 +60,7 @@ org.rocksdb rocksdbjni +${rocksdb-version} Review Comment: I missed

[GitHub] [storm] bipinprasad commented on a diff in pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-04-28 Thread via GitHub
bipinprasad commented on code in PR #3539: URL: https://github.com/apache/storm/pull/3539#discussion_r1180600883 ## storm-server/pom.xml: ## @@ -60,6 +60,7 @@ org.rocksdb rocksdbjni +${rocksdb-version} Review Comment: The versi

[GitHub] [storm] agresch commented on a diff in pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-04-28 Thread via GitHub
agresch commented on code in PR #3539: URL: https://github.com/apache/storm/pull/3539#discussion_r1180543200 ## storm-server/pom.xml: ## @@ -60,6 +60,7 @@ org.rocksdb rocksdbjni +${rocksdb-version} Review Comment: even though t

[GitHub] [storm] bipinprasad commented on a diff in pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-04-28 Thread via GitHub
bipinprasad commented on code in PR #3539: URL: https://github.com/apache/storm/pull/3539#discussion_r1180506358 ## storm-server/pom.xml: ## @@ -60,6 +60,7 @@ org.rocksdb rocksdbjni +${rocksdb-version} Review Comment: Not speci

[GitHub] [storm] agresch commented on a diff in pull request #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-04-28 Thread via GitHub
agresch commented on code in PR #3539: URL: https://github.com/apache/storm/pull/3539#discussion_r1180464412 ## storm-server/pom.xml: ## @@ -60,6 +60,7 @@ org.rocksdb rocksdbjni +${rocksdb-version} Review Comment: just curious

[GitHub] [storm] bipinprasad opened a new pull request, #3539: [STORM-3913] Update rocksdb to version 8.1.1 that has Mac OSX JNI lib

2023-04-27 Thread via GitHub
bipinprasad opened a new pull request, #3539: URL: https://github.com/apache/storm/pull/3539 ## What is the purpose of the change *Version 6.27.3 does not have Mac OSX JNI Library. Some tests fail to load because of this missing dependency on Mac.* ## How was the change tested

[GitHub] [storm] vesense merged pull request #3537: [STORM-3912] Reference new clojar for carbonite version 1.6.0

2023-04-27 Thread via GitHub
vesense merged PR #3537: URL: https://github.com/apache/storm/pull/3537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

[GitHub] [storm] bipinprasad commented on a diff in pull request #3537: [STORM-3912] Reference new clojar for carbonite version 1.6.0

2023-04-17 Thread via GitHub
bipinprasad commented on code in PR #3537: URL: https://github.com/apache/storm/pull/3537#discussion_r1169127101 ## DEPENDENCY-LICENSES: ## @@ -14,6 +14,7 @@ List of third-party dependencies grouped by their license type. Apache License +* carbonite (org.clojar

[GitHub] [storm] rzo1 commented on a diff in pull request #3537: [STORM-3912] Reference new clojar for carbonite version 1.6.0

2023-04-17 Thread via GitHub
rzo1 commented on code in PR #3537: URL: https://github.com/apache/storm/pull/3537#discussion_r1169089745 ## DEPENDENCY-LICENSES: ## @@ -14,6 +14,7 @@ List of third-party dependencies grouped by their license type. Apache License +* carbonite (org.clojars.bipin

[GitHub] [storm] rzo1 commented on a diff in pull request #3537: [STORM-3912] Reference new clojar for carbonite version 1.6.0

2023-04-17 Thread via GitHub
rzo1 commented on code in PR #3537: URL: https://github.com/apache/storm/pull/3537#discussion_r1169089745 ## DEPENDENCY-LICENSES: ## @@ -14,6 +14,7 @@ List of third-party dependencies grouped by their license type. Apache License +* carbonite (org.clojars.bipin

[GitHub] [storm] dependabot[bot] opened a new pull request, #3538: Bump spring-core from 5.3.26 to 5.3.27 in /examples/storm-jms-examples

2023-04-17 Thread via GitHub
dependabot[bot] opened a new pull request, #3538: URL: https://github.com/apache/storm/pull/3538 Bumps [spring-core](https://github.com/spring-projects/spring-framework) from 5.3.26 to 5.3.27. Release notes Sourced from https://github.com/spring-projects/spring-framework/releases";

[GitHub] [storm-site] dependabot[bot] closed pull request #36: Bump nokogiri from 1.13.3 to 1.13.9

2023-04-11 Thread via GitHub
dependabot[bot] closed pull request #36: Bump nokogiri from 1.13.3 to 1.13.9 URL: https://github.com/apache/storm-site/pull/36 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [storm-site] dependabot[bot] commented on pull request #36: Bump nokogiri from 1.13.3 to 1.13.9

2023-04-11 Thread via GitHub
dependabot[bot] commented on PR #36: URL: https://github.com/apache/storm-site/pull/36#issuecomment-1504707642 Superseded by #39. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [storm-site] dependabot[bot] opened a new pull request, #39: Bump nokogiri from 1.13.3 to 1.14.3

2023-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #39: URL: https://github.com/apache/storm-site/pull/39 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.3 to 1.14.3. Release notes Sourced from https://github.com/sparklemotion/nokogiri/releases";>nokogiri's releases.

[GitHub] [storm-site] dependabot[bot] closed pull request #37: Bump nokogiri from 1.13.3 to 1.13.9 in /content

2023-04-11 Thread via GitHub
dependabot[bot] closed pull request #37: Bump nokogiri from 1.13.3 to 1.13.9 in /content URL: https://github.com/apache/storm-site/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [storm-site] dependabot[bot] commented on pull request #37: Bump nokogiri from 1.13.3 to 1.13.9 in /content

2023-04-11 Thread via GitHub
dependabot[bot] commented on PR #37: URL: https://github.com/apache/storm-site/pull/37#issuecomment-1504705472 Superseded by #38. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [storm-site] dependabot[bot] opened a new pull request, #38: Bump nokogiri from 1.13.3 to 1.14.3 in /content

2023-04-11 Thread via GitHub
dependabot[bot] opened a new pull request, #38: URL: https://github.com/apache/storm-site/pull/38 Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.3 to 1.14.3. Release notes Sourced from https://github.com/sparklemotion/nokogiri/releases";>nokogiri's releases.

[GitHub] [storm] vesense merged pull request #3534: [STORM-3909] Use python3 in metrics test

2023-04-10 Thread via GitHub
vesense merged PR #3534: URL: https://github.com/apache/storm/pull/3534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

[GitHub] [storm] bipinprasad opened a new pull request, #3537: [STORM-3912] Reference new clojar for carbonite version 1.6.0

2023-04-10 Thread via GitHub
bipinprasad opened a new pull request, #3537: URL: https://github.com/apache/storm/pull/3537 ## What is the purpose of the change *Carbonite:1.5.0 jar hasn't been changed since 2012 and includes some very old dependencies and java version. Create a new carbonite jar with version 1.6.

[GitHub] [storm] bipinprasad opened a new pull request, #3536: [STORM-3911] fetch net.minidev:json-smart:2.3 artifact from maven repo before conjars.org repo is referenced

2023-04-07 Thread via GitHub
bipinprasad opened a new pull request, #3536: URL: https://github.com/apache/storm/pull/3536 ## What is the purpose of the change *Transitive dependency from hadoop-auth pulls in net.minidev:json-smart from http://conjars.org. conjars.org site is no longer active. And timeouts in

[GitHub] [storm] bipinprasad opened a new pull request, #3535: [STORM-3910] Enhanced logging for rocksdb metrics store.

2023-04-07 Thread via GitHub
bipinprasad opened a new pull request, #3535: URL: https://github.com/apache/storm/pull/3535 ## What is the purpose of the change *Rocksdb requires a platform specific JNI library. This library is included in the rocksdbjni jar but is not loaded unless the dynamic library is in a loc

[GitHub] [storm] bipinprasad opened a new pull request, #3534: [STORM-3909] Use python3 in metrics test

2023-04-07 Thread via GitHub
bipinprasad opened a new pull request, #3534: URL: https://github.com/apache/storm/pull/3534 ## What is the purpose of the change *Ensure that python version 3 is used* ## How was the change tested *Run test* -- This is an automated message from the Apache Git Service.

[GitHub] [storm] vesense merged pull request #3533: [STORM-3908] Increase heap memory for MAVEN_OPTS used in github actions

2023-04-07 Thread via GitHub
vesense merged PR #3533: URL: https://github.com/apache/storm/pull/3533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache.org

[GitHub] [storm] bipinprasad opened a new pull request, #3533: [STORM-3908] Increase heap memory for MAVEN_OPTS used in github actions

2023-04-05 Thread via GitHub
bipinprasad opened a new pull request, #3533: URL: https://github.com/apache/storm/pull/3533 ## What is the purpose of the change *Sometimes github actions get out-of-memory exception. Since the Github Action Runners as bigger VMs that Travis used in the past, the heap can be made bi

[GitHub] [storm] bipinprasad merged pull request #3532: [STORM-3907] Update mockito to version 4.11.0 and change code to match

2023-04-05 Thread via GitHub
bipinprasad merged PR #3532: URL: https://github.com/apache/storm/pull/3532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] bipinprasad merged pull request #3530: [STORM-3905] Replace anonymous class with lambda in storm-core commands

2023-04-05 Thread via GitHub
bipinprasad merged PR #3530: URL: https://github.com/apache/storm/pull/3530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] bipinprasad merged pull request #3531: [STORM-3906] Remove org.mockito.internal.util.reflection.FieldSetter and set mockito.version to 3.11.2

2023-03-30 Thread via GitHub
bipinprasad merged PR #3531: URL: https://github.com/apache/storm/pull/3531 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] rzo1 commented on pull request #3492: Enable s390x builds on Travis

2023-03-29 Thread via GitHub
rzo1 commented on PR #3492: URL: https://github.com/apache/storm/pull/3492#issuecomment-1488488044 Think it needs https://github.com/actions/runner/issues/2263 to support x390 for GH actions. -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [storm] shahidhs-ibm closed pull request #3492: Enable s390x builds on Travis

2023-03-29 Thread via GitHub
shahidhs-ibm closed pull request #3492: Enable s390x builds on Travis URL: https://github.com/apache/storm/pull/3492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [storm] shahidhs-ibm commented on pull request #3492: Enable s390x builds on Travis

2023-03-29 Thread via GitHub
shahidhs-ibm commented on PR #3492: URL: https://github.com/apache/storm/pull/3492#issuecomment-1488485620 Closing this PR as it is no longer valid as Storm has replaced Travis with GitHub Actions. Ref. https://github.com/apache/storm/pull/3520 -- This is an automated message from the Apa

[GitHub] [storm] bipinprasad merged pull request #3528: [STORM-3904] Bump spring-core from 5.3.20 to 5.3.26 in /examples/storm-jms-examples

2023-03-28 Thread via GitHub
bipinprasad merged PR #3528: URL: https://github.com/apache/storm/pull/3528 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] bipinprasad merged pull request #3529: [STORM-3903] Bump commons-fileupload from 1.3.3 to 1.5

2023-03-28 Thread via GitHub
bipinprasad merged PR #3529: URL: https://github.com/apache/storm/pull/3529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@storm.apache

[GitHub] [storm] bipinprasad opened a new pull request, #3532: [STORM-3907] Update mockito to version 4.11.0 and change code to martch

2023-03-28 Thread via GitHub
bipinprasad opened a new pull request, #3532: URL: https://github.com/apache/storm/pull/3532 ## What is the purpose of the change *Update mockito so to version 4 with eventual goal of moving to version 5* ## How was the change tested *Local build and test* -- This is a

[GitHub] [storm] rzo1 commented on pull request #3509: [STORM-3884] Bump calcite-core from 1.14.0 to 1.32.0

2023-03-27 Thread via GitHub
rzo1 commented on PR #3509: URL: https://github.com/apache/storm/pull/3509#issuecomment-1486255145 Rebase for GH actions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [storm] rzo1 commented on pull request #3506: STORM-3888 HdfsBlobStoreFile set wrong permission for file

2023-03-27 Thread via GitHub
rzo1 commented on PR #3506: URL: https://github.com/apache/storm/pull/3506#issuecomment-1486254715 @skysiders can you rebase? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

<    2   3   4   5   6   7   8   >