Github user zhuoliu commented on the issue:
https://github.com/apache/storm/pull/1627
Since with the refactoring we directly access the disruptor queue to get
the backpressure status rather than having an additional flag in executor data
which is error-prone when flipping (which is
Github user zhuoliu commented on the issue:
https://github.com/apache/storm/pull/1632
Looks great to me, thanks. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user zhuoliu commented on the issue:
https://github.com/apache/storm/pull/1627
sure, Alex. Really appreciate if you can submit a separate PR for 1949.
+1 to this one!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user zhuoliu commented on the issue:
https://github.com/apache/storm/pull/1627
@abellina looks good to me, just one extra suggestion:
In
https://github.com/apache/storm/blob/master/storm-core/src/clj/org/apache/storm/daemon/worker.clj#L156
To reduce the traffic to
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1320#issuecomment-209574168
@HeartSaVioR sure. Fix for master branch:
https://github.com/apache/storm/pull/1338
---
If your project is set up for it, you can reply to this email and have your
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1338
[STORM-1696] status not sync if zk fails in backpressure #1320
This is a fix for master branch.
When there is a zk exception happens during worker-backpressure!,
there is a bad state
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1320
[STORM-1696]-1.x-branch status not sync if zk fails in backpressure
This issue can cause a topology to be blocked.
You can merge this pull request into a Git repository by running:
$ git pull
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1320#issuecomment-207134141
I can either put the refactoring part as a separate pull request or within
this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1315#issuecomment-206575929
Sorry, this is not a bug. No need to fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zhuoliu closed the pull request at:
https://github.com/apache/storm/pull/1315
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1314#issuecomment-206575442
Sorry, this is not a bug. No need to fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zhuoliu closed the pull request at:
https://github.com/apache/storm/pull/1314
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1315
[STORM-1690]-1.x-branch: fix backpressure flag init
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm STORM-1690-1.x-branch
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1314
[STORM-1690] fix backpressure flag initialization
Found that in different DisruptorQueues in a worker, the
_enableBackpressure flags have both true and false, which cause topology to be
blocked
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1310#issuecomment-206455912
Thanks for the reviews, merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1312
[STORM-1687] divide by zero in StatsUtil
uptime sometimes equals to zero which causes divide exception.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1311
[STORM-1687]-1.x divide by zero in stats
This fixes the "divide by zero" error in stats/compute-agg-capacity.
You can merge this pull request into a Git repository by running:
$ git
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1310
[STORM-1286] port kill_workers to java.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhuoliu/storm 1286
Alternatively you can review and
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1306#discussion_r58316450
--- Diff: docs/Storm-Scheduler.md ---
@@ -0,0 +1,27 @@
+---
+title: Scheduler
+layout: documentation
+documentation: true
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1306#discussion_r58316422
--- Diff: docs/Storm-Scheduler.md ---
@@ -0,0 +1,27 @@
+---
+title: Scheduler
+layout: documentation
+documentation: true
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1306#discussion_r58316401
--- Diff: docs/Storm-Scheduler.md ---
@@ -0,0 +1,27 @@
+---
+title: Scheduler
+layout: documentation
+documentation: true
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1306#discussion_r58316364
--- Diff: docs/Storm-Scheduler.md ---
@@ -0,0 +1,27 @@
+---
+title: Scheduler
+layout: documentation
+documentation: true
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1306#discussion_r58316346
--- Diff: docs/Storm-Scheduler.md ---
@@ -0,0 +1,27 @@
+---
+title: Scheduler
+layout: documentation
+documentation: true
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1306#discussion_r58316336
--- Diff: docs/Storm-Scheduler.md ---
@@ -0,0 +1,27 @@
+---
+title: Scheduler
+layout: documentation
+documentation: true
Github user zhuoliu closed the pull request at:
https://github.com/apache/storm/pull/1299
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1299#issuecomment-204544681
Taylor has applied this patch to 1.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1299#issuecomment-204541667
@ptgoetz, nice, then I will close this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1299#issuecomment-204539772
@ptgoetz , thanks for applying this one to 1.x already. One minor concern
is that the change to logviewer_test.clj is not included.
---
If your project is set up for
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1299#issuecomment-204538236
@HeartSaVioR this is for 1.x, just one line difference from the patch to
master.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1299
[STORM-1671]-1.x Enable logviewer to delete directory with no yaml file
Apply [https://github.com/apache/storm/pull/1285] to 1.x-branch
You can merge this pull request into a Git repository by
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1285#issuecomment-204452676
@HeartSaVioR Sure. Added this issue to epic Storm-1491. Will apply it to
1.0 once gets merged into master.
Upmerged.
---
If your project is set up for it, you
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1285#issuecomment-204066326
Will also cherry-pick this patch to 1.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1285
[STORM-1671] Enable logviewer to delete a dir without yaml
For those old and dead worker directories, in some weird case, there is no
yaml file in it. We should enable logviewer to delete them
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1280#discussion_r58081089
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -296,11 +293,15 @@
(worker-launcher-and-wait conf user ["signal
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1280#discussion_r58066223
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -296,11 +293,15 @@
(worker-launcher-and-wait conf user ["signal
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1280#discussion_r57974731
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -269,10 +269,7 @@
(catch IOException e
(log-warn-error e "Fail
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1280
[STORM-1667] Log the IO exception when deleting worker pid dir
We find a race condition in supervisor which can sometimes crash supervisor.
This race condition exists because: shutdown-worker is
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1232#issuecomment-202427400
@jerrypeng , I have addressed your comments. Could you check back? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1232#discussion_r57487640
--- Diff:
storm-core/test/jvm/org/apache/storm/scheduler/resource/TestResourceAwareScheduler.java
---
@@ -54,6 +61,681 @@
private static int
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1257#discussion_r57458382
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/StandaloneSupervisor.java
---
@@ -0,0 +1,83 @@
+/**
+ * Licensed to the Apache
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1257#discussion_r57457270
--- Diff: storm-core/src/clj/org/apache/storm/daemon/local_supervisor.clj
---
@@ -0,0 +1,64 @@
+;; Licensed to the Apache Software Foundation (ASF) under
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1232#issuecomment-201057484
Hi @knusbaum , comments addressed. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1232#discussion_r57397001
--- Diff:
storm-core/test/jvm/org/apache/storm/scheduler/resource/TestUtilsForResourceAwareScheduler.java
---
@@ -109,7 +112,7 @@
public static Map
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1232#issuecomment-200985657
Hi @jerrypeng @d2r @revans2 , would you mind having a look at this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1242#issuecomment-199603671
I would suggest testing a special topology with backpressure enabled. E.g.,
[this
one.](https://github.com/zhuoliu/storm/blob/1643/examples/storm-starter/src/jvm/org
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1242#discussion_r56929816
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -491,7 +493,7 @@
EVENTLOGGER-STREAM-ID
[component-id
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1232
[STORM-1300] backtype.storm.scheduler.resource-aware-scheduler-test
Port backtype.storm.scheduler.resource-aware-scheduler-test to java
You can merge this pull request into a Git repository by
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1211#issuecomment-197056859
Good catch. +1.
Checked, it was introduced only to master. 1.x is OK.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1212#issuecomment-197055834
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1206#issuecomment-197019532
Looks good. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1206#discussion_r56240881
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -73,6 +73,7 @@
(teardown-topology-errors! [this storm-id])
(heartbeat-storms
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1202#discussion_r55882679
--- Diff:
storm-core/test/jvm/org/apache/storm/cluster/StormClusterStateImplTest.java ---
@@ -0,0 +1,116 @@
+/**
+ * Licensed to the Apache Software
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1202#discussion_r55882536
--- Diff: storm-core/src/clj/org/apache/storm/daemon/nimbus.clj ---
@@ -1142,6 +1142,9 @@
(blob-rm-key blob-store (ConfigUtils/masterStormConfKey id
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1206#issuecomment-195527698
Just minor nit, mostly looks good to me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1206#discussion_r55881939
--- Diff: storm-core/src/clj/org/apache/storm/cluster.clj ---
@@ -73,6 +73,7 @@
(teardown-topology-errors! [this storm-id])
(heartbeat-storms
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1201#issuecomment-195011076
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1192#issuecomment-194906318
still +1, sure
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1192#issuecomment-194074562
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55254223
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/StandaloneSupervisor.java
---
@@ -0,0 +1,87 @@
+/**
+ * Licensed to the Apache
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1184#discussion_r55253935
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ShutdownWork.java ---
@@ -0,0 +1,125 @@
+/**
+ * Licensed to the Apache Software
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1152#issuecomment-189735905
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1158#issuecomment-189378341
jdk8 test passed, jdk7 test failure seems unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1158#issuecomment-189362515
Manual test passed. Could @kishorvpatil and @revans2 also look at this one?
Mostly the same as [1149](https://github.com/apache/storm/pull/1149)
---
If your project is
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1134#issuecomment-189351785
can we close this duplicate one?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1158
[Storm-1574] [1.x-branch]Better handle backpressure exception etc.
Better handle backpressure exception etc. Clear backpressure topo dir
during kill. Add unit test.
You can merge this pull request
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1149#issuecomment-189018954
Also, I need to put up another pull request for 1.x.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1134#issuecomment-189015333
Can you please create a named branch in your repository and then do the
pull request? Otherwise it would be difficult for it be merged.
---
If your project is set up
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1134#issuecomment-189013152
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1148#issuecomment-189012476
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1149#issuecomment-189009158
@revans2 updated the test with timeout, and fixed the Cast exception
(Int/Long) in Storm-1578, also manual test works fine.
---
If your project is set up for it, you
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1149#discussion_r54172980
--- Diff: storm-core/src/clj/org/apache/storm/daemon/worker.clj ---
@@ -155,7 +155,10 @@
;; update the worker's backpressure flag to zook
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1149#issuecomment-188939301
Since we will ignore all exception with onEvent in worker.clj, we should
not need to test RuntimeException here. So delete it.
---
If your project is set up for it
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1149#issuecomment-188898763
@revans2 Updated the exception handling.
Filed a JIRA for the Utils.uncaughtExceptionHandler renaming here:
https://issues.apache.org/jira/browse/STORM-1577
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1149
[STORM-1574] Better handle backpressure thread exception & clear dir.
1. Better handle exception.
2. Remove topo dir during kill.
3. Add a unit test.
You can merge this pull request in
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1135#issuecomment-188043611
LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1145#issuecomment-188035152
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1100#issuecomment-186363277
@redsanket thanks, upmerged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1100#issuecomment-186023847
Hi @revans2, really appreciate your comments! I addressed your comment in
[Storm-1563](https://issues.apache.org/jira/browse/STORM-1563) to change all
the Shutdownable
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1053#issuecomment-184812340
Looks good! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1081#issuecomment-184515933
We would also like @knusbaum to review this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1100#discussion_r52790876
--- Diff: storm-core/src/jvm/org/apache/storm/ProcessSimulator.java ---
@@ -0,0 +1,89 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1100
[STORM-1230] port backtype.storm.process-simulator to java.
From storm-core/src/clj/org/apache/storm/process-simulator.clj to
storm-core/src/jvm/org/apache/storm/ProcessSimulator.java
You can
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52352681
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/core/DevicesCore.java ---
@@ -0,0 +1,185 @@
+/**
+ * Licensed to the Apache Software
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52351834
--- Diff: conf/defaults.yaml ---
@@ -263,7 +263,7 @@ topology.state.checkpoint.interval.ms: 1000
# topology priority describing the importance of the
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52342723
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java ---
@@ -0,0 +1,207 @@
+/**
+ * Licensed to the Apache Software
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52342637
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupUtils.java ---
@@ -0,0 +1,128 @@
+/**
+ * Licensed to the Apache Software
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52342665
--- Diff:
storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupOperation.java ---
@@ -0,0 +1,80 @@
+/**
+ * Licensed to the Apache Software
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1053#discussion_r52338605
--- Diff: conf/defaults.yaml ---
@@ -263,7 +263,7 @@ topology.state.checkpoint.interval.ms: 1000
# topology priority describing the importance of the
GitHub user zhuoliu opened a pull request:
https://github.com/apache/storm/pull/1078
[STORM-1368] change heapdump file permissions so that UI download wilâ¦
Change heapdump file permissions so that UI download wil work in secure
clusters.
a. For automatically generated
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1057#issuecomment-176969832
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1030#issuecomment-175694846
Hi @knusbaum , I addressed your comments. Could you check back on this one?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zhuoliu commented on the pull request:
https://github.com/apache/storm/pull/1049#issuecomment-175250031
LGTM! +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50754732
--- Diff: storm-core/src/clj/org/apache/storm/util.clj ---
@@ -48,21 +48,21 @@
(:require [ring.util.codec :as codec])
(:use [org.apache.storm
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50754345
--- Diff: storm-core/test/clj/org/apache/storm/security/auth/auth_test.clj
---
@@ -14,27 +14,28 @@
;; See the License for the specific language
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50754397
--- Diff:
storm-core/test/clj/org/apache/storm/security/serialization/BlowfishTupleSerializer_test.clj
---
@@ -15,7 +15,7 @@
;; limitations under the
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50754051
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -1198,21 +1220,23 @@
(let [expected-name topology-name
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1043#discussion_r50753833
--- Diff: storm-core/test/clj/org/apache/storm/nimbus_test.clj ---
@@ -352,6 +372,7 @@
(is (= 2 (storm-num-workers state "mystorm")))
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1030#discussion_r50602689
--- Diff: storm-core/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -0,0 +1,711 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1030#discussion_r50602239
--- Diff: storm-core/src/jvm/org/apache/storm/utils/ConfigUtils.java ---
@@ -0,0 +1,711 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF
Github user zhuoliu commented on a diff in the pull request:
https://github.com/apache/storm/pull/1030#discussion_r50600899
--- Diff:
storm-core/src/jvm/org/apache/storm/testing/staticmocking/MockedConfigUtils.java
---
@@ -0,0 +1,31 @@
+/**
+ * Licensed to the Apache
1 - 100 of 301 matches
Mail list logo
