Github user roshannaik commented on the pull request:
https://github.com/apache/storm/pull/1250#issuecomment-200924901
yes .. that corresponds with my observations with profiling... clojure
lookups and reflection are among the most common bottlenecks.
---
If your project is set up fo
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1250#issuecomment-200853358
@roshannaik
Yes we need to do a renewed effort in profiling once a lot of the code has
moved to java for JStorm. I know that the throughput is about 1/2 of wha
Github user roshannaik commented on the pull request:
https://github.com/apache/storm/pull/1250#issuecomment-200609948
My gut feeling based on profiling storm recently is that there are much
bigger bottlenecks elsewhere that will eclipse any potential improvement this
can deliver. I
Github user hustfxj closed the pull request at:
https://github.com/apache/storm/pull/1250
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is ena
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1250#issuecomment-200490900
@hustfxj
If you want to close this pull request I will leave it up to you. In some
situations the uniqueness of a number is important, and having Random emit
t
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1250#issuecomment-200444929
@revans2 It is used in a non-thread safe way, especialy spout/bolt thread.
So we think it may not make sense. So I will close the PR?
---
If your project is set up for
Github user hustfxj commented on the pull request:
https://github.com/apache/storm/pull/1250#issuecomment-200402469
@revans2 ThreadLocalRandom is 20% faster than XORShiftRandom. But
ThreadLocalRandom is static.Yes, we can't use XORShiftRandom in
executor.clj due to thread safety
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57174134
--- Diff: storm-core/src/clj/org/apache/storm/config.clj ---
@@ -53,7 +54,7 @@
[freq]
(let [freq (int freq)
start (int 0)
-
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57173711
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -75,7 +76,7 @@
"Returns a function that returns a vector of which task indices
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57167482
--- Diff:
storm-core/src/jvm/org/apache/storm/transactional/TransactionalSpoutCoordinator.java
---
@@ -71,7 +72,7 @@ public ITransactionalSpout getSpout() {
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57167305
--- Diff: storm-core/src/jvm/org/apache/storm/grouping/ShuffleGrouping.java
---
@@ -35,7 +36,7 @@
@Override
public void prepare(Worker
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57167152
--- Diff:
storm-core/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -36,7 +37,7 @@
@Override
public void prepa
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57167003
--- Diff:
storm-core/src/jvm/org/apache/storm/grouping/LoadAwareShuffleGrouping.java ---
@@ -36,7 +37,7 @@
@Override
public void prepa
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57166843
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -698,7 +699,7 @@
executor-stats (:stats executor-data)
{:key
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1250#discussion_r57166147
--- Diff: storm-core/src/clj/org/apache/storm/daemon/executor.clj ---
@@ -508,7 +509,7 @@
^Integer max-spout-pending (if max-spout-pending (int
m
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1250#issuecomment-200363377
How does the performance compare to
http://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ThreadLocalRandom.html
which is also not thread safe,
GitHub user hustfxj opened a pull request:
https://github.com/apache/storm/pull/1250
[STORM-1650] improve performance by XORShiftRandom
XORShiftRandom have much better performance than Random, So I use
XORShiftRandom replace Random at some places
You can merge this pull request int
17 matches
Mail list logo
