GitHub user HeartSaVioR opened a pull request:
https://github.com/apache/storm/pull/1608
STORM-2016 Topology submission improvement: support adding local jars and
maven artifacts on submission (1.x)
* JIRA issue: http://issues.apache.org/jira/browse/STORM-2016
* design doc:
htt
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r7369
--- Diff: bin/storm.py ---
@@ -154,6 +157,39 @@ def confvalue(name, extrapaths, daemon=True):
return " ".join(tokens[1:])
return ""
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73704312
--- Diff: bin/storm.py ---
@@ -154,6 +157,39 @@ def confvalue(name, extrapaths, daemon=True):
return " ".join(tokens[1:])
return
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73706186
--- Diff: bin/storm.py ---
@@ -154,6 +157,39 @@ def confvalue(name, extrapaths, daemon=True):
return " ".join(tokens[1:])
return
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73821960
--- Diff: bin/storm.py ---
@@ -754,18 +827,24 @@ def parse_config_opts(args):
elif token == "--config":
global CONFFILE
CONFFI
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73822027
--- Diff: bin/storm.py ---
@@ -754,18 +827,24 @@ def parse_config_opts(args):
elif token == "--config":
global CONFFILE
CONFFI
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73822736
--- Diff: bin/storm.py ---
@@ -754,18 +827,24 @@ def parse_config_opts(args):
elif token == "--config":
global CONFFILE
CONF
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73822799
--- Diff: bin/storm.py ---
@@ -754,18 +827,24 @@ def parse_config_opts(args):
elif token == "--config":
global CONFFILE
CONF
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73823221
--- Diff: bin/storm.py ---
@@ -754,18 +827,24 @@ def parse_config_opts(args):
elif token == "--config":
global CONFFILE
CONF
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73823437
--- Diff: docs/Command-line-client.md ---
@@ -43,6 +43,19 @@ Syntax: `storm jar topology-jar-path class ...`
Runs the main method of `class` with
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73823457
--- Diff: docs/Command-line-client.md ---
@@ -43,6 +43,19 @@ Syntax: `storm jar topology-jar-path class ...`
Runs the main method of `class` with
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73823982
--- Diff: docs/Command-line-client.md ---
@@ -43,6 +43,19 @@ Syntax: `storm jar topology-jar-path class ...`
Runs the main method of `class` wit
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73824049
--- Diff: docs/Command-line-client.md ---
@@ -43,6 +43,19 @@ Syntax: `storm jar topology-jar-path class ...`
Runs the main method of `class` wit
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73825149
--- Diff: docs/Command-line-client.md ---
@@ -43,6 +43,19 @@ Syntax: `storm jar topology-jar-path class ...`
Runs the main method of `class` with
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73825749
--- Diff: docs/Command-line-client.md ---
@@ -43,6 +43,19 @@ Syntax: `storm jar topology-jar-path class ...`
Runs the main method of `class` wit
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73826382
--- Diff: bin/storm.py ---
@@ -754,18 +827,24 @@ def parse_config_opts(args):
elif token == "--config":
global CONFFILE
CONFFI
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73840557
--- Diff: storm-core/src/jvm/org/apache/storm/generated/Assignment.java ---
@@ -787,15 +787,15 @@ public void read(org.apache.thrift.protocol.TProtocol
ipro
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73841599
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -893,29 +891,61 @@
(let [rsrc-file-path (File. (.getFilePath loca
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73841656
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -875,14 +875,12 @@
(worker-launcher-and-wait conf (storm-conf TOPOLOGY-SU
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73842378
--- Diff: storm-core/src/jvm/org/apache/storm/generated/Assignment.java ---
@@ -787,15 +787,15 @@ public void read(org.apache.thrift.protocol.TProtocol
ip
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73984302
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -893,29 +891,61 @@
(let [rsrc-file-path (File. (.getFilePath lo
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73984542
--- Diff: storm-core/src/clj/org/apache/storm/daemon/supervisor.clj ---
@@ -875,14 +875,12 @@
(worker-launcher-and-wait conf (storm-conf TOPOLOGY-
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73985164
--- Diff: storm-core/src/clj/org/apache/storm/config.clj ---
@@ -141,6 +141,10 @@
[conf stormconf-path]
(merge conf (clojurify-structure (Utils
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73985493
--- Diff: storm-core/src/clj/org/apache/storm/config.clj ---
@@ -141,6 +141,10 @@
[conf stormconf-path]
(merge conf (clojurify-structure (Uti
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r73985944
--- Diff: storm-core/src/clj/org/apache/storm/config.clj ---
@@ -141,6 +141,10 @@
[conf stormconf-path]
(merge conf (clojurify-structure (Uti
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74000389
--- Diff:
external/storm-submit/src/main/java/org/apache/storm/submit/command/DependencyResolverMain.java
---
@@ -0,0 +1,105 @@
+/**
+ * Licensed t
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74000507
--- Diff:
external/storm-submit/src/main/java/org/apache/storm/submit/dependency/AetherUtils.java
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apa
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74001827
--- Diff:
external/storm-submit/src/main/java/org/apache/storm/submit/command/DependencyResolverMain.java
---
@@ -0,0 +1,105 @@
+/**
+ * Licensed
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74002305
--- Diff:
external/storm-submit/src/main/java/org/apache/storm/submit/dependency/AetherUtils.java
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apa
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74002489
--- Diff:
external/storm-submit/src/main/java/org/apache/storm/submit/dependency/AetherUtils.java
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the A
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74004298
--- Diff:
storm-core/src/jvm/org/apache/storm/dependency/DependencyUploader.java ---
@@ -0,0 +1,166 @@
+/**
+ * Licensed to the Apache Software Founda
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74005045
--- Diff: storm-core/src/jvm/org/apache/storm/StormSubmitter.java ---
@@ -233,6 +236,23 @@ public static void submitTopologyAs(String name, Map
stormConf, Sto
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74005317
--- Diff:
storm-core/src/jvm/org/apache/storm/dependency/DependencyUploader.java ---
@@ -0,0 +1,166 @@
+/**
+ * Licensed to the Apache Software Fo
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74005642
--- Diff: storm-core/src/jvm/org/apache/storm/StormSubmitter.java ---
@@ -233,6 +236,23 @@ public static void submitTopologyAs(String name, Map
stormConf,
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74005665
--- Diff:
external/storm-submit/src/main/java/org/apache/storm/submit/dependency/AetherUtils.java
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the A
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74009279
--- Diff:
storm-core/src/jvm/org/apache/storm/dependency/DependencyUploader.java ---
@@ -0,0 +1,166 @@
+/**
+ * Licensed to the Apache Software Founda
Github user manuzhang commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74014016
--- Diff:
external/storm-submit/src/main/java/org/apache/storm/submit/dependency/AetherUtils.java
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the Apa
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74023201
--- Diff: storm-core/src/jvm/org/apache/storm/StormSubmitter.java ---
@@ -238,39 +239,24 @@ public static void submitTopologyAs(String name, Map
stormConf, St
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74027328
--- Diff: storm-core/src/jvm/org/apache/storm/StormSubmitter.java ---
@@ -238,39 +239,24 @@ public static void submitTopologyAs(String name, Map
stormConf
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74028593
--- Diff: bin/storm.py ---
@@ -754,18 +827,24 @@ def parse_config_opts(args):
elif token == "--config":
global CONFFILE
CONF
Github user satishd commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74029648
--- Diff: storm-core/src/jvm/org/apache/storm/StormSubmitter.java ---
@@ -238,39 +239,24 @@ public static void submitTopologyAs(String name, Map
stormConf, St
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74031650
--- Diff: storm-core/src/jvm/org/apache/storm/StormSubmitter.java ---
@@ -238,39 +239,24 @@ public static void submitTopologyAs(String name, Map
stormConf
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74032406
--- Diff:
external/storm-submit/src/main/java/org/apache/storm/submit/dependency/AetherUtils.java
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the A
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74032928
--- Diff: storm-core/src/jvm/org/apache/storm/StormSubmitter.java ---
@@ -238,39 +239,24 @@ public static void submitTopologyAs(String name, Map
stormConf
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74033001
--- Diff:
external/storm-submit/src/main/java/org/apache/storm/submit/dependency/AetherUtils.java
---
@@ -0,0 +1,81 @@
+/**
+ * Licensed to the A
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74365965
--- Diff: bin/storm.py ---
@@ -232,44 +271,91 @@ def jar(jarfile, klass, *args):
The process is configured so that StormSubmitter
(http://s
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74366031
--- Diff: bin/storm.py ---
@@ -754,18 +827,24 @@ def parse_config_opts(args):
elif token == "--config":
global CONFFILE
CONFFIL
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74367004
--- Diff: bin/storm.py ---
@@ -754,18 +827,24 @@ def parse_config_opts(args):
elif token == "--config":
global CONFFILE
CONF
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74367408
--- Diff: bin/storm.py ---
@@ -232,44 +271,91 @@ def jar(jarfile, klass, *args):
The process is configured so that StormSubmitter
(http:
Github user harshach commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r74539478
--- Diff: bin/storm.py ---
@@ -232,44 +271,91 @@ def jar(jarfile, klass, *args):
The process is configured so that StormSubmitter
(http://s
Github user HeartSaVioR closed the pull request at:
https://github.com/apache/storm/pull/1608
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
51 matches
Mail list logo
