[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76611455 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,437 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76610605 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,429 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76609083 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java --- @@ -0,0 +1,300 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76609228 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,569 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-29 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76608228 --- Diff: storm-core/src/jvm/org/apache/storm/container/ResourceIsolationInterface.java --- @@ -56,4 +64,13 @@ */ List

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-28 Thread abellina
Github user abellina commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76535956 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,569 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-28 Thread abellina
Github user abellina commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76535617 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java --- @@ -0,0 +1,300 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76479982 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ContainerLauncher.java --- @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76479255 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ContainerLauncher.java --- @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76478540 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/ContainerLauncher.java --- @@ -0,0 +1,99 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76477726 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,437 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76476353 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,437 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76476827 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,417 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76476005 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,437 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76475950 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,437 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76474776 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,437 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76474197 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,437 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76473887 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,437 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76472957 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,437 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76472894 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,437 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76464179 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java --- @@ -0,0 +1,202 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76462779 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java --- @@ -0,0 +1,202 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76462048 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java --- @@ -0,0 +1,202 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76460431 --- Diff: storm-core/src/jvm/org/apache/storm/container/cgroup/CgroupManager.java --- @@ -211,4 +209,15 @@ public void releaseResourcesForWorker(String workerId)

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76460236 --- Diff: storm-core/src/jvm/org/apache/storm/container/ResourceIsolationInterface.java --- @@ -56,4 +64,13 @@ */ List

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-26 Thread d2r
Github user d2r commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76459256 --- Diff: storm-core/src/jvm/org/apache/storm/cluster/StormClusterStateImpl.java --- @@ -164,21 +164,18 @@ public Assignment assignmentInfo(String stormId,

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76334398 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java --- @@ -0,0 +1,202 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76334407 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java --- @@ -0,0 +1,202 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76309477 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -17,135 +17,541 @@ */ package

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76309388 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,749 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76308994 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,749 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76308561 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76308272 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76303019 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76274105 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -17,135 +17,541 @@ */ package

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76273872 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,749 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76272537 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,749 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76272495 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java --- @@ -0,0 +1,749 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76271453 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,429 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76270332 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76271101 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76270910 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76270667 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76270530 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread harshach
Github user harshach commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76269608 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java --- @@ -0,0 +1,494 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76245840 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -17,135 +17,541 @@ */ package

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-25 Thread revans2
Github user revans2 commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76245649 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,417 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-24 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76169008 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java --- @@ -17,135 +17,541 @@ */ package

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-24 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76162679 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,417 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-24 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76161402 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,417 @@ +/** + * Licensed to the Apache Software

[GitHub] storm pull request #1642: DO NOT MERGE: Please review STORM-2018: Supervisor...

2016-08-24 Thread knusbaum
Github user knusbaum commented on a diff in the pull request: https://github.com/apache/storm/pull/1642#discussion_r76160977 --- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java --- @@ -0,0 +1,417 @@ +/** + * Licensed to the Apache Software