Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2698
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193104685
--- Diff: storm-core/pom.xml ---
@@ -193,10 +193,6 @@
curator-framework
compile
-
--- End diff --
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193103356
--- Diff:
storm-server/src/main/java/org/apache/storm/testing/InProcessZookeeper.java ---
@@ -12,15 +12,16 @@
package org.apache.storm.testing;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193090616
--- Diff:
storm-server/src/main/java/org/apache/storm/testing/InProcessZookeeper.java ---
@@ -12,15 +12,16 @@
package org.apache.storm.testing;
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193089630
--- Diff: storm-core/pom.xml ---
@@ -193,10 +193,6 @@
curator-framework
compile
-
--- End diff
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193084777
--- Diff:
storm-client/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java ---
@@ -54,8 +55,8 @@ public static String exec(String cmd) throws IOExcep
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193081199
--- Diff:
storm-client/test/jvm/org/apache/storm/security/auth/ClientAuthUtilsTest.java
---
@@ -172,59 +178,47 @@ public void makeDigestPayloadTest() throws
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193080442
--- Diff: shaded-deps/pom.xml ---
@@ -0,0 +1,272 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XM
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193080453
--- Diff:
storm-client/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java ---
@@ -54,8 +55,8 @@ public static String exec(String cmd) throws IOEx
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193078809
--- Diff: shaded-deps/pom.xml ---
@@ -0,0 +1,272 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193077896
--- Diff: shaded-deps/pom.xml ---
@@ -0,0 +1,272 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r193077799
--- Diff: shaded-deps/pom.xml ---
@@ -0,0 +1,272 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r192818795
--- Diff:
storm-client/src/jvm/org/apache/storm/container/cgroup/SystemOperation.java ---
@@ -54,8 +55,8 @@ public static String exec(String cmd) throws IOExcep
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r192816102
--- Diff: shaded-deps/pom.xml ---
@@ -0,0 +1,272 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XM
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r192822576
--- Diff:
storm-client/test/jvm/org/apache/storm/security/auth/ClientAuthUtilsTest.java
---
@@ -172,59 +178,47 @@ public void makeDigestPayloadTest() throws
N
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r192822955
--- Diff: storm-core/pom.xml ---
@@ -193,10 +193,6 @@
curator-framework
compile
-
--- End diff --
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r192823787
--- Diff:
storm-server/src/main/java/org/apache/storm/testing/InProcessZookeeper.java ---
@@ -12,15 +12,16 @@
package org.apache.storm.testing;
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r192814731
--- Diff: shaded-deps/pom.xml ---
@@ -0,0 +1,272 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XM
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r192814411
--- Diff: shaded-deps/pom.xml ---
@@ -0,0 +1,272 @@
+
+
+
+http://maven.apache.org/POM/4.0.0";
+ xmlns:xsi="http://www.w3.org/2001/XM
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r192434951
--- Diff: examples/storm-loadgen/pom.xml ---
@@ -67,6 +67,22 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xs
c
Github user Ethanlm commented on a diff in the pull request:
https://github.com/apache/storm/pull/2698#discussion_r192433936
--- Diff: DEVELOPER.md ---
@@ -239,8 +239,13 @@ To pull in a merge request you should generally follow
the command line instruct
# Build the code and ru
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/2698
STORM-2882: shade storm-client dependencies
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2882
Alternatively yo
22 matches
Mail list logo
