Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1428#issuecomment-220056112
@srdo that would not be a backwards compatible change for something that
never had to have this before. And we don't require it to be serializable, if
you ha
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1428#issuecomment-220122053
+1 for the comment. I think that would be great, and having the KafkaSpout
register things with kryo would be good, but I don't know if the API is setup
to support
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1443#issuecomment-221620918
@abhishekagarwal87 and @victor-wong
I am on the fence on this. Having a spout that is stuck forever is really
bad, but having it crash, lose data, come back
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1441#discussion_r64634284
--- Diff: bin/storm.py ---
@@ -241,7 +240,6 @@ def jar(jarfile, klass, *args):
extrajars=[tmpjar, USER_CONF_DIR, STORM_BIN_DIR
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1441#discussion_r64638916
--- Diff: bin/storm.py ---
@@ -241,7 +240,6 @@ def jar(jarfile, klass, *args):
extrajars=[tmpjar, USER_CONF_DIR, STORM_BIN_DIR
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/1448#issuecomment-222158287
+1 the travis failures look unrelated (but we should pull this change into
master before 1.x.
---
If your project is set up for it, you can reply to this email and
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1515#discussion_r68279943
--- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java
---
@@ -113,6 +113,15 @@ public StormTopology createTopology() {
Map
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1515#discussion_r68280207
--- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java
---
@@ -179,8 +188,13 @@ public BoltDeclarer setBolt(String id, IRichBolt bolt
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1515#discussion_r68280266
--- Diff: storm-core/src/jvm/org/apache/storm/topology/TopologyBuilder.java
---
@@ -339,8 +353,13 @@ public SpoutDeclarer setSpout(String id, IRichSpout
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1526
one minor nit, but overall I am +1 with or without the change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1526#discussion_r70251081
--- Diff: storm-core/src/jvm/org/apache/storm/spout/ShellSpout.java ---
@@ -47,6 +50,8 @@
private String[] _command;
private Map env = new
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1526
+1 but all 4 CI jobs failed. They look unrelated to this, as some of them
are failing because of a RAT problem. Lets fix the build ASAP before we merge
in much more.
---
If your project is set
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1526
The file without a license is
external/storm-kafka-monitor/src/main/java/org/apache/storm/kafka/monitor/KafkaPartitionOffsetLag.java
I'll file a separate JIRA for that.
---
If your pr
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1551
+1 pending travis
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1551
Travis passed this is just a comment/documentation change, not a code
change so I will push this in without waiting 24 hours.
---
If your project is set up for it, you can reply to this email and
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1553
STORM-1962: support python 3 and 2 in multilang
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-1962
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1552
I thought we already did a lot of this for the search side of things.
https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/ui/UIHelpers.java#L243-L245
How
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/414
@danny0405 like @HeartSaVioR said it depends on the versions you are
upgrading between. Most of the time we have maintained wire and binary
compatibility so you can do the upgrade piecemeal. This
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1574
The code to do the leader election based off of the IDs was removed because
architecturally the blobstore should be in charge of maintaining high
availability. Exposing what is stored on the local
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1572
+1, but I would like to see a tool that can kill a corrupted topology
without nimbus being involved, or instructions somewhere on how to do it by
logging directly into ZooKeeper.
---
If your
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1574
@HeartSaVioR
I am OK with this change, like I am OK with the change for STORM-1976. I
just don't think that this is the final solution for the local
blobstore+nimbus, nor do I think
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1572
@HeartSaVioR actually I have thought about it more and I am probably
overreacting. If you want to call these blockers it is not that big of a
deal. I would just like the community have a follow
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1572
@harshach I don't think that would fix the issue, although it is an
improvement. If I think about it more I think what happened was that they were
not running with HA/expecting HA to work, bu
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/414
@danny0405 That is very similar to what we want to move towards in our
rolling upgrades. We have done a very good job of maintaining compatibility of
LS and ZK once we moved to thrift for all of
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1574
@HeartSaVioR the local file system blobstore behaves exactly the same as
the nimbus HA before it. It tries to replicate all of the blobs to all of the
nimbus nodes as quickly as possible. It
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1572
Yes I am good with merging this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1574
@HeartSaVioR yes there is no bug with this code. I am +1 on merging this
in as is.
The bug I found is in the BlobStore implementation. It impacts this patch
in the future, because if we
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1606
STORM-2020: Stop using sun internal classes.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-2020
Alternatively
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1586
@harshach actually some of the build errors are related see
https://issues.apache.org/jira/browse/STORM-2021
---
If your project is set up for it, you can reply to this email and have your
reply
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1522
@HeartSaVioR looks like one of the test failures was related.
https://issues.apache.org/jira/browse/STORM-2022
---
If your project is set up for it, you can reply to this email and have
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1606
@HeartSaVioR @satishd
I fixed a few other things that are also breaking the build on master. If
you want me the break them apart I can.
---
If your project is set up for it, you can
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1606
This time the failures really are unrelated :).
```
[WARNING] Could not transfer metadata
org.apache.storm:multilang-python:2.0.0-SNAPSHOT/maven-metadata.xml from/to
apache-snapshots
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1608#discussion_r7369
--- Diff: bin/storm.py ---
@@ -154,6 +157,39 @@ def confvalue(name, extrapaths, daemon=True):
return " ".join(tokens[1:])
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1608
Conceptually I like the idea, and overall the code looks good. My biggest
concern is around cleanup of the bobs after the topology finishes. I don't see
anywhere in the code that it is doing
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1606
@HeartSaVioR thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1630
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1628
@HeartSaVioR Technically I don't think the bylaws cover changing minimum
requirements beyond a code change. If you want to modify the bylaws in that
way I would be happy to support you in
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/1642
DO NOT MERGE: Please review STORM-2018: Supervisor V2.
Still needs run as user and CGroup work, but the rest is working
Any feedback on this would be welcome. I am particularly
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/838
@knusbaum can you please take a look at what we have internally and be sure
that the fail over/load balancing features all got merged in to open source?
If it is all in then we probably need some
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76245649
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,417 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76245840
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java ---
@@ -17,135 +17,541 @@
*/
package
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/838
@knusbaum please file a JIRA and make sure that we do that soon. Did you
do that work or was it @redsanket ?
---
If your project is set up for it, you can reply to this email and have your
reply
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76303019
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,494 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76308272
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,494 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76308561
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,494 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76308994
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,749 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76309388
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,749 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76309477
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Supervisor.java ---
@@ -17,135 +17,541 @@
*/
package
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
@harshach @knusbaum I think I addressed all of your review comments along
with upmerging to the latest master. I still have a bit more to do, mostly
with writing a replacement for
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76334407
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java ---
@@ -0,0 +1,202 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76334398
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java ---
@@ -0,0 +1,202 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76608228
--- Diff:
storm-core/src/jvm/org/apache/storm/container/ResourceIsolationInterface.java
---
@@ -56,4 +64,13 @@
*/
List
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76609228
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,569 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76609083
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/AdvancedFSOps.java ---
@@ -0,0 +1,300 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76610605
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,429 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76611455
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,437 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
@d2r @abellina @harshach @knusbaum
I believe that I am done and that the code is ready to merge. I have
addressed all of the review comments to date. I have finished with updating
the
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76684178
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/ContainerLauncher.java ---
@@ -0,0 +1,99 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76873184
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,629 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76873268
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/BasicContainer.java ---
@@ -0,0 +1,629 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76873417
--- Diff:
storm-core/src/jvm/org/apache/storm/daemon/supervisor/Container.java ---
@@ -0,0 +1,493 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76874493
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,769 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76875102
--- Diff: storm-core/src/jvm/org/apache/storm/daemon/supervisor/Slot.java
---
@@ -0,0 +1,769 @@
+/**
+ * Licensed to the Apache Software Foundation
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/1642#discussion_r76875777
--- Diff:
storm-core/src/jvm/org/apache/storm/localizer/LocalDownloadedResource.java ---
@@ -0,0 +1,107 @@
+/**
+ * Licensed to the Apache Software
Github user revans2 commented on the issue:
https://github.com/apache/storm/pull/1642
@abellina I addressed all of your comments. I also have manually run all
of the unit tests and they are passing for me, despite the travis issues.
---
If your project is set up for it, you can
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/273#discussion_r18237335
--- Diff:
storm-core/src/jvm/backtype/storm/security/auth/authorizer/SimpleACLAuthorizer.java
---
@@ -107,12 +108,18 @@ public boolean permit(ReqContext
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/273#issuecomment-57360464
Once your remove the debug logging I too am +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/274#issuecomment-57361560
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/177#issuecomment-57363269
@itaifrenkel and @anyatch both of you should be in README.markdown now.
Thanks again for your contribution.
---
If your project is set up for it, you can reply to this
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/273#issuecomment-57383504
Looks great thanks for the quick turn around.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/291#issuecomment-59222813
@itaifrenkel Sorry for the long silence. We have been battling a fire
here with all hands on deck. I don't see much of a reason for this to wait on
STORM-528. You
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/291#issuecomment-59226497
I am +1 for this change. The code looks to do as expected, and everything
runs well.
---
If your project is set up for it, you can reply to this email and have your
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/302
[STORM-533] Added in client and server IConnection metrics.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm iconn
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/280#issuecomment-61983313
Sorry it took me so long to respond. The changes look good to me, but I
don't have a windows box so I cannot test the windows support, I am +1 on the
changes so far
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/302#issuecomment-61989690
The metrics system is very generic, and not that complex. Essentially it
sets up a timer that will periodically call getValueAndReset on an instance of
IMetric. These
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/302#issuecomment-61990146
@clockfly what specifically about the status of the connection do you want?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/121#issuecomment-62754593
I think we are at the point where we should merge the security branch into
master. This is a little bit different from most patches/pull requests we have
done, partly
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/121#issuecomment-62782715
Like I said in the mailing list, I have been out for a few weeks. I didn't
see 0.9.3 go out, but I thought that it must be very close by now. I'll send a
sep
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/121#issuecomment-62944630
I see a 0.9.3-branch already out in the git repo. I assume that this is
good enough. I will merge in the security work but just to be sure I'll tag
the repo
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/314
[STORM-557] Created docs directory and added in some svg diagrams.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/302#issuecomment-63134572
@clockfly is it OK to merge this code in? I am happy to file a new JIRA for
rethinking how we do metrics in storm, if you think that would be helpful.
---
If your
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/315#issuecomment-63326875
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/314#issuecomment-63332256
I was curious if we wanted to keep a 5MB file in our github repo that
everyone must download to get storm? As it stands now the git repo is about
11MB total. This could
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/314#issuecomment-63337668
OK so the next question I have is, should we split the one big SVG file up
along side rasterized PNG equivalents for use in the docs?
---
If your project is set up for
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/302#issuecomment-63340062
Thanks for the comments on this. I merged it into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r20450306
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -372,6 +372,13 @@
(throw (RuntimeException. (str "Got unexpected process name: &q
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/275#issuecomment-63347222
The changes look fine to me. +1, @d2r in this case the bolt is taking its
input and sending it to a kafka queue. I don't think we want to send ticks to
the kafka
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/275#issuecomment-63349586
OK I am wrong. When I tried to compile with this change the following
tests failed.
```
Failed tests:
shouldEmitSomethingIfTickTupleIsReceived
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/314#issuecomment-63354593
OK I split them apart, cleaned up one of the SVG images to make it smaller,
and added in some PNG versions, along with updating the security document to
use one of the
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/275#issuecomment-63355950
That is what I expected, thanks for clarifying @nielsbasjes Now I am very
confused why there is a test that looks like it explicitly tests that the ticks
are persisted
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/317
[STORM-410] Add groups support to log-viewer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/revans2/incubator-storm STORM-410
Alternatively
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/250#issuecomment-63491318
ping? I really would like to try and get this in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/120#discussion_r20513760
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -122,36 +124,64 @@ public static void sleep(long millis
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/120#issuecomment-63492543
I just had one comment, to avoid YAML doing some potentially unsafe things,
but it is not that critical, because placing a --config on the command line is
going to use a
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/310#issuecomment-63493192
This is a duplicate of STORM-188 as @clockfly suggested. This patch has a
regression, in that it does not search the classpath for the --config option.
I don't e
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/120#discussion_r20514725
--- Diff: storm-core/src/jvm/backtype/storm/utils/Utils.java ---
@@ -122,36 +124,64 @@ public static void sleep(long millis
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/311#issuecomment-63495857
@ptgoetz I traced this down in the netty code to the second parameter to
the call to bind in the socket.
https://docs.oracle.com/javase/7/docs/api/java/net
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/250#issuecomment-63524216
Not a problem it is great work, I would like to see it in. Also note that
security has been merged into master so if you could update your pull request
to master that
Github user revans2 commented on a diff in the pull request:
https://github.com/apache/storm/pull/296#discussion_r20535744
--- Diff: storm-core/src/clj/backtype/storm/util.clj ---
@@ -372,6 +372,13 @@
(throw (RuntimeException. (str "Got unexpected process name: &q
GitHub user revans2 opened a pull request:
https://github.com/apache/storm/pull/328
[STORM-570] replace table sorter with data table. Also upraded several ...
...javascript libraries to latest versions to make integration simpler.
I know this is kind of a lot. I upgraded
1 - 100 of 3781 matches
Mail list logo
