Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1674
Thanks @revans2 for the details. get it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1565
I will add new external project examples (such as `storm-druid`,
`storm-kinesis`) to the `examples` directory in a following up jira after this
PR being merged.
---
If your project is set up for
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1359
@revans2 Do you have time to take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1682#discussion_r78509309
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/ISqlTridentDataSource.java
---
@@ -17,14 +17,32 @@
*/
package
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1682#discussion_r78509264
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/ISqlTridentDataSource.java
---
@@ -17,14 +17,32 @@
*/
package
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1682
@HeartSaVioR
one minor comment, others looks good to me.
about sync send `.get()`, please take a look at previous comments:
https://github.com/apache/storm/pull/743#commitcomment-14195354
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1682
+1
and I have filed a jira for improving the TridentKafkaState batch sending.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1683
STORM-2092: optimize TridentKafkaState batch sending
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm STORM-2092
Alternatively
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1683
ci failure is unrelated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1681#discussion_r78530932
--- Diff:
external/sql/storm-sql-core/src/jvm/org/apache/storm/sql/StormSqlImpl.java ---
@@ -140,6 +142,40 @@ public void submit
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1681
Nice Job. one minor comment. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1681
Btw, I'm ok with current explain output. Spark's is even better, maybe
there is a chance to improve Calcite.
---
If your project is set up for it, you can reply to this email and have
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1683#discussion_r78544642
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -73,30 +74,35 @@ public void prepare(Properties options
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1683#discussion_r78545097
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -73,30 +74,35 @@ public void prepare(Properties options
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1683#discussion_r79296575
--- Diff:
external/storm-kafka/src/jvm/org/apache/storm/kafka/trident/TridentKafkaState.java
---
@@ -73,30 +74,35 @@ public void prepare(Properties options
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1603
@HeartSaVioR I recommend upgrading kafka to the 0.8.2.2 version since this
version fixed some important bugs. this is a minor change. hope to be merged.
---
If your project is set up for it, you
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1746
STORM-1607: Add MongoMapState for supporting trident's exactly once
semantics
major changes as following:
* new MongoMapState
* new MongoStateQuery
* new MongoLookupBolt
* u
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1748
[STORM-2103][SQL] Introduce new sql external module: storm-sql-mongodb
major changes as following:
* new KafkaDataSourcesProvider & unit tests
* change DataSourcesProvider me
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1748
since this PR has some common logics, hope it will be merged ASAP.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1567
@darionyaphet This issue has been fixed. Can you close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1748
@HeartSaVioR they are independent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1751
[STORM-2172][SQL] Support Avro as input / output format
* new AvroScheme & AvroSerializer , unit tests
* new avro CachedSchemas
* new SerdeUtils
You can merge this pull request into a
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1751
After https://github.com/apache/storm/pull/1748 getting merged, I will
update this PR accordingly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1754
[STORM-2177][SQL] Support TSV as input / output format
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm STORM-2177
Alternatively
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1754
This PR is on top of https://github.com/apache/storm/pull/1751
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1754
I added STORM-2173 to current PR since it is on top of #1751 too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1748
I want to make it clear that PRs getting merged order is
https://github.com/apache/storm/pull/1748
https://github.com/apache/storm/pull/1751
https://github.com/apache/storm/pull/1754
Hope these
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1748
@HeartSaVioR Thanks for your quick reply.
The reason tuple data is serialized to one field is that the method
`write(List data, ByteBuffer buffer)` in interface
`IOutputSerializer
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1748
@HeartSaVioR Thanks for your quick reply.
The reason tuple data is serialized to one field is that the method
`write(List data, ByteBuffer buffer)` in interface
`IOutputSerializer
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1748
Thanks @HeartSaVioR for your response and field Jiras. After my current
tasks completed, I will pick them up.
I will update #1751 accordingly, and then you can take a look if you have
time
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1751
@sachin-goyal @sachingsachin Thanks for your review. I think I have
addressed all of your comments.
Can you take a look again?
---
If your project is set up for it, you can reply to this email
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1751#discussion_r86676691
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/serde/avro/AvroScheme.java
---
@@ -0,0 +1,81 @@
+/*
+ * Licensed to
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1751#discussion_r86676696
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/utils/SerdeUtils.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1751#discussion_r86676693
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/utils/SerdeUtils.java
---
@@ -0,0 +1,100 @@
+/*
+ * Licensed to the
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1751
@HeartSaVioR ready for merging after get responses from @sachin-goyal and
@sachingsachin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1751#discussion_r86734548
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/serde/avro/CachedSchemas.java
---
@@ -0,0 +1,37 @@
+/*
+ * Licensed to
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1751#discussion_r86734617
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/utils/SerdeUtils.java
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1763
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1751
@sachingsachin Addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1751#discussion_r87122964
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/utils/SerdeUtils.java
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1751#discussion_r87123062
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/utils/SerdeUtils.java
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1751
@sachingsachin
>Could you also add a small note on the JIRA STORM-2172 why you are trying
to support avro?
STORM-2172 is a part of STORM-2149, you can see the Jira Description for
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1751
@HeartSaVioR You can take a look at the code after I addressed that using
`input.avro.schema` and `output.avro.schema` for input and output Avro Schemas.
---
If your project is set up for it, you
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1751
example SQL:
_NOTE: All the `\n` should be removed before you test it_
```
CREATE EXTERNAL TABLE ORDERS (ID INT PRIMARY KEY, UNIT_PRICE INT, QUANTITY
INT)
STORED AS
INPUTFORMAT
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1751
@HeartSaVioR I will create another PR for 1.x-branch because I find that
`Utils.newInstance` has changed.
We need a type casting in 1.x-branch.
---
If your project is set up for it, you can
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1770
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1772
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1773
STORM-2198: perform RotationAction when stopping HdfsBolt
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm STORM-2198
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1751
@HeartSaVioR Oh, the `NotSerializableException` is because that I removed
`CachedSchemas` in previous commit. Sorry for that, fixed.
---
If your project is set up for it, you can reply to this
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1751
Yes, I also find that the sql with Avro schema string is a little terrible.
it's not easy to edit for users. maybe I can take time to improve later.
---
If your project is set up for it, yo
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1751
@HeartSaVioR Thanks for your patience.
After this PR getting merged, I will modify the PR for TSV/CSV format ASAP.
---
If your project is set up for it, you can reply to this email and have your
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1751
@HeartSaVioR OK. I will create a PR for 1.x-branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1774
[STORM-2172][SQL][1.x branch] Support Avro as input / output format
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm STORM-2172-1
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1754
The code is ready for reviewing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1754
@HeartSaVioR Do you have time to take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1778
[STORM-2082][SQL] add sql external module storm-sql-hdfs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense/storm STORM-2082
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1777#discussion_r87968161
--- Diff: docs/storm-sql-reference.md ---
@@ -1203,4 +1203,103 @@ and class for aggregate function is here:
For now users can skip implementing `result
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1777#discussion_r87967670
--- Diff: docs/storm-sql-reference.md ---
@@ -1203,4 +1203,103 @@ and class for aggregate function is here:
For now users can skip implementing `result
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1777
Thanks @HeartSaVioR Just two minor comments. Others looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1778#discussion_r87985832
--- Diff:
external/sql/storm-sql-external/storm-sql-hdfs/src/jvm/org/apache/storm/sql/hdfs/HdfsDataSourcesProvider.java
---
@@ -0,0 +1,132
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1778#discussion_r87985904
--- Diff:
external/sql/storm-sql-external/storm-sql-hdfs/src/test/org/apache/storm/sql/hdfs/TestHdfsDataSourcesProvider.java
---
@@ -0,0 +1,152
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1778
@HeartSaVioR Addressed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1746
Any comments are welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1410
@chuanlei I think this issue has been fixed by STORM-2173. Can you close
this?
BTW, the` CsvScheme` in STORM-2173 uses standard RFC4180 CSV parser
supporting strings like `a,"b,c",d`
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1773
@HeartSaVioR OK. I'll do it right now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fe
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1780
STORM-2198: [1.x-branch] perform RotationAction when stopping HdfsBolt
This is STORM-2198 for 1.x-branch.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1773
Done. PTAL #1780
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1359
@HeartSaVioR Yes, it's still failed. I may need some help in repairing the
unit tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitH
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1742#discussion_r88449665
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/SocketDataSourcesProvider.java
---
@@ -0,0 +1,94
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1742#discussion_r88447536
--- Diff:
external/sql/storm-sql-runtime/src/jvm/org/apache/storm/sql/runtime/datasource/socket/SocketDataSourcesProvider.java
---
@@ -0,0 +1,94
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1742#discussion_r88448768
--- Diff:
external/sql/storm-sql-runtime/src/resources/META-INF/services/org.apache.storm.sql.runtime.DataSourcesProvider
---
@@ -0,0 +1,32
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1742
Thanks @HeartSaVioR LGTM +1 Just left several comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1739
@HeartSaVioR Overall looks good to me.
And I have a question: Now I'm working on STORM-2147 which I think should
be based on STORM-1443. Through this PR we can set the parallelism by
speci
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1742
@HeartSaVioR It would be better to add some `how to use` document.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1742
OK. nice :smile:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1739
@HeartSaVioR
>There might be some ways to pass partition count to upstream, and easy way
to do might be adding method to DataSourcesProvider. What I'm considering is
that we
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1789
STORM-2209: Update documents adding new integration for some externalâ¦
⦠systems
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vesense
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1789
@revans2 @HeartSaVioR Yes, the new files are copied from external modules
README.md.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1783
Overall looks good to me. My major concern is that on-heap caches(like
Guava cache, Ehcache) might cause bad GC situations. I didn't use Caffeine in
the past, maybe is a candidate.
---
If
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1783
@revans2 Yes, we can find a balance between high rate of cache hits and
full GCs. I'm OK for adding a built-in cache if we set parameters carefully.
---
If your project is set up for it, yo
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1783
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1783#discussion_r89250230
--- Diff:
external/storm-hbase/src/main/java/org/apache/storm/hbase/bolt/HBaseLookupBolt.java
---
@@ -40,51 +48,81 @@
*
*/
public class
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1789
Added kubernetes integration.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1778
@HeartSaVioR Now I'm a little busy, I will add it later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1789
@revans2 @HeartSaVioR I think this PR should be cherry-picked to 1.x-branch
since 1.x has contained these new modules . And we'd better sync documents to
storm site.
---
If your project is s
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1778
>provide `working SQL example statements` to test
Kafka -> HDFS
```
CREATE EXTERNAL TABLE ORDERS (ID INT PRIMARY KEY, UNIT_PRICE INT, QUANTITY
INT) LOCATION 'kafka:
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1801#discussion_r89728994
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/bolt/BaseCassandraBolt.java
---
@@ -92,6 +94,8 @@ public void prepare(Map
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1801#discussion_r89727286
--- Diff:
external/storm-cassandra/src/main/java/org/apache/storm/cassandra/bolt/BaseCassandraBolt.java
---
@@ -105,17 +109,43 @@ public BaseCassandraBolt
GitHub user vesense opened a pull request:
https://github.com/apache/storm/pull/1802
STORM-2209: 1.x-branch Update documents adding new integration for some
external systems
This PR is STORM-2209 for 1.x-branch. PR for master branch has been merged.
You can merge this pull
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1789
I created https://github.com/apache/storm/pull/1802 for 1.x-branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1742
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1783
+1 for merging to master after updating `docs/storm-hbase.md`.
`external/storm-hbase/README.md` has been documented.
---
If your project is set up for it, you can reply to this email and have your
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1816
hi @hmcl
Maybe the licenses between Apache Storm and JPMML(licensed under AGPLv3)
are incompatible.
Accoding to https://www.apache.org/licenses/GPL-compatibility.html
>GP
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1816
@hmcl @HeartSaVioR Got it. Thanks.
But I wonder the legacy code(https://github.com/jpmml/jpmml) was updated
three years ago and it seems would never been updated. This can be a problem.
Also
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1816
@harshach Thanks for your detailed explanations. Yes, this is a good start.
I'm +1 for adding this in. This might attract many people who interest NLP, ML.
---
If your project is set up f
Github user vesense commented on a diff in the pull request:
https://github.com/apache/storm/pull/1816#discussion_r91297902
--- Diff:
external/storm-pmml/src/main/java/org/apache/storm/pmml/runner/ModelRunner.java
---
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1816
@hmcl Code looks good. Left one comment. I think it is also necessary to
add a README file to let people know how to use it.
---
If your project is set up for it, you can reply to this email and
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1823
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1822
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user vesense commented on the issue:
https://github.com/apache/storm/pull/1823
Thanks @marblejenka Merged into 1.x-branch and cherry-picked to master
branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
401 - 500 of 587 matches
Mail list logo
