Why some test cases are excluded from integration tests?

2015-11-21 Thread Rajkumar Rajaratnam
Devs, The following test cases is annotated with "failed" group. As "failed" group is excluded in testng.xml, these test cases won't be executed in integration tests. GroupTerminationBehaviorTestCase IaaSProviderTestCase PartitionOneAfterAnotherClusterTestCase Any reason to do this? Thanks, Raj

Re: Stratos creating thread pools per application?

2015-11-21 Thread Imesh Gunaratne
Hi Akila, On Sat, Nov 21, 2015 at 1:20 PM, Akila Ravihansa Perera wrote: > > Any idea why thread pools are created per monitor object? Is it not > possible to share a common thread pool as per the current design? > No, we do not create a thread pool per monitor object, have a look at the code c

Re: One test scenario doesn't need to be tested in multiple test cases

2015-11-21 Thread Imesh Gunaratne
On Sun, Nov 22, 2015 at 12:03 AM, Lahiru Sandaruwan wrote: > Hi Raj, > > Yes. A good point. I didn't carefully analysed the test cases. But I guess > the problem is that we have automated the samples as test cases, where all > the samples do basic stuff again and again. > > No, now we have proper

Server Log Client for Stratos Integration Tests

2015-11-21 Thread Isuru Haththotuwa
Hi Devs, Added a $subject, class 'ServerLogClient'. This allows to monitor the back end logs of the Stratos server or any Carbon Server against which the integration tests are run, by providing the server URL. For an example, in a setup with multiple CEP nodes, we can use this to read the BE logs

Jenkins build is back to stable : Stratos-41x-Commit-Build #169

2015-11-21 Thread Apache Jenkins Server
See

Jenkins build is back to stable : Stratos-41x-Commit-Build » Apache Stratos - Integration Tests #169

2015-11-21 Thread Apache Jenkins Server
See

Re: One test scenario doesn't need to be tested in multiple test cases

2015-11-21 Thread Lahiru Sandaruwan
Hi Raj, Yes. A good point. I didn't carefully analysed the test cases. But I guess the problem is that we have automated the samples as test cases, where all the samples do basic stuff again and again. I think the solution should be a master test plan, building a story to start with the simple us

Re: Jenkins build became unstable: Stratos-41x-Commit-Build #168

2015-11-21 Thread Gayan Gunarathne
On Sat, Nov 21, 2015 at 11:05 PM, Akila Ravihansa Perera wrote: > Nice catch Raj! > > We might have to check whether this flawed logic is used in other test > cases. > > On Sat, Nov 21, 2015 at 11:02 PM, Rajkumar Rajaratnam > wrote: > >> I have fixed this now with dfb878c9f9272cd549de145482906b3

Re: Jenkins build became unstable: Stratos-41x-Commit-Build #168

2015-11-21 Thread Akila Ravihansa Perera
Nice catch Raj! We might have to check whether this flawed logic is used in other test cases. On Sat, Nov 21, 2015 at 11:02 PM, Rajkumar Rajaratnam wrote: > I have fixed this now with dfb878c9f9272cd549de145482906b3c9cba9d80. > > So this particular bug has not been revealed until now :). May be

Re: Jenkins build became unstable: Stratos-41x-Commit-Build #168

2015-11-21 Thread Rajkumar Rajaratnam
I have fixed this now with dfb878c9f9272cd549de145482906b3c9cba9d80. So this particular bug has not been revealed until now :). May be application force-undeployment has not been triggered for this particular test-case. Thanks, Raj. On Sat, Nov 21, 2015 at 10:55 PM, Rajkumar Rajaratnam wrote:

Re: Jenkins build became unstable: Stratos-41x-Commit-Build #168

2015-11-21 Thread Rajkumar Rajaratnam
This is a bug in the test case :). "assertEquals" should be changed to "assertTrue". Refer [1]. [1] https://github.com/apache/stratos/blob/stratos-4.1.x/products/stratos/modules/integration/test-integration/src/test/java/org/apache/stratos/integration/tests/application/ApplicationBurstingTestCas

Re: Jenkins build became unstable: Stratos-41x-Commit-Build #168

2015-11-21 Thread Gayan Gunarathne
Seems our integration test are getting failed. Will check with the local build. testApplicationBusting(org.apache.stratos.integration.tests.application.ApplicationBurstingTestCase) Time elapsed: 530.134 sec <<< FAILURE! java.lang.AssertionError: expected: but was: at org.testng.Assert.fa

Re: Updates done to CC configuration does not get reflected in spinning new instances

2015-11-21 Thread Isuru Haththotuwa
Committed an integration test to verify the scenario of IaaS properties getting properly picked and overridden when spawning instances. Commit ids: 28e65f2bf9c9b2f8f62173160b773368ac3b88f1 and 516609907b76b0078c0b0eef0c768793a8239720. On Wed, Nov 18, 2015 at 9:27 AM, Isuru Haththotuwa wrote: > H

Jenkins build became unstable: Stratos-41x-Commit-Build » Apache Stratos - Integration Tests #168

2015-11-21 Thread Apache Jenkins Server
See

Jenkins build became unstable: Stratos-41x-Commit-Build #168

2015-11-21 Thread Apache Jenkins Server
See

Re: One test scenario doesn't need to be tested in multiple test cases

2015-11-21 Thread Gayan Gunarathne
+1.We don't need to test the same test case again and again.IMO we can remove duplicate test cases. Also we can introduce separate test groups for test cases based on their test use case.This will provide you the option to run specific test group based on your modification. Thanks, Gayan On Sat,

One test scenario doesn't need to be tested in multiple test cases

2015-11-21 Thread Rajkumar Rajaratnam
Devs, We don't need to test the same test scenarios in different test cases. For example, "testing whether any used policies can be removed or not" ​should be tested only in one test case. But we are doing this check in couple of test cases. This is an unnecessary delay in running integration test

Re: Integration Test Failure in Branch 4.1.x

2015-11-21 Thread Gayan Gunarathne
On Sat, Nov 21, 2015 at 1:34 PM, Akila Ravihansa Perera wrote: > Devs, > > Please make sure you cleanup all the artifacts after test cases are > executed. Also make sure artifact names and IDs (auto-scaling policy id, > app id, network-partition-id etc.) *contain the test class name*. > Please do

Re: Stratos creating thread pools per application?

2015-11-21 Thread Isuru Haththotuwa
Hi, +1 for a common Thread pool. On Sat, Nov 21, 2015 at 8:08 PM, Reka Thirunavukkarasu wrote: > Hi Akila, > > Yah..I think that we can share a common thread pool per monitor. AFAIK, > there was no specific reason to maintain thread pool per monitor object. > > @Gayan, Do you aware of any parti

Re: Stratos creating thread pools per application?

2015-11-21 Thread Gayan Gunarathne
IMO it is ok to have separate thread pools for each monitors.With the separate thread pool for each monitor makes sure that those tasks get run regardless of how busy the rest of the monitors are.I don't think we can get any advantage by having common thread pool for this. But we need to introduce

[jira] [Resolved] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread Rajkumar Rajaratnam (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajkumar Rajaratnam resolved STRATOS-1628. -- Resolution: Implemented > Improve the way intergration test determines whether

[jira] [Commented] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020540#comment-15020540 ] ASF GitHub Bot commented on STRATOS-1628: - Github user ravihansa3000 commented o

[GitHub] stratos pull request: implementing STRATOS-1628

2015-11-21 Thread ravihansa3000
Github user ravihansa3000 commented on a diff in the pull request: https://github.com/apache/stratos/pull/492#discussion_r45547425 --- Diff: products/stratos/modules/integration/test-common/src/main/java/org/apache/stratos/integration/common/extensions/StratosServerExtension.java ---

[jira] [Commented] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020527#comment-15020527 ] ASF GitHub Bot commented on STRATOS-1628: - Github user asfgit closed the pull re

[GitHub] stratos pull request: implementing STRATOS-1628

2015-11-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/stratos/pull/492 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

Re: Stratos creating thread pools per application?

2015-11-21 Thread Reka Thirunavukkarasu
Hi Akila, Yah..I think that we can share a common thread pool per monitor. AFAIK, there was no specific reason to maintain thread pool per monitor object. @Gayan, Do you aware of any particular reason why we did like that? All the monitors need one thread allocated for periodic execution. Other

[jira] [Commented] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020505#comment-15020505 ] ASF GitHub Bot commented on STRATOS-1628: - Github user R-Rajkumar commented on a

[GitHub] stratos pull request: implementing STRATOS-1628

2015-11-21 Thread R-Rajkumar
Github user R-Rajkumar commented on a diff in the pull request: https://github.com/apache/stratos/pull/492#discussion_r45546741 --- Diff: components/org.apache.stratos.mock.iaas.api/src/main/java/org/apache/stratos/mock/iaas/api/MockIaasApi.java --- @@ -49,6 +51,24 @@ pub

[jira] [Commented] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020502#comment-15020502 ] ASF GitHub Bot commented on STRATOS-1628: - Github user R-Rajkumar commented on a

[GitHub] stratos pull request: implementing STRATOS-1628

2015-11-21 Thread R-Rajkumar
Github user R-Rajkumar commented on a diff in the pull request: https://github.com/apache/stratos/pull/492#discussion_r45546720 --- Diff: products/stratos/modules/integration/test-common/src/main/java/org/apache/stratos/integration/common/extensions/StratosServerExtension.java ---

[jira] [Commented] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020501#comment-15020501 ] ASF GitHub Bot commented on STRATOS-1628: - Github user R-Rajkumar commented on a

[jira] [Commented] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020499#comment-15020499 ] ASF GitHub Bot commented on STRATOS-1628: - Github user R-Rajkumar commented on a

[GitHub] stratos pull request: implementing STRATOS-1628

2015-11-21 Thread R-Rajkumar
Github user R-Rajkumar commented on a diff in the pull request: https://github.com/apache/stratos/pull/492#discussion_r45546693 --- Diff: components/org.apache.stratos.mock.iaas.client/src/main/java/org/apache/stratos/mock/iaas/client/MockIaasApiClient.java --- @@ -48,6 +49,20 @@

[GitHub] stratos pull request: implementing STRATOS-1628

2015-11-21 Thread R-Rajkumar
Github user R-Rajkumar commented on a diff in the pull request: https://github.com/apache/stratos/pull/492#discussion_r45546692 --- Diff: components/org.apache.stratos.mock.iaas.client/src/main/java/org/apache/stratos/mock/iaas/client/MockIaasApiClient.java --- @@ -48,6 +49,20 @@

[jira] [Commented] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020498#comment-15020498 ] ASF GitHub Bot commented on STRATOS-1628: - Github user ravihansa3000 commented o

[GitHub] stratos pull request: implementing STRATOS-1628

2015-11-21 Thread ravihansa3000
Github user ravihansa3000 commented on a diff in the pull request: https://github.com/apache/stratos/pull/492#discussion_r45546678 --- Diff: components/org.apache.stratos.mock.iaas.api/src/main/java/org/apache/stratos/mock/iaas/api/MockIaasApi.java --- @@ -49,6 +51,24 @@

[jira] [Commented] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020497#comment-15020497 ] ASF GitHub Bot commented on STRATOS-1628: - Github user ravihansa3000 commented o

[GitHub] stratos pull request: implementing STRATOS-1628

2015-11-21 Thread ravihansa3000
Github user ravihansa3000 commented on a diff in the pull request: https://github.com/apache/stratos/pull/492#discussion_r45546634 --- Diff: products/stratos/modules/integration/test-common/src/main/java/org/apache/stratos/integration/common/extensions/StratosServerExtension.java ---

[jira] [Commented] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020495#comment-15020495 ] ASF GitHub Bot commented on STRATOS-1628: - Github user ravihansa3000 commented o

[GitHub] stratos pull request: implementing STRATOS-1628

2015-11-21 Thread ravihansa3000
Github user ravihansa3000 commented on a diff in the pull request: https://github.com/apache/stratos/pull/492#discussion_r45546625 --- Diff: products/stratos/modules/integration/test-common/src/main/java/org/apache/stratos/integration/common/extensions/StratosServerExtension.java ---

[jira] [Commented] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020492#comment-15020492 ] ASF GitHub Bot commented on STRATOS-1628: - Github user ravihansa3000 commented o

[GitHub] stratos pull request: implementing STRATOS-1628

2015-11-21 Thread ravihansa3000
Github user ravihansa3000 commented on a diff in the pull request: https://github.com/apache/stratos/pull/492#discussion_r45546596 --- Diff: components/org.apache.stratos.mock.iaas.client/src/main/java/org/apache/stratos/mock/iaas/client/MockIaasApiClient.java --- @@ -48,6 +49,20

[jira] [Commented] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020465#comment-15020465 ] ASF GitHub Bot commented on STRATOS-1628: - Github user lahirus commented on a di

[GitHub] stratos pull request: implementing STRATOS-1628

2015-11-21 Thread lahirus
Github user lahirus commented on a diff in the pull request: https://github.com/apache/stratos/pull/492#discussion_r45546039 --- Diff: components/org.apache.stratos.mock.iaas.client/src/main/java/org/apache/stratos/mock/iaas/client/MockIaasApiClient.java --- @@ -48,6 +49,20 @@ pub

[jira] [Commented] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020435#comment-15020435 ] ASF GitHub Bot commented on STRATOS-1628: - GitHub user R-Rajkumar opened a pull

[GitHub] stratos pull request: implementing STRATOS-1628

2015-11-21 Thread R-Rajkumar
GitHub user R-Rajkumar opened a pull request: https://github.com/apache/stratos/pull/492 implementing STRATOS-1628 Currently, integrations test is looking at specific log messages to determine whether the stratos server is ready to handle request or not. Proper way would be to chec

[jira] [Created] (STRATOS-1628) Improve the way intergration test determines whether the server is ready or not

2015-11-21 Thread Rajkumar Rajaratnam (JIRA)
Rajkumar Rajaratnam created STRATOS-1628: Summary: Improve the way intergration test determines whether the server is ready or not Key: STRATOS-1628 URL: https://issues.apache.org/jira/browse/STRATOS-1628

[jira] [Commented] (STRATOS-1621) NPE Application Undeployment

2015-11-21 Thread Rajkumar Rajaratnam (JIRA)
[ https://issues.apache.org/jira/browse/STRATOS-1621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15020419#comment-15020419 ] Rajkumar Rajaratnam commented on STRATOS-1621: -- Hi Isuru, Do you still ge

Jenkins build is back to stable : Stratos-41x-Commit-Build » Apache Stratos - Integration Tests #165

2015-11-21 Thread Apache Jenkins Server
See

Jenkins build is back to stable : Stratos-41x-Commit-Build #165

2015-11-21 Thread Apache Jenkins Server
See

Re: Integration Test Failure in Branch 4.1.x

2015-11-21 Thread Akila Ravihansa Perera
Devs, Please make sure you cleanup all the artifacts after test cases are executed. Also make sure artifact names and IDs (auto-scaling policy id, app id, network-partition-id etc.) *contain the test class name*. Please do not copy paste from other test cases and leave as it is. This might cause c

Jenkins build became unstable: Stratos-41x-Commit-Build #164

2015-11-21 Thread Apache Jenkins Server
See

Jenkins build became unstable: Stratos-41x-Commit-Build » Apache Stratos - Integration Tests #164

2015-11-21 Thread Apache Jenkins Server
See