Re: Validator Plugin

2004-04-02 Thread Martin Cooper
Wow. I don't know what happened to my previous message. What showed up wasn't anything like what I sent, so I'm sending again (using a different mail client). See below. On Fri, 2 Apr 2004, David Graham wrote: > > --- Robert Leland <[EMAIL PROTECTED]> wrote: > > Currently the Validator PlugIn doe

RE: Validator Plugin

2004-04-02 Thread Martin Cooper
> -Original Message- > From: David Graham [mailto:[EMAIL PROTECTED] > Sent: Friday, April 02, 2004 5:39 AM > To: Struts Developers List > Subject: Re: Validator Plugin > > > > --- Robert Leland <[EMAIL PROTECTED]> wrote: > > Currently the Validator PlugIn doesnb -

RE: Splitting struts-config into multiple jar and read them as reso urce stream

2004-04-02 Thread Martin Cooper
> -Original Message- > From: Filippo Munafò [mailto:[EMAIL PROTECTED] > Sent: Friday, April 02, 2004 9:30 AM > To: Struts Developers List > Subject: RE: Splitting struts-config into multiple jar and read them as > reso urce stream > > > My two cents about Martin's points: > > 1 & 2) Havin

cvs commit: jakarta-struts/src/share/org/apache/struts/validator DynaValidatorActionForm.java DynaValidatorForm.java ValidatorActionForm.java ValidatorForm.java

2004-04-02 Thread germuska
germuska2004/04/02 06:30:58 Modified:src/share/org/apache/struts/validator DynaValidatorActionForm.java DynaValidatorForm.java ValidatorActionForm.java ValidatorForm.java Log: Push validate code up into ValidatorForm and add a getValida

cvs commit: jakarta-struts/src/share/org/apache/struts/validator ValidatorPlugIn.java

2004-04-02 Thread rleland
rleland 2004/04/02 16:06:55 Modified:src/share/org/apache/struts/validator ValidatorPlugIn.java Log: Modify Validator PlugIn to validate XML file. Failure no loner just logs failure and disables that skips that validation file. Errors now result in an exception being thrown to lou

Re: Fw: UrlValidator() takes options - but how?

2004-04-02 Thread Niall Pemberton
Theres many reasons why url validation can fail - theres been a fair discussion on this list on just whether a slash is valid at the end of a url this week. Add to that allowing different configuration options for url validation somebody could believe they are typing in a valid url and get frustrat

Re: Fw: UrlValidator() takes options - but how?

2004-04-02 Thread [EMAIL PROTECTED]
> -Original Message- > From: Niall Pemberton [mailto:[EMAIL PROTECTED]> > I'll have a look a doing a patch. I'm probably being really stupid but how > do you mean group by powers of 2? You mean 1, 2, 4, 8, 16, 32, 64 etc. - Yes 1<<0 1<<1,1<<2, 1<<3,1<<4 but > how would it group? That'

Re: Fw: UrlValidator() takes options - but how?

2004-04-02 Thread Niall Pemberton
thx - Original Message - From: "Adam Hardy" <[EMAIL PROTECTED]> To: "Struts Developers List" <[EMAIL PROTECTED]> Sent: Friday, April 02, 2004 9:03 PM Subject: Re: Fw: UrlValidator() takes options - but how? > Niall, > have a look at org.apache.commons.validator.util.Flags to see how it's

Re: Fw: UrlValidator() takes options - but how?

2004-04-02 Thread Adam Hardy
Niall, have a look at org.apache.commons.validator.util.Flags to see how it's done. Adam On 04/02/2004 09:50 PM Niall Pemberton wrote: I'll have a look a doing a patch. I'm probably being really stupid but how do you mean group by powers of 2? You mean 1, 2, 4, 8, 16, 32, 64 etc. - but how would i

Re: Fw: UrlValidator() takes options - but how?

2004-04-02 Thread Niall Pemberton
I'll have a look a doing a patch. I'm probably being really stupid but how do you mean group by powers of 2? You mean 1, 2, 4, 8, 16, 32, 64 etc. - but how would it group? Niall - Original Message - From: "Robert Leland" <[EMAIL PROTECTED]> To: "Struts Developers List" <[EMAIL PROTECTED]

RE: Splitting struts-config into multiple jar and read them as reso urce stream

2004-04-02 Thread Joe Germuska
So, my question is: are you sure that the enhancement of reading config files through jars is not something missing in the default behaviour? Well, I guess if people have been using Struts as much as they have up until now, then no, I don't think it's missing 8^) On the other hand, I wouldn't say

Re: Fw: UrlValidator() takes options - but how?

2004-04-02 Thread Niall Pemberton
Sending this again...as it seems to have got lost... Theres many reasons why url validation can fail - theres been a fair discussion on this list on just whether a slash is valid at the end of a url this week. Add to that allowing different configuration options for url validation somebody could

Re: Fw: UrlValidator() takes options - but how?

2004-04-02 Thread Robert Leland
Comments In Line. > -Original Message- > From: Niall Pemberton [mailto:[EMAIL PROTECTED]> While I was testing this I did have > another thought - UrlValidator just > returns true or false when it validates and gives no indication of what bit > of the validation failed. What do you think

Re: Validator Plugin

2004-04-02 Thread James Mitchell
On Fri, 2 Apr 2004, David Graham wrote: > > --- Robert Leland <[EMAIL PROTECTED]> wrote: > > Currently the Validator PlugIn doesn’t validate the XML file. I have > > updated it to remove the deprecated methods and to validate the XML > > files. > > > > Here is the question: Currently, the validato

RE: Splitting struts-config into multiple jar and read them as reso urce stream

2004-04-02 Thread Filippo Munafò
My two cents about Martin's points: 1 & 2) Having jar's name correspond to a module name. Interesting, but: - what about mixing subproject's jar and module's jar? How can we mix and discover them? - not common, but how if a jar need more configs, one for a module and one for another? 3) Mix

Re: Fw: UrlValidator() takes options - but how?

2004-04-02 Thread Adam Hardy
Actually as a developer though it would certainly help diagnosis of the test results to determine what was passing and what was failing! It's taking an unexpectedly long time for me with the testing since there are a huge number of tests done, plus the possibility of changing the options on the

Re: URL validation

2004-04-02 Thread Adam Hardy
My changes to the isValidPath() method cause the current checks for ".." combinations to break. I have worked out a pattern to check that any path containing ".." must be enclosed by slashes, i.e. /../ or /.. However I'm not certain whether it is valid to have the path start with "..", e.g.

DO NOT REPLY [Bug 28150] - Refactor ValidatorForm to facilitate overriding Validation Key

2004-04-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

RE: Splitting struts-config into multiple jar and read them as reso urce stream

2004-04-02 Thread Joe Germuska
At 10:48 PM -0800 4/1/04, Martin Cooper wrote: 4) As I've mentioned before (in this same thread, I think), I believe we need to factor out the configuration code and make it pluggable. Although this is Martin's fourth point, I think it should be the starting point. If we move to a way where confi

Re: Validator Plugin

2004-04-02 Thread David Graham
--- Robert Leland <[EMAIL PROTECTED]> wrote: > Currently the Validator PlugIn doesn’t validate the XML file. I have > updated it to remove the deprecated methods and to validate the XML > files. > > Here is the question: Currently, the validator plugin fails by logging a > message but doesn’t tak

Re: Fw: UrlValidator() takes options - but how?

2004-04-02 Thread David Graham
--- Niall Pemberton <[EMAIL PROTECTED]> wrote: > Sorry I jumped the gun and have put up a patch without agreeing the > variable > names - if its not acceptable I can always change it and re-submit the > patch. > > I have used the three options you mention (except mine are currently all > lower ca

DO NOT REPLY [Bug 28152] - problem with wrapper and dofilter

2004-04-02 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

RE: struts-faces - tiles (problems?)

2004-04-02 Thread Matthias Wessendorf
and the third is: if i enter web-app via /foo.faces (which the jsp that has this statement:) my commandLinks get rendered like: http://localhost:8080/strutsIntegration/foo.faces# all works now fine! (incl. struts-actions...) but only in that way! cheers, Matthias (sorry for don't writing a "wh

RE: struts-faces - tiles (problems?)

2004-04-02 Thread Matthias Wessendorf
Me again, to the second error that comes up i have in the pages some links via ... in the navi() i call dispatch on ExternalContext, however. if i "start" my app with url : /start.do i the commandLinks get rendered like this http://localhost:8080/strutsIntegration/start.do# after i click them the

struts-faces - tiles (problems?)

2004-04-02 Thread Matthias Wessendorf
Hi, i am using the struts-faces.jar. i have noticed two 'behaviors'. 1. first i have this base-tile: i use it in that way, that i use JSF-UI-Components and action-formbean-couple of struts. it works fine. now i have written a jsp(foo.jsp) with that code [code] <%@