Re: Checkstyle (was svn commit: r360442 [1/3] )

It's just that I don't have a lot of time right now to try and get IDEA or Jalopy to match our CheckStyle setup. If CheckStyle is going to be held up as the arbitrator of coding style, it would be nice if a code reformatter could reach the CheckStyle configuration directly. If anyone would like to

Re: svn commit: r369992 - in /struts/shale/trunk/tiger: nbproject/private/ src/java/org/apache/shale/tiger/faces/ src/test/org/apache/shale/tiger/config/ src/test/org/apache/shale/tiger/faces/

On 1/17/06, Gary VanMatre <[EMAIL PROTECTED]> wrote: > > >On 1/17/06, Gary VanMatre <[EMAIL PROTECTED]> wrote: > >> > >> This seems like a handly utility. Clay has something similar, > PropUtils, > >> that uses the ConvertUtils. I think we could refactor to use this > >> utility. Is there a spec

Re: svn commit: r369992 - in /struts/shale/trunk/tiger: nbproject/private/ src/java/org/apache/shale/tiger/faces/ src/test/org/apache/shale/tiger/config/ src/test/org/apache/shale/tiger/faces/

>On 1/17/06, Gary VanMatre <[EMAIL PROTECTED]> wrote: >> >> This seems like a handly utility. Clay has something similar, PropUtils, >> that uses the ConvertUtils. I think we could refactor to use this >> utility. Is there a specific reason that you wanted to factor out Commons >> BeanUtils? > >

Re: Non-discussion emails

Fair enough to wait a few months while infrastructure sorts things out. - Posted via Jive Forums http://forums.opensymphony.com/thread.jspa?threadID=14616&messageID=29056#29056

svn commit: r370045 - in /struts/shale/trunk/clay-plugin/src: java/org/apache/shale/clay/component/chain/PropertyValueCommand.java java/org/apache/shale/clay/utils/PropUtils.java test/org/apache/shale

Author: gvanmatre Date: Tue Jan 17 20:35:49 2006 New Revision: 370045 URL: http://svn.apache.org/viewcvs?rev=370045&view=rev Log: Refactored removing a dependency with commons-beanutils by using the new ProperyHelper and ConverterHelper classes in the shale core library. Removed: struts/sha

Re: Checkstyle (was svn commit: r360442 [1/3] )

You may want to have a look at Jalopy: jalopy.sf.net There are plugins for various IDEs and editors, as well as an Ant task (IIRC, you can use Ant tasks from Maven?). It won't fix everything, but it will help enforce many of the more common coding standards. It should be possible to configu

Re: Checkstyle (was svn commit: r360442 [1/3] )

It just fills the errors list with checkstyle errors, that you can then click on to be taken to the file and line. It was very handy for cleaning up Scripting. Don Ted Husted wrote: Does it actually reformat the code? Or just report on what should be reformatted? On 1/17/06, Don Brown <[EM

Re: Checkstyle (was svn commit: r360442 [1/3] )

Does it actually reformat the code? Or just report on what should be reformatted? On 1/17/06, Don Brown <[EMAIL PROTECTED]> wrote: > I've been using jEdit's checkstyle plugin. I had to temporary modify > the checkstyle xml to remove those dynamic properties, but otherwise, it > worked great. > >

Re: Checkstyle (was svn commit: r360442 [1/3] )

I've been using jEdit's checkstyle plugin. I had to temporary modify the checkstyle xml to remove those dynamic properties, but otherwise, it worked great. Don Ted Husted wrote: Is anyone using an automatic code reformatting tool that can read a CheckStyle configuration? I'd like to clean

Re: 1.3.0 Release - Next Steps

On 1/17/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: > And we also need to remove the example of the cglib enhanced form from > apps/examples. Done in r370014. -- Wendy - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional c

svn commit: r370014 - in /struts/apps/trunk/examples: project.xml src/java/org/apache/struts/webapp/exercise/EnhancedDynaFormAction.java src/webapp/WEB-INF/exercise/struts-config.xml src/webapp/exerci

Author: wsmoak Date: Tue Jan 17 18:36:06 2006 New Revision: 370014 URL: http://svn.apache.org/viewcvs?rev=370014&view=rev Log: Removed the example of CGLIB enhancement. See Bug# 37730 and r369764 in struts-action. Removed: struts/apps/trunk/examples/src/java/org/apache/struts/webapp/exerci

Re: svn commit: r369992 - in /struts/shale/trunk/tiger: nbproject/private/ src/java/org/apache/shale/tiger/faces/ src/test/org/apache/shale/tiger/config/ src/test/org/apache/shale/tiger/faces/

On 1/17/06, Gary VanMatre <[EMAIL PROTECTED]> wrote: > > This seems like a handly utility. Clay has something similar, PropUtils, > that uses the ConvertUtils. I think we could refactor to use this > utility. Is there a specific reason that you wanted to factor out Commons > BeanUtils? Yes ...

Re: Non-discussion emails

Committers obviously need to have oversight of everything - wiki, bugs, commits and posted messages, but thats a limited number of us and easy to ensure that we're fully subscribed up to everything. For other community members Jive is excellent and I think this is a great addition to support co

Re: Non-discussion emails

On 1/17/06, Patrick Lightbody <[EMAIL PROTECTED]> wrote: > Thoughts? I understand that this does involve some work, and for those of you > who are > quite happy with how things are now, it may seem like a waste of time. As > such, I'm > more than willing to do the actual work for any proposed sol

Re: svn commit: r369992 - in /struts/shale/trunk/tiger: nbproject/private/ src/java/org/apache/shale/tiger/faces/ src/test/org/apache/shale/tiger/config/ src/test/org/apache/shale/tiger/faces/

This seems like a handly utility. Clay has something similar, PropUtils, that uses the ConvertUtils. I think we could refactor to use this utility. Is there a specific reason that you wanted to factor out Commons BeanUtils? Gary -- Original message -- From: [EMAIL PRO

Re: J'J'JIRA (was Non-discussion emails)

Unfortunately, Contegix did not respond to the Request for Proposal, and another host has been recommended to the board. When the host takes over, hopefully we will be able to try more things, but that's still several months down the road. If for some reason, the new host didn't work out, I'm sure

Re: Checkstyle (was svn commit: r360442 [1/3] )

Is anyone using an automatic code reformatting tool that can read a CheckStyle configuration? I'd like to clean up some of the stylistic errors, but I would prefer that most of the reformatting be done by a proven tool. I have utter confidence in IDEA, but I don't know if we can perfectly align th

Re: Non-discussion emails

Wow, seems like there is a lot of push back on this topic. All I ask Please respect that Jason and I (as well as the WebWork community) come from a very well-established open source community and have a lot of alternative experience in this area. We both have different perspectives, but this mer

Re: 1.3.0 Release - Next Steps

I reviewed the notes in November, and I'll go over the commit logs since, to see if there is anything else we need to mention. But they should already be very close. One question would be whether we should copy the release notes page to each of the subproject and then edit them down to contain onl

svn commit: r369992 - in /struts/shale/trunk/tiger: nbproject/private/ src/java/org/apache/shale/tiger/faces/ src/test/org/apache/shale/tiger/config/ src/test/org/apache/shale/tiger/faces/

Author: craigmcc Date: Tue Jan 17 16:58:12 2006 New Revision: 369992 URL: http://svn.apache.org/viewcvs?rev=369992&view=rev Log: In VariableResolverImpl, remove direct dependency on Commons BeanUtils by using the new helper methods for property access and conversion. As a side effect of this chan

svn commit: r369991 - in /struts/shale/trunk/core-library/src/java/org/apache/shale: resources/Bundle.properties util/ConverterHelper.java util/PropertyHelper.java

Author: craigmcc Date: Tue Jan 17 16:56:48 2006 New Revision: 369991 URL: http://svn.apache.org/viewcvs?rev=369991&view=rev Log: Clean up some logic errors surfaced by writing some unit tests using these two helper classes. Modified: struts/shale/trunk/core-library/src/java/org/apache/shale/

Re: Non-discussion emails

I don't think anyone, and certainly not I, is arguing that wiki and ticket messages are somehow less important, only that they are different, and perhaps viewed at different times or in different ways. Just as those that prefer mail clients heavily use folders to sort their mail, I've found RSS

Re: Non-discussion emails

On 1/17/06, Don Brown <[EMAIL PROTECTED]> wrote: > I'd like to see a compromise where I could sign up for mailing list that only > contains > discussions, yet track tickets, > wiki updates, and commits via RSS. This discussion-only mailing list could > be a second > mailing list that just > auto

J'J'JIRA (was Non-discussion emails)

Sort of also going off tangent again, but I can't sing the praises enough about Contegix and their hosting service. I know there are plenty of legal concerns that Ted tried explaining to me that might prevent them from being used, but if those can be worked around or addressed in another way, I

Re: Non-discussion emails

On 1/17/06, Don Brown <[EMAIL PROTECTED]> wrote: > > That's great for folks that manage their information via email and email > folders, but not all do. I'm finding myself > use RSS more and more to manage project, hobby, and personal information, > leaving email only for correspondences that I >

Re: J'J'JIRA (was Re: Non-discussion emails)

On 1/17/06, Ted Husted <[EMAIL PROTECTED]> wrote: > > On 1/17/06, Sean Schofield <[EMAIL PROTECTED]> wrote: > > BTW, there was talk of switching to JIRA a while back. I'm still +1 > > for that. Its a much nicer system and I find it less cumbersome then > > bugzilla. My point here is that its mor

Re: Non-discussion emails

That's great for folks that manage their information via email and email folders, but not all do. I'm finding myself use RSS more and more to manage project, hobby, and personal information, leaving email only for correspondences that I need to respond to. I'd like to see a compromise where I

Re: Non-discussion emails

On 1/17/06, Sean Schofield <[EMAIL PROTECTED]> wrote: > > > IMHO, it sounds like Jive is not up to the task of managing an > > ASF-style dev list. Any decent mailreader can filter mails into > > whatever folders we find convenient, creating the personal equivalent > > of five or six separate lists,

svn commit: r369940 - in /struts/shale/trunk/core-library/src/java/org/apache/shale: resources/Bundle.properties util/ConverterHelper.java

Author: craigmcc Date: Tue Jan 17 13:55:55 2006 New Revision: 369940 URL: http://svn.apache.org/viewcvs?rev=369940&view=rev Log: Throw an informative ConverterException if conversion is requested for a type that has no by-type converter registered. Modified: struts/shale/trunk/core-library/s

svn commit: r369939 - /struts/shale/trunk/test-framework/src/java/org/apache/shale/test/mock/MockApplication.java

Author: craigmcc Date: Tue Jan 17 13:54:58 2006 New Revision: 369939 URL: http://svn.apache.org/viewcvs?rev=369939&view=rev Log: Make the createConverter() methods return null (per spec) if no matching registered converter can be found. Modified: struts/shale/trunk/test-framework/src/java/or

Re: Non-discussion emails

Of course http://struts.roomity.com is both (as is news.gmane.org) (It's a nail, I am the hammer) .V To that end, mailing lists work, and forums do not. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands,

J'J'JIRA (was Re: Non-discussion emails)

On 1/17/06, Sean Schofield <[EMAIL PROTECTED]> wrote: > BTW, there was talk of switching to JIRA a while back. I'm still +1 > for that. Its a much nicer system and I find it less cumbersome then > bugzilla. My point here is that its more tempting to "reply" to the > bug in the proper place. Web

Re: Non-discussion emails

> IMHO, it sounds like Jive is not up to the task of managing an > ASF-style dev list. Any decent mailreader can filter mails into > whatever folders we find convenient, creating the personal equivalent > of five or six separate lists, if that's what someone wants. GMail also has *excellent* searc

Re: Non-discussion emails

My 2 cents (I know, you were dying to know how I feel ;): I want to be a part of this (and many other) communities, and that means keeping up to date with the discussions that happen for a given project. To that end, mailing lists work, and forums do not. It's nice to be able to filter m

Re: Non-discussion emails

On 1/17/06, Patrick Lightbody <[EMAIL PROTECTED]> wrote: > I definitely understand where you are coming from, and I hope you can see > where I'm > coming from. Often when people have different work behaviors, the best bet is > to provide > more options. This can be done by somehow allowing indivi

Re: Non-discussion emails

I agree with Ted about the importance of mailing lists. Mailing lists are the "Apache Way." The only time I have used off-llist communication is during an infrastructure move where we needed to rapidly complete several steps in a short period of time. Even then the basic outline of work was agre

Re: [ANNOUNCEMENT] New Struts committers: Jason Carreira and Patrick Lightbody

Welcome!!! -- James Mitchell EdgeTech, Inc. http://edgetechservices.net/ 678.910.8017 Skype: jmitchtx On Jan 17, 2006, at 1:54 PM, Don Brown wrote: Please join me in welcoming Jason Carreira and Patrick Lightbody as new Struts committers. Jason and Patrick are the core WebWork 2 developer

[ANNOUNCEMENT] New Struts committers: Jason Carreira and Patrick Lightbody

Please join me in welcoming Jason Carreira and Patrick Lightbody as new Struts committers. Jason and Patrick are the core WebWork 2 developers and they are joining us in an important step in the merger process. I, and many other Struts committers, have personally met and talked at length with bo

Re: 1.3.0 Release - Next Steps

On 1/17/06, Ted Husted <[EMAIL PROTECTED]> wrote: > > OK, I see by the commit and wiki logs that Wendy has done the deed, > and everything is checked that going to be checked :) > > * http://wiki.apache.org/struts/StrutsClassicRelease130 > > Since a multiproject relesae is still new ground, I'm thi

Re: 1.3.0 Release - Next Steps

On 1/17/06, Ted Husted <[EMAIL PROTECTED]> wrote: > OK, I see by the commit and wiki logs that Wendy has done the deed, > and everything is checked that going to be checked :) The release notes could use a final review; I didn't check it off on the release plan. And we also need to remove the ex

Non-discussion emails

Ted, I'm sure you didn't mean it this way, but you seem to imply that I don't have any experience with this sort of stuff. I do. We too at OpenSymphony use mailing lists quite heavily (as does every other decent open source project out there). However, as technologies like RSS have grown more p

Re: 1.3.0 Release - Next Steps

> 25267 (Cactus test) is still open but will be dealt with later. Yes, I'm thinking that it's the tests that are broken, rather than the code. Having the cactus tests would be better, but it's better to release without than not release. We have been testing the code through the unit tests and ex

Re: 1.3.0 Release - Next Steps

I hate to say it, but I'm not going to have time to work on fixing this in time for the 1.3 release. Wendy's suggestion (removing the feature for now) probably makes the most sense; I'll look at adding the serialization support and putting the enhanced form bean support into 'extras' post 1

Re: Non-discussion emails

I'm not sure if I'd call those posts "non-discussion". We often have discussions by commenting on bug tickets. Since we are "commit then review", a commit log or wiki post is often the genesis of a discussion about the change. A commit or wiki event are not historical footnotes. These posts are a

Re: 1.3.0 Release - Next Steps

OK, I see by the commit and wiki logs that Wendy has done the deed, and everything is checked that going to be checked :) * http://wiki.apache.org/struts/StrutsClassicRelease130 Since a multiproject relesae is still new ground, I'm thinking the next step would be to assembly a prototype of what a

Re: 1.3.0 Release - Next Steps

On 1/16/06, Ted Husted <[EMAIL PROTECTED]> wrote: > Any new input on #37730? > > If we are not ready to resolve the serialization issue, then we should > table this new feature for a subsequent release. Done in r369764, see comments on Bug# 37730. I resolved the CGLIB-related bugs and updated th

[Struts Wiki] Update of "StrutsClassicRelease130" by WendySmoak

Dear Wiki user, You have subscribed to a wiki page or wiki category on "Struts Wiki" for change notification. The following page has been changed by WendySmoak: http://wiki.apache.org/struts/StrutsClassicRelease130 The comment on the change is: Updated bug status --

DO NOT REPLY [Bug 37301] - Allow dynamic interface implementation by ActionForms using CGLib

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 37730] - Enhanced DynaActionForms cannot be correct deserialized

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

[Struts Wiki] Update of "StrutsClassicRelease130" by WendySmoak

Dear Wiki user, You have subscribed to a wiki page or wiki category on "Struts Wiki" for change notification. The following page has been changed by WendySmoak: http://wiki.apache.org/struts/StrutsClassicRelease130 The comment on the change is: Removed CGLIB dependency; See Bug# 37730

DO NOT REPLY [Bug 37730] - Enhanced DynaActionForms cannot be correct deserialized

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

svn commit: r369764 - in /struts/action/trunk: ./ conf/java/ src/java/org/apache/struts/action/ src/java/org/apache/struts/config/ src/java/org/apache/struts/util/ src/test/org/apache/struts/action/ x

Author: wsmoak Date: Tue Jan 17 04:26:20 2006 New Revision: 369764 URL: http://svn.apache.org/viewcvs?rev=369764&view=rev Log: Removed CGLIB enhancement. May be re-added when Bug# 37730 ("Enhanced DynaActionForms cannot be correctly deserialized") is resolved. Removed: struts/action/trunk/sr

DO NOT REPLY [Bug 38298] - Enhancement to Shale Dialogs

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 38298] New: - Enhancement to Shale Dialogs

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu