Re: Problem in building latest source code

2007-09-20 Thread Don Brown
Just update your code and if you are still seeing the problem, let me know, and I'll try to resolve it this weekend. In the meantime, use Ted's suggestion to increase your memory for Maven. Don On 9/21/07, pppsunil <[EMAIL PROTECTED]> wrote: > > I am facing this problem in building trunk code. I

Re: Problem in building latest source code

2007-09-20 Thread pppsunil
Setting heap size to 512 MB did not help either. So i took easy way of skiping unit test cases and i am able to build code now. Thank you for the help Sunil Ted Husted wrote: > > You need to increase the heap space for Maven. > > // Bash > export MAVEN_OPTS=-Xmx512m > > // Windows > set MAVE

Re: Problem in building latest source code

2007-09-20 Thread pppsunil
I am facing this problem in building trunk code. I used http://svn.apache.org/repos/asf/struts/struts2/trunk this path for downloading sourcecode from SVN. What all data should i post on the forum to help with clean up. Sunil Don Brown-2 wrote: > > Are you building the 2.0 branch or trunk? If

Re: Multithreaded use of HashMap

2007-09-20 Thread Don Brown
Could you please file a JIRA ticket and put it against the 2.1.0 release? Thanks, Don On 9/21/07, Don Brown <[EMAIL PROTECTED]> wrote: > That's a good idea. My only concern is that Retrotranslator, which we > use to build 1.4 jars, would need to know how to handle it. > Otherwise, it looks like

Re: Multithreaded use of HashMap

2007-09-20 Thread Don Brown
That's a good idea. My only concern is that Retrotranslator, which we use to build 1.4 jars, would need to know how to handle it. Otherwise, it looks like that would be a good replacement for all our map-based caches. Don On 9/21/07, Shepherd, Darren S <[EMAIL PROTECTED]> wrote: > Don, > > Your

Re: Problem in building latest source code

2007-09-20 Thread Don Brown
Are you building the 2.0 branch or trunk? If our tests are leaking memory, I'd like to get that cleaned up. Don On 9/21/07, pppsunil <[EMAIL PROTECTED]> wrote: > > Hi, > > I am trying to build latest Struts 2.0 source code on machine but i am > getting this exception. > > Tests run: 1, Failures:

Re: [OT] Re: Should I announce SmartURLs or wait?

2007-09-20 Thread Don Brown
The generally accepted terminology for release numbering is MAJOR.MINOR.PATCH. Yes, Struts does things strangely, but that doesn't change how users expect things to work. Throwing in big features, and yes, I consider new annotations big features as they worm their way into user code, is not somet

Re: Problem in building latest source code

2007-09-20 Thread Ted Husted
You need to increase the heap space for Maven. // Bash export MAVEN_OPTS=-Xmx512m // Windows set MAVEN_OPTS=-Xmx512m * http://struts.apache.org/2.x/docs/building-with-maven.html -- HTH, Ted On 9/20/07, pppsunil <[EMAIL PROTECTED]> wrote: > > Hi, > > I am tryin

Re: [OT] Re: Should I announce SmartURLs or wait?

2007-09-20 Thread Ted Husted
As I understand it, 2.0.x is not a "patch release". It's part of the 2.0.x minor release series. By our reckoning, 2.0.10.1 would be a "patch" release, and in that case, I would agree. AFAIK, we have always agreed that minor releases are *not* feature-locked. If we start feature-locking minor-rele

Problem in building latest source code

2007-09-20 Thread pppsunil
Hi, I am trying to build latest Struts 2.0 source code on machine but i am getting this exception. Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.265 sec Running org.apache.struts2.views.jsp.SortIteratorTagTest Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3.

RE: struts action results

2007-09-20 Thread Shepherd, Darren S
I think it could be a simple and elegant change to support a generic toString() functionality on the execute return object. Currently the DefaultActionInvocation calls the execute method and gets an Object back. It then checks if the object is instanceof Result, if so it uses it as the result,

Re: struts action results

2007-09-20 Thread Adam Hardy
Chris Pratt on 20/09/07 17:20, wrote: On 9/20/07, Adam Hardy <[EMAIL PROTECTED]> wrote: Would it be a big deal to change com.opensymphony.xwork2.DefaultActionInvocation to allow my Action to return an enumeration instead of a string? How about creating a subclass of ActionSupport that has it'

Re: Struts 2.0.11 Release Notes created

2007-09-20 Thread Ted Husted
On 9/20/07, Piero Sartini <[EMAIL PROTECTED]> wrote: > Since there is no official 2.0.10 release, how is this handled within JIRA? Struts 2.0.0 through 2.0.5 weren't official releases either. These were all test-builds or distributions, just like 2.0.10. While JIRA uses the term "release", we read

Re: struts action results

2007-09-20 Thread Chris Pratt
On 9/20/07, Adam Hardy <[EMAIL PROTECTED]> wrote: > Would it be a big deal to change > com.opensymphony.xwork2.DefaultActionInvocation > to allow my Action to return an enumeration instead of a string? > How about creating a subclass of ActionSupport that has it's own execute style method, we cou

struts action results

2007-09-20 Thread Adam Hardy
Would it be a big deal to change com.opensymphony.xwork2.DefaultActionInvocation to allow my Action to return an enumeration instead of a string? I tried it myself but the code wants to cast my Enumeration to a string, rather than call .toString(): return (String) methodResult;

RE: Multithreaded use of HashMap

2007-09-20 Thread Shepherd, Darren S
Don, Your right about OgnlUtils, that was a dumb mistake overlooking that. I was actually more concerned about the SpringObjectFactory. I noticed it wasn't synchronized, but I'm concerned about the performance of making it synchronized. The ObjectFactory is accessed so frequently that I pers

Re: Struts 2.0.11 Release Notes created

2007-09-20 Thread Antonio Petrelli
2007/9/20, Piero Sartini <[EMAIL PROTECTED]>: > > I think just linking to both TODO and DONE pages does help. I agree, but the JIRA filters should filter 2.0.10 and 2.0.11 tickets. Antonio

Re: Struts 2.0.11 Release Notes created

2007-09-20 Thread Piero Sartini
I think just linking to both TODO and DONE pages does help. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Struts 2.0.11 Release Notes created

2007-09-20 Thread Piero Sartini
Am Donnerstag, 20. September 2007 09:01:06 schrieb Antonio Petrelli: > AFAIK you simply do not need to do anything, except referring to the > release notes of the "real" preceding release (in this case 2.0.9). > 2.0.10 remains a simple test build. This happens frequently at Tomcat: did > not you ev

[OSS Bamboo] Struts 2 SVN - Main Build (Java 6) build 185 was SUCCESSFUL (with 710 tests). Change made by Don Brown

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build (Java 6) has the following 1 change by 1 author: *Don Brown* made the following changes at Comment: Fixing tests WW-1715 > /struts/struts2/trunk/plugins/struts1/src/test/java/org/apache/struts2/s1/Struts1FactoryTest.java > (55) > /struts/struts2/trunk

[OSS Bamboo] Struts 2 SVN - Main Build build 532 was SUCCESSFUL (with 710 tests). Change made by Don Brown

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build has the following 1 change by 1 author: *Don Brown* made the following changes at Comment: Fixing tests WW-1715 > /struts/struts2/trunk/plugins/struts1/src/test/java/org/apache/struts2/s1/Struts1FactoryTest.java > (55) > /struts/struts2/trunk/plugins/p

[OSS Bamboo] Struts 2 SVN - Main Build (Java 6) build 184 has FAILED (0 tests failed). Change made by musachy

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build (Java 6) has the following 1 change by 1 author: *musachy* made the following changes at Comment: Fixing javadocs for snippet plugin > /struts/struts2/trunk/plugins/dojo/src/main/java/org/apache/struts2/dojo/components/Autocompleter.java > (577766) ---

[OSS Bamboo] Struts 2 SVN - Main Build build 531 has FAILED (0 tests failed). Change made by musachy

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build has the following 1 change by 1 author: *musachy* made the following changes at Comment: Fixing javadocs for snippet plugin > /struts/struts2/trunk/plugins/dojo/src/main/java/org/apache/struts2/dojo/components/Autocompleter.java > (577766) -

[OSS Bamboo] Struts 2 SVN - Main Build (Java 6) build 183 has FAILED (0 tests failed). Change made by musachy

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build (Java 6) has the following 1 change by 1 author: *musachy* made the following changes at Comment: Fixing javadocs for snippet plugin > /struts/struts2/trunk/plugins/dojo/src/main/java/org/apache/struts2/dojo/components/Anchor.java > (577758) --

[OSS Bamboo] Struts 2 SVN - Main Build build 530 has FAILED (0 tests failed). Change made by musachy

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build has the following 1 change by 1 author: *musachy* made the following changes at Comment: Fixing javadocs for snippet plugin > /struts/struts2/trunk/plugins/dojo/src/main/java/org/apache/struts2/dojo/components/Anchor.java > (577758)

[OSS Bamboo] Struts 2 SVN - Main Build (Java 6) build 182 has FAILED (0 tests failed). Change made by Don Brown

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build (Java 6) has the following 1 change by 1 author: *Don Brown* made the following changes at Comment: Fixing blank test WW-1715 > /struts/struts2/trunk/apps/blank/src/test/java/example/HelloWorldTest.java > (577750) -

[OSS Bamboo] Struts 2 SVN - Main Build build 529 has FAILED (0 tests failed). Change made by Don Brown

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build has the following 1 change by 1 author: *Don Brown* made the following changes at Comment: Fixing blank test WW-1715 > /struts/struts2/trunk/apps/blank/src/test/java/example/HelloWorldTest.java > (577750) ---

Re: Multithreaded use of HashMap

2007-09-20 Thread Don Brown
OgnlUtil properly protects its caches by surrounding them in synchronized blocks, but you are right, the SpringObjectFactory class does not. I fixed it in trunk. Don On 9/20/07, Shepherd, Darren S <[EMAIL PROTECTED]> wrote: > I noticed two different cases where a HashMap is being used in a > mu

[OSS Bamboo] Struts 2 SVN - Main Build (Java 6) build 181 has FAILED (1 tests failed, no failures were new). Change made by musachy

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build (Java 6) has the following 2 changes by 1 author: *musachy* made the following changes at Comment: Fixing javadocs for snippet plugin > /struts/struts2/trunk/plugins/dojo/src/main/java/org/apache/struts2/dojo/components/Head.java > (577745) *musachy* made

[OSS Bamboo] Struts 2 SVN - Main Build build 528 has FAILED (1 tests failed, no failures were new). Change made by musachy

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build has the following 2 changes by 1 author: *musachy* made the following changes at Comment: Fixing javadocs for snippet plugin > /struts/struts2/trunk/plugins/dojo/src/main/java/org/apache/struts2/dojo/components/Head.java > (577745) *musachy* made the follo

[OSS Bamboo] Struts 2 SVN - Main Build build 527 has FAILED (1 tests failed)

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
This is a manual build of Struts 2 SVN - Main Build. --- The build has 1 failed test and 709 successful tests. Click http://opensource.bamboo.atlassian.com/browse/STRUTS-MAIN-527 to find out more. Thanks, Bamb

[OSS Bamboo] Struts 2 SVN - Main Build (Java 6) build 180 has FAILED (1 tests failed). Change made by musachy

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build (Java 6) has the following 1 change by 1 author: *musachy* made the following changes at Comment: Fixing javadocs for snippet plugin > /struts/struts2/trunk/plugins/dojo/src/main/java/org/apache/struts2/dojo/components/Autocompleter.java > (577743) ---

[OSS Bamboo] Struts 2 SVN - Main Build build 526 has FAILED (0 tests failed). Change made by musachy

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build has the following 2 changes by 1 author: *musachy* made the following changes at Comment: Remove break lines from javadoc > /struts/struts2/trunk/plugins/dojo/src/main/java/org/apache/struts2/dojo/components/Autocompleter.java > (577738) *musachy* made the

Multithreaded use of HashMap

2007-09-20 Thread Shepherd, Darren S
I noticed two different cases where a HashMap is being used in a multithreaded read/write manner. As we all know the java HashMap implementation does not allow concurrent read/writes that are not externally synchronized. Is there some reason I should not be concerned? The classes are OgnlUtil

[OSS Bamboo] Struts 2 SVN - Main Build (Java 6) build 179 has FAILED (0 tests failed). Change made by musachy

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build (Java 6) has the following 1 change by 1 author: *musachy* made the following changes at Comment: Remove break lines from javadoc > /struts/struts2/trunk/plugins/dojo/src/main/java/org/apache/struts2/dojo/components/Autocompleter.java > (577738) --

[OSS Bamboo] Struts 2 SVN - Main Build build 525 has FAILED (0 tests failed)

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
This is a manual build of Struts 2 SVN - Main Build. --- No failed tests found, a possible compilation error. Click http://opensource.bamboo.atlassian.com/browse/STRUTS-MAIN-525 to find out more. Thanks, Bambo

[OSS Bamboo] Struts 2 SVN - Main Build (Java 6) build 178 has FAILED (0 tests failed). Change made by Don Brown

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build (Java 6) has the following 1 change by 1 author: *Don Brown* made the following changes at Comment: Updating docs on plugin api points WW-1715 > /struts/struts2/trunk/core/src/main/java/org/apache/struts2/config/BeanSelectionProvider.java > (577733) --

[OSS Bamboo] Struts 2 SVN - Main Build build 524 has FAILED (0 tests failed). Change made by Don Brown

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build has the following 1 change by 1 author: *Don Brown* made the following changes at Comment: Updating docs on plugin api points WW-1715 > /struts/struts2/trunk/core/src/main/java/org/apache/struts2/config/BeanSelectionProvider.java > (577733)

[OSS Bamboo] Struts 2 SVN - Main Build build 523 has FAILED (0 tests failed). Change made by Don Brown

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build has the following 1 change by 1 author: *Don Brown* made the following changes at Comment: Changes necessary for XWork 2.1: * New EL abstraction to allow ONGL to be replaced * Got rid of static factories and state, in favor of dep injection * New plugin A

[OSS Bamboo] Struts 2 SVN - Main Build (Java 6) build 177 has FAILED (0 tests failed). Change made by Don Brown

2007-09-20 Thread Atlassian Open Source Bamboo Integration Server
The project Struts 2 SVN - Main Build (Java 6) has the following 1 change by 1 author: *Don Brown* made the following changes at Comment: Changes necessary for XWork 2.1: * New EL abstraction to allow ONGL to be replaced * Got rid of static factories and state, in favor of dep injection * Ne

Re: [OT] Re: Should I announce SmartURLs or wait?

2007-09-20 Thread Don Brown
I'd prefer we give this more thought and keep it in the 2.1.x branch. I view patch releases as those that only provide bug fixes or minor stability features. Something like annotations, which will be used in client code, is really a public API feature and should be reserved for minor, at the least,

Re: Struts 2.0.11 Release Notes created

2007-09-20 Thread Antonio Petrelli
2007/9/19, James Holmes <[EMAIL PROTECTED]>: > > I created the release notes for the Struts 2.0.11 release. I'm not sure I > did it correctly though since 2.0.10 never saw the light of day. How do we > handle the scenario where this release is simply fixes to the previous > release that had all of