Re: [TEST] Apache Struts 6.6.0 test build is ready

2024-07-20 Thread Greg Huber
Sorry, please ignore previous emails, I went back in my logs and found the same errors.  Fixed it by updating my crusty code. <%@ include file="/WEB-INF/jsps/taglibs-struts2.jsp" %> <% pageContext.setAttribute("version",my.model.MyFactory.getMe().getVersion());

Re: [TEST] Apache Struts 6.6.0 test build is ready

2024-07-20 Thread Greg Huber
May have been some formatting on previous mail, here it is again 2024-07-20 09:39:59,406 WARN org.apache.struts2.interceptor.TokenSessionStoreInterceptor TokenSessionStoreInterceptor:handleInvalidToken - testHandleInvalidToken 2024-07-20 09:39:59,535 WARN

Re: [TEST] Apache Struts 6.6.0 test build is ready

2024-07-20 Thread Greg Huber
I am looking into duplicate session postings (circular nulls in TokenSessionStoreInterceptor by refresh post) in my app, and noticed this now in the tomcat log 2024-07-20 09:39:59,406 WARN org.apache.struts2.interceptor.TokenSessionStoreInterceptor

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-23 Thread Greg Huber
() {    return filter; } Just an idea. On 18/06/2024 08:57, Kusal Kithul-Godage wrote: Yeah good call I'll look into it On Tue, Jun 18, 2024 at 5:54 PM Greg Huber wrote: OK thanks. Can the logging be the same others - Developer Notification rather than changing the debug level? ie for a bad date I

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-18 Thread Greg Huber
as they have been able to do in Struts 6 and earlier. Also feel free to have a read of this section if you haven't had a chance too: https://struts.apache.org/security/#defining-and-annotating-your-action-parameters On Tue, Jun 18, 2024 at 5:22 PM Greg Huber wrote

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-18 Thread Greg Huber
For the |struts.parameters.requireAnnotations=||true| If I test my action, there are no log messages for these.  ie missing @StrutsParameter. It also says Action class, what if I have a bean in the action class, do I need to do these also? If I add them to every field/bean is this the same

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Greg Huber
Struts application with this issue. I'll update the documentation to better acknowledge this case as well as the options I outlined above. Lukasz if you could give me edit permission for the Struts 7.x migration guide, I'll add a quick note there too. On Sun, Jun 16, 2024 at 8:21 PM Greg Huber

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Greg Huber
why your application is relying on this behaviour. On Sun, Jun 16, 2024 at 7:39 PM Greg Huber wrote: I use both spring and hibernate v6 testing, I would not want to make any drastic changes to these as they are painful. Here is one (of many) 2024-06-16 09:26:21,419 WARN com.opensymphony.xwork2

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Greg Huber
to investigate why this is the case On Sun, Jun 16, 2024 at 7:19 PM Greg Huber wrote: The text looks ok, but I get this in the log also: 2024-06-16 10:15:12,587 WARN com.opensymphony.xwork2.ognl.SecurityMemberAccess SecurityMemberAccess:isAccessible - Access to proxy is blocked! Target [][ Where

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Greg Huber
if there are many repetitive ones On Sun, Jun 16, 2024 at 7:10 PM Greg Huber wrote: Sorry checked the wrong log file, it was this one, needed to be false. Is there any docs on this? ie and example of what would go in the list, as its excluding struts default stuff. On 16/06/2024 10:01, Kusal Kithul-Godage

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Greg Huber
/files Once you have isolated and corrected any issues, please re-enable the options as they offer significant protection against vulnerabilities. On Sun, Jun 16, 2024 at 6:39 PM Greg Huber wrote: I tried this and there is alot of text missing on my jsp pages it mentions

Re: [TEST] Apache Struts 7.0.0-M7 test build is ready

2024-06-16 Thread Greg Huber
I tried this and there is alot of text missing on my jsp pages it mentions these: |struts.ognl.allowStaticFieldAccess=||false| |struts.ognl.expressionMaxLength=||150| |struts.disallowDefaultPackageAccess=||true| |struts.disallowProxyMemberAccess=||true|

Re: Struts2 7.x official release

2024-05-17 Thread Greg Huber
I am not sure there is a date,  but M6 is quite good and stable. On 17/05/2024 10:55, Sai Charan Teja Pratti wrote: Hi, Inorder to upgrade to tomcat 10.x, we have dependency with struts2 7.x Can you please let us know when can we expect the struts2 7.x official release Thanks, Sai On Tue,

Re: [TEST] Apache Struts 7.0.0-M6 test build is read

2024-04-22 Thread Greg Huber
) uploadedFile.getContent()) ... } On 22/04/2024 05:45, Lukasz Lenart wrote: niedz., 21 kwi 2024 o 20:11 Greg Huber napisał(a): I run my ide directly from git, and it is the struts project that won't build. I was following the previous modification changing the struts pom 3x -jakarta entries which

Re: [TEST] Apache Struts 7.0.0-M6 test build is read

2024-04-21 Thread Greg Huber
21 kwi 2024 o 11:12 Greg Huber napisał(a): > > > > Using 7.0.0-M6 I still get > > > > The POM for org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M6 is > > missing, no dependency information available > > Do you specify "struts2-freemarker-jakarta

Re: [TEST] Apache Struts 7.0.0-M6 test build is read

2024-04-21 Thread Greg Huber
Using 7.0.0-M6 I still get The POM for org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M6 is missing, no dependency information available #Sun Apr 21 10:00:20 BST 2024 apache.snapshots|https\://repository.apache.org/snapshots|javadoc=1713690020922

Re: [TEST] Apache Struts 7.0.0-M6 test build is read

2024-04-20 Thread Greg Huber
What would be the pom fix value we need to use? 7.0.0-M6-SNAPSHOT org.apache.struts struts2-velocity-tools-view-jakarta 7.0.0-M6-SNAPSHOT On 20/04/2024 08:45, Lukasz Lenart wrote: Hello, This is a third milestone of Struts 7.x series, which is based on JakartaEE 6. Please take the time

Re: [VOTE] Apache Struts 6.4.0

2024-04-19 Thread Greg Huber
Works great for me. Thanks. [x] General Availability (GA) B On 18/04/2024 06:23, Lukasz Lenart wrote: The Apache Struts 6.4.0 test build is available. With this release the following issues were addressed: Bug [WW-5192] - Radio tag not setting enum key values [WW-5319] - StrutsUtils is not

Re: Unable to load configuration: /struts2-core-6.4.0.jar!/struts-beans.xml:39:72

2024-04-18 Thread Greg Huber
st place... Thanks! Markus Am 18.04.24 um 11:08 schrieb i...@flyingfischer.ch: I simply use   org.apache.struts2.tiles.StrutsTilesListener   without any further params. Is this incomplete? Markus Am 18.04.24 um 10:29 schrieb Greg Huber: How do you load your tiles from web.

Re: Unable to load configuration: /struts2-core-6.4.0.jar!/struts-beans.xml:39:72

2024-04-18 Thread Greg Huber
..what would the pattern be? /WEB-INF/tiles*.xml On 18/04/2024 09:35, Łukasz Lenart wrote: Yes, this works but it doesn't support wildcards org.apache.tiles.definition.DefinitionsFactory.DEFINITIONS_CONFIG /WEB-INF/tiles.xml czw., 18 kwi 2024 o 10:30 Greg Huber napisał(a): How

Re: Unable to load configuration: /struts2-core-6.4.0.jar!/struts-beans.xml:39:72

2024-04-18 Thread Greg Huber
How do you load your tiles from web.xml? ..For my setup this works. org.apache.struts2.tiles.StrutsTilesListener           org.apache.tiles.definition.DefinitionsFactory.DEFINITIONS_CONFIG           /WEB-INF/tiles.xml         On 18/04/2024 08:47, i...@flyingfischer.ch

Re: [VOTE] Apache Struts Master 15

2024-04-09 Thread Greg Huber
Builds ok for me. [x] General Availability (GA) On 06/04/2024 18:14, Lukasz Lenart wrote: The Struts Master 15 test build is now available as a Maven artifact. https://repository.apache.org/content/groups/staging/org/apache/struts/struts-master/15/ Release notes: * uses the latest version of

Re: [VOTE] Apache Struts Master 15

2024-04-09 Thread Greg Huber
What is the correct way to test this? Do a project build? On 06/04/2024 18:14, Lukasz Lenart wrote: The Struts Master 15 test build is now available as a Maven artifact. https://repository.apache.org/content/groups/staging/org/apache/struts/struts-master/15/ Release notes: * uses the latest

Re: improve documentation for UploadedFilesAware

2024-03-25 Thread Greg Huber
it.  Maybe better to wait a bit before upgrading? On 24/03/2024 20:47, Lukasz Lenart wrote: pon., 18 mar 2024 o 14:42 Greg Huber napisał(a): OK...I did not spot the link in the text. I repeated the links in the Examples sections of both Che

Re: improve documentation for UploadedFilesAware

2024-03-18 Thread Greg Huber
OK...I did not spot the link in the text. On Mon, 18 Mar 2024 at 12:59, Łukasz Lenart wrote: > pon., 18 mar 2024 o 13:05 Greg Huber napisał(a): > > > > > See [this page] for more examples and advanced configuration. > > > > Which page? > > On these pa

Re: improve documentation for UploadedFilesAware

2024-03-18 Thread Greg Huber
See [this page] for more examples and advanced configuration. Which page? I reverted this idea and UploadedFile isn't generic. that would be in 7.0.0_M4? I used _M3 to test it. On 18/03/2024 11:56, Lukasz Lenart wrote: pon., 18 mar 2024 o 08:21 Greg Huber napisał(a): Rechecking

Re: improve documentation for UploadedFilesAware

2024-03-18 Thread Greg Huber
rg0) { } On 17/03/2024 16:46, Lukasz Lenart wrote: Added :) Also adjusted the Showcasehttps://github.com/apache/struts/pull/895 niedz., 17 mar 2024 o 12:29 Greg Huber napisał(a): Looks good, but what happened to the examples with the stream stuff? Something like this for MultipleFileUploadUsi

Re: improve documentation for UploadedFilesAware

2024-03-17 Thread Greg Huber
4 09:33, Lukasz Lenart wrote: Better? https://struts.staged.apache.org/core-developers/action-file-upload https://struts.staged.apache.org/core-developers/file-upload czw., 14 mar 2024 o 15:29 Greg Huber napisał(a): Sorry, I meant we need to copy/duplicate this page : https://struts.apache.org/core-develop

Re: improve documentation for UploadedFilesAware

2024-03-14 Thread Greg Huber
Lenart wrote: > Done > https://github.com/apache/struts-site/pull/231 > > czw., 14 mar 2024 o 11:35 Greg Huber napisał(a): > > > > There is a really good page for the old upload > > > > https://struts.apache.org/core-developers/file-upload.html > > > &g

Re: improve documentation for UploadedFilesAware

2024-03-14 Thread Greg Huber
imilar detail page, updated and with the stream stuff. return this.uploadedFiles.stream().map(UploadedFile::getContentType).toArray(); otherwise without streams List>uploads =this.uploadedFiles; if(uploads !=null&()>0){ for(inti =0;i pon., 26 lut 2024 o 12:08 Greg Huber napisał(a): T

Re: [TEST] Apache Struts 7.0.0-M3 test build is ready

2024-02-28 Thread Greg Huber
on the projects having the errors and selecting "Maven > Disable Workspace Resolution". Then you can run the unit tests within Eclipse. On 2024/02/25 10:57:34 Greg Huber wrote: Also building in eclipse I get these strange errors Missing artifact org.apache.struts:struts2-freemarker-ja

improve documentation for UploadedFilesAware

2024-02-26 Thread Greg Huber
The documentation only lists one file |public void withUploadedFiles(List uploadedFiles) { if (!uploadedFiles.isEmpty()) { this.uploadedFile = uploadedFiles.get(0); this.fileName = uploadedFile.getName(); this.contentType = uploadedFile.getContentType(); this.originalName =

Re: [TEST] Apache Struts 7.0.0-M3 test build is ready

2024-02-26 Thread Greg Huber
alName(file.getOriginalName()))     .toArray(String[]::new);     } This .map stuff is not good for debugging. On 26/02/2024 06:26, Łukasz Lenart wrote: niedz., 25 lut 2024 o 09:42 Greg Huber napisał(a): Testing the file upload and it now does not work. I get an error where its using the

Re: [TEST] Apache Struts 7.0.0-M3 test build is ready

2024-02-26 Thread Greg Huber
The old version.  The pom change to snapshot worked so I will have a look now. On 26/02/2024 06:26, Łukasz Lenart wrote: niedz., 25 lut 2024 o 09:42 Greg Huber napisał(a): Testing the file upload and it now does not work. I get an error where its using the wrong file name ie

Re: [TEST] Apache Struts 7.0.0-M3 test build is ready

2024-02-25 Thread Greg Huber
}             org.apache.struts struts2-spring-plugin     ${project.version} Seems to be the newer jars, are the maven details correct? On 26/02/2024 06:28, Lukasz Lenart wrote: niedz., 25 lut 2024 o 11:57 Greg Huber napisał(a): Also building in eclipse I get these strange errors

Re: [TEST] Apache Struts 7.0.0-M3 test build is ready

2024-02-25 Thread Greg Huber
Also building in eclipse I get these strange errors Missing artifact org.apache.struts:struts2-freemarker-jakarta:jar:7.0.0-M3 Missing artifact org.apache.struts:struts2-velocity-tools-jsp-jakarta:jar:7.0.0-M3 Missing artifact

Re: [TEST] Apache Struts 7.0.0-M3 test build is ready

2024-02-25 Thread Greg Huber
Testing the file upload and it now does not work. I get an error where its using the wrong file name ie upload5549a568d9794ef5b654da83d07961350045.tmp rather than the actual file name. I put back the mods I did, and it still does not work. Were there any other changes? I did not test

Re: [7.0.0-M3] Error message

2024-02-16 Thread Greg Huber
What happened to M3? There is no tag on https://github.com/apache/struts On 16/02/2024 07:27, Lukasz Lenart wrote: I'm going to prepare another M4 which will contain the latest fixes around file upload and changes from the master branch pt., 9 lut 2024 o 16:53 Burton Rhodes napisał(a):

Re: file uploading

2024-02-13 Thread Greg Huber
Yes, only in the java templates plugin. Will do a PR. On Tue, 13 Feb 2024 at 15:18, Łukasz Lenart wrote: > I noticed your ticket in JIRA, so this problem is only related to the > Java templates plugin? > > pon., 12 lut 2024 o 16:56 Greg Huber napisał(a): > > >

Re: file uploading

2024-02-12 Thread Greg Huber
This is happening on the current version. I was just looking at what I need to do for the ActionFileUploadInterceptor. On Mon, 12 Feb 2024 at 15:52, Lukasz Lenart wrote: > pon., 12 lut 2024 o 16:48 Greg Huber napisał(a): > > > > Current version 6.3.0.2. > > This version

Re: file uploading

2024-02-12 Thread Greg Huber
Current version 6.3.0.2. On Mon, 12 Feb 2024 at 15:45, Lukasz Lenart wrote: > pon., 12 lut 2024 o 16:36 Greg Huber napisał(a): > > > > Was looking at switching to the new FileUploadInterceptor. > > > > But testing the current version, I noticed that after the

file uploading

2024-02-12 Thread Greg Huber
Was looking at switching to the new FileUploadInterceptor. But testing the current version, I noticed that after the upload it gives details of the webapp location in the value attribute.

Re: [7.0.0-M1] Actions not setting parameters with Multi-part forms

2024-01-23 Thread Greg Huber
I use the default which is struts.multipart.parser=org.apache.struts2.dispatcher.multipart.JakartaMultiPartRequest What would the jakarta-stream do that is different? On 23/01/2024 03:12, Burton Rhodes wrote: The biggest issue I'm having at the moment is with all of my multi-part forms

Re: [TEST] Apache Struts 7.0.0-M1 test build is ready

2024-01-23 Thread Greg Huber
Seems to pass all my tests and  runs good.  Upload seems to work OK, both my ajax and struts version. Stack: zulu17.42.19-ca-crac-jdk17.0.7-linux_x64 Spring framework 6.1.3 Spring Security 6.2.1 apache-tomcat-10.1.18 On 20/01/2024 11:12, Lukasz Lenart wrote: Hello, This is the first

Re: tooltip on

2023-10-11 Thread Greg Huber
"${parameters.tooltip}"<#rt/> <#rt/> ...but then should use the title rather than the tooltip on the component. On 10/10/2023 14:20, Lukasz Lenart wrote: wt., 10 paź 2023 o 11:50 Greg Huber napisał(a): My bad the filter mapping has changed from /struts/*. struts2 /sta

Re: tooltip on

2023-10-10 Thread Greg Huber
, Łukasz Lenart wrote: Maybe serving static content is disabled https://struts.apache.org/core-developers/static-content (mobile) W dniu niedz., 8.10.2023 o 13:23 Greg Huber napisał(a): All I get is a 404 Loading failed for the

Re: tooltip on

2023-10-08 Thread Greg Huber
All I get is a 404 Loading failed for the

Re: tooltip on

2023-10-08 Thread Greg Huber
entPath}/domTT.js" /> <#lt/><@s.link rel="stylesheet" type="text/css" href="${base}${parameters.staticContentPath}/domTT.css" /> <#t/> On 08/10/2023 11:44, Lukasz Lenart wrote: niedz., 8 paź 2023 o 12:08 Greg Huber napisał(a): How is this suppose

tooltip on

2023-10-08 Thread Greg Huber
How is this supposed to work? I get this at the bottom of the form, but for me it maps to an invalid url? http://www.xx.xx/static/domTT.js Is there some js that is supposed to take care of this? https://struts.apache.org/tag-developers/textfield-tag does not mention anything.

Re: Struts 2.5.x EOL

2023-10-04 Thread Greg Huber
Spring 5 Framework has an EOL of 2024-12-31, and 6 is Java 17+. * Spring Framework 6.1.x: Jakarta EE 9-11 (jakarta namespace) * Spring Framework 6.0.x: Jakarta EE 9-10 (jakarta namespace) * Spring Framework 5.3.x: Java EE 7-8 (javax namespace) On 04/10/2023 05:32, Lukasz Lenart wrote:

Re: Struts 2.5.x EOL

2023-10-04 Thread Greg Huber
+1. If we are going to create a plugin for the Jakarta changes, would make it easier. On 04/10/2023 05:32, Lukasz Lenart wrote: Hi, I would like to announce that we end support for Struts 2.5.x branch. Is setting this date to the 1st of the new year ok? Not too short a period of time?

Re: [VOTE] Apache Struts 6.3.0

2023-09-01 Thread Greg Huber
Works great for me.  Thanks. [x] General Availability (GA) On 01/09/2023 07:44, Lukasz Lenart wrote: Once you have had a chance to review the test build, please respond with a vote on its quality: [ ] Leave at test build [ ] Alpha [ ] Beta [ ] General Availability (GA) Everyone who has

Re: [VOTE] Apache Struts 6.3.0

2023-08-31 Thread Greg Huber
Is this vote still open? On 30/08/2023 12:01, Lukasz Lenart wrote: There is a blocker [1] discovered by Kusal, should I merge the PR into the master branch and roll a new release -> 6.3.1 or rather clean up everything and start over with 6.3.0. Some uses get confused if there is there is a

Re: tiles taglib

2023-07-20 Thread Greg Huber
://www.lenart.org.pl/ pon., 17 lip 2023 o 13:03 Greg Huber napisał(a): ...if we do change it, it is built with pom build-autotags Changed in BuildAutotags.java String taglibURI = "/struts-tiles"; and copied over from target. On 17/07/2023 10:47, Lukasz Lenart wrote: pon., 17

Re: tiles taglib

2023-07-17 Thread Greg Huber
...if we do change it, it is built with pom build-autotags Changed in  BuildAutotags.java   String taglibURI = "/struts-tiles"; and copied over from target. On 17/07/2023 10:47, Lukasz Lenart wrote: pon., 17 lip 2023 o 11:44 Greg Huber napisał(a):> I now get this pesky e

Re: tiles taglib

2023-07-17 Thread Greg Huber
A good idea. ./struts-tiles ### I guess an eclipse thing.  Every thing looks ok. On 17/07/2023 10:47, Lukasz Lenart wrote: pon., 17 lip 2023 o 11:44 Greg Huber napisał(a):> I now get this pesky error (eclipse) using this <%@ taglib uri="http://tiles.apache.org/tags-ti

tiles taglib

2023-07-17 Thread Greg Huber
I now get this pesky error (eclipse) using this <%@ taglib uri="http://tiles.apache.org/tags-tiles; prefix="tiles" %> Maybe we are missing something for this? - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For

Re: [TEST] Apache Struts 6.3.0-RC1 test build is read

2023-07-16 Thread Greg Huber
Work great for me. Thanks. On 16/07/2023 09:23, Lukasz Lenart wrote: Hello, This is another minor version of Struts 6.x series, yet it includes the Apache Struts tiles code base instead of depending on the outdated libraries. Please take the time and test the bits - any help is appreciated.

Re: [VOTE] Apache Struts 6.2.0

2023-07-05 Thread Greg Huber
Work great for me.  Thanks. On 05/07/2023 11:25, Lukasz Lenart wrote: [x] General Availability (GA) (B) - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org

blog post not helpful

2023-06-08 Thread Greg Huber
I noticed on searching, that it shows "a people ask", If I click on the link, Is Struts 2 outdated? People also ask Is Struts 2 outdated? Yes, you can be surprised but *after almost 18 years on the market the Apache Struts project is still maintained and under active development*.10 Sept

Re: String variable with a number s:if test

2023-05-25 Thread Greg Huber
mageSource.equals('') Thanks! On 25/05/2023 08:17, Lukasz Lenart wrote: czw., 25 maj 2023 o 09:12 Greg Huber napisał(a): Thanks, need to try and remembered this! Would explain why some of my item types don't select/work as expected. I would use "==" to be sure, as documented in htt

Re: String variable with a number s:if test

2023-05-25 Thread Greg Huber
Thanks, need to try and remembered this! Would explain why some of my item types don't select/work as expected. On 24/05/2023 12:26, Lukasz Lenart wrote: śr., 24 maj 2023 o 11:23 Greg Huber napisał(a): If I have a bean with a variable of type of String ie public String getType() { return

String variable with a number s:if test

2023-05-24 Thread Greg Huber
If I have a bean with a variable of type of String ie public String getType() { return type; } AND it has a number, eg 2. In my jsp Does not work: I must use this: Is this how it should work? Some old code uses .equals('2'), as the bean is a string, and is not working as

Re: Struts 6.2.0

2023-05-17 Thread Greg Huber
Maybe a separate release immediately after 6.2.0?  It is only a refactor, with no code changes, but might have missed something especially if using velocity heavily. On 16/05/2023 19:56, Lukasz Lenart wrote: Hi, I think it's time to release a new version which addresses over 50 issues [1]

action="%{tmp}" on other tags

2023-04-19 Thread Greg Huber
The form tag does this : On 19/04/2023 08:25, Lukasz Lenart wrote: śr., 19 kwi 2023 o 09:19 Greg Huber napisał(a): clickById("entry_%{#mainAction}!publish") This patch fixes the format by calculating the action first: https://github.com/apache/str

Re: looking at roller upgrade again

2023-04-19 Thread Greg Huber
at the same time, is that correct? yes, other tags must be doing this already? On 19/04/2023 08:25, Lukasz Lenart wrote: śr., 19 kwi 2023 o 09:19 Greg Huber napisał(a): clickById("entry_%{#mainAction}!publish") This patch fixes the format by calculating the action first: https://github.

Re: looking at roller upgrade again

2023-04-19 Thread Greg Huber
@Greg Huber is the current approach ok? https://github.com/apache/struts/pull/678 This works but not really related to this formatting issue. As there is nothing wrong with Struts, it never formatted it correctly in the first place, which can be seen from the test clickById : clickById

Re: looking at roller upgrade again

2023-04-15 Thread Greg Huber
// current version You see. I just renamed local var name to translatedName to not confuse name with this.name. So am wondering how _tmp_id = ...escape(name)...; uses an evaluated name in previous versions! Regards. On 4/12/2023 7:13 PM, Greg Huber wrote: There is nothing wrong w

Re: looking at roller upgrade again

2023-04-12 Thread Greg Huber
oblem exactly is. > > 1. Was your app depended to Struts internal behavior of id generation > and so your app is broken now? > > 2. Or no, Struts itself is broken now by my change? > > > On 4/11/2023 10:16 AM, Greg Huber wrote: > > More housekeeping, the id on the form

Re: looking at roller upgrade again

2023-04-11 Thread Greg Huber
- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ sob., 1 kwi 2023 o 12:43 Greg Huber napisał(a): Maybe a user question (sorry) Using action like this : action="%{#mainAction}!saveDraft"/> struts seems to get the "id" wrong?  ...but the "name" correct. eg: entryE

Re: looking at roller upgrade again

2023-04-10 Thread Greg Huber
Modified version here https://github.com/gregh3269/struts/tree/WW-5302-unevaluated-id   myConfig   action="%{#mainAction}!save" />   method="save" />   id="myConfig_myConfig_save"> On 09/04/2023 15:16, Lukasz Lenart wrote: niedz., 9 kwi 2023 o

Re: looking at roller upgrade again

2023-04-10 Thread Greg Huber
branch WW-5302-unevaluated-id Seems the same to me.  Note the action has a variable: %{#mainAction}!save All it seems to be doing is escaping action: %{#mainAction}!save : %{#mainAction}!save ___mainAction}_save On 09/04/2023 15:16, Lukasz Lenart wrote: niedz., 9 kwi 2023 o 12:20 Greg Huber

Re: looking at roller upgrade again

2023-04-09 Thread Greg Huber
Testing the branch it is still the same? myConfig id="myConfigmainAction__save" > What we want is: id="myConfig_myConfig_save" > ## It needs this from previous email // determine actual action ActionMapping mapping = new ActionMapping();

Re: looking at roller upgrade again

2023-04-09 Thread Greg Huber
I guess what we want. ### In the FormButton populateComponentHtmlId(Form form) it evaluates the action based on the text rather than the "actual" action. If the action is determined from the mapping it renders correctly. See "// determine actual action" in code below entryEdit

Re: looking at roller upgrade again

2023-04-03 Thread Greg Huber
+ 48 606 323 122 http://www.lenart.org.pl/ sob., 1 kwi 2023 o 12:43 Greg Huber napisał(a): Maybe a user question (sorry) Using action like this : action="%{#mainAction}!saveDraft"/> struts seems to get the "id" wrong? ...but the "name" correct. eg: ent

looking at roller upgrade again

2023-04-01 Thread Greg Huber
Maybe a user question (sorry) Using action like this : action="%{#mainAction}!saveDraft"/> struts seems to get the "id" wrong?  ...but the "name" correct. eg: entryEdit renders: id="entrymainAction__saveDraft" name="action:entryAdd!saveDraft" class="btn btn-warning"> Should be

Fwd: Struts2-bootstrap-plugin

2023-03-23 Thread Greg Huber
This may not be an issue.  So please ignore the previous email. ..dependency stuff linked with using the plugin. Forwarded Message Subject:Struts2-bootstrap-plugin Date: Thu, 23 Mar 2023 10:02:55 + From: Greg Huber To: Struts Developers List I

Struts2-bootstrap-plugin

2023-03-23 Thread Greg Huber
I was looking at apache roller which uses the struts2-bootstrap-plugin. When I check the generated id's they seem to have extra underscores? id="entrymainAction__publish" name="action:entryEdit!publish" class="btn btn-success"> Is this intentional? ### When I look at "normal" tags only

Re: Apache tiles

2023-03-21 Thread Greg Huber
Dave, BTW, Struts devs are planning to merge the tiles code base into the Struts Tiles Plugin to eliminate the dependency on the now Attic project. https://github.com/apache/struts/tree/WW-5233-tiles/plugins/tiles On 20/03/2023 21:38, Dave wrote: Hi Laurent and PJ, The Apache Roller

Re: Apache tiles

2023-03-21 Thread Greg Huber
Maybe tiles will live on. On 20/03/2023 21:38, Dave wrote: Hi Laurent and PJ, The Apache Roller project still uses Struts, Tiles and Velocity and I would like to see the projects continue and move into Jakarta land. I have some limited time to help out. What do y'all need help with? Dave On

Re: [VOTE] Struts Maven Archetypes 6.0.0

2023-03-14 Thread Greg Huber
+1 It works OK. [ ] Leave at test build [ ] Alpha [ ] Beta [x] General Availability (GA) (B) On 13/03/2023 12:54, Lukasz Lenart wrote: One more binding vote is needed :) pt., 10 mar 2023 o 09:09 Johannes Geppert napisał(a): +1 (binding) [ ] Leave at test build [ ] Alpha [ ] Beta [X]

Re: [CLOSED] [VOTE] [FASTTRACK] Apache Struts 6.1.2

2023-03-13 Thread Greg Huber
g/message/fexjsvlz3u6uwdt5> From: Lukasz Lenart (luka...@apache.org) Date: Mar 9, 2023 10:59:12 pm List: *org.apache.struts.user* Can the dev list be added also? On 13/03/2023 10:27, Lukasz Lenart wrote: pon., 13 mar 2023 o 10:56 Greg Huber napisał(a): OK thanks. I checked my spa

Re: [CLOSED] [VOTE] [FASTTRACK] Apache Struts 6.1.2

2023-03-13 Thread Greg Huber
OK thanks.  I checked my spam/bin folder, maybe the email did not get sent? On 13/03/2023 09:50, Lukasz Lenart wrote: pon., 13 mar 2023 o 10:46 Greg Huber napisał(a): Was there an email of the official release? May have missed it. Yes, it was https://lists.apache.org/thread

Re: [CLOSED] [VOTE] [FASTTRACK] Apache Struts 6.1.2

2023-03-13 Thread Greg Huber
Was there an email of the official release?  May have missed it. On 10/03/2023 06:18, Lukasz Lenart wrote: Vote passed with result: GA +1 x3 (binding) GA +1 x2 (non-binding) Thanks & regards Łukasz śr., 8 mar 2023 o 21:10 Lukasz Lenart napisał(a):

Re: [VOTE] [FASTTRACK] Apache Struts 6.1.2

2023-03-08 Thread Greg Huber
Works for me. Thanks. [ ] Leave at test build [ ] Alpha [ ] Beta [x] General Availability (GA) (B) On 08/03/2023 20:10, Lukasz Lenart wrote: The Apache Struts 6.1.2 test build is now available. It includes the latest security patch which fixes potential security vulnerability: * missing max

Re: Fileupload on JakartaEE

2023-02-28 Thread Greg Huber
it right now). I will try to help make this happen :) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ niedz., 1 sty 2023 o 10:38 Greg Huber napisał(a): I rechecked tomcats work folder to see what the parts are, there are no files with zero size, only the the hidden fields, submit

Re: Fileupload on JakartaEE

2023-01-01 Thread Greg Huber
      style="width:80%;display:none;">                                        id="uploadFiles_uploadedFiles" multiple="multiple">              id="uploadFiles_uploadedFiles" multiple=&qu

Re: Fileupload on JakartaEE

2022-12-30 Thread Greg Huber
/upload_0f8323e4_9dd9_4972_8305_6b7c31911f47_0033.tmp, size=1050531 bytes, isFormField=false, FieldName=uploadedFiles name=, StoreLocation=null, size=0 bytes, isFormField=false, FieldName=uploadedFiles On 30/12/2022 09:18, Lukasz Lenart wrote: pt., 30 gru 2022 o 10:06 Greg Huber napisał(a): Also need an extra check || "&qu

Re: Fileupload on JakartaEE

2022-12-30 Thread Greg Huber
field: {}", part.getName());     } else { // file upload     LOG.error("Storing file: {} in save dir: {}", part.getSubmittedFileName(), saveDir);     parseFile(part, saveDir);     }     } On 30/12/2022 09:01, Lukasz Lenart wrote: pt.,

Re: Fileupload on JakartaEE

2022-12-30 Thread Greg Huber
ile ((read = fileContent.read(bytes)) != -1) {            out.write(bytes, 0, read);        }    } Is it possible to use the original temp file that tomcat creates rather than creating another one? On 30/12/2022 08:18, Lukasz Lenart wrote: czw., 29 gru 2022 o 17:40 Greg Huber napisał

Re: Fileupload on JakartaEE

2022-12-29 Thread Greg Huber
      fileUploadServlet /user/resources.action   makes it work, but ends up with an empty file called embeddable53b33ea6a4fb4bb1957d35fa60af338c.jpg. Will debug some more. On 29/12/2022 12:56, Lukasz Lenart wrote: czw., 29 gru 2022 o 13:34 Greg Huber napisał(a): I have now set

Re: Fileupload on JakartaEE

2022-12-29 Thread Greg Huber
ean isMultipartRequest = request instanceof MultiPartRequestWrapper is still false. On 29/12/2022 12:56, Lukasz Lenart wrote: czw., 29 gru 2022 o 13:34 Greg Huber napisał(a): I have now set struts.multipart.parser=org.apache.struts2.dispatcher.multipart.ServletMultiPartRequest this m

Re: Fileupload on JakartaEE

2022-12-29 Thread Greg Huber
404 Message The requested resource [/user/resources.action] is not available On 29/12/2022 11:41, Lukasz Lenart wrote: czw., 29 gru 2022 o 11:55 Greg Huber napisał(a): I made no changes just used the branch as is. I tried deleting the commons jar to make sure it was using the new code but

Re: Fileupload on JakartaEE

2022-12-29 Thread Greg Huber
Lenart wrote: czw., 29 gru 2022 o 11:40 Greg Huber napisał(a): WW-5273-servlet-upload branch works on both my ajax and forms based upload. Great to hear that! Did you have any problem with configuring that additional FileUploadServlet which is needed by Servlet API 3.1? (although commons

Re: Fileupload on JakartaEE

2022-12-29 Thread Greg Huber
WW-5273-servlet-upload branch works on both my ajax and forms based upload. (although commons-fileupload-1.4.jar is still included) On 29/12/2022 09:38, Lukasz Lenart wrote: Take a look on that PR https://github.com/apache/struts/pull/650 Regards

Re: [GitHub] [struts] lukaszlenart closed pull request #644: Bump spring-web from 5.3.23 to 6.0.0

2022-12-13 Thread Greg Huber
Is there a plan for the Jakarta namespace change?  All of Spring is now jdk 17. On 13/12/2022 07:52, GitBox wrote: lukaszlenart closed pull request #644: Bump spring-web from 5.3.23 to 6.0.0 URL: https://github.com/apache/struts/pull/644

Re: [VOTE] Apache Struts 6.1.1

2022-11-24 Thread Greg Huber
Thanks, works great for me. [x] General Availability (GA) (B) On 24/11/2022 19:16, Lukasz Lenart wrote: The Apache Struts 6.1.1 test build is available. With this release the following issues were addressed: Release notes: * https://cwiki.apache.org/confluence/display/WW/Version+Notes+6.1.1

Re: [GitHub] [struts] gregh3269 opened a new pull request, #616: WW 5233 Add velocity classes and tests

2022-10-18 Thread Greg Huber
If anyone has a complex tiles/freemarker layout please can you give the plugin a spin On 18/10/2022 14:47, GitBox wrote: gregh3269 opened a new pull request, #616: URL: https://github.com/apache/struts/pull/616 Whilst I can remember the complex cut and paste, I have added the velocity

Re: Tiles support

2022-10-13 Thread Greg Huber
a lot of issues around Tiles or new feature requests, so having this as simple as possible is the way to go :) Cheers -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ wt., 11 paź 2022 o 11:24 Greg Huber napisał(a): I thought about the autotag stuff and with the validation/tests etc, seemed

Re: Tiles support

2022-10-11 Thread Greg Huber
on request. Regards Łukasz niedz., 9 paź 2022 o 16:17 Greg Huber napisał(a): Looking at it in more depth, I think we need to leave as much code as possible in the attic, including the autotag stuff. Keep only the parts to make it work, and update the tag classes manually. Having to maintain classes

  1   2   3   4   5   >