Ok, I think it's time to merge this PR and release a new version
https://github.com/apache/struts/pull/608
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
Great, feel free to open PR with those tests, even the generator can
stay where it is now.
czw., 13 paź 2022 o 09:16 Greg Huber napisał(a):
>
> My thinking also, keep things simple. The patch includes all the tests
> for completeness, I guess as it was meant to be.
>
> On 13/10/2022 08:10, Lukas
My thinking also, keep things simple. The patch includes all the tests
for completeness, I guess as it was meant to be.
On 13/10/2022 08:10, Lukasz Lenart wrote:
To be honest, I would like to reduce as much as possible by taking
some custom steps to generate something. I do not expect to have
To be honest, I would like to reduce as much as possible by taking
some custom steps to generate something. I do not expect to have a lot
of issues around Tiles or new feature requests, so having this as
simple as possible is the way to go :)
Cheers
--
Łukasz
+ 48 606 323 122 http://www.lenart.or
I thought about the autotag stuff and with the validation/tests etc,
seemed a good idea to keep it, as its not that involved.
Basically it uses template-suite.xml to generate the tag files and tld.
I have got it all working, and passing the tests.
Rather than the maven autotag plugin, I have a
I copied some auto generated classes but they depend on Autotag
classes, so I copied them as well. If something is still missing I
have a Tiles build locally and can copy other auto generated stuff.
And yes, we should avoid maintaining Autotag, it complicates things.
As far as I understand we only
Looking at it in more depth, I think we need to leave as much code as
possible in the attic, including the autotag stuff. Keep only the parts to
make it work, and update the tag classes manually. Having to maintain
classes to generate the tag classes is pointless (might as well update them
direct
Or better, try to build the tags (whatever the maven-autotag-pluging
did) on the plugin build?
On 09/10/2022 10:28, Greg Huber wrote:
The reason why the taglibs were missing, they are generated by tiles
auto tag
https://tiles.apache.org/tiles-autotag/
Tiles-3 introduces a f Autotag Project,
The reason why the taglibs were missing, they are generated by tiles
auto tag
https://tiles.apache.org/tiles-autotag/
Tiles-3 introduces a f Autotag Project, a project that automatically
generates tags (or tag-like) artifact from a common template code for a
range of templating languages. Tod
Sure, looks like I forgot to copy Tiles JSP
czw., 6 paź 2022 o 18:00 Greg Huber napisał(a):
>
> I can do a pr on branch WW-5233-tiles with it working?
>
> I will clean up the code also.
>
>
>
> -
> To unsubscribe, e-mail: dev-uns
I can do a pr on branch WW-5233-tiles with it working?
I will clean up the code also.
-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org
Managed to get it to work.
I had to add all of the tag classes from tiles-jsp-3.0.8.jar to
org/apache/tiles/web/jsp/taglib
and change the package to match in the tiles-jsp.tld.
ie
org.apache.tiles.jsp.taglib.
to
org.apache.tiles.web.jsp.taglib.
One java class that won't compi
I have built it now, where is the
<%@ taglib uri="http://tiles.apache.org/tags-tiles"; prefix="tiles" %>
stored? It was in the tiles-jsp-3.0.8.jar file before.
If I look in
struts/plugins/tiles/target/classes/META-INF
struts/plugins/tiles/target/classes/META-INF/tld
there is only tiles-extr
ok, sorry missed a delete of a jar,
...just need to fix the missing tld
/WEB-INF/jsps/tiles/tiles-page.jsp (line: [3], column: [0]) The absolute
uri: [http://tiles.apache.org/tags-tiles] cannot be resolved in either
web.xml or the jar files deployed with this application
I have this with the
It might be the way I am running it but I get:
SEVERE: Error configuring application listener of class
[org.apache.struts2.tiles.StrutsTilesListener]
java.lang.NoClassDefFoundError: org/apache/tiles/startup/TilesInitializer
web.xml
org.apache.struts2.tiles.StrutsTilesListener
Yes
W dniu czw., 6.10.2022 o 15:19 Greg Huber napisał(a):
> I can test it from the git branch in eclipse. Normally I would delete
> the struts2* jars, so I guess its all of the tiles-* as well?
>
> On 06/10/2022 14:14, Lukasz Lenart wrote:
> > czw., 6 paź 2022 o 15:11 Greg Huber napisał(a):
>
I can test it from the git branch in eclipse. Normally I would delete
the struts2* jars, so I guess its all of the tiles-* as well?
On 06/10/2022 14:14, Lukasz Lenart wrote:
czw., 6 paź 2022 o 15:11 Greg Huber napisał(a):
Is the branch WW-5233-tiles working? I could give it a test drive.😛
czw., 6 paź 2022 o 15:11 Greg Huber napisał(a):
>
> Is the branch WW-5233-tiles working? I could give it a test drive.😛
Yes, you can build a snapshot version out of it. That would be cool, thanks!
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
--
Is the branch WW-5233-tiles working? I could give it a test drive.😛
On 06/10/2022 14:05, Lukasz Lenart wrote:
I have prepared a PR to copy Tiles code base into the Tile plugin -
just copied what is needed by the plugin. I would like to merge it
after releasing 6.1.0
https://github.com/apache/s
I have prepared a PR to copy Tiles code base into the Tile plugin -
just copied what is needed by the plugin. I would like to merge it
after releasing 6.1.0
https://github.com/apache/struts/pull/608
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
wt., 9 sie 2022 o 16:43 Antonio Pet
Il giorno mar 9 ago 2022 alle ore 07:32 Lukasz Lenart <
lukaszlen...@apache.org> ha scritto:
> ... but from my perspective
> Struts 2 is using just a few features of the Apache Tiles and from
> project management perspective it will be easier to copy what is
> needed instead of managing & releasin
Am 09.08.22 um 07:31 schrieb Lukasz Lenart:
> Hi Antonio, thank you for your explanation, but from my perspective
> Struts 2 is using just a few features of the Apache Tiles and from
> project management perspective it will be easier to copy what is
> needed instead of managing & releasing a whole
I also use Tiles and it's very useful in my projects.
Am 9. August 2022 10:29:17 MESZ schrieb Stefaan Dutry :
>On my previous workplace we used tiles with struts to greatly reduce
>duplicate code and simplify an application. I think it's still in use and i
>see no reason for changing that.
>
>I be
On my previous workplace we used tiles with struts to greatly reduce
duplicate code and simplify an application. I think it's still in use and i
see no reason for changing that.
I believe, and hope, more people reason like this, since I agree with
Greg that the continuous rewriting of applications
pon., 8 sie 2022 o 18:13 Antonio Petrelli
napisał(a):
> Hello I am Antonio Petrelli, former PMC member of the Apache Tiles project.
> Tiles is in the attic, this does not mean that it can get out of it, given
> that there is enough will to reboot a PMC.
> Copying code does not look like a good thi
I think there are still quite a few users, if you look at Maven Central
at the usages there are quite a few.
https://mvnrepository.com/artifact/org.apache.tiles
It would be good if Tiles was on maintenance only, rather than the attic.
..We have not all abandoned the tried and tested technologi
I use all the jars below, except tiles-request-servlet-1.0.7.jar.
However that may be an outlier here.
It seems all the jars are needed.
Best regards
Markus
Am 08.08.22 um 20:43 schrieb Greg Huber:
Sounds like a good idea, maybe add the required code to our plugin?
...I have had a look at wh
Sounds like a good idea, maybe add the required code to our plugin?
...I have had a look at what I have as dependencies, does it really need
all these jars for it to work?
tiles-api-3.0.8.jar
tiles-autotag-core-runtime-1.2.jar
tiles-core-3.0.8.jar
tiles-el-3.0.8.jar
tiles-freemarker-3.0.8.jar
til
Il giorno lun 8 ago 2022 alle ore 18:13 Antonio Petrelli <
antonio.petre...@gmail.com> ha scritto:
> Tiles is in the attic, this does not mean that it can get out of it, given
> that there is enough will to reboot a PMC.
>
I meant "can't" :-)
>
Il giorno lun 8 ago 2022 alle ore 14:43 Lukasz Lenart <
lukaszlen...@apache.org> ha scritto:
> Hi,
>
> If you didn't notice the Apache Tiles project has retired and I wonder
> how to continue support for it. I thought maybe copying all the
> required code into the Strut Tiles Plugin is the right s
Hi,
If you didn't notice the Apache Tiles project has retired and I wonder
how to continue support for it. I thought maybe copying all the
required code into the Strut Tiles Plugin is the right solution, wdyt?
Cheers
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
gzilla/show_bug.cgi?id=18426
Add Tiles Support to tag.
[EMAIL PROTECTED] changed:
What|Removed |Added
Status|NEW |RESOLVED
Reso
gzilla/show_bug.cgi?id=18426
Add Tiles Support to tag.
--- Additional Comments From [EMAIL PROTECTED] 2004-09-23 15:01 ---
All the tag is doing is rendering a url and I believe theres
nothing in Struts currently which handles "tiles" urls so I don't see how this
is possib
33 matches
Mail list logo
