Re: FREE Apache Subversion Meetup: Thursday, November 4, at ApacheCon NA in Atlanta, GA

2010-10-15 Thread Greg Stein
woot! I'll be there, most definitely! On Mon, Oct 4, 2010 at 09:45, C. Michael Pilato wrote: > For those who don't know, ApacheCon North America comes to Atlanta, GA, > November 1-5 this year.  You can find out more about the conference via the > official conference website at http://na.apacheco

Re: svn commit: r1022931 - in /subversion/trunk/subversion/libsvn_wc: status.c wc-queries.sql wc_db.c wc_db.h

2010-10-15 Thread C. Michael Pilato
On 10/15/2010 05:26 PM, Bob Archer wrote: - cold cache: 1.7 is almost 50% faster than 1.6 1.7: 22s 1.6: 42s - hot cache: 1.7 is just about on par with 1.6 (only 20% slower) 1.7: 0.86s 1.6: 0.72s >>> >>> What do you guys mean by "cold cache" and "hot cache"? I

RE: svn commit: r1022931 - in /subversion/trunk/subversion/libsvn_wc: status.c wc-queries.sql wc_db.c wc_db.h

2010-10-15 Thread Bob Archer
> >> - cold cache: 1.7 is almost 50% faster than 1.6 > >> 1.7: 22s > >> 1.6: 42s > >> > >> - hot cache: 1.7 is just about on par with 1.6 (only 20% slower) > >> 1.7: 0.86s > >> 1.6: 0.72s > >> > > > > What do you guys mean by "cold cache" and "hot cache"? If they > mean what I think they mean, woul

Re: svn commit: r1022931 - in /subversion/trunk/subversion/libsvn_wc: status.c wc-queries.sql wc_db.c wc_db.h

2010-10-15 Thread Erik Huelsmann
>> - cold cache: 1.7 is almost 50% faster than 1.6 >> 1.7: 22s >> 1.6: 42s >> >> - hot cache: 1.7 is just about on par with 1.6 (only 20% slower) >> 1.7: 0.86s >> 1.6: 0.72s >> > > What do you guys mean by "cold cache" and "hot cache"? If they mean what I > think they mean, wouldn't "hot cache" be

RE: svn commit: r1022931 - in /subversion/trunk/subversion/libsvn_wc: status.c wc-queries.sql wc_db.c wc_db.h

2010-10-15 Thread Bob Archer
> On Fri, Oct 15, 2010 at 4:19 PM, wrote: > > Author: philip > > Date: Fri Oct 15 14:19:36 2010 > > New Revision: 1022931 > > > > URL: http://svn.apache.org/viewvc?rev=1022931&view=rev > > Log: > > Implement status using per-dir queries.  On my machine (Linux, > local > > disk) this improves the

Re: svn commit: r1022931 - in /subversion/trunk/subversion/libsvn_wc: status.c wc-queries.sql wc_db.c wc_db.h

2010-10-15 Thread Johan Corveleyn
On Fri, Oct 15, 2010 at 4:19 PM, wrote: > Author: philip > Date: Fri Oct 15 14:19:36 2010 > New Revision: 1022931 > > URL: http://svn.apache.org/viewvc?rev=1022931&view=rev > Log: > Implement status using per-dir queries.  On my machine (Linux, local > disk) this improves the speed of status on a

RE: svn commit: r1022707 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2010-10-15 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: donderdag 14 oktober 2010 23:39 > To: dev@subversion.apache.org > Subject: Re: svn commit: r1022707 - in /subversion/trunk: ./ > subversion/libsvn_subr/io.c > > On Thu, Oct 14, 2010 at 09:00:44PM -, hwri...@a

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-15 Thread Branko Čibej
On 15.10.2010 15:06, Hyrum K. Wright wrote: > (I hope our C docs point this out explicitly, too.) If not, you're bound to find out sooner or later. :) -- Brane

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-15 Thread Hyrum K. Wright
On Fri, Oct 15, 2010 at 4:35 AM, Branko Čibej wrote: >  On 14.10.2010 20:39, Hyrum K. Wright wrote: >> The following is a somewhat naïve implementation, but does it jive >> with your suggestion? > > Roughly yes, see the other comment. > On reflection, though, I like the suggestion of returning an

Re: trunk failing tests on Windows XP (32 bit): prop-tests.py 33, stat-tests.py 5, upgrade-tests.py 11

2010-10-15 Thread Branko Čibej
On 15.10.2010 12:22, Johan Corveleyn wrote: > On Fri, Oct 15, 2010 at 12:20 PM, Johan Corveleyn wrote: >> I saw that the problem was fixed in r102170 by Bert > s/r102170/r1021760/ > > I really should install that "Undo send" google labs extension :) I saw they also have a beta of "delete from in

Re: trunk failing tests on Windows XP (32 bit): prop-tests.py 33, stat-tests.py 5, upgrade-tests.py 11

2010-10-15 Thread Johan Corveleyn
On Fri, Oct 15, 2010 at 12:20 PM, Johan Corveleyn wrote: > I saw that the problem was fixed in r102170 by Bert s/r102170/r1021760/ I really should install that "Undo send" google labs extension :) -- Johan

Re: trunk failing tests on Windows XP (32 bit): prop-tests.py 33, stat-tests.py 5, upgrade-tests.py 11

2010-10-15 Thread Johan Corveleyn
On Sun, Oct 10, 2010 at 3:07 PM, Johan Corveleyn wrote: > On Sat, Oct 2, 2010 at 11:24 AM, Bert Huijben wrote: >>> -Original Message- >>> From: Paul Burba [mailto:ptbu...@gmail.com] >>> Sent: vrijdag 1 oktober 2010 15:46 >>> To: Bert Huijben >>> Cc: Johan Corveleyn; Subversion Development

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-15 Thread Steinar Bang
> Steinar Bang : > Philipp Marek : >> It might be easier for callers if this did >> if (isNull) >> return ""; >> so that the value could just be used in printf() and similar without >> explicit checking. > If that was ok to do, one might as well represent a NULL with an empty > string.

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-15 Thread Steinar Bang
> Branko Čibej : > std::string also doesn't have any virtual functions, nor does a bool > member require a destructor. Memory deallocation is OK. std::string is > actually a POD and tricky rules apply that allow you do do this > safely, IIRC ... Nevertheless, deleting a derived object from a

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-15 Thread Branko Čibej
On 14.10.2010 20:39, Hyrum K. Wright wrote: > The following is a somewhat naïve implementation, but does it jive > with your suggestion? Roughly yes, see the other comment. On reflection, though, I like the suggestion of returning an std::pair. Make a typedef of that so that users can declare ret

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-15 Thread Branko Čibej
On 14.10.2010 20:39, Hyrum K. Wright wrote: > inline operator bool() const > { > return !isNull; > } This bit seriously changes the semantics of std::string. I recommend not to override operator bool() like this. Write a different accessor function instead. -- Brane

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-15 Thread Branko Čibej
On 14.10.2010 21:32, Steinar Bang wrote: >> Branko Čibej : >> All right. Then derive svn::string from std::string, and add a .null() >> method. You get to use all the standard string alogorithm >> specializations, plus you get what you want. > There is one known objection to this: std::string

Re: [PATCH] Simplify WC DB function start_directory_update_txn()

2010-10-15 Thread Julian Foad
Greg Stein wrote: > Seems fine. Thanks. Committed revision 1022862. - Julian > On Thu, Oct 14, 2010 at 18:32, Julian Foad wrote: > > Hi Bert. > > > > Any objection to me simplifying start_directory_update_txn(), as in the > > attached patch? It appears that it's doing relatively a lot of wor

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2010-10-15 Thread Philip Martin
Ramkumar Ramachandra writes: > Hi Philip, > > [sorry about the delayed reply: I had a bad internet connection] > > Philip Martin writes: >> If we are going to use the APR atomic interface then the two reads >> should use apr_atomic_read32. >> >> It would be better to use svn_atomic__init_once.

Re: object-model: Return by value, reference or pointer? (or something else?)

2010-10-15 Thread Steinar Bang
> Philipp Marek : > It might be easier for callers if this did > if (isNull) > return ""; > so that the value could just be used in printf() and similar without > explicit checking. If that was ok to do, one might as well represent a NULL with an empty string.